SeneddView::display_front_senedd() - Code Metrics - Inspection of "Homepage class tidy and tweaks" - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1834)

unknown

created 2025-03-26 12:39 UTC

SeneddView::display_front_senedd() B

↳ Parent: Project

Complexity

Conditions	8
Paths	12

Size

Total Lines	58
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	8
eloc	37
c	1
b	0
f	0
nc	12
nop	0
dl	0
loc	58
rs	8.0835

How to fix Long Method

<?php

namespace MySociety\TheyWorkForYou\SectionView;

class SeneddView extends SectionView {
    protected $index_template = 'section/senedd_index';

    public function __construct() {
        if (LANGUAGE == 'cy') {

            $this->major = 11;
            $this->class = 'SENEDDCYLIST';
        } else {
            $this->major = 10;
            $this->class = 'SENEDDENLIST';
        }
        parent::__construct();
    }

    protected function display_front() {
        if (get_http_var('more')) {
            return parent::display_front();
        } else {
            $homepage = new \MySociety\TheyWorkForYou\Homepage\Wales();
            return $homepage->display();
        }
    }

    protected function front_content() {
        return $this->list->display('biggest_debates', ['days' => 30, 'num' => 20], 'none');
    }

    protected function getURLs($data) {
        $urls = [];

        $day = new \MySociety\TheyWorkForYou\Url('senedddebates');
        $urls['seneddday'] = $day;
        $urls['day'] = $day;

        return $urls;
    }

    protected function getSearchSections() {
        return [
            [ 'section' => 'wales' ],
        ];
    }
}


1			<?php
2
3			namespace MySociety\TheyWorkForYou\SectionView;
4
5			class SeneddView extends SectionView {
6			protected $index_template = 'section/senedd_index';
7
8			public function __construct() {
9			if (LANGUAGE == 'cy') {
			0 ignored issues – show introduced 2023-04-05 16:47 UTC by Report Bug Copy Issue Report The condition `MySociety\TheyWorkForYou...onView\LANGUAGE == 'cy'` is always `false`. Loading history...
10			$this->major = 11;
11			$this->class = 'SENEDDCYLIST';
12			} else {
13			$this->major = 10;
14			$this->class = 'SENEDDENLIST';
15			}
16			parent::__construct();
17			}
18
19			protected function display_front() {
20			if (get_http_var('more')) {
21			return parent::display_front();
22			} else {
23			$homepage = new \MySociety\TheyWorkForYou\Homepage\Wales();
24			return $homepage->display();
25			}
26			}
27
28			protected function front_content() {
29			return $this->list->display('biggest_debates', ['days' => 30, 'num' => 20], 'none');
30			}
31
32			protected function getURLs($data) {
33			$urls = [];
34
35			$day = new \MySociety\TheyWorkForYou\Url('senedddebates');
36			$urls['seneddday'] = $day;
37			$urls['day'] = $day;
38
39			return $urls;
40			}
41
42			protected function getSearchSections() {
43			return [
44			[ 'section' => 'wales' ],
45			];
46			}
47			}
48

mysociety / theyworkforyou

Pull Request — master (#1834)

SeneddView::display_front_senedd() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like