NiView::display_front_ni() - Code Metrics - Inspection of "Homepage class tidy and tweaks" - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1834)

unknown

created 2025-03-26 12:39 UTC

NiView::display_front_ni() B

↳ Parent: Project

Complexity

Conditions	8
Paths	12

Size

Total Lines	56
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	35
nc	12
nop	0
dl	0
loc	56
rs	8.1155
c	0
b	0
f	0

How to fix Long Method

<?php

namespace MySociety\TheyWorkForYou\SectionView;

class NiView extends SectionView {
    public $major = 5;
    protected $class = 'NILIST';
    protected $index_template = 'section/ni_index';

    protected function display_front() {
        if (get_http_var('more')) {
            return parent::display_front();
        } else {
            $homepage = new \MySociety\TheyWorkForYou\Homepage\NI();
            return $homepage->display();
        }
    }

    protected function front_content() {
        return $this->list->display('biggest_debates', ['days' => 30, 'num' => 20], 'none');
    }

    protected function getURLs($data) {
        $urls = [];

        $day = new \MySociety\TheyWorkForYou\Url('nidebates');
        $urls['niday'] = $day;

        $urls['day'] = $day;

        return $urls;
    }

    protected function getSearchSections() {
        return [
            [ 'section' => 'ni' ],
        ];
    }
}


1			<?php
2
3			namespace MySociety\TheyWorkForYou\SectionView;
4
5			class NiView extends SectionView {
6			public $major = 5;
7			protected $class = 'NILIST';
8			protected $index_template = 'section/ni_index';
9
10			protected function display_front() {
11			if (get_http_var('more')) {
12			return parent::display_front();
13			} else {
14			$homepage = new \MySociety\TheyWorkForYou\Homepage\NI();
15			return $homepage->display();
16			}
17			}
18
19			protected function front_content() {
20			return $this->list->display('biggest_debates', ['days' => 30, 'num' => 20], 'none');
21			}
22
23			protected function getURLs($data) {
24			$urls = [];
25
26			$day = new \MySociety\TheyWorkForYou\Url('nidebates');
27			$urls['niday'] = $day;
28
29			$urls['day'] = $day;
30
31			return $urls;
32			}
33
34			protected function getSearchSections() {
35			return [
36			[ 'section' => 'ni' ],
37			];
38			}
39			}
40

mysociety / theyworkforyou

Pull Request — master (#1834)

NiView::display_front_ni() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like