mysociety / theyworkforyou

www/includes/easyparliament/people.php

Spacing +9 added lines, -9 removed lines

@@ -14,7 +14,7 @@ 
         $this->db = new ParlDB;
     }
 
-    public function display ($view, $args=array(), $format='html') {
+    public function display($view, $args = array(), $format = 'html') {
         global $PAGE;
 
         $validviews = array('mps', 'peers', 'mlas', 'msps');
@@ -22,13 +22,13 @@ 
         if (in_array($view, $validviews)) {
 
             // What function do we call for this view?
-            $function = '_get_data_by_'.$view;
+            $function = '_get_data_by_' . $view;
 
             // Get all the data that's to be rendered.
             $data = $this->$function($args);
 
         } else {
-            $PAGE->error_message ("You haven't specified a view type.");
+            $PAGE->error_message("You haven't specified a view type.");
             return false;
         }
 
@@ -39,7 +39,7 @@ 
 
 
 
-    public function render($view, $data, $format='html') {
+    public function render($view, $data, $format = 'html') {
         // Once we have the data that's to be rendered,
         // include the template.
 
@@ -49,7 +49,7 @@ 
         }
 
         //This should really be a single template? (rjp)
-        include (INCLUDESPATH."easyparliament/templates/$format/people_$view" . ".php");
+        include (INCLUDESPATH . "easyparliament/templates/$format/people_$view" . ".php");
         return true;
 
     }
@@ -131,7 +131,7 @@ 
         $q = $this->db->query($query . "ORDER BY $sqlorder", $params);
 
         $data = array();
-        for ($row=0; $row<$q->rows(); $row++) {
+        for ($row = 0; $row < $q->rows(); $row++) {
             $p_id = $q->field($row, 'person_id');
             $dept = $q->field($row, 'dept');
             $pos = $q->field($row, 'position');
@@ -144,7 +144,7 @@ 
                     $q->field($row, 'lordofname'));
                 $constituency = $q->field($row, 'constituency');
                 $url = make_member_url($name, $constituency, $args['house'], $p_id);
-                $narray = array (
+                $narray = array(
                     'person_id' 	=> $p_id,
                     'given_name' => $q->field($row, 'given_name'),
                     'family_name' => $q->field($row, 'family_name'),
@@ -177,8 +177,8 @@ 
         if ($args['house'] == 2 && ($order == 'name' || $order == 'constituency'))
             uasort($data, array($this, 'by_peer_name'));
 
-        $data = array (
-            'info' => array (
+        $data = array(
+            'info' => array(
                 'order' => $order
             ),
             'data' => $data

Braces +39 added lines, -24 removed lines

@@ -27,7 +27,8 @@ 
             // Get all the data that's to be rendered.
             $data = $this->$function($args);
 
-        } else {
+        }
+        else {
             $PAGE->error_message ("You haven't specified a view type.");
             return false;
         }
@@ -100,30 +101,37 @@ 
         if (isset($args['date'])) {
             $query .= 'AND from_date <= :date AND :date <= to_date ';
             $params[':date'] = $args['date'];
-        } else {
+        }
+        else {
             $query .= 'AND to_date="9999-12-31" ';
         }
         if ($use_personinfo) {
             $query .= 'LEFT OUTER JOIN personinfo ON member.person_id = personinfo.person_id AND data_key="' . $personinfo_key . '" ';
         }
         $query .= ' JOIN person_names p ON p.person_id = member.person_id AND p.type = "name" ';
-        if (isset($args['date']))
-            $query .= 'AND start_date <= :date AND :date <= end_date ';
-        else
-            $query .= 'AND end_date="9999-12-31" ';
+        if (isset($args['date'])) {
+                    $query .= 'AND start_date <= :date AND :date <= end_date ';
+        }
+        else {
+                    $query .= 'AND end_date="9999-12-31" ';
+        }
         $query .= 'WHERE house=' . $args['house'] . ' ';
-        if (isset($args['date']))
-            $query .= 'AND entered_house <= :date AND :date <= left_house ';
-        elseif (!isset($args['all']) || $args['house'] == 1)
-            $query .= 'AND left_house = (SELECT MAX(left_house) FROM member) ';
+        if (isset($args['date'])) {
+                    $query .= 'AND entered_house <= :date AND :date <= left_house ';
+        }
+        elseif (!isset($args['all']) || $args['house'] == 1) {
+                    $query .= 'AND left_house = (SELECT MAX(left_house) FROM member) ';
+        }
 
         if (isset($args['order'])) {
             $order = $args['order'];
             if ($args['order'] == 'given_name') {
                 $sqlorder = 'given_name, family_name';
-            } elseif ($args['order'] == 'constituency') {
+            }
+            elseif ($args['order'] == 'constituency') {
                 $sqlorder = 'constituency';
-            } elseif ($args['order'] == 'party') {
+            }
+            elseif ($args['order'] == 'party') {
                 $sqlorder = 'party, family_name, given_name, constituency';
             }
         }
@@ -138,7 +146,8 @@ 
             if (isset($data[$p_id])) {
                 $data[$p_id]['dept'] = array_merge((array) $data[$p_id]['dept'], (array) $dept);
                 $data[$p_id]['pos'] = array_merge((array) $data[$p_id]['pos'], (array) $pos);
-            } else {
+            }
+            else {
                 $name = member_full_name($args['house'], $q->field($row, 'title'),
                     $q->field($row, 'given_name'), $q->field($row, 'family_name'),
                     $q->field($row, 'lordofname'));
@@ -165,7 +174,8 @@ 
                     $narray['party'] = '-';
                     $narray['pos'] = 'Speaker';
                     $narray['dept'] = 'House of Commons';
-                } elseif ($narray['party'] == 'CWM' || $narray['party'] == 'DCWM') {
+                }
+                elseif ($narray['party'] == 'CWM' || $narray['party'] == 'DCWM') {
                     $narray['party'] = '-';
                     $narray['pos'] = 'Deputy Speaker';
                     $narray['dept'] = 'House of Commons';
@@ -174,8 +184,9 @@ 
                 $data[$p_id] = $narray;
             }
         }
-        if ($args['house'] == 2 && ($order == 'name' || $order == 'constituency'))
-            uasort($data, array($this, 'by_peer_name'));
+        if ($args['house'] == 2 && ($order == 'name' || $order == 'constituency')) {
+                    uasort($data, array($this, 'by_peer_name'));
+        }
 
         $data = array (
             'info' => array (
@@ -188,14 +199,18 @@ 
 
     }
     public function by_peer_name($a, $b) {
-        if (!$a['family_name'] && !$b['family_name'])
-            return strcmp($a['lordofname'], $b['lordofname']);
-        if (!$a['family_name'])
-            return strcmp($a['lordofname'], $b['family_name']);
-        if (!$b['family_name'])
-            return strcmp($a['family_name'], $b['lordofname']);
-        if (strcmp($a['family_name'], $b['family_name']))
-            return strcmp($a['family_name'], $b['family_name']);
+        if (!$a['family_name'] && !$b['family_name']) {
+                    return strcmp($a['lordofname'], $b['lordofname']);
+        }
+        if (!$a['family_name']) {
+                    return strcmp($a['lordofname'], $b['family_name']);
+        }
+        if (!$b['family_name']) {
+                    return strcmp($a['family_name'], $b['lordofname']);
+        }
+        if (strcmp($a['family_name'], $b['family_name'])) {
+                    return strcmp($a['family_name'], $b['family_name']);
+        }
         return strcmp($a['lordofname'], $b['lordofname']);
     }
 

www/includes/easyparliament/recess.php

Spacing +79 added lines, -79 removed lines

@@ -12,20 +12,20 @@ 
     ),
     2001 => array(
         1=>array('less'=>8),
-        2=>array('between'=>array(15,26)),
-        4=>array('between'=>array(10,23)),
+        2=>array('between'=>array(15, 26)),
+        4=>array('between'=>array(10, 23)),
         5=>array('more'=>13),
         6=>array('less'=>13),
         7=>array('more'=>20),
         8=>array('all'=>1),
         9=>array('less'=>14, 'more'=>14),
-        10=>array('less'=>4, 'between'=>array(4,8, 8,15)),
+        10=>array('less'=>4, 'between'=>array(4, 8, 8, 15)),
         12=>array('more'=>19) ),
     2002 => array(
         1=>array('less'=>8),
-        2=>array('between'=>array(14,25)),
+        2=>array('between'=>array(14, 25)),
         3=>array('more'=>26),
-        4=>array('less'=>3, 'between'=>array(3,10)),
+        4=>array('less'=>3, 'between'=>array(3, 10)),
         5=>array('more'=>24),
         6=>array('less'=>10),
         7=>array('more'=>24),
@@ -35,8 +35,8 @@ 
         12=>array('more'=>19) ),
     2003 => array(
         1=>array('less'=>7),
-        2=>array('between'=>array(13,24)),
-        4=>array('between'=>array(14,28)),
+        2=>array('between'=>array(13, 24)),
+        4=>array('between'=>array(14, 28)),
         5=>array('more'=>22),
         6=>array('less'=>3),
         7=>array('more'=>17),
@@ -46,8 +46,8 @@ 
         12=>array('more'=>18)),
     2004 => array(
         1=>array('less'=>5),
-        2=>array('between'=>array(12,23)),
-        4=>array('between'=>array(1,19)),
+        2=>array('between'=>array(12, 23)),
+        4=>array('between'=>array(1, 19)),
         5=>array('more'=>27),
         6=>array('less'=>7),
         7=>array('more'=>22),
@@ -57,7 +57,7 @@ 
         12=>array('more'=>21) ),
     2005 => array(
         1=>array('less'=>10),
-        2=>array('between'=>array(10,21)),
+        2=>array('between'=>array(10, 21)),
         3=>array('more'=>24),
         4=>array('less'=>4, 'more'=>10),
         5=>array('less'=>11, 'more'=>26),
@@ -69,7 +69,7 @@ 
         12=>array('more'=>20) ),
     2006 => array(
         1=>array('less'=>9),
-        2=>array('between'=>array(16,27)),
+        2=>array('between'=>array(16, 27)),
         3=>array('more'=>30),
         4=>array('less'=>18),
         5=>array('more'=>25),
@@ -82,7 +82,7 @@ 
     ),
     2007 => array(
         1=>array('less'=>8),
-        2=>array('between'=>array(8,19)),
+        2=>array('between'=>array(8, 19)),
         3=>array('more'=>29),
         4=>array('less'=>16),
         5=>array('more'=>24),
@@ -95,8 +95,8 @@ 
     ),
     2008 => array(
         1=>array('less'=>7),
-        2=>array('between'=>array(7,18)),
-        4=>array('between'=>array(3,21)),
+        2=>array('between'=>array(7, 18)),
+        4=>array('between'=>array(3, 21)),
         5=>array('more'=>22),
         6=>array('less'=>2),
         7=>array('more'=>22),
@@ -107,8 +107,8 @@ 
     ),
     2009 => array(
         1=>array('less'=>12),
-        2=>array('between'=>array(12,23)),
-        4=>array('between'=>array(2,20)),
+        2=>array('between'=>array(12, 23)),
+        4=>array('between'=>array(2, 20)),
         5=>array('more'=>21),
         6=>array('less'=>1),
         7=>array('more'=>21),
@@ -119,7 +119,7 @@ 
     ),
     2010 => array(
         1=>array('less'=>5),
-        2=>array('between'=>array(10,22)),
+        2=>array('between'=>array(10, 22)),
         3=>array('more'=>30),
         4=>array('less'=>6, 'more'=>8),
         5=>array('less'=>18, 'more'=>27),
@@ -132,62 +132,62 @@ 
     ),
     2011 => array(
         1=>array('less'=>10),
-        2=>array('between'=>array(17,28)),
-        4=>array('between'=>array(5,26)),
+        2=>array('between'=>array(17, 28)),
+        4=>array('between'=>array(5, 26)),
         5=>array('more'=>24),
         6=>array('less'=>7),
         7=>array('more'=>19),
         8=>array('all'=>1),
         9=>array('less'=>5, 'more'=>15),
         10=>array('less'=>10),
-        11=>array('between'=>array(15,21)),
+        11=>array('between'=>array(15, 21)),
         12=>array('more'=>20),
     ),
     2012 => array(
         1=>array('less'=>10),
-        2=>array('between'=>array(9,20)),
+        2=>array('between'=>array(9, 20)),
         3=>array('more'=>27),
         4=>array('less'=>16),
         5=>array('more'=>24),
         6=>array('less'=>11),
         7=>array('more'=>17),
         8=>array('all'=>1),
-        9=>array('less'=>3,'more'=>18),
+        9=>array('less'=>3, 'more'=>18),
         10=>array('less'=>15),
-        11=>array('between'=>array(13,19)),
+        11=>array('between'=>array(13, 19)),
         12=>array('more'=>20)
     ),
     2013 => array(
         1=>array('less'=>7),
-        2=>array('between'=>array(14,25)),
+        2=>array('between'=>array(14, 25)),
         3=>array('more'=>26),
         4=>array('less'=>15),
         5=>array('more'=>21),
         6=>array('less'=>3),
         7=>array('more'=>18),
         8=>array('all'=>1),
-        9=>array('less'=>2,'more'=>13),
+        9=>array('less'=>2, 'more'=>13),
         10=>array('less'=>8),
-        11=>array('between'=>array(12,18)),
+        11=>array('between'=>array(12, 18)),
         12=>array('more'=>19)
     ),
     2014 => array(
         1=>array('less'=>6),
-        2=>array('between'=>array(13,24)),
-        4=>array('between'=>array(10,28)),
-        5=>array('between'=>array(1,6))
+        2=>array('between'=>array(13, 24)),
+        4=>array('between'=>array(10, 28)),
+        5=>array('between'=>array(1, 6))
     ),
     2015 => array(
         7=>array('more'=>21),
         8=>array('all'=>1),
         9=>array('less'=>7, 'more'=>17),
         10=>array('less'=>12),
-        11=>array('between'=>array(10,16)),
+        11=>array('between'=>array(10, 16)),
         12=>array('more'=>17)
     ),
     2016 => array(
         1=>array('less'=>5),
-        2=>array('between'=>array(11,22))
+        2=>array('between'=>array(11, 22))
     )
 );
 # Lords differences
@@ -199,15 +199,15 @@ 
 $GLOBALS['recessdates'][101][2010][12]['more'] = 22;
 $GLOBALS['recessdates'][101][2011] = array(
     1 => array('less'=>10),
-    2 => array('between'=>array(16,28)),
-    4 => array('between'=>array(6,26)),
+    2 => array('between'=>array(16, 28)),
+    4 => array('between'=>array(6, 26)),
     5 => array('more'=>25),
     6 => array('less'=>6),
     7 => array('more'=>20),
     8 => array('all'=>1),
     9 => array('less'=>5, 'more'=>15),
     10 => array('less'=>3),
-    11=>array('between'=>array(16,21)),
+    11=>array('between'=>array(16, 21)),
     12 => array('more'=>21),
 );
 
@@ -216,74 +216,74 @@ 
     1999 => array(
         7 => array('more' => 2),
         8 => array('less' => 31),
-        10 => array('between' => array(8,25)),
+        10 => array('between' => array(8, 25)),
         12 => array('more' => 17)
     ),
     2000 => array(
         1 => array('less' => 10),
-        4 => array('between' => array(7,25)),
+        4 => array('between' => array(7, 25)),
         7 => array('more' => 7),
         8 => array('all' => 1),
         9 => array('less' => 4),
-        10 => array('between' => array(6,23)),
+        10 => array('between' => array(6, 23)),
         12 => array('more' => 20)
     ),
     2001 => array(
         1=>array('less'=>8),
-        2=>array('between'=>array(16,26)),
-        4=>array('between'=>array(6,23)),
+        2=>array('between'=>array(16, 26)),
+        4=>array('between'=>array(6, 23)),
         6=>array('more'=>29),
         7=>array('all'=>1),
         8=>array('all'=>1),
         9=>array('less'=>3),
-        10=>array('between'=>array(5,22)),
+        10=>array('between'=>array(5, 22)),
         12=>array('more'=>21) ),
     2002 => array(
         1=>array('less'=>7),
-        2=>array('between'=>array(15,25)),
+        2=>array('between'=>array(15, 25)),
         3=>array('more'=>28),
         4=>array('less'=>15),
         7=>array('more'=>10),
         8=>array('all'=>1),
         9=>array('less'=>2),
-        10=>array('between'=>array(11,28)),
+        10=>array('between'=>array(11, 28)),
         12=>array('more'=>20) ),
     2003 => array(
         1=>array('less'=>6),
-        4=>array('between'=>array(0,31)),
+        4=>array('between'=>array(0, 31)),
         5=>array('less'=>2),
         6=>array('more'=>27),
         7=>array('all'=>1),
         8=>array('all'=>1),
-        10=>array('between'=>array(10,27)),
+        10=>array('between'=>array(10, 27)),
         12=>array('more'=>19)),
     2004 => array(
         1=>array('less'=>5),
-        2=>array('between'=>array(13,23)),
-        4=>array('between'=>array(2,19)),
+        2=>array('between'=>array(13, 23)),
+        4=>array('between'=>array(2, 19)),
         6=>array('more'=>25),
         7=>array('all'=>1),
         8=>array('less'=>30),
-        10=>array('between'=>array(10,23)),
+        10=>array('between'=>array(10, 23)),
         12=>array('more'=>26) ),
     2005 => array(
         1=>array('less'=>8),
-        2=>array('between'=>array(11,21)),
+        2=>array('between'=>array(11, 21)),
         3=>array('more'=>24),
         4=>array('less'=>11),
         7=>array('more'=>1),
         8=>array('all'=>1),
         9=>array('less'=>5),
-        10=>array('between'=>array(7,24)),
+        10=>array('between'=>array(7, 24)),
         12=>array('more'=>23) ),
     2006 => array(
         1=>array('less'=>9),
-        2=>array('between'=>array(10,20)),
+        2=>array('between'=>array(10, 20)),
         4=>array('less'=>18),
         7=>array('more'=>0),
         8=>array('all'=>1),
         9=>array('less'=>4),
-        10=>array('between'=>array(6,23)),
+        10=>array('between'=>array(6, 23)),
         12=>array('more'=>22),
     ),
     2007 => array(
@@ -293,18 +293,18 @@ 
         7=>array('all'=>1),
         8=>array('all'=>1),
         9=>array('less'=>3),
-        10=>array('between'=>array(5,22)),
+        10=>array('between'=>array(5, 22)),
         12=>array('more'=>21),
     ),
     2008 => array(
         1=>array('less'=>5),
-        2=>array('between'=>array(8,18)),
+        2=>array('between'=>array(8, 18)),
         3=>array('more'=>28),
         4=>array('less'=>14),
         6=>array('more'=>27),
         7=>array('all'=>1),
         8=>array('all'=>1),
-        10=>array('between'=>array(10,27)),
+        10=>array('between'=>array(10, 27)),
     ),
 );
 
@@ -369,39 +369,39 @@ 
         else
             $to = "$year-9-" . $dates[$year][9]['less'];
     }
-    if ( (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less'])
+    if ((isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less'])
     || (isset($dates[$year][$month]['more']) && $day > $dates[$year][$month]['more'])
     || (isset($dates[$year][$month]['between']) && $day > $dates[$year][$month]['between'][0] && $day < $dates[$year][$month]['between'][1])
-    || (isset($dates[$year][$month]['between'][2]) && $day > $dates[$year][$month]['between'][2] && $day < $dates[$year][$month]['between'][3]) ) {
+    || (isset($dates[$year][$month]['between'][2]) && $day > $dates[$year][$month]['between'][2] && $day < $dates[$year][$month]['between'][3])) {
         switch ($month) {
             case 1: case 12: $recess = 'Christmas Recess'; break;
-            case 2: if ($body==1 || $body==101) $recess = 'Half Term Week';
-                elseif ($body==4) $recess = 'February Recess';
+            case 2: if ($body == 1 || $body == 101) $recess = 'Half Term Week';
+                elseif ($body == 4) $recess = 'February Recess';
                 break;
-            case 3: if ($body==1 || $body==101) $recess = 'Easter Recess';
-                elseif ($body==4) $recess = 'Spring Recess';
+            case 3: if ($body == 1 || $body == 101) $recess = 'Easter Recess';
+                elseif ($body == 4) $recess = 'Spring Recess';
                 break;
             case 4: if (isset($dates[$year][$month]['more']) && $day > $dates[$year][$month]['more']) {
                     $recess = 'Election Recess';
-                } elseif ($body==4 && $year==2003) {
+                } elseif ($body == 4 && $year == 2003) {
                     $recess = 'Election Recess';
-                } elseif ($body==1 || $body==101) {
+                } elseif ($body == 1 || $body == 101) {
                     $recess = 'Easter Recess';
-                } elseif ($body==4) {
+                } elseif ($body == 4) {
                     $recess = 'Spring Recess';
                 }
                 break;
-            case 5: if ($year==2001 || (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less'])) {
+            case 5: if ($year == 2001 || (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less'])) {
                     $recess = 'Election Recess';
                 } else {
                     $recess = 'Whit Recess';
                 }
                 break;
-            case 6: if ($year==2001) {
+            case 6: if ($year == 2001) {
                     $recess = 'Election Recess';
-                } elseif ($body==1 || $body==101) {
+                } elseif ($body == 1 || $body == 101) {
                     $recess = 'Whit Recess';
-                } elseif ($body==4) {
+                } elseif ($body == 4) {
                     $recess = 'Summer Recess';
                 } else {
                     trigger_error("Argh6");
@@ -411,15 +411,15 @@ 
                 break;
             case 9: if (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less']) {
                     $recess = 'Summer Recess';
-                } elseif ($body==1 || $body==101) {
+                } elseif ($body == 1 || $body == 101) {
                     $recess = 'Conference Recess';
                 } else {
                     trigger_error("Argh9");
                 }
                 break;
-            case 10: if ($body==1 || $body==101) $recess = 'Conference Recess';
-                elseif ($body==4) $recess = 'Autumn Recess';
-                elseif ($body==5) $recess = 'Halloween Recess';
+            case 10: if ($body == 1 || $body == 101) $recess = 'Conference Recess';
+                elseif ($body == 4) $recess = 'Autumn Recess';
+                elseif ($body == 5) $recess = 'Halloween Recess';
                 break;
             case 11: $recess = 'Autumn Recess';
                 break;
@@ -427,12 +427,12 @@ 
         }
         if (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less']) {
             $to = "$year-$month-" . $dates[$year][$month]['less'];
-            if ($month==1)
-                $from = ($year-1)."-12-" . $dates[$year-1][12]['more'];
+            if ($month == 1)
+                $from = ($year - 1) . "-12-" . $dates[$year - 1][12]['more'];
             else {
-                for ($newmonth = $month-1; $newmonth>=1; $newmonth--) {
+                for ($newmonth = $month - 1; $newmonth >= 1; $newmonth--) {
                     if (isset($dates[$year][$newmonth]['more'])) {
-                        $from = "$year-".($newmonth)."-" . $dates[$year][$newmonth]['more'];
+                        $from = "$year-" . ($newmonth) . "-" . $dates[$year][$newmonth]['more'];
                         break;
                     }
                 }
@@ -440,12 +440,12 @@ 
         }
         if (isset($dates[$year][$month]['more']) && $day > $dates[$year][$month]['more']) {
             $from = "$year-$month-" . $dates[$year][$month]['more'];
-            if ($month==12)
-                $to = ($year+1)."-01-" . $dates[$year+1][1]['less'];
+            if ($month == 12)
+                $to = ($year + 1) . "-01-" . $dates[$year + 1][1]['less'];
             else {
-                for ($newmonth = $month+1; $newmonth<=12; $newmonth++) {
+                for ($newmonth = $month + 1; $newmonth <= 12; $newmonth++) {
                     if (isset($dates[$year][$newmonth]['less'])) {
-                        $to = "$year-".($newmonth)."-" . $dates[$year][$newmonth]['less'];
+                        $to = "$year-" . ($newmonth) . "-" . $dates[$year][$newmonth]['less'];
                         break;
                     }
                 }

Braces +56 added lines, -27 removed lines

@@ -359,15 +359,19 @@ 
         $recess = 'Summer Recess';
         if (isset($dates[$year][7]['all'])) {
             $from = "$year-6-" . $dates[$year][6]['more'];
-        } else {
+        }
+        else {
             $from = "$year-7-" . $dates[$year][7]['more'];
         }
-        if (!isset($dates[$year][9]))
-            $to = "$year-08-31";
-        elseif (isset($dates[$year][9]['all']))
-            $to = "$year-10-" . $dates[$year][10]['less'];
-        else
-            $to = "$year-9-" . $dates[$year][9]['less'];
+        if (!isset($dates[$year][9])) {
+                    $to = "$year-08-31";
+        }
+        elseif (isset($dates[$year][9]['all'])) {
+                    $to = "$year-10-" . $dates[$year][10]['less'];
+        }
+        else {
+                    $to = "$year-9-" . $dates[$year][9]['less'];
+        }
     }
     if ( (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less'])
     || (isset($dates[$year][$month]['more']) && $day > $dates[$year][$month]['more'])
@@ -375,35 +379,50 @@ 
     || (isset($dates[$year][$month]['between'][2]) && $day > $dates[$year][$month]['between'][2] && $day < $dates[$year][$month]['between'][3]) ) {
         switch ($month) {
             case 1: case 12: $recess = 'Christmas Recess'; break;
-            case 2: if ($body==1 || $body==101) $recess = 'Half Term Week';
-                elseif ($body==4) $recess = 'February Recess';
+            case 2: if ($body==1 || $body==101) {
+                $recess = 'Half Term Week';
+            }
+                elseif ($body==4) {
+                    $recess = 'February Recess';
+                }
                 break;
-            case 3: if ($body==1 || $body==101) $recess = 'Easter Recess';
-                elseif ($body==4) $recess = 'Spring Recess';
+            case 3: if ($body==1 || $body==101) {
+                $recess = 'Easter Recess';
+            }
+                elseif ($body==4) {
+                    $recess = 'Spring Recess';
+                }
                 break;
             case 4: if (isset($dates[$year][$month]['more']) && $day > $dates[$year][$month]['more']) {
                     $recess = 'Election Recess';
-                } elseif ($body==4 && $year==2003) {
+                }
+                elseif ($body==4 && $year==2003) {
                     $recess = 'Election Recess';
-                } elseif ($body==1 || $body==101) {
+                }
+                elseif ($body==1 || $body==101) {
                     $recess = 'Easter Recess';
-                } elseif ($body==4) {
+                }
+                elseif ($body==4) {
                     $recess = 'Spring Recess';
                 }
                 break;
             case 5: if ($year==2001 || (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less'])) {
                     $recess = 'Election Recess';
-                } else {
+                }
+                else {
                     $recess = 'Whit Recess';
                 }
                 break;
             case 6: if ($year==2001) {
                     $recess = 'Election Recess';
-                } elseif ($body==1 || $body==101) {
+                }
+                elseif ($body==1 || $body==101) {
                     $recess = 'Whit Recess';
-                } elseif ($body==4) {
+                }
+                elseif ($body==4) {
                     $recess = 'Summer Recess';
-                } else {
+                }
+                else {
                     trigger_error("Argh6");
                 }
                 break;
@@ -411,15 +430,23 @@ 
                 break;
             case 9: if (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less']) {
                     $recess = 'Summer Recess';
-                } elseif ($body==1 || $body==101) {
+                }
+                elseif ($body==1 || $body==101) {
                     $recess = 'Conference Recess';
-                } else {
+                }
+                else {
                     trigger_error("Argh9");
                 }
                 break;
-            case 10: if ($body==1 || $body==101) $recess = 'Conference Recess';
-                elseif ($body==4) $recess = 'Autumn Recess';
-                elseif ($body==5) $recess = 'Halloween Recess';
+            case 10: if ($body==1 || $body==101) {
+                $recess = 'Conference Recess';
+            }
+                elseif ($body==4) {
+                    $recess = 'Autumn Recess';
+                }
+                elseif ($body==5) {
+                    $recess = 'Halloween Recess';
+                }
                 break;
             case 11: $recess = 'Autumn Recess';
                 break;
@@ -427,8 +454,9 @@ 
         }
         if (isset($dates[$year][$month]['less']) && $day < $dates[$year][$month]['less']) {
             $to = "$year-$month-" . $dates[$year][$month]['less'];
-            if ($month==1)
-                $from = ($year-1)."-12-" . $dates[$year-1][12]['more'];
+            if ($month==1) {
+                            $from = ($year-1)."-12-" . $dates[$year-1][12]['more'];
+            }
             else {
                 for ($newmonth = $month-1; $newmonth>=1; $newmonth--) {
                     if (isset($dates[$year][$newmonth]['more'])) {
@@ -440,8 +468,9 @@ 
         }
         if (isset($dates[$year][$month]['more']) && $day > $dates[$year][$month]['more']) {
             $from = "$year-$month-" . $dates[$year][$month]['more'];
-            if ($month==12)
-                $to = ($year+1)."-01-" . $dates[$year+1][1]['less'];
+            if ($month==12) {
+                            $to = ($year+1)."-01-" . $dates[$year+1][1]['less'];
+            }
             else {
                 for ($newmonth = $month+1; $newmonth<=12; $newmonth++) {
                     if (isset($dates[$year][$newmonth]['less'])) {

www/includes/easyparliament/glossary.php

Spacing +23 added lines, -23 removed lines

@@ -21,22 +21,22 @@ 
 */
 
 // This handles basic insertion and approval functions for all epobjects
-include_once INCLUDESPATH."easyparliament/editqueue.php";
-include_once INCLUDESPATH."easyparliament/searchengine.php";
-include_once INCLUDESPATH."url.php";
+include_once INCLUDESPATH . "easyparliament/editqueue.php";
+include_once INCLUDESPATH . "easyparliament/searchengine.php";
+include_once INCLUDESPATH . "url.php";
 
 class GLOSSARY {
 
-    public $num_terms;			// how many glossary entries do we have
+    public $num_terms; // how many glossary entries do we have
                             // (changes depending on how GLOSSARY is called
-    public $hansard_count;		// how many times does the phrase appear in hansard?
-    public $query;				// search term
-    public $glossary_id;		// if this is set then we only have 1 glossary term
-    public $current_term;		// will only be set if we have a valid epobject_id
+    public $hansard_count; // how many times does the phrase appear in hansard?
+    public $query; // search term
+    public $glossary_id; // if this is set then we only have 1 glossary term
+    public $current_term; // will only be set if we have a valid epobject_id
     public $current_letter;
 
     // constructor...
-    public function __construct($args=array()) {
+    public function __construct($args = array()) {
     // We can optionally start the glossary with one of several arguments
     //		1. glossary_id - treat the glossary as a single term
     //		2. glossary_term - search within glossary for a term
@@ -75,16 +75,16 @@ 
 
             // These stop stupid submissions.
             // everything should be lowercase.
-            $this->stopwords = array( "the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate" );
+            $this->stopwords = array("the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate");
 
     }
 
-    public function get_glossary_item($args=array()) {
+    public function get_glossary_item($args = array()) {
         // Search for and fetch glossary item with title or glossary_id
         // We could also search glossary text that contains the title text, for cross references
 
         $this->alphabet = array();
-        foreach (range ("A", "Z") as $letter) {
+        foreach (range("A", "Z") as $letter) {
             $this->alphabet[$letter] = array();
         }
 
@@ -93,11 +93,11 @@ 
             WHERE g.glossary_id=eq.glossary_id AND u.user_id=eq.user_id AND g.visible=1 AND eq.approved=1
             ORDER by g.title");
         if ($q->success() && $q->rows()) {
-            for ($i=0; $i < $q->rows(); $i++) {
-                $this->terms[ $q->field($i,"glossary_id") ] = $q->row($i);
+            for ($i = 0; $i < $q->rows(); $i++) {
+                $this->terms[$q->field($i, "glossary_id")] = $q->row($i);
                 // Now add the epobject to the alphabet navigation.
-                $first_letter = strtoupper(substr($q->field($i,"title"),0,1));
-                $this->alphabet[$first_letter][] = $q->field($i,"glossary_id");
+                $first_letter = strtoupper(substr($q->field($i, "title"), 0, 1));
+                $this->alphabet[$first_letter][] = $q->field($i, "glossary_id");
             }
 
             $this->num_terms = $q->rows();
@@ -140,7 +140,7 @@ 
         }
     }
 
-    public function search_glossary($args=array()) {
+    public function search_glossary($args = array()) {
         // Search for and fetch glossary item with a title
         // Useful for the search page, and nowhere else (so far)
 
@@ -155,8 +155,8 @@ 
             ORDER by g.title";
         $q = $this->db->query($query);
         if ($q->success() && $q->rows()) {
-            for ($i=0; $i < $q->rows(); $i++) {
-                $this->search_matches[ $q->field($i,"glossary_id") ] = $q->row($i);
+            for ($i = 0; $i < $q->rows(); $i++) {
+                $this->search_matches[$q->field($i, "glossary_id")] = $q->row($i);
             }
             $this->num_search_matches = $q->rows();
         }
@@ -192,12 +192,12 @@ 
         global $THEUSER;
 
         if ($data['title'] == '') {
-            error ("Sorry, you can't define a term without a title");
+            error("Sorry, you can't define a term without a title");
             return false;
         }
 
         if ($data['body'] == '') {
-            error ("You haven't entered a definition!");
+            error("You haven't entered a definition!");
             return false;
         }
 
@@ -250,7 +250,7 @@ 
         }
     }
 
-    public function glossarise($body, $tokenize=0, $urlize=0) {
+    public function glossarise($body, $tokenize = 0, $urlize = 0) {
     // Turn a body of text into a link-up wonderland of glossary joy
 
         global $this_page;
@@ -293,7 +293,7 @@ 
             }
             else {
                 if ($this_page == "admin_glossary") {
-                    $link_url = "#gl".$glossary_id;
+                    $link_url = "#gl" . $glossary_id;
                 }
                 else {
                     $link_url = $URL->generate('url');

Braces +11 added lines, -6 removed lines

@@ -107,7 +107,9 @@ 
             if (isset($args['glossary_id']) && ($args['glossary_id'] != "")) {
                 $next = 0; $first_term = null;
                 foreach ($this->terms as $term) {
-                    if (!$first_term) $first_term = $term;
+                    if (!$first_term) {
+                        $first_term = $term;
+                    }
                     $last_term = $term;
                     if ($next == 1) {
                         $this->next_term = $term;
@@ -234,7 +236,8 @@ 
 
         if ($success) {
             return ($success);
-        } else {
+        }
+        else {
             return false;
         }
     }
@@ -278,8 +281,9 @@ 
 
         // check for any glossary terms to replace
         foreach ($this->replace_order as $glossary_id => $count) {
-            if ($glossary_id == $this->glossary_id)
-                continue;
+            if ($glossary_id == $this->glossary_id) {
+                            continue;
+            }
 
             $term_body = $this->terms[$glossary_id]['body'];
             $term_title = $this->terms[$glossary_id]['title'];
@@ -304,8 +308,9 @@ 
         }
         // Highlight all occurrences of another glossary term in the definition.
         $body = preg_replace($findwords, $replacewords, $body, 1);
-        if (isset($this->glossary_id))
-            $body = preg_replace("/(?<![>\.\'\/])\b(" . $this->terms[$this->glossary_id]['title'] . ")\b(?![<\'])/i", '<strong>\\1</strong>', $body, 1);
+        if (isset($this->glossary_id)) {
+                    $body = preg_replace("/(?<![>\.\'\/])\b(" . $this->terms[$this->glossary_id]['title'] . ")\b(?![<\'])/i", '<strong>\\1</strong>', $body, 1);
+        }
 
         // Replace any phrases in wikipedia
         // TODO: Merge this code into above, so our gloss and wikipedia

tests/UserPageTest.php

Spacing +7 added lines, -7 removed lines

@@ -8,7 +8,7 @@ 
      */
     public function getDataSet()
     {
-        return $this->createMySQLXMLDataSet(dirname(__FILE__).'/_fixtures/user.xml');
+        return $this->createMySQLXMLDataSet(dirname(__FILE__) . '/_fixtures/user.xml');
     }
 
     private function fetch_page($vars)
@@ -16,14 +16,14 @@ 
         return $this->base_fetch_page($vars, 'user');
     }
 
-    private function fetch_user_page( $vars = array(), $page = 'user' )
+    private function fetch_user_page($vars = array(), $page = 'user')
     {
-        return $this->base_fetch_page_user( $vars, '1.fbb689a0c092f5534b929d302db2c8a9', $page );
+        return $this->base_fetch_page_user($vars, '1.fbb689a0c092f5534b929d302db2c8a9', $page);
     }
 
     public function testLoginPageLoads()
     {
-        $page = $this->base_fetch_page( array(), 'user/login' );
+        $page = $this->base_fetch_page(array(), 'user/login');
         $this->assertContains('Sign in', $page);
     }
 
@@ -34,7 +34,7 @@ 
             'password' => 'password',
             'submitted' => 'true',
         );
-        $page = $this->base_fetch_page( $vars, 'user/login' );
+        $page = $this->base_fetch_page($vars, 'user/login');
         # it's a redirect which means we should get nothing
         # as we're using the cli version of php :(
         $this->assertEquals('', $page);
@@ -49,7 +49,7 @@ 
 
     public function testEditUserInfo()
     {
-        $page = $this->fetch_user_page( array('pg' => 'edit' ) );
+        $page = $this->fetch_user_page(array('pg' => 'edit'));
         $this->assertContains('Your details', $page);
         $this->assertContains('name="pg" value="edit"', $page);
         $this->assertContains('value="Test"', $page);
@@ -62,7 +62,7 @@ 
             'email' => 'user@example.org',
             'submitted' => 'true',
         );
-        $page = $this->fetch_user_page( $vars );
+        $page = $this->fetch_user_page($vars);
         $this->assertContains('Example User', $page);
     }
 }

tests/FetchPageTestCase.php

Spacing +2 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
     protected function base_fetch_page($vars, $dir, $page = 'index.php', $req_uri = '')
     {
         foreach ($vars as $k => $v) {
-            $vars[$k] =  $k . '=' . urlencode($v);
+            $vars[$k] = $k . '=' . urlencode($v);
         }
 
         if (!$req_uri) {
@@ -26,7 +26,7 @@ 
     protected function base_fetch_page_user($vars, $cookie, $dir, $page = 'index.php', $req_uri = '')
     {
         foreach ($vars as $k => $v) {
-            $vars[$k] =  $k . '=' . urlencode($v);
+            $vars[$k] = $k . '=' . urlencode($v);
         }
 
         if (!$req_uri) {