mysociety / theyworkforyou

www/includes/easyparliament/templates/html/homepage/devolved-list.php

Spacing +3 added lines, -3 removed lines

@@ -1,9 +1,9 @@
 <?php
-$nav_items =  [
+$nav_items = [
     ['hansard', 'alldebatesfront', 'mps', 'peers', 'interests_home', 'wranswmsfront', 'divisions_recent_commons', 'divisions_recent_lords'],
     ['sp_home', 'sp_home', 'spdebatesfront', 'msps', 'interest_category_sp', 'spwransfront', 'divisions_recent_sp'],
-    ['wales_home', 'wales_home', 'wales_debates', 'mss','interest_category_wp', 'welshlanguage', 'divisions_recent_wales'],
-    ['ni_home', 'ni_home', 'nioverview', 'mlas','interest_category_ni'],
+    ['wales_home', 'wales_home', 'wales_debates', 'mss', 'interest_category_wp', 'welshlanguage', 'divisions_recent_wales'],
+    ['ni_home', 'ni_home', 'nioverview', 'mlas', 'interest_category_ni'],
 ];
 
 ?>  

classes/DataClass/Regmem/CategoryList.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 
     public function limitToCategoryIds(array $categoryIds) {
         // Filter the categories to only include those with the given IDs
-        $this->items = array_filter($this->items, function ($category) use ($categoryIds) {
+        $this->items = array_filter($this->items, function($category) use ($categoryIds) {
             return in_array($category->category_id, $categoryIds);
         });
     }

classes/Renderer/Header.php

Spacing +3 added lines, -3 removed lines

@@ -169,7 +169,7 @@ 
 
         if ($nextprev) {
             // Four different kinds of back/forth links we might build.
-            $links =  ["first", "prev", "up", "next", "last"];
+            $links = ["first", "prev", "up", "next", "last"];
 
             foreach ($links as $type) {
                 if ($link = $this->generate_next_prev_link($nextprev, $type)) {
@@ -307,9 +307,9 @@ 
         // Page names mapping to those in metadata.php.
         // Links in the top menu, and the sublinks we see if
         // we're within that section.
-        $nav_items =  [
+        $nav_items = [
             ['home'],
-            ['hansard', 'mps', 'peers', 'alldebatesfront', 'interests_home', 'wranswmsfront', 'pbc_front', 'divisions_recent_commons', 'divisions_recent_lords',  'calendar_summary'],
+            ['hansard', 'mps', 'peers', 'alldebatesfront', 'interests_home', 'wranswmsfront', 'pbc_front', 'divisions_recent_commons', 'divisions_recent_lords', 'calendar_summary'],
             ['sp_home', 'spoverview', 'msps', 'interest_category_sp', 'spdebatesfront', 'divisions_recent_sp'], #'spwransfront'
             ['ni_home', 'nioverview', 'mlas', 'interest_category_ni'],
             ['wales_home', 'seneddoverview', 'mss', 'interest_category_wp', 'wales_debates', 'divisions_recent_wales'],

www/includes/easyparliament/templates/html/mp/votes.php

Indentation +4 added lines, -4 removed lines

@@ -131,8 +131,8 @@ 
 
                     <ul class="vote-descriptions">
                               <?php foreach ($sig_diff_policy->policy_pairs as $policy_pair) {
-                                  include '_vote_description.php';
-                              } ?>
+                                    include '_vote_description.php';
+                                } ?>
                             </ul>
 
                     <?php } ?>
@@ -165,9 +165,9 @@ 
                             <ul class="vote-descriptions">
                               <?php foreach ($segment->policy_pairs as $policy_pair) {
 
-                                  include '_vote_description.php';
+                                    include '_vote_description.php';
 
-                              } ?>
+                                } ?>
                             </ul>
 
                             <p class="voting-information-provenance">

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
                         <nav class="subpage-content-list js-accordion" aria-label="Comparison periods">
                             <h3 class="js-accordion-button">For period: <?= $comparison_period->description ?></h3>
                             <ul class="js-accordion-content">
-                                <?php foreach($available_periods as $period) { ?>
+                                <?php foreach ($available_periods as $period) { ?>
                                     <li><a href="?comparison_period=<?= $period->lslug() ?>" class="<?= $period->lslug() === $comparison_period->lslug() ? 'active-comparison-period' : '' ?>"><?= $period->description ?></a></li>
                                 <?php } ?>
                             </ul>

tests/DivisionsTest.php

Spacing +3 added lines, -3 removed lines

@@ -13,12 +13,12 @@ 
     }
 
     private function fetch_mp_recent_page() {
-        $vars = [ 'pagetype' => 'recent', 'pid' => 2, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/recent' ];
+        $vars = ['pagetype' => 'recent', 'pid' => 2, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/recent'];
         return $this->base_fetch_page($vars, 'mp', 'index.php', '/mp/recent.php');
     }
 
     private function fetch_recent_page() {
-        return $this->base_fetch_page(['url' => '/divisions' ], 'divisions', 'index.php', '/divisions/index.php');
+        return $this->base_fetch_page(['url' => '/divisions'], 'divisions', 'index.php', '/divisions/index.php');
     }
 
 
@@ -54,7 +54,7 @@ 
     }
 
     public function testSingleDivision() {
-        $page = $this->base_fetch_page(['url' => '/divisions/division.php', 'vote' => 'pw-3012-01-01-1-commons' ], 'divisions', 'division.php', '/divisions/division.php');
+        $page = $this->base_fetch_page(['url' => '/divisions/division.php', 'vote' => 'pw-3012-01-01-1-commons'], 'divisions', 'division.php', '/divisions/division.php');
         $this->assertStringContainsString('A majority of MPs  <b>voted in favour</b> of a thing', $page);
         $this->assertStringContainsString('Aye: 200', $page);
         $this->assertStringNotContainsString('No:', $page); # Summary 100, but no actual votes. In reality, summary can only be <= actual.

classes/Renderer/Markdown.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
         $og_image_parl = $extra_vars['_social_image_parliament'] ?? 'uk';
         $og_image_url = \MySociety\TheyWorkForYou\Url::generateSocialImageUrl($og_image_title, $og_image_subtitle, $og_image_parl);
 
-        $html = preg_replace_callback('/<h([1-3])>([^<]+)<\/h[1-3]>/i', function ($matches) {
+        $html = preg_replace_callback('/<h([1-3])>([^<]+)<\/h[1-3]>/i', function($matches) {
             $level = $matches[1];
             $htitle = $matches[2];
             $slug = slugify($htitle);

classes/PolicyDistributionCollection.php

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
             $group_name = $policies->getSetDescriptions()[$set_slug];
             $group_slug = $set_slug;
             $comparison_period_slug = $period_slug;
-            $policy_pairs = array_filter($pairs, function ($pair) use ($policy_ids) {
+            $policy_pairs = array_filter($pairs, function($pair) use ($policy_ids) {
                 $is_policy_valid = in_array($pair->getPolicyID(), $policy_ids);
                 $has_own_distribution = $pair->member_distribution !== null && !$pair->member_distribution->noDataAvailable();
                 return $is_policy_valid && $has_own_distribution;

tests/PartyTest.php

Spacing +3 added lines, -3 removed lines

@@ -108,7 +108,7 @@ 
 
 
     private function getMemberFromPersonId($person_id) {
-        return new MySociety\TheyWorkForYou\Member([ "person_id" => $person_id ]);
+        return new MySociety\TheyWorkForYou\Member(["person_id" => $person_id]);
     }
 
     public function testMPPartyPolicyTextWhenDiffersVotes() {
@@ -137,7 +137,7 @@ 
         // this is a single person party i think - so no party comparison?
         // need to check what votes would actually produce
 
-        $page = $this->fetch_page(['pid' => 4, 'pagetype' => 'votes','url' => '/mp/4/test_mp_d/test_westminster_constituency/votes']);
+        $page = $this->fetch_page(['pid' => 4, 'pagetype' => 'votes', 'url' => '/mp/4/test_mp_d/test_westminster_constituency/votes']);
         $this->assertStringContainsString('Test MP D', $page);
         $this->assertStringContainsString('<li class="vote-description"', $page);
         $this->assertStringNotContainsString('comparable B Party MPs voted', $page);
@@ -148,7 +148,7 @@ 
 
         // this is just a boring, person aligned with party example
 
-        $page = $this->fetch_page(['pagetype' => 'votes', 'pid' => 16,  'url' => '/mp/16/test_mp_g_party_2/test_westminster_constituency/votes']);
+        $page = $this->fetch_page(['pagetype' => 'votes', 'pid' => 16, 'url' => '/mp/16/test_mp_g_party_2/test_westminster_constituency/votes']);
         $this->assertStringContainsString('Test MP G Party 2', $page);
 
         $this->assertStringNotContainsString('sometimes differs from their party colleagues', $page);

www/includes/easyparliament/templates/html/mp/memberships.php

Braces +4 added lines, -1 removed lines

@@ -114,7 +114,10 @@
                                                 <ul>
                                                     <li><span class="appg-property-label">Purpose:</span> <?= $membership->appg->purpose ?></li>
                                                     <li><span class="appg-property-label">Membership Source:</span> <a href="<?= $membership->membership_source_url ?>">Source</a></li>
-                                                    <li><span class="appg-property-label">APPG Website:</span> <?php if ($membership->appg->website): ?><a href="<?= $membership->appg->website ?>"><?= $membership->appg->website ?></a><?php else: ?>N/A<?php endif; ?></li>
+                                                    <li><span class="appg-property-label">APPG Website:</span> <?php if ($membership->appg->website): ?><a href="<?= $membership->appg->website ?>"><?= $membership->appg->website ?></a><?php else {
+    : ?>N/A<?php endif;
+}
+?></li>
                                                     <li><span class="appg-property-label">APPG register:</span> <a href="<?= $membership->appg->source_url ?>">Parliament website</a></li>
                                                 </ul>
                                             </div>