mysociety / theyworkforyou

www/docs/admin/photos.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
 </form>
 
 <p style="clear:both; margin-top: 3em"><a href="/images/mps/photo-status.php">List MPs without photos</a></p>
-EOF;
+eof;
 
     return $out;
 }
@@ -193,7 +193,7 @@ 
     <span class="formw"><input type="submit" name="submit" value="Update attribution"></span>
 </div>
 </form>
-EOF;
+eof;
 
     return $out;
 }

Spacing +2 added lines, -2 removed lines

@@ -94,7 +94,7 @@ 
 
     $houses = array(1 => 'MP', 'Lord', 'MLA', 'MSP');
 
-    for ($i=0; $i<$q->rows(); $i++) {
+    for ($i = 0; $i < $q->rows(); $i++) {
         $p_id = $q->field($i, 'person_id');
         $house = $q->field($i, 'house');
         $desc = member_full_name($house, $q->field($i, 'title'), $q->field($i, 'given_name'), $q->field($i, 'family_name'), $q->field($i, 'lordofname')) .
@@ -112,7 +112,7 @@ 
         } else {
             $desc .= ' [no photo]';
         }
-        $out .= '<option value="'.$p_id.'">'.$desc.'</option>' . "\n";
+        $out .= '<option value="' . $p_id . '">' . $desc . '</option>' . "\n";
     }
 
     $out .= ' </select></span> </div> ';

Braces +45 added lines, -28 removed lines

@@ -26,7 +26,8 @@ 
 $out = '';
 if (get_http_var('submit')) {
     $out = DEVSITE ? submit_photo() : submit_attribution();
-} else {
+}
+else {
     $out = DEVSITE ? display_photo_form() : display_attribution_form();
 }
 print $out;
@@ -36,28 +37,36 @@ 
     $pid = intval(get_http_var('pid'));
     $errors = array();
 
-    if (!array_key_exists('photo', $_FILES))
-        array_push($errors, 'Not got the photo.');
-    elseif ($_FILES['photo']['error'] > 0)
-        array_push($errors, 'There was an error uploading the photo.');
-    elseif (!is_uploaded_file($_FILES['photo']['tmp_name']))
-        array_push($errors, 'Did not get an uploaded file.');
+    if (!array_key_exists('photo', $_FILES)) {
+            array_push($errors, 'Not got the photo.');
+    }
+    elseif ($_FILES['photo']['error'] > 0) {
+            array_push($errors, 'There was an error uploading the photo.');
+    }
+    elseif (!is_uploaded_file($_FILES['photo']['tmp_name'])) {
+            array_push($errors, 'Did not get an uploaded file.');
+    }
     else {
         $tmp_name = $_FILES['photo']['tmp_name'];
 
         $image = new Imagick();
         $image->readImage($tmp_name);
-        if (!$image)
-            array_push($errors, 'Failed to read image from uploaded file');
+        if (!$image) {
+                    array_push($errors, 'Failed to read image from uploaded file');
+        }
             $imageS = clone $image;
-        if (!$image->scaleImage(0, 118))
-            array_push($errors, 'Scaling large failed');
-        if (!$imageS->scaleImage(0, 59))
-            array_push($errors, 'Scaling small failed');
-        if (!$image->writeImage("$dir/mpsL/$pid.jpeg"))
-            array_push($errors, "Saving to $dir/mpsL/$pid.jpeg failed");
-        if (!$imageS->writeImage("$dir/mps/$pid.jpeg"))
-            array_push($errors, "Saving to $dir/mps/$pid.jpeg failed");
+        if (!$image->scaleImage(0, 118)) {
+                    array_push($errors, 'Scaling large failed');
+        }
+        if (!$imageS->scaleImage(0, 59)) {
+                    array_push($errors, 'Scaling small failed');
+        }
+        if (!$image->writeImage("$dir/mpsL/$pid.jpeg")) {
+                    array_push($errors, "Saving to $dir/mpsL/$pid.jpeg failed");
+        }
+        if (!$imageS->writeImage("$dir/mps/$pid.jpeg")) {
+                    array_push($errors, "Saving to $dir/mps/$pid.jpeg failed");
+        }
         if (!$errors) {
             print "<pre>";
             chdir($dir);
@@ -70,8 +79,9 @@ 
         }
     }
 
-    if ($errors)
-        return display_photo_form($errors);
+    if ($errors) {
+            return display_photo_form($errors);
+    }
     return "<p><em>Photo uploaded and resized for pid $pid</em> &mdash; check how it looks <a href=\"/mp?p=$pid\">on their page</a></p>" . display_photo_form();
 }
 
@@ -99,7 +109,9 @@ 
         $house = $q->field($i, 'house');
         $desc = member_full_name($house, $q->field($i, 'title'), $q->field($i, 'given_name'), $q->field($i, 'family_name'), $q->field($i, 'lordofname')) .
                 " " . $houses[$house];
-        if ($q->field($i, 'party')) $desc .= ' (' . $q->field($i, 'party') . ')';
+        if ($q->field($i, 'party')) {
+            $desc .= ' (' . $q->field($i, 'party') . ')';
+        }
         if ($q->field($i, 'constituency')) {
             $desc .= ', ' . $q->field($i, 'constituency');
         }
@@ -107,9 +119,11 @@ 
         list($dummy, $sz) = MySociety\TheyWorkForYou\Utility\Member::findMemberImage($p_id);
         if ($sz == 'L') {
             $desc .= ' [has large photo]';
-        } elseif ($sz == 'S') {
+        }
+        elseif ($sz == 'S') {
             $desc .= ' [has small photo]';
-        } else {
+        }
+        else {
             $desc .= ' [no photo]';
         }
         $out .= '<option value="'.$p_id.'">'.$desc.'</option>' . "\n";
@@ -150,13 +164,16 @@ 
     $attr_link = get_http_var('attr_link');
     $errors = array();
 
-    if (!$pid || !$attr_text)
-        array_push($errors, 'Missing information');
-    elseif ($attr_link && substr($attr_link, 0, 4) != 'http')
-        array_push($errors, 'Bad link');
+    if (!$pid || !$attr_text) {
+            array_push($errors, 'Missing information');
+    }
+    elseif ($attr_link && substr($attr_link, 0, 4) != 'http') {
+            array_push($errors, 'Bad link');
+    }
 
-    if ($errors)
-        return display_attribution_form($errors);
+    if ($errors) {
+            return display_attribution_form($errors);
+    }
 
     # UPDATE
     global $db;

www/docs/section.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 }
 
 if ($type = ucfirst(get_http_var('type'))) {
-    $class_name = "MySociety\TheyWorkForYou\SectionView\\${type}View";
+    $class_name = "MySociety\TheyWorkForYou\SectionView\\${type}view";
     $view = new $class_name();
     $data = $view->display();
     if ($data) {

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     $view = new $class_name();
     $data = $view->display();
     if ($data) {
-        if ( !empty($data['template']) ) {
+        if (!empty($data['template'])) {
             $template = $data['template'];
         } else {
             $template = 'section/section';

Braces +2 added lines, -1 removed lines

@@ -19,7 +19,8 @@
     if ($data) {
         if ( !empty($data['template']) ) {
             $template = $data['template'];
-        } else {
+        }
+        else {
             $template = 'section/section';
         }
         MySociety\TheyWorkForYou\Renderer::output($template, $data);

scripts/populate-policy-images.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 }
 
 $count = 0;
-while ( ( $policy = fgetcsv($file) ) !== FALSE ) {
+while ( ( $policy = fgetcsv($file) ) !== false ) {
     if ( intval($policy[0]) ) {
         $policy_id = $policy[0];
         $img_id = $policy[1] ? $policy[1] : $policy_id;

Spacing +4 added lines, -4 removed lines

@@ -33,7 +33,7 @@ 
     exit(1);
 }
 
-if ( !file_exists($csvfile) ) {
+if (!file_exists($csvfile)) {
     print "$csvfile cannot be found\n";
     exit(1);
 }
@@ -46,8 +46,8 @@ 
 }
 
 $count = 0;
-while ( ( $policy = fgetcsv($file) ) !== FALSE ) {
-    if ( intval($policy[0]) ) {
+while (($policy = fgetcsv($file)) !== FALSE) {
+    if (intval($policy[0])) {
         $policy_id = $policy[0];
         $img_id = $policy[1] ? $policy[1] : $policy_id;
         $title = $policy[2];
@@ -69,7 +69,7 @@ 
                 ':image_attribution' => $attribution,
                 ':license_url' => $licence_url)
         );
-        if ( $q->success() ) {
+        if ($q->success()) {
             $count += $q->affected_rows();
         } else {
             print "failed to update data for $policy_id\n";

Braces +2 added lines, -1 removed lines

@@ -71,7 +71,8 @@
         );
         if ( $q->success() ) {
             $count += $q->affected_rows();
-        } else {
+        }
+        else {
             print "failed to update data for $policy_id\n";
         }
     }

tests/Bootstrap.php

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -8,9 +8,9 @@ 
 // Test to make sure we have the test DB environment variables. If not, this isn't testing, so abort.
 // Define the DB connection constants before we do anything else.
 if (
-    isset($_SERVER['TWFY_TEST_DB_HOST']) AND
-    isset($_SERVER['TWFY_TEST_DB_USER']) AND
-    isset($_SERVER['TWFY_TEST_DB_PASS']) AND
+    isset($_SERVER['TWFY_TEST_DB_HOST']) and
+    isset($_SERVER['TWFY_TEST_DB_USER']) and
+    isset($_SERVER['TWFY_TEST_DB_PASS']) and
     isset($_SERVER['TWFY_TEST_DB_NAME'])
 ) {
 
@@ -37,7 +37,7 @@ 
 }
 
 // Explicitly declare we're in testing (avoids trying deploy-only things)
-define('TESTING', TRUE);
+define('TESTING', true);
 
 // Load up the init script (handles the rest of the config, DB connection etc)
 include_once('www/includes/easyparliament/init.php');

Spacing +2 added lines, -2 removed lines

@@ -21,13 +21,13 @@
     define('OPTION_TWFY_DB_NAME', $_SERVER['TWFY_TEST_DB_NAME']);
     
     // Define the base directory
-    define ("BASEDIR", dirname(__FILE__) . '/../www/docs'); 
+    define("BASEDIR", dirname(__FILE__) . '/../www/docs'); 
 
     # point to the default mapit
     define('OPTION_MAPIT_URL', 'https://mapit.mysociety.org/');
 
     // If there isn't a config file (most likely this is running an automated test) copy one in.
-    if ( ! file_exists(dirname(__FILE__) . '/../conf/general')) {
+    if (!file_exists(dirname(__FILE__) . '/../conf/general')) {
         copy(dirname(__FILE__) . '/../conf/general-example', dirname(__FILE__) . '/../conf/general');
     }
 

Braces +2 added lines, -1 removed lines

@@ -31,7 +31,8 @@
         copy(dirname(__FILE__) . '/../conf/general-example', dirname(__FILE__) . '/../conf/general');
     }
 
-} else {
+}
+else {
     echo "Testing environment variables not set. This will cause bad things to happen if testing happens on production. Aborting.\n";
     exit(1);
 }

www/docs/alert/update-mp/index.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-$new_style_template = TRUE;
+$new_style_template = true;
 
 include_once '../../../includes/easyparliament/init.php';
 include_once INCLUDESPATH . 'easyparliament/member.php';

www/docs/user/login/fb.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
     If the input is not OK, the form is displayed again with error messages.
 */
 
-$new_style_template = TRUE;
+$new_style_template = true;
 
 include_once '../../../includes/easyparliament/init.php';
 # need to include this as login code uses error_message

Indentation +3 added lines, -3 removed lines

@@ -27,11 +27,11 @@
 
 $data['fb_login_url'] = $login->getLoginURL();
 if (isset($data['token'])) {
-  $success = $login->loginUser($data['token']);
-  if (!$success) {
+    $success = $login->loginUser($data['token']);
+    if (!$success) {
     $data['error'] = 'Could not login using Facebook token';
     \MySociety\TheyWorkForYou\Renderer::output('login/facebook', $data);
-  }
+    }
 } else {
     \MySociety\TheyWorkForYou\Renderer::output('login/facebook', $data);
 }

Braces +2 added lines, -1 removed lines

@@ -32,6 +32,7 @@
     $data['error'] = 'Could not login using Facebook token';
     \MySociety\TheyWorkForYou\Renderer::output('login/facebook', $data);
   }
-} else {
+}
+else {
     \MySociety\TheyWorkForYou\Renderer::output('login/facebook', $data);
 }

classes/User.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
  */
 
 class User {
-    public function getUserDetails($user_id = False) {
+    public function getUserDetails($user_id = false) {
         global $THEUSER;
 
         $user = $THEUSER;
@@ -250,7 +250,7 @@ 
             }
 
             if ($details['email'] != $THEUSER->email()) {
-                $results['email_changed'] = True;
+                $results['email_changed'] = true;
             }
 
 

Doc Comments +3 added lines

@@ -321,6 +321,9 @@
         return array();
     }
 
+    /**
+     * @param Member $member
+     */
     private function constructMPData($member, $user, $mp_house) {
         $mp_data = array();
         $mp_data['name'] = $member->full_name();

Spacing +11 added lines, -11 removed lines

@@ -33,10 +33,10 @@ 
         $data['email'] = $user->email();
         $data['emailpublic'] = $user->emailpublic() == true ? "Yes" : "No";
         $data['optin'] = $user->optin() == true ? "Yes" : "No";
-        $data['postcode']	= $user->postcode();
+        $data['postcode'] = $user->postcode();
         $data['website']	= $user->url();
-        $data['registrationtime']	= $user->registrationtime();
-        $data['status']= $user->status();
+        $data['registrationtime'] = $user->registrationtime();
+        $data['status'] = $user->status();
         $data["deleted"] = $user->deleted();
         $data["confirmed"] = $user->confirmed();
         $data["status"] = $user->status();
@@ -243,10 +243,10 @@ 
         // Who are we updating? $THEUSER or someone else?
         if ($this_page == "otheruseredit") {
             $who = 'the user’s';
-            $success = $THEUSER->update_other_user ( $details );
+            $success = $THEUSER->update_other_user($details);
         } else {
             $who = 'your';
-            $success = $THEUSER->update_self ( $details );
+            $success = $THEUSER->update_self($details);
         }
 
 
@@ -278,12 +278,12 @@ 
         // If this goes well, the user will have their data
         // added to the database and a confirmation email
         // will be sent to them.
-        $success = $THEUSER->add ( $details );
+        $success = $THEUSER->add($details);
 
         $errors = array();
 
         if (!$success) {
-            $errors["db"] = "Sorry, we were unable to create an account for you. Please <a href=\"mailto:". str_replace('@', '&#64;', CONTACTEMAIL) . "\">let us know</a>. Thanks.";
+            $errors["db"] = "Sorry, we were unable to create an account for you. Please <a href=\"mailto:" . str_replace('@', '&#64;', CONTACTEMAIL) . "\">let us know</a>. Thanks.";
         }
 
         return $errors;
@@ -291,7 +291,7 @@ 
 
     public function getRep($cons_type, $mp_house) {
         global $THEUSER;
-        if ( !$THEUSER->has_postcode() ) {
+        if (!$THEUSER->has_postcode()) {
             return array();
         }
 
@@ -304,11 +304,11 @@ 
         // Scottish homepage
         try {
             $constituencies = \MySociety\TheyWorkForYou\Utility\Postcode::postcodeToConstituencies($THEUSER->postcode());
-            if ( isset($constituencies[$cons_type]) ) {
+            if (isset($constituencies[$cons_type])) {
                 $constituency = $constituencies[$cons_type];
                 $MEMBER = new Member(array('constituency'=>$constituency, 'house'=> $mp_house));
             }
-        } catch ( MemberException $e ) {
+        } catch (MemberException $e) {
             return array();
         }
 
@@ -345,7 +345,7 @@ 
         $mreg = array();
         if ($THEUSER->isloggedin() && $THEUSER->postcode() != '' || $THEUSER->postcode_is_set()) {
             $reps = \MySociety\TheyWorkForYou\Member::getRegionalList($THEUSER->postcode, $mp_house, $cons_type);
-            foreach ( $reps as $rep ) {
+            foreach ($reps as $rep) {
                 $member = new \MySociety\TheyWorkForYou\Member(array('person_id' => $rep['person_id']));
                 $mreg[$rep['person_id']] = $this->constructMPData($member, $THEUSER, $mp_house);
             }

Braces +24 added lines, -12 removed lines

@@ -62,7 +62,8 @@ 
             $details = $this->getUserDetails();
             $details["password"] = '';
             $details["emailpublic"] = false;
-        } else {
+        }
+        else {
             $details["firstname"] = trim(get_http_var("firstname"));
             $details["lastname"] = trim(get_http_var("lastname"));
 
@@ -96,14 +97,16 @@ 
             if (get_http_var("deleted") != "") {
                 $deleted = get_http_var("deleted");
                 $details["deleted"] = $deleted[0] == "true" ? true : false;
-            } else {
+            }
+            else {
                 $details['deleted'] = false;
             }
 
             if (get_http_var("confirmed") != "") {
                 $confirmed = get_http_var("confirmed");
                 $details["confirmed"] = $confirmed[0] == "true" ? true : false;
-            } else {
+            }
+            else {
                 $details['confirmed'] = false;
             }
         }
@@ -139,11 +142,13 @@ 
                 if ($details["email"] == "") {
                     $errors["email"] = "Please enter an email address";
 
-                } elseif (!validate_email($details["email"])) {
+                }
+                elseif (!validate_email($details["email"])) {
                     // validate_email() is in includes/utilities.php
                     $errors["email"] = "Please enter a valid email address";
 
-                } else {
+                }
+                else {
 
                     $USER = new \USER;
                     $id_of_user_with_this_addresss = $USER->email_exists($details["email"], true);
@@ -159,7 +164,8 @@ 
                             $errors["email"] = "Someone else has already joined with this email address";
                         }
 
-                    } else {
+                    }
+                    else {
                         // User is joining. Check no one is already here with this email.
                         if ($this_page == "userjoin" && $id_of_user_with_this_addresss) {
                             $errors["email"] = "There is already a user with this email address";
@@ -175,7 +181,8 @@ 
                 if ($details["password"] == "") {
                     $errors["password"] = "Please enter a password";
 
-                } elseif (strlen($details["password"]) < 6) {
+                }
+                elseif (strlen($details["password"]) < 6) {
                     $errors["password"] = "Please enter at least six characters";
                 }
 
@@ -187,7 +194,8 @@ 
                     $errors["password"] = "The passwords did not match. Please try again.";
                 }
 
-            } else {
+            }
+            else {
 
                 // Update details pages.
 
@@ -205,7 +213,8 @@ 
         if ($details["postcode"] != "") {
             if (!validate_postcode($details["postcode"])) {
                 $errors["postcode"] = "Sorry, this isn't a valid UK postcode.";
-            } else {
+            }
+            else {
                 try {
                     $mp = new \MySociety\TheyWorkForYou\Member(array(
                         'postcode' => $details['postcode'],
@@ -244,7 +253,8 @@ 
         if ($this_page == "otheruseredit") {
             $who = 'the user&rsquo;s';
             $success = $THEUSER->update_other_user ( $details );
-        } else {
+        }
+        else {
             $who = 'your';
             $success = $THEUSER->update_self ( $details );
         }
@@ -255,7 +265,8 @@ 
 
             if ($this_page == 'otheruseredit') {
                 $this_page = "userview";
-            } else {
+            }
+            else {
                 $this_page = "userviewself";
             }
 
@@ -264,7 +275,8 @@ 
             }
 
 
-        } else {
+        }
+        else {
             $results['errors'] = array("db" => "Sorry, we were unable to update $who details. Please <a href=\"mailto:" . str_replace('@', '&#64;', CONTACTEMAIL) . "\">let us know</a> what you were trying to change. Thanks.");
         }
 

www/docs/user/index.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         // And make sure the user is allowed to do this!
 
         $template = 'user/form';
-        if (is_numeric( get_http_var("u") ) && $THEUSER->is_able_to("edituser")) {
+        if (is_numeric(get_http_var("u")) && $THEUSER->is_able_to("edituser")) {
 
             $data = $user->getUserDetails(get_http_var('u'));
             $data['showall'] = true;

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -5,7 +5,7 @@ 
  * page so leave it like that for now.
  */
 
-$new_style_template = TRUE;
+$new_style_template = true;
 
 include_once '../../includes/easyparliament/init.php';
 # need to include this as login code uses error_message
@@ -127,7 +127,7 @@ 
                 $data['errors'] = $results['errors'];
                 $template = 'user/form';
             } else {
-                $data['edited'] = True;
+                $data['edited'] = true;
                 if (isset($results['email_changed'])) {
                     $data['email_changed'] = $results['email_changed'];
                 }

Indentation +4 added lines, -4 removed lines

@@ -106,12 +106,12 @@
 
 // if data has been submitted then handle that
 if (
-      get_http_var("submitted") == "true" && (
+        get_http_var("submitted") == "true" && (
         $this_page == 'useredit' || $this_page == 'otheruseredit' || $this_page == 'userjoin'
-      )
-   ) {
+        )
+    ) {
     // Put all the user-submitted data in an array.
-     $data = $user->getUpdateDetails($this_page, $THEUSER);
+        $data = $user->getUpdateDetails($this_page, $THEUSER);
 
     if ($this_page == 'useredit') {
         $data['facebook_user'] = $THEUSER->facebook_user();

Braces +18 added lines, -9 removed lines

@@ -41,7 +41,8 @@ 
             $data['pg'] = 'editother';
             $this_page = "otheruseredit";
 
-        } else if ($THEUSER->isloggedin()) {
+        }
+        else if ($THEUSER->isloggedin()) {
             // Revert to editing THEUSER's own info.
             $data = $user->getUserDetails();
             $data['pg'] = 'edit';
@@ -52,7 +53,8 @@ 
                 $this_page = 'userviewself';
             }
 
-        } else {
+        }
+        else {
             $this_page = "userjoin";
             $template = 'user/join';
         }
@@ -71,7 +73,8 @@ 
                 $this_page = 'userviewself';
             }
             $data['pg'] = 'edit';
-        } else {
+        }
+        else {
             // Unlikely to get to this page without being logged in,
             // but just in case, show them the blank form.
             $this_page = "userjoin";
@@ -89,12 +92,14 @@ 
             $template = 'user/index';
             $data = $user->getUserDetails();
             $this_page = 'userviewself';
-        } else if (is_numeric(get_http_var('u'))) {
+        }
+        else if (is_numeric(get_http_var('u'))) {
             // Viewing someone else's details.
             $template = 'user/view_user';
             $data = $user->getUserDetails(get_http_var('u'));
             $this_page = "userview";
-        } else {
+        }
+        else {
             // probably want to login
             $URL = new URL('userlogin');
             $URL->insert(array('ret'=>'/user/'));
@@ -129,25 +134,29 @@ 
         if ($this_page == 'userjoin') {
             $template = 'user/join';
         }
-    } else {
+    }
+    else {
         if ($this_page == 'useredit' || $this_page == 'otheruseredit') {
             $results = $user->update($data);
             if (isset($results['errors'])) {
                 $data['errors'] = $results['errors'];
                 $template = 'user/form';
-            } else {
+            }
+            else {
                 $data['edited'] = True;
                 if (isset($results['email_changed'])) {
                     $data['email_changed'] = $results['email_changed'];
                 }
                 $template = 'user/index';
             }
-        } else {
+        }
+        else {
             $errors = $user->add($data);
             if (sizeof($errors) > 0) {
                 $data['errors'] = $errors;
                 $template = 'user/join';
-            } else {
+            }
+            else {
                 $template = 'user/welcome';
             }
         }

www/includes/easyparliament/templates/html/user/form.php

Indentation +1 added lines, -1 removed lines

@@ -125,7 +125,7 @@
                   <span class="label">Security status:</span>
                   <span class="formw"><select name="status">
                   <?php
-                  foreach ($statuses as $n => $status_name) { ?>
+                    foreach ($statuses as $n => $status_name) { ?>
                     <option value="<?= $status_name ?>"<?= $status_name == $status ? ' selected' : '' ?>>
                       <?= $status_name ?>
                     </option>

Spacing +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
 
                 <input type="hidden" name="submitted" value="true">
 
-                <?php if (isset($ret) && $ret != '' ) { ?>
+                <?php if (isset($ret) && $ret != '') { ?>
                     <input type="hidden" name="ret" value="<?= _htmlentities($ret) ?>">
                 <?php } ?>
 

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
                 <input type="hidden" name="pg" value="edit">
               </form>
             <?php } else { ?>
-              <?php if (isset($showall) && $showall == True && isset($user_id)) { ?>
+              <?php if (isset($showall) && $showall == true && isset($user_id)) { ?>
               <h1>Edit the user&rsquo;s details</h1>
               <?php } else { ?>
               <h1>Edit your details</h1>
@@ -142,7 +142,7 @@ 
                     <input type="radio" name="emailpublic" id="emailpublicfalse" value="false" <?= $emailpublic == 'No' ? ' checked' : '' ?>> <label for="emailpublicfalse">No</label></span>
                 </div>
 
-                <?php if (isset($showall) && $showall == True) { ?>
+                <?php if (isset($showall) && $showall == true) { ?>
                   <?php if (isset($errors['status'])) { ?>
                   <p class="error">
                       <?= $errors['status'] ?>
@@ -210,7 +210,7 @@ 
                     <input type="hidden" name="pg" value="<?= $pg ?>">
                 <?php } ?>
 
-                <?php if (isset($showall) && $showall == True && isset($user_id)) { ?>
+                <?php if (isset($showall) && $showall == true && isset($user_id)) { ?>
                     <input type="hidden" name="u" value="<?= _htmlentities($user_id) ?>">
                 <?php } ?>
 

Braces +4 added lines, -2 removed lines

@@ -37,10 +37,12 @@
 
                 <input type="hidden" name="pg" value="edit">
               </form>
-            <?php } else { ?>
+            <?php }
+else { ?>
               <?php if (isset($showall) && $showall == True && isset($user_id)) { ?>
               <h1>Edit the user&rsquo;s details</h1>
-              <?php } else { ?>
+              <?php }
+else { ?>
               <h1>Edit your details</h1>
               <?php } ?>