MySociety\TheyWorkForYou\DataClass\Groups\MiniGroupList

Complexity

Total Complexity

9

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	findBySlug()	0	7	3
A	findByName()	0	7	3
A	__construct()	0	2	1
A	uk_committees()	0	9	2

<?php

declare(strict_types=1);

namespace MySociety\TheyWorkForYou\DataClass\Groups;

use MySociety\TheyWorkForYou\DataClass\BaseCollection;

/**
 * @extends BaseCollection<MiniGroup>
 */
class MiniGroupList extends BaseCollection {
    public function __construct(MiniGroup ...$members) {
        $this->items = $members;

It seems like $members of type array<integer,MySociety\TheyWorkForYou\DataClass\Groups\MiniGroup> is incompatible with the declared type Rutek\Dataclass\T[] of property $items.

    }

    public function findByName(string $name): ?MiniGroup {
        foreach ($this->items as $member) {
            if ($member->name === $name) {
                return $member;
            }
        }
        return null;
    }

    public function findBySlug(string $slug): ?MiniGroup {
        foreach ($this->items as $member) {
            if ($member->slug === $slug) {
                return $member;
            }
        }
        return null;
    }

    public static function uk_committees(): self {
        $file_dir = RAWDATA . "scrapedjson/committees/uk_committees_groups.json";

The constant MySociety\TheyWorkForYou\DataClass\Groups\RAWDATA was not found. Maybe you did not declare it correctly or list all dependencies?

        $result = self::fromCachedFile($file_dir);
        // if $result is null the file isn't present, return an empty list
        if ($result === null) {
            return new self();
        }
        return $result;

The expression return $result returns the type MySociety\TheyWorkForYou\DataClass\BaseInterface which includes types incompatible with the type-hinted return MySociety\TheyWorkForYou\DataClass\Groups\MiniGroupList.

    }
}