SeneddView::display_front_senedd() - Code Metrics - Inspection of "Welsh parliament support" - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1700)

by Struan

created 2023-05-02 17:41 UTC

SeneddView::display_front_senedd() B

↳ Parent: SeneddView

Complexity

Conditions	8
Paths	12

Size

Total Lines	55
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	8
eloc	34
c	1
b	0
f	0
nc	12
nop	0
dl	0
loc	55
rs	8.1315

How to fix Long Method

<?php

namespace MySociety\TheyWorkForYou\SectionView;

class SeneddView extends SectionView {
    protected $index_template = 'section/senedd_index';

    public function __construct() {
        if (LANGUAGE == 'cy') {

            $this->major = 11;
            $this->class = 'SENEDDCYLIST';
        } else {
            $this->major = 10;
            $this->class = 'SENEDDENLIST';
        }
        parent::__construct();
    }

    protected function display_front() {
        if (get_http_var('more')) {
            return parent::display_front();
        } else {
            return $this->display_front_senedd();
        }
    }

    protected function front_content() {
        return $this->list->display('biggest_debates', array('days'=>30, 'num'=>20), 'none');
    }

    protected function getURLs($data) {
        $urls = array();

        $day = new \MySociety\TheyWorkForYou\Url('senedddebates');
        $urls['seneddday'] = $day;
        $urls['day'] = $day;

        return $urls;
    }

    protected function getSearchSections() {
        return array(
            array( 'section' => 'wales' )
        );
    }

    protected function display_front_senedd() {
        global $this_page;
        $this_page = "seneddoverview";

        $data = array();

        $data['popular_searches'] = null;


        $data['urls'] = $this->getURLs($data);

        $DEBATELIST = new $this->class();

        $debates = $DEBATELIST->display('recent_debates', array('days' => 30, 'num' => 6), 'none');
        $MOREURL = new \MySociety\TheyWorkForYou\Url('senedddebatesfront');
        $MOREURL->insert( array( 'more' => 1 ) );

        // this makes sure that we don't repeat this debate in the list below
        $random_debate = null;
        if ( isset($debates['data']) && count($debates['data']) ) {
            $random_debate = $debates['data'][0];
        }

        $recent = array();
        if ( isset($debates['data']) && count($debates['data']) ) {
            // at the start of a session there may be less than 6
            // debates
            $max = 6;
            if ( count($debates['data']) < 6 ) {
                $max = count($debates['data']);
            }
            for ( $i = 1; $i < $max; $i++ ) {
                $debate = $debates['data'][$i];
                $debate['desc'] = "Senedd";
                $debate['more_url'] = $MOREURL->generate();
                $recent[] = $debate;
            }
        }

        $featured = array();
        if ( $random_debate ) {
            $featured = $random_debate;
            $featured['more_url'] = $MOREURL->generate();
            $featured['desc'] = 'Senedd';
            $featured['related'] = array();
            $featured['featured'] = false;
        }

        $data['featured'] = $featured;
        $data['debates'] = array( 'recent' => $recent);

        $data['regional'] = $this->getMSList();
        $data['template'] = 'senedd/index';

        return $data;
    }

    protected function getMSList() {
        global $THEUSER;

        $mreg = array();
        if ($THEUSER->isloggedin() && $THEUSER->postcode() != '' || $THEUSER->postcode_is_set()) {

            return array_merge(
                \MySociety\TheyWorkForYou\Member::getRegionalList($THEUSER->postcode, 5, 'WAC'),
                \MySociety\TheyWorkForYou\Member::getRegionalList($THEUSER->postcode, 5, 'WAE')
            );
        }

        return $mreg;
    }
}


1			<?php
2
3			namespace MySociety\TheyWorkForYou\SectionView;
4
5			class SeneddView extends SectionView {
6			protected $index_template = 'section/senedd_index';
7
8			public function __construct() {
9			if (LANGUAGE == 'cy') {
			0 ignored issues – show introduced 2023-04-05 16:47 UTC by Report Bug Copy Issue Report The condition `MySociety\TheyWorkForYou...onView\LANGUAGE == 'cy'` is always `false`. Loading history...
10			$this->major = 11;
11			$this->class = 'SENEDDCYLIST';
12			} else {
13			$this->major = 10;
14			$this->class = 'SENEDDENLIST';
15			}
16			parent::__construct();
17			}
18
19			protected function display_front() {
20			if (get_http_var('more')) {
21			return parent::display_front();
22			} else {
23			return $this->display_front_senedd();
24			}
25			}
26
27			protected function front_content() {
28			return $this->list->display('biggest_debates', array('days'=>30, 'num'=>20), 'none');
29			}
30
31			protected function getURLs($data) {
32			$urls = array();
33
34			$day = new \MySociety\TheyWorkForYou\Url('senedddebates');
35			$urls['seneddday'] = $day;
36			$urls['day'] = $day;
37
38			return $urls;
39			}
40
41			protected function getSearchSections() {
42			return array(
43			array( 'section' => 'wales' )
44			);
45			}
46
47			protected function display_front_senedd() {
48			global $this_page;
49			$this_page = "seneddoverview";
50
51			$data = array();
52
53			$data['popular_searches'] = null;
54
55
56			$data['urls'] = $this->getURLs($data);
57
58			$DEBATELIST = new $this->class();
59
60			$debates = $DEBATELIST->display('recent_debates', array('days' => 30, 'num' => 6), 'none');
61			$MOREURL = new \MySociety\TheyWorkForYou\Url('senedddebatesfront');
62			$MOREURL->insert( array( 'more' => 1 ) );
63
64			// this makes sure that we don't repeat this debate in the list below
65			$random_debate = null;
66			if ( isset($debates['data']) && count($debates['data']) ) {
67			$random_debate = $debates['data'][0];
68			}
69
70			$recent = array();
71			if ( isset($debates['data']) && count($debates['data']) ) {
72			// at the start of a session there may be less than 6
73			// debates
74			$max = 6;
75			if ( count($debates['data']) < 6 ) {
76			$max = count($debates['data']);
77			}
78			for ( $i = 1; $i < $max; $i++ ) {
79			$debate = $debates['data'][$i];
80			$debate['desc'] = "Senedd";
81			$debate['more_url'] = $MOREURL->generate();
82			$recent[] = $debate;
83			}
84			}
85
86			$featured = array();
87			if ( $random_debate ) {
88			$featured = $random_debate;
89			$featured['more_url'] = $MOREURL->generate();
90			$featured['desc'] = 'Senedd';
91			$featured['related'] = array();
92			$featured['featured'] = false;
93			}
94
95			$data['featured'] = $featured;
96			$data['debates'] = array( 'recent' => $recent);
97
98			$data['regional'] = $this->getMSList();
99			$data['template'] = 'senedd/index';
100
101			return $data;
102			}
103
104			protected function getMSList() {
105			global $THEUSER;
106
107			$mreg = array();
108			if ($THEUSER->isloggedin() && $THEUSER->postcode() != '' \|\| $THEUSER->postcode_is_set()) {
			0 ignored issues – show introduced 2019-07-26 09:15 UTC by Report Bug Copy Issue Report Consider adding parentheses for clarity. Current Interpretation: `($THEUSER->isloggedin() ...USER->postcode_is_set()`, Probably Intended Meaning: `$THEUSER->isloggedin() &...SER->postcode_is_set())` Loading history...
109			return array_merge(
110			\MySociety\TheyWorkForYou\Member::getRegionalList($THEUSER->postcode, 5, 'WAC'),
111			\MySociety\TheyWorkForYou\Member::getRegionalList($THEUSER->postcode, 5, 'WAE')
112			);
113			}
114
115			return $mreg;
116			}
117			}
118

mysociety / theyworkforyou

Pull Request — master (#1700)

SeneddView::display_front_senedd() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like