Policies::getPoliciesWithFreeVote() - Code Metrics - Inspection of "label policies with free votes on MP voting record..." - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1953)

by Struan

created 2025-10-15 09:36 UTC

Policies::getPoliciesWithFreeVote() A

↳ Parent: Policies

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	0
dl	0
loc	12
ccs	0
cts	0
cp	0
crap	6
rs	10
c	0
b	0
f	0

<?php
/**
 * Policies Class
 *
 * @package TheyWorkForYou
 */

namespace MySociety\TheyWorkForYou;

/**
 * Policies
 *
 * Class to provide management (selection, sorting etc) of PublicWhip policies.
 */

class Policies {
    private $commons_only = [
        811,
        826,
        1053,
    ];

    # policies where votes affected by covid voting restrictions
    protected $covid_affected = [1136, 6860];

    private $db;

    private $policy_id;
    /**
     * @var array $policies key-value of policy id to the context description.
     * e.g. "363": "introducing <b>foundation hospitals</b>"
     */
    private array $policies;

    /**
     * @var array $sets - key-value pair of a set slug to an array of policy IDs
     * in that set.
     * e.g. "foreignpolicy": ["975", "984"]
     */
    private array $sets;

    /**
     * @var array $set_descs - key-value pairs of a set slug to a description
     * of that set.
     * e.g. "foreignpolicy": "Foreign Policy"
     */
    private array $set_descs;

    /**
     * @var array $all_policy_agreements - key-value pair of a policy ID to
     * an array of
     * agreements links.
     * e.g. "1030": [{
     *   "division_name": "Approval of SI setting 2050 Net Zero target date",
     *   "alignment": "agree",
     *   "gid": "2019-06-24b.530.1",
     *   "url": "/debates/?id=2019-06-24b.530.1",
     *   "house": "commons",
     *   "strength": "strong",
     *   "date": "2019-06-24"
     * }]
     */
    public array $all_policy_agreements;

    public function __construct($policy_id = null) {
        $this->db = new \ParlDB();

        if (defined('TESTING') && TESTING == true) {

            $policy_data = json_decode(file_get_contents(dirname(__FILE__) . '/../tests/policies.json'), true);
        } else {
            $policy_data = json_decode(file_get_contents(RAWDATA . '/scrapedjson/policies.json'), true);

        }
        $this->policies = $policy_data['policies'] ?? [];
        $this->set_descs = $policy_data['set_descs'] ?? [];
        $this->sets = $policy_data['sets'] ?? [];

        $this->all_policy_agreements = $policy_data['agreements'] ?? [];

        if ($policy_id) {
            $this->policy_id = $policy_id;
            $this->policies = [
                $policy_id => $this->policies[$policy_id] ?? '',
            ];
        }
    }

    public function getCovidAffected() {
        return $this->covid_affected;
    }

    public function getPolicies() {
        return $this->policies;
    }

    public function getPolicyIDs() {
        return array_keys($this->policies);
    }

    public function getSets() {
        return $this->sets;
    }

    public function getSetDescriptions() {
        return $this->set_descs;
    }

    /**
     * Get Array
     *
     * Return an array of policies.
     *
     * @return array Array of policies in the form `[ {id} , {text} ]`
     */
    public function getPoliciesData() {
        $out = [];
        foreach ($this->policies as $policy_id => $policy_text) {
            $out[] = [
                'id' => $policy_id,
                'text' => $policy_text,
                'commons_only' => in_array($policy_id, $this->commons_only),
            ];
        }
        return $out;
    }

    /**
     * Shuffle
     *
     * Shuffles the list of policy positions.
     *
     * @return self
     */

    public function shuffle() {
        $random = Utility\Shuffle::keyValue($this->policies);

        $new_policies = new self();
        $new_policies->policies = $random;

        return $new_policies;
    }

    /**
     * Limit To Set
     *
     * Limit the policies to those in a set and order accordingly
     *
     * @param string $set The name of the set to use.
     *
     * @return self
     */
    public function limitToSet($set) {

        // Sanity check the set exists
        if (isset($this->sets[$set])) {
            $out = [];
            // Reassemble the new policies list based on the set.
            foreach ($this->sets[$set] as $set_policy) {
                if (isset($this->policies[$set_policy])) {
                    $out[$set_policy] = $this->policies[$set_policy];
                } else {
                    // if we've limited the policies to a single one then we only
                    // want to complain here if we're looking for that policy and
                    // it does not exist. Otherwise, if the single policy isn't in
                    // the set we want to return an empty set
                    if (!isset($this->policy_id) || $set_policy == $this->policy_id) {
                        throw new \Exception('Policy ' . $set_policy . ' in set "' . $set . '" does not exist.');
                    }
                }
            }

            $new_policies = new self($this->policy_id);
            $new_policies->policies = $out;

            return $new_policies->shuffle();

        } else {
            throw new \Exception('Policy set "' . $set . '" does not exist.');
        }
    }

    public function limitToArray($policies) {
        $out = [];
        // Reassemble the new policies list based on the set.
        foreach ($policies as $policy) {
            if (isset($this->policies[$policy])) {
                $out[$policy] = $this->policies[$policy];
            }
        }

        $new_policies = new self();
        $new_policies->policies = $out;

        return $new_policies;
    }

    public function getPoliciesWithFreeVote() {
        $q = $this->db->query(
            "SELECT policy_id
            FROM policies WHERE contains_free_vote = 1",
        );

        $ids = [];
        foreach ($q as $row) {
            $ids[] = $row['policy_id'];
        }

        return $ids;
    }

    public function getPolicyDetails($policyID) {
        $q = $this->db->query(
            "SELECT policy_id, title, description, contains_free_vote, image, image_attrib, image_license, image_license_url, image_source
            FROM policies WHERE policy_id = :policy_id",
            [':policy_id' => $policyID]
        )->first();

        $props = [
            'policy_id' => $q['policy_id'],
            'title' => $q['title'],
            // remove full stops from the end of descriptions. Some of them have them and
            // some of them don't so we enforce consistency here
            'description' => preg_replace('/\. *$/', '', $q['description']),
            'contains_free_vote' => $q['contains_free_vote'],
            'image' => '/images/header-debates-uk.jpg', // TODO: get a better default image
            'image_license' => '',
            'image_attribution' => '',
            'image_source' => '',
            'image_license_url' => '',
        ];

        $image = $q['image'];

        if ($image && file_exists(BASEDIR . '/' . $image)) {
            $props['image'] = $image;
            $props['image_license'] = $q['image_license'];
            $props['image_attribution'] = $q['image_attrib'];
            $props['image_source'] = $q['image_source'];
            $props['image_license_url'] = $q['image_license_url'];
        }

        return $props;
    }

    /**
     * Get annotation counts for all policies for a specific person
     *
     * @param int $personId The person ID to check
     * @return array Array of policy_id => annotation_count
     */
    /**
     * Get annotation counts for all policies for a specific person
     *
     * @param int $personId The person ID to check
     * @return array Array of policy_id => annotation_count
     */
    public function getAnnotationCountsForAllPolicies($personId) {
        $args = [
            ':person_id' => $personId,
        ];

        $result = $this->db->query(
            "SELECT pdl.policy_id, COUNT(*) as annotation_count
            FROM policydivisionlink pdl
            JOIN persondivisionvotes pdv ON pdl.division_id = pdv.division_id
            WHERE pdv.person_id = :person_id 
            AND pdv.annotation IS NOT NULL 
            AND pdv.annotation != ''
            GROUP BY pdl.policy_id",
            $args
        )->fetchAll();

        $annotation_counts = [];
        foreach ($result as $row) {
            $annotation_counts[$row['policy_id']] = $row['annotation_count'];
        }

        return $annotation_counts;
    }

}


1			<?php
2			/**
3			* Policies Class
4			*
5			* @package TheyWorkForYou
6			*/
7
8			namespace MySociety\TheyWorkForYou;
9
10			/**
11			* Policies
12			*
13			* Class to provide management (selection, sorting etc) of PublicWhip policies.
14			*/
15
16			class Policies {
17			private $commons_only = [
18			811,
19			826,
20			1053,
21			];
22
23			# policies where votes affected by covid voting restrictions
24			protected $covid_affected = [1136, 6860];
25
26			private $db;
27
28			private $policy_id;
29			/**
30			* @var array $policies key-value of policy id to the context description.
31			* e.g. "363": "introducing <b>foundation hospitals</b>"
32			*/
33			private array $policies;
34
35			/**
36			* @var array $sets - key-value pair of a set slug to an array of policy IDs
37			* in that set.
38			* e.g. "foreignpolicy": ["975", "984"]
39			*/
40			private array $sets;
41
42			/**
43			* @var array $set_descs - key-value pairs of a set slug to a description
44			* of that set.
45			* e.g. "foreignpolicy": "Foreign Policy"
46			*/
47			private array $set_descs;
48
49			/**
50			* @var array $all_policy_agreements - key-value pair of a policy ID to
51			* an array of
52			* agreements links.
53			* e.g. "1030": [{
54			* "division_name": "Approval of SI setting 2050 Net Zero target date",
55			* "alignment": "agree",
56			* "gid": "2019-06-24b.530.1",
57			* "url": "/debates/?id=2019-06-24b.530.1",
58			* "house": "commons",
59			* "strength": "strong",
60			* "date": "2019-06-24"
61			* }]
62			*/
63			public array $all_policy_agreements;
64
65			public function __construct($policy_id = null) {
66			$this->db = new \ParlDB();
67
68			if (defined('TESTING') && TESTING == true) {
			0 ignored issues – show Coding Style Best Practice introduced 2024-01-16 16:44 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
69			$policy_data = json_decode(file_get_contents(dirname(__FILE__) . '/../tests/policies.json'), true);
70			} else {
71			$policy_data = json_decode(file_get_contents(RAWDATA . '/scrapedjson/policies.json'), true);
			0 ignored issues – show Bug introduced 2023-12-18 15:20 UTC by Report Bug Copy Issue Report The constant `MySociety\TheyWorkForYou\RAWDATA` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
72			}
73			$this->policies = $policy_data['policies'] ?? [];
74			$this->set_descs = $policy_data['set_descs'] ?? [];
75			$this->sets = $policy_data['sets'] ?? [];
76
77			$this->all_policy_agreements = $policy_data['agreements'] ?? [];
78
79			if ($policy_id) {
80			$this->policy_id = $policy_id;
81			$this->policies = [
82			$policy_id => $this->policies[$policy_id] ?? '',
83			];
84			}
85			}
86
87			public function getCovidAffected() {
88			return $this->covid_affected;
89			}
90
91			public function getPolicies() {
92			return $this->policies;
93			}
94
95			public function getPolicyIDs() {
96			return array_keys($this->policies);
97			}
98
99			public function getSets() {
100			return $this->sets;
101			}
102
103			public function getSetDescriptions() {
104			return $this->set_descs;
105			}
106
107			/**
108			* Get Array
109			*
110			* Return an array of policies.
111			*
112			* @return array Array of policies in the form `[ {id} , {text} ]`
113			*/
114			public function getPoliciesData() {
115			$out = [];
116			foreach ($this->policies as $policy_id => $policy_text) {
117			$out[] = [
118			'id' => $policy_id,
119			'text' => $policy_text,
120			'commons_only' => in_array($policy_id, $this->commons_only),
121			];
122			}
123			return $out;
124			}
125
126			/**
127			* Shuffle
128			*
129			* Shuffles the list of policy positions.
130			*
131			* @return self
132			*/
133
134			public function shuffle() {
135			$random = Utility\Shuffle::keyValue($this->policies);
136
137			$new_policies = new self();
138			$new_policies->policies = $random;
139
140			return $new_policies;
141			}
142
143			/**
144			* Limit To Set
145			*
146			* Limit the policies to those in a set and order accordingly
147			*
148			* @param string $set The name of the set to use.
149			*
150			* @return self
151			*/
152			public function limitToSet($set) {
153
154			// Sanity check the set exists
155			if (isset($this->sets[$set])) {
156			$out = [];
157			// Reassemble the new policies list based on the set.
158			foreach ($this->sets[$set] as $set_policy) {
159			if (isset($this->policies[$set_policy])) {
160			$out[$set_policy] = $this->policies[$set_policy];
161			} else {
162			// if we've limited the policies to a single one then we only
163			// want to complain here if we're looking for that policy and
164			// it does not exist. Otherwise, if the single policy isn't in
165			// the set we want to return an empty set
166			if (!isset($this->policy_id) \|\| $set_policy == $this->policy_id) {
167			throw new \Exception('Policy ' . $set_policy . ' in set "' . $set . '" does not exist.');
168			}
169			}
170			}
171
172			$new_policies = new self($this->policy_id);
173			$new_policies->policies = $out;
174
175			return $new_policies->shuffle();
176
177			} else {
178			throw new \Exception('Policy set "' . $set . '" does not exist.');
179			}
180			}
181
182			public function limitToArray($policies) {
183			$out = [];
184			// Reassemble the new policies list based on the set.
185			foreach ($policies as $policy) {
186			if (isset($this->policies[$policy])) {
187			$out[$policy] = $this->policies[$policy];
188			}
189			}
190
191			$new_policies = new self();
192			$new_policies->policies = $out;
193
194			return $new_policies;
195			}
196
197			public function getPoliciesWithFreeVote() {
198			$q = $this->db->query(
199			"SELECT policy_id
200			FROM policies WHERE contains_free_vote = 1",
201			);
202
203			$ids = [];
204			foreach ($q as $row) {
205			$ids[] = $row['policy_id'];
206			}
207
208			return $ids;
209			}
210
211			public function getPolicyDetails($policyID) {
212			$q = $this->db->query(
213			"SELECT policy_id, title, description, contains_free_vote, image, image_attrib, image_license, image_license_url, image_source
214			FROM policies WHERE policy_id = :policy_id",
215			[':policy_id' => $policyID]
216			)->first();
217
218			$props = [
219			'policy_id' => $q['policy_id'],
220			'title' => $q['title'],
221			// remove full stops from the end of descriptions. Some of them have them and
222			// some of them don't so we enforce consistency here
223			'description' => preg_replace('/\. *$/', '', $q['description']),
224			'contains_free_vote' => $q['contains_free_vote'],
225			'image' => '/images/header-debates-uk.jpg', // TODO: get a better default image
226			'image_license' => '',
227			'image_attribution' => '',
228			'image_source' => '',
229			'image_license_url' => '',
230			];
231
232			$image = $q['image'];
233
234			if ($image && file_exists(BASEDIR . '/' . $image)) {
235			$props['image'] = $image;
236			$props['image_license'] = $q['image_license'];
237			$props['image_attribution'] = $q['image_attrib'];
238			$props['image_source'] = $q['image_source'];
239			$props['image_license_url'] = $q['image_license_url'];
240			}
241
242			return $props;
243			}
244
245			/**
246			* Get annotation counts for all policies for a specific person
247			*
248			* @param int $personId The person ID to check
249			* @return array Array of policy_id => annotation_count
250			*/
251			/**
252			* Get annotation counts for all policies for a specific person
253			*
254			* @param int $personId The person ID to check
255			* @return array Array of policy_id => annotation_count
256			*/
257			public function getAnnotationCountsForAllPolicies($personId) {
258			$args = [
259			':person_id' => $personId,
260			];
261
262			$result = $this->db->query(
263			"SELECT pdl.policy_id, COUNT(*) as annotation_count
264			FROM policydivisionlink pdl
265			JOIN persondivisionvotes pdv ON pdl.division_id = pdv.division_id
266			WHERE pdv.person_id = :person_id
267			AND pdv.annotation IS NOT NULL
268			AND pdv.annotation != ''
269			GROUP BY pdl.policy_id",
270			$args
271			)->fetchAll();
272
273			$annotation_counts = [];
274			foreach ($result as $row) {
275			$annotation_counts[$row['policy_id']] = $row['annotation_count'];
276			}
277
278			return $annotation_counts;
279			}
280
281			}
282

mysociety / theyworkforyou

Pull Request — master (#1953)

Policies::getPoliciesWithFreeVote() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like