Banner::get_text() - Code Metrics - Inspection of "PHP7 Code Changes" - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1428)

by Nick

created 2019-04-29 11:37 UTC

Banner::get_text() A

↳ Parent: Banner

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	4
nop	0
dl	0
loc	16
ccs	0
cts	10
cp	0
crap	20
rs	9.9666
c	0
b	0
f	0

<?php
/**
 * Banner Model
 *
 * @package TheyWorkForYou
 */

namespace MySociety\TheyWorkForYou\Model;

class Banner {

    /**
     * DB handle
     */
    private $db;

    /*
     * Memcache handle
     */
    private $mem;

    public function __construct()
    {
        $this->db = new \ParlDB;
        $this->mem = new \MySociety\TheyWorkForYou\Memcache();
    }

    public function get_text() {
        $text = $this->mem->get('banner');

        if ( $text === false ) {

            $q = $this->db->query("SELECT value FROM editorial WHERE item = 'banner'")->first();

            if ($q) {
                $text = $q['value'];
                if ( trim($text) == '' ) {
                    $text = NULL;
                }
                $this->mem->set('banner', $text, 86400);
            }
        }

        return $text;
    }

    public function set_text($text) {
        $q = $this->db->query("REPLACE INTO editorial set item = 'banner', value = :banner_text",
            array(
                ':banner_text' => $text
            )
        );

        if ( $q->success() ) {
            if ( trim($text) == '' ) {
                $text = NULL;
            }
            $this->mem->set('banner', $text, 86400);
            return true;
        }
        return false;
    }
}


1		<?php
2		/**
3		* Banner Model
4		*
5		* @package TheyWorkForYou
6		*/
7
8		namespace MySociety\TheyWorkForYou\Model;
9
10		class Banner {
11
12		/**
13		* DB handle
14		*/
15		private $db;
16
17		/*
18		* Memcache handle
19		*/
20		private $mem;
21
22	1	public function __construct()
23		{
24	1	$this->db = new \ParlDB;
25	1	$this->mem = new \MySociety\TheyWorkForYou\Memcache();
26	1	}
27
28		public function get_text() {
29		$text = $this->mem->get('banner');
30
31		if ( $text === false ) {
		0 ignored issues – show introduced 2018-10-30 10:15 UTC by Report Bug Copy Issue Report The condition `$text === false` is always `true`. Loading history...
32		$q = $this->db->query("SELECT value FROM editorial WHERE item = 'banner'")->first();
33
34		if ($q) {
35		$text = $q['value'];
36		if ( trim($text) == '' ) {
37		$text = NULL;
38		}
39		$this->mem->set('banner', $text, 86400);
40		}
41		}
42
43		return $text;
44		}
45
46	1	public function set_text($text) {
47	1	$q = $this->db->query("REPLACE INTO editorial set item = 'banner', value = :banner_text",
48		array(
49	1	':banner_text' => $text
50		)
51		);
52
53	1	if ( $q->success() ) {
54	1	if ( trim($text) == '' ) {
55	1	$text = NULL;
56		}
57	1	$this->mem->set('banner', $text, 86400);
58	1	return true;
59		}
60		return false;
61		}
62		}
63

mysociety / theyworkforyou

Pull Request — master (#1428)

Banner::get_text() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like