Inspection of "Autoload Refactoring 6: url.php" - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#1327)

by Nick

created 2017-12-04 14:20 UTC

Status

Switch Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -488,20 +488,20 @@
 block discarded – undo
 
     public static function getRepNameForHouse($house) {
         switch ( $house ) {
-        case 1:
-            $name = 'MP';
-            break;
-        case 2:
-            $name = 'Peer';
-            break;
-        case 3:
-            $name = 'MLA';
-            break;
-        case 4:
-            $name = 'MSP';
-            break;
-        default:
-            $name = '';
+            case 1:
+                $name = 'MP';
+                break;
+            case 2:
+                $name = 'Peer';
+                break;
+            case 3:
+                $name = 'MLA';
+                break;
+            case 4:
+                $name = 'MSP';
+                break;
+            default:
+                $name = '';
         }
         return $name;
     }

Please login to merge, or discard this patch.

classes/Search.php 1 patch

Switch Indentation +36 added lines, -36 removed lines patch added patch discarded remove patch

@@ -82,42 +82,42 @@
 block discarded – undo
     private function prettify_search_section($section) {
         $name = '';
         switch ($section) {
-        case 'wrans':
-            $name = 'Written Answers';
-            break;
-        case 'uk':
-            $name = 'All UK';
-            break;
-        case 'debates':
-            $name = 'House of Commons debates';
-            break;
-        case 'whall':
-            $name = 'Westminster Hall debates';
-            break;
-        case 'lords':
-            $name = 'House of Lords debates';
-            break;
-        case 'wms':
-            $name = 'Written ministerial statements';
-            break;
-        case 'standing':
-            $name = 'Bill Committees';
-            break;
-        case 'future':
-            $name = 'Future Business';
-            break;
-        case 'ni':
-            $name = 'Northern Ireland Assembly Debates';
-            break;
-        case 'scotland':
-            $name = 'All Scotland';
-            break;
-        case 'sp':
-            $name = 'Scottish Parliament Debates';
-            break;
-        case 'spwrans':
-            $name = 'Scottish Parliament Written answers';
-            break;
+            case 'wrans':
+                $name = 'Written Answers';
+                break;
+            case 'uk':
+                $name = 'All UK';
+                break;
+            case 'debates':
+                $name = 'House of Commons debates';
+                break;
+            case 'whall':
+                $name = 'Westminster Hall debates';
+                break;
+            case 'lords':
+                $name = 'House of Lords debates';
+                break;
+            case 'wms':
+                $name = 'Written ministerial statements';
+                break;
+            case 'standing':
+                $name = 'Bill Committees';
+                break;
+            case 'future':
+                $name = 'Future Business';
+                break;
+            case 'ni':
+                $name = 'Northern Ireland Assembly Debates';
+                break;
+            case 'scotland':
+                $name = 'All Scotland';
+                break;
+            case 'sp':
+                $name = 'Scottish Parliament Debates';
+                break;
+            case 'spwrans':
+                $name = 'Scottish Parliament Written answers';
+                break;
         }
 
         return $name;

Please login to merge, or discard this patch.

www/docs/mp/index.php 1 patch

Switch Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -731,26 +731,26 @@
 block discarded – undo
 function person_error_page($message) {
     global $this_page;
     switch($this_page) {
-    case 'mla':
-        $rep = 'MLA';
-        $SEARCHURL = '/postcode/';
-        $MPSURL = new \MySociety\TheyWorkForYou\Url('mlas');
-        break;
-    case 'msp':
-        $rep = 'MSP';
-        $SEARCHURL = '/postcode/';
-        $MPSURL = new \MySociety\TheyWorkForYou\Url('msps');
-        break;
-    case 'peer':
-        $rep = 'Lord';
-        $SEARCHURL = '';
-        $MPSURL = new \MySociety\TheyWorkForYou\Url('peers');
-        break;
-    default:
-        $rep = 'MP';
-        $SEARCHURL = new \MySociety\TheyWorkForYou\Url('mp');
-        $SEARCHURL = $SEARCHURL->generate();
-        $MPSURL = new \MySociety\TheyWorkForYou\Url('mps');
+        case 'mla':
+            $rep = 'MLA';
+            $SEARCHURL = '/postcode/';
+            $MPSURL = new \MySociety\TheyWorkForYou\Url('mlas');
+            break;
+        case 'msp':
+            $rep = 'MSP';
+            $SEARCHURL = '/postcode/';
+            $MPSURL = new \MySociety\TheyWorkForYou\Url('msps');
+            break;
+        case 'peer':
+            $rep = 'Lord';
+            $SEARCHURL = '';
+            $MPSURL = new \MySociety\TheyWorkForYou\Url('peers');
+            break;
+        default:
+            $rep = 'MP';
+            $SEARCHURL = new \MySociety\TheyWorkForYou\Url('mp');
+            $SEARCHURL = $SEARCHURL->generate();
+            $MPSURL = new \MySociety\TheyWorkForYou\Url('mps');
     }
 
     $data = array(

Please login to merge, or discard this patch.

		@@ -488,20 +488,20 @@
		block discarded – undo
488	488
489	489	public static function getRepNameForHouse($house) {
490	490	switch ( $house ) {
491		- case 1:
492		- $name = 'MP';
493		- break;
494		- case 2:
495		- $name = 'Peer';
496		- break;
497		- case 3:
498		- $name = 'MLA';
499		- break;
500		- case 4:
501		- $name = 'MSP';
502		- break;
503		- default:
504		- $name = '';
	491	+ case 1:
	492	+ $name = 'MP';
	493	+ break;
	494	+ case 2:
	495	+ $name = 'Peer';
	496	+ break;
	497	+ case 3:
	498	+ $name = 'MLA';
	499	+ break;
	500	+ case 4:
	501	+ $name = 'MSP';
	502	+ break;
	503	+ default:
	504	+ $name = '';
505	505	}
506	506	return $name;
507	507	}

		@@ -731,26 +731,26 @@
		block discarded – undo
731	731	function person_error_page($message) {
732	732	global $this_page;
733	733	switch($this_page) {
734		- case 'mla':
735		- $rep = 'MLA';
736		- $SEARCHURL = '/postcode/';
737		- $MPSURL = new \MySociety\TheyWorkForYou\Url('mlas');
738		- break;
739		- case 'msp':
740		- $rep = 'MSP';
741		- $SEARCHURL = '/postcode/';
742		- $MPSURL = new \MySociety\TheyWorkForYou\Url('msps');
743		- break;
744		- case 'peer':
745		- $rep = 'Lord';
746		- $SEARCHURL = '';
747		- $MPSURL = new \MySociety\TheyWorkForYou\Url('peers');
748		- break;
749		- default:
750		- $rep = 'MP';
751		- $SEARCHURL = new \MySociety\TheyWorkForYou\Url('mp');
752		- $SEARCHURL = $SEARCHURL->generate();
753		- $MPSURL = new \MySociety\TheyWorkForYou\Url('mps');
	734	+ case 'mla':
	735	+ $rep = 'MLA';
	736	+ $SEARCHURL = '/postcode/';
	737	+ $MPSURL = new \MySociety\TheyWorkForYou\Url('mlas');
	738	+ break;
	739	+ case 'msp':
	740	+ $rep = 'MSP';
	741	+ $SEARCHURL = '/postcode/';
	742	+ $MPSURL = new \MySociety\TheyWorkForYou\Url('msps');
	743	+ break;
	744	+ case 'peer':
	745	+ $rep = 'Lord';
	746	+ $SEARCHURL = '';
	747	+ $MPSURL = new \MySociety\TheyWorkForYou\Url('peers');
	748	+ break;
	749	+ default:
	750	+ $rep = 'MP';
	751	+ $SEARCHURL = new \MySociety\TheyWorkForYou\Url('mp');
	752	+ $SEARCHURL = $SEARCHURL->generate();
	753	+ $MPSURL = new \MySociety\TheyWorkForYou\Url('mps');
754	754	}
755	755
756	756	$data = array(

		@@ -82,42 +82,42 @@
		block discarded – undo
82	82	private function prettify_search_section($section) {
83	83	$name = '';
84	84	switch ($section) {
85		- case 'wrans':
86		- $name = 'Written Answers';
87		- break;
88		- case 'uk':
89		- $name = 'All UK';
90		- break;
91		- case 'debates':
92		- $name = 'House of Commons debates';
93		- break;
94		- case 'whall':
95		- $name = 'Westminster Hall debates';
96		- break;
97		- case 'lords':
98		- $name = 'House of Lords debates';
99		- break;
100		- case 'wms':
101		- $name = 'Written ministerial statements';
102		- break;
103		- case 'standing':
104		- $name = 'Bill Committees';
105		- break;
106		- case 'future':
107		- $name = 'Future Business';
108		- break;
109		- case 'ni':
110		- $name = 'Northern Ireland Assembly Debates';
111		- break;
112		- case 'scotland':
113		- $name = 'All Scotland';
114		- break;
115		- case 'sp':
116		- $name = 'Scottish Parliament Debates';
117		- break;
118		- case 'spwrans':
119		- $name = 'Scottish Parliament Written answers';
120		- break;
	85	+ case 'wrans':
	86	+ $name = 'Written Answers';
	87	+ break;
	88	+ case 'uk':
	89	+ $name = 'All UK';
	90	+ break;
	91	+ case 'debates':
	92	+ $name = 'House of Commons debates';
	93	+ break;
	94	+ case 'whall':
	95	+ $name = 'Westminster Hall debates';
	96	+ break;
	97	+ case 'lords':
	98	+ $name = 'House of Lords debates';
	99	+ break;
	100	+ case 'wms':
	101	+ $name = 'Written ministerial statements';
	102	+ break;
	103	+ case 'standing':
	104	+ $name = 'Bill Committees';
	105	+ break;
	106	+ case 'future':
	107	+ $name = 'Future Business';
	108	+ break;
	109	+ case 'ni':
	110	+ $name = 'Northern Ireland Assembly Debates';
	111	+ break;
	112	+ case 'scotland':
	113	+ $name = 'All Scotland';
	114	+ break;
	115	+ case 'sp':
	116	+ $name = 'Scottish Parliament Debates';
	117	+ break;
	118	+ case 'spwrans':
	119	+ $name = 'Scottish Parliament Written answers';
	120	+ break;
121	121	}
122	122
123	123	return $name;

mysociety / theyworkforyou

Pull Request — master (#1327)

Status

Category

Switch Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Switch Indentation +36 added lines, -36 removed lines patch added patch discarded remove patch

Switch Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch