person_recent_appearances()

Complexity

Conditions	4
Paths	8

Size

Total Lines	93
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function person_recent_appearances($member) {
    global $DATA, $SEARCHENGINE, $this_page, $hansardmajors;

    $out = [];
    $out['speeches'] = [];
    $out['written_questions'] = [];

    //$this->block_start(array('id'=>'hansard', 'title'=>$title));
    // This is really far from ideal - I don't really want $PAGE to know
    // anything about HANSARDLIST / DEBATELIST / WRANSLIST.
    // But doing this any other way is going to be a lot more work for little
    // benefit unfortunately.
    twfy_debug_timestamp();

    $person_id = $member->person_id();

    $memcache = new MySociety\TheyWorkForYou\Memcache();

    // Perform separate searches for each category to ensure adequate coverage
    $hansard = new MySociety\TheyWorkForYou\Hansard();

    // Search for speeches and debates (everything except written questions - major != 3)
    $speeches_key = "recent_speeches:$person_id:" . LANGUAGE;
    $recent_speeches = $memcache->get($speeches_key);

    if (!$recent_speeches) {

The condition $recent_speeches is always false.

        $searchstring_speeches = "speaker:$person_id -section:wrans";  // Exclude written answers section
        $SEARCHENGINE = new \SEARCHENGINE($searchstring_speeches);

        // Search query excluding written questions
        $args_speeches = [
            's' => $searchstring_speeches,
            'p' => 1,                       // First page
            'num' => 8,                     // 8 recent speeches/debates
            'pop' => 1,                     // Disable search logging
            'o' => 'd',                     // Decending by date order
        ];
        $results_speeches = $hansard->search($searchstring_speeches, $args_speeches);
        $recent_speeches = serialize($results_speeches['rows'] ?? []);
        $memcache->set($speeches_key, $recent_speeches, 3600); // Cache for 1 hour
    }
    $out['speeches'] = unserialize($recent_speeches);

    // Search for written questions/answers (major = 3)
    $wrans_key = "recent_wrans:$person_id:" . LANGUAGE;
    $recent_wrans = $memcache->get($wrans_key);

    if (!$recent_wrans) {

The condition $recent_wrans is always false.

        $searchstring_wrans = "speaker:$person_id section:wrans";  // Only written answers section
        $SEARCHENGINE = new \SEARCHENGINE($searchstring_wrans);

        // Search query for written questions only
        $args_wrans = [
            's' => $searchstring_wrans,
            'p' => 1,
            'num' => 8,
            'pop' => 1,
            'o' => 'd',
        ];
        $results_wrans = $hansard->search($searchstring_wrans, $args_wrans);
        $recent_wrans = serialize($results_wrans['rows'] ?? []);
        $memcache->set($wrans_key, $recent_wrans, 3600); // Cache for 1 hour
    }
    $out['written_questions'] = unserialize($recent_wrans);
    twfy_debug_timestamp();

    $MOREURL = new \MySociety\TheyWorkForYou\Url('search');
    $MOREURL->insert(['pid' => $person_id, 'pop' => 1]);

    $out['more_href'] = $MOREURL->generate();
    $out['more_text'] = sprintf(gettext('More of %s’s recent appearances'), ucfirst($member->full_name()));

    // Create separate "More" links for speeches and written questions
    $MORE_SPEECHES_URL = new \MySociety\TheyWorkForYou\Url('search');
    $MORE_SPEECHES_URL->insert(['pid' => $person_id, 'pop' => 1, 's' => "speaker:$person_id -section:wrans"]);
    $out['more_speeches_href'] = $MORE_SPEECHES_URL->generate();
    $out['more_speeches_text'] = sprintf(gettext('More of %s\'s speeches and debates'), ucfirst($member->full_name()));

    $MORE_QUESTIONS_URL = new \MySociety\TheyWorkForYou\Url('search');
    $MORE_QUESTIONS_URL->insert(['pid' => $person_id, 'pop' => 1, 's' => "speaker:$person_id section:wrans"]);
    $out['more_questions_href'] = $MORE_QUESTIONS_URL->generate();
    $out['more_questions_text'] = sprintf(gettext('More of %s\'s written questions'), ucfirst($member->full_name()));

    if ($rssurl = $DATA->page_metadata($this_page, 'rss')) {
        // If we set an RSS feed for this page.
        $HELPURL = new \MySociety\TheyWorkForYou\Url('help');
        $out['additional_links'] = '<a href="' . WEBPATH . $rssurl . '" title="XML version of this person&rsquo;s recent appearances">RSS feed</a> (<a href="' . $HELPURL->generate() . '#rss" title="An explanation of what RSS feeds are for">?</a>)';
    }

    // Keep array of combined list for overview and menu checks
    $out['appearances'] = array_merge($out['speeches'], $out['written_questions']);

    return $out;