DataFrame::toHTML() - Code Metrics - Inspection of "[Register] Space after emoji, spot a heading dash." - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1e77ab...d0f64e )

by Matthew

created 2025-03-04 09:23 UTC

DataFrame::toHTML() B

↳ Parent: DataFrame

Complexity

Conditions	10
Paths	39

Size

Total Lines	39
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	26
c	1
b	0
f	0
nc	39
nop	1
dl	0
loc	39
rs	7.6666

How to fix Complexity

<?php

declare(strict_types=1);

namespace MySociety\TheyWorkForYou\DataClass;

class Cell {
    public string $key;
    public $value;

    public function getValue() {
        return $this->value;
    }
}

class Row {
    /** @var Cell[] $cells */
    public array $cells = [];

    public function __construct(array $data) {
        foreach ($data as $key => $value) {
            $cell = new Cell();
            $cell->key = (string) $key;
            $cell->value = $value;
            $this->cells[$key] = $cell;
        }
    }

    public function get(string $column) {
        $cell = $this->cells[$column] ?? null;
        return $cell ? $cell->getValue() : null;
    }

    public function toArray(): array {
        $array = [];
        foreach ($this->cells as $cell) {
            $array[$cell->key] = $cell->value;
        }
        return $array;
    }
}

class DataFrame {
    /**
     * @var Row[] $rows An array of Row objects
     * @var string[] $columns An array of strings representing column names
     */
    public array $rows = [];
    public array $columns = [];

    public function __construct(array $data) {
        /**
         * Accepts an array of associative arrays, where each associative array represents a row in the DataFrame.
         * From this extract the column names and create a Row object for each row.
         */
        foreach ($data as $rowData) {
            // update the columns with any new keys in each row
            $this->columns = array_unique(array_merge($this->columns, array_keys($rowData)));
            // make sure all columns are strings rather than ints
            $this->rows[] = new Row($rowData);
        }
    }

    public function toArray(): array {
        return array_map(fn($row) => $row->toArray(), $this->rows);
    }

    public function toHTML(?string $url_column = null): string {
        // Generate a HTML table from the DataFrame
        $html = '<div style="overflow-x: auto; white-space: nowrap;">';
        $html .= '<table class="df-table">';
        // Add table headers
        $html .= '<tr class="df-row">';
        foreach ($this->columns as $column) {
            if ($url_column === $column) {
                continue;
            }
            $html .= '<th class="df-header">' . htmlspecialchars($column) . '</th>';
        }
        $html .= '</tr>';
        // Add table rows
        foreach ($this->rows as $row) {
            $url_value = $url_column ? $row->get($url_column) : null;
            $html .= '<tr class="df-row">';
            foreach ($this->columns as $index => $column) {
                if ($url_column === $column) {
                    continue;
                }
                $raw_cell_value = $row->get($column);
                $cell_value = htmlspecialchars((string) $raw_cell_value);
                $data_classes = ['df-data'];
                if (is_numeric($raw_cell_value)) {
                    $data_classes[] = 'df-data--number';
                }

                if ($url_value && $index === 0) {
                    // wrap first value in url
                    $cell_value = '<a href="' . $url_value . '">' . $cell_value . '</a>';
                }
                $html .= '<td class="' . implode(' ', $data_classes) . '">' . $cell_value . '</td>';
            }
            $html .= '</tr>';
        }
        $html .= '</table>';
        $html .= '</div>';
        return $html;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace MySociety\TheyWorkForYou\DataClass;
6
7			class Cell {
8			public string $key;
9			public $value;
10
11			public function getValue() {
12			return $this->value;
13			}
14			}
15
16			class Row {
17			/** @var Cell[] $cells */
18			public array $cells = [];
19
20			public function __construct(array $data) {
21			foreach ($data as $key => $value) {
22			$cell = new Cell();
23			$cell->key = (string) $key;
24			$cell->value = $value;
25			$this->cells[$key] = $cell;
26			}
27			}
28
29			public function get(string $column) {
30			$cell = $this->cells[$column] ?? null;
31			return $cell ? $cell->getValue() : null;
32			}
33
34			public function toArray(): array {
35			$array = [];
36			foreach ($this->cells as $cell) {
37			$array[$cell->key] = $cell->value;
38			}
39			return $array;
40			}
41			}
42
43			class DataFrame {
44			/**
45			* @var Row[] $rows An array of Row objects
46			* @var string[] $columns An array of strings representing column names
47			*/
48			public array $rows = [];
49			public array $columns = [];
50
51			public function __construct(array $data) {
52			/**
53			* Accepts an array of associative arrays, where each associative array represents a row in the DataFrame.
54			* From this extract the column names and create a Row object for each row.
55			*/
56			foreach ($data as $rowData) {
57			// update the columns with any new keys in each row
58			$this->columns = array_unique(array_merge($this->columns, array_keys($rowData)));
59			// make sure all columns are strings rather than ints
60			$this->rows[] = new Row($rowData);
61			}
62			}
63
64			public function toArray(): array {
65			return array_map(fn($row) => $row->toArray(), $this->rows);
66			}
67
68			public function toHTML(?string $url_column = null): string {
69			// Generate a HTML table from the DataFrame
70			$html = '<div style="overflow-x: auto; white-space: nowrap;">';
71			$html .= '<table class="df-table">';
72			// Add table headers
73			$html .= '<tr class="df-row">';
74			foreach ($this->columns as $column) {
75			if ($url_column === $column) {
76			continue;
77			}
78			$html .= '<th class="df-header">' . htmlspecialchars($column) . '</th>';
79			}
80			$html .= '</tr>';
81			// Add table rows
82			foreach ($this->rows as $row) {
83			$url_value = $url_column ? $row->get($url_column) : null;
84			$html .= '<tr class="df-row">';
85			foreach ($this->columns as $index => $column) {
86			if ($url_column === $column) {
87			continue;
88			}
89			$raw_cell_value = $row->get($column);
90			$cell_value = htmlspecialchars((string) $raw_cell_value);
91			$data_classes = ['df-data'];
92			if (is_numeric($raw_cell_value)) {
93			$data_classes[] = 'df-data--number';
94			}
95
96			if ($url_value && $index === 0) {
97			// wrap first value in url
98			$cell_value = '<a href="' . $url_value . '">' . $cell_value . '</a>';
99			}
100			$html .= '<td class="' . implode(' ', $data_classes) . '">' . $cell_value . '</td>';
101			}
102			$html .= '</tr>';
103			}
104			$html .= '</table>';
105			$html .= '</div>';
106			return $html;
107			}
108			}
109

mysociety / theyworkforyou

Push — master ( 1e77ab...d0f64e )

DataFrame::toHTML() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like