Passed
Pull Request — master (#1874)
by
unknown
05:36
created
www/docs/admin/featured.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     global $hansardmajors;
31 31
     global $db;
32 32
 
33
-    $q = $db->query("SELECT major FROM hansard WHERE gid = :gid", [ ':gid' => $gid ])->first();
33
+    $q = $db->query("SELECT major FROM hansard WHERE gid = :gid", [':gid' => $gid])->first();
34 34
     $url_gid = fix_gid_from_db($gid);
35 35
     $url = new \MySociety\TheyWorkForYou\Url($hansardmajors[$q['major']]['page']);
36 36
     $url->insert(['id' => $url_gid]);
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     print "<h2>Preview Content</h2>";
119 119
     if ($gid !== null) {
120 120
         $h = new MySociety\TheyWorkForYou\Homepage();
121
-        $featured = $h->getFeaturedDebate($gid, $title, $context, [ $related_gid1, $related_gid2, $related_gid3 ]);
121
+        $featured = $h->getFeaturedDebate($gid, $title, $context, [$related_gid1, $related_gid2, $related_gid3]);
122 122
 
123 123
         include INCLUDESPATH . 'easyparliament/templates/html/homepage/featured.php';
124 124
     } else {
Please login to merge, or discard this patch.
www/docs/admin/policies.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -128,9 +128,9 @@
 block discarded – undo
128 128
 
129 129
     $rettext .= '<div id="subnav_websites">';
130 130
     foreach ($subnav as $label => $path) {
131
-        $rettext .=  '<a href="' . $path . '">' . $label . '</a>';
131
+        $rettext .= '<a href="' . $path . '">' . $label . '</a>';
132 132
     }
133
-    $rettext .=  '</div>';
133
+    $rettext .= '</div>';
134 134
 
135 135
     return $rettext;
136 136
 }
Please login to merge, or discard this patch.
www/docs/admin/alert_stats.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -18,13 +18,13 @@  discard block
 block discarded – undo
18 18
 
19 19
 print '<h3>Headline stats</h3> <table>';
20 20
 $data = [
21
-    'header' => [ 'Alert Type', 'Count' ],
21
+    'header' => ['Alert Type', 'Count'],
22 22
     'rows' => [
23
-        [ 'Confirmed', $q_confirmed ],
24
-        [ 'Not Confirmed', $q_not_confirmed ],
25
-        [ 'Deleted', $q_deleted ],
26
-        [ 'For a Speaker<sup>*</sup>', $q_speaker ],
27
-        [ 'For a Keyword', $q_keyword ],
23
+        ['Confirmed', $q_confirmed],
24
+        ['Not Confirmed', $q_not_confirmed],
25
+        ['Deleted', $q_deleted],
26
+        ['For a Speaker<sup>*</sup>', $q_speaker],
27
+        ['For a Keyword', $q_keyword],
28 28
     ],
29 29
 ];
30 30
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     $criteria = $row['criteria'];
41 41
     $rows[] = [$id, $critera];
42 42
 }
43
-$data = [ 'rows' => $rows ];
43
+$data = ['rows' => $rows];
44 44
 $PAGE->display_table($data);
45 45
 
46 46
 $q = $db->query('select count(*) as c, criteria from alerts where criteria like "speaker:%" and confirmed and not deleted group by criteria order by c desc');
@@ -79,15 +79,15 @@  discard block
 block discarded – undo
79 79
     }
80 80
 }
81 81
 
82
-$people_header = [ 'Name', 'Confirmed', 'Unconfirmed'];
82
+$people_header = ['Name', 'Confirmed', 'Unconfirmed'];
83 83
 print '<h3>Alert signups by MP/Peer</h3>';
84 84
 $rows = [];
85 85
 foreach ($tots as $person_id => $c) {
86 86
     $u = $unconfirmed[$person_id] ?? 0;
87
-    $rows[] = [ $name[$person_id], $c, $u ];
87
+    $rows[] = [$name[$person_id], $c, $u];
88 88
 }
89 89
 $data = [
90
-    'header' => [ 'Name', 'Confirmed', 'Unconfirmed'],
90
+    'header' => ['Name', 'Confirmed', 'Unconfirmed'],
91 91
     'rows' => $rows,
92 92
 ];
93 93
 $PAGE->display_table($data);
@@ -114,10 +114,10 @@  discard block
 block discarded – undo
114 114
 foreach ($total as $criteria => $tot) {
115 115
     $c = $confirmed[$criteria] ?? 0;
116 116
     $u = $unconfirmed[$criteria] ?? 0;
117
-    $rows[] = [ $criteria, $c, $u ];
117
+    $rows[] = [$criteria, $c, $u];
118 118
 }
119 119
 $data = [
120
-    'header' => [ 'Criteria', 'Confirmed', 'Unconfirmed'],
120
+    'header' => ['Criteria', 'Confirmed', 'Unconfirmed'],
121 121
     'rows' => $rows,
122 122
 ];
123 123
 $PAGE->display_table($data);
Please login to merge, or discard this patch.
www/docs/admin/edittopic.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
             <select name="sets[]" multiple>
126 126
               <option value="">None</option>
127 127
             <?php
128
-              $policies = new \MySociety\TheyWorkForYou\Policies();
128
+                $policies = new \MySociety\TheyWorkForYou\Policies();
129 129
 $set_descriptions = $policies->getSetDescriptions();
130 130
 $related_sets = $topic->getPolicySets();
131 131
 foreach ($set_descriptions as $set => $description) { ?>
Please login to merge, or discard this patch.
www/docs/admin/websites.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     $sysretval = 0;
107 107
     $personid = get_http_var('editperson');
108 108
 
109
-    $q  = $db->query("DELETE FROM personinfo WHERE data_key = 'mp_website' AND personinfo.person_id = :person_id", [
109
+    $q = $db->query("DELETE FROM personinfo WHERE data_key = 'mp_website' AND personinfo.person_id = :person_id", [
110 110
         ':person_id' => $personid,
111 111
     ]);
112 112
 
@@ -142,9 +142,9 @@  discard block
 block discarded – undo
142 142
 
143 143
     $rettext .= '<div id="subnav_websites">';
144 144
     foreach ($subnav as $label => $path) {
145
-        $rettext .=  '<a href="' . $path . '">' . $label . '</a>';
145
+        $rettext .= '<a href="' . $path . '">' . $label . '</a>';
146 146
     }
147
-    $rettext .=  '</div>';
147
+    $rettext .= '</div>';
148 148
 
149 149
     return $rettext;
150 150
 }
Please login to merge, or discard this patch.
www/docs/random/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,5 +11,5 @@
 block discarded – undo
11 11
 $gid = fix_gid_from_db($gid);
12 12
 
13 13
 $URL = new \MySociety\TheyWorkForYou\Url('debates');
14
-$URL->insert([ 'id' => $gid ]);
14
+$URL->insert(['id' => $gid]);
15 15
 header('Location: ' . $URL->generate());
Please login to merge, or discard this patch.
www/docs/postcode/index.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -89,13 +89,13 @@
 block discarded – undo
89 89
     $member_names = \MySociety\TheyWorkForYou\Utility\House::house_to_members($house);
90 90
     if ($house == HOUSE_TYPE_SCOTLAND) {
91 91
         $urlp = 'msp';
92
-        $a = [ $areas['SPC'], $areas['SPE'] ];
92
+        $a = [$areas['SPC'], $areas['SPE']];
93 93
     } elseif ($house == HOUSE_TYPE_WALES) {
94 94
         $urlp = 'ms';
95
-        $a = [ $areas['WAC'], $areas['WAE'] ];
95
+        $a = [$areas['WAC'], $areas['WAE']];
96 96
     } elseif ($house == HOUSE_TYPE_NI) {
97 97
         $urlp = 'mla';
98
-        $a = [ $areas['NIE'] ];
98
+        $a = [$areas['NIE']];
99 99
     }
100 100
     $urlpl = $urlp . 's';
101 101
     $urlp = "/$urlp/?p=";
Please login to merge, or discard this patch.
www/docs/mp/index.php 2 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@
 block discarded – undo
221 221
 // Basic name, title and description
222 222
 $member_name = ucfirst($MEMBER->full_name());
223 223
 $title = $member_name;
224
-$desc = "Read $member_name's contributions to Parliament, including speeches and questions";
224
+$desc = "read $member_name's contributions to Parliament, including speeches and questions";
225 225
 
226 226
 // Enhance description if this is a current member
227 227
 if ($MEMBER->current_member_anywhere()) {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
         $divisions = new MySociety\TheyWorkForYou\Divisions($MEMBER);
394 394
         $policySummaries = $divisions->getMemberDivisionDetails(true);
395 395
 
396
-        $policyOptions = [ 'summaries' => $policySummaries];
396
+        $policyOptions = ['summaries' => $policySummaries];
397 397
 
398 398
         // Generate voting segments
399 399
         $set_descriptions = $policiesList->getSetDescriptions();
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
                 'health', 'education', 'reform', 'home', 'environment',
411 411
                 'transport', 'housing', 'misc',
412 412
             ];
413
-            $sets = array_filter($sets, function ($v) use ($set_descriptions) {
413
+            $sets = array_filter($sets, function($v) use ($set_descriptions) {
414 414
                 return array_key_exists($v, $set_descriptions);
415 415
             });
416 416
             shuffle($sets);
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
 
434 434
         $data['sorted_diffs_only'] = array_filter(
435 435
             $data['sorted_diffs'],
436
-            function ($k) { return $k['score_difference'] >= 2; }
436
+            function($k) { return $k['score_difference'] >= 2; }
437 437
         );
438 438
 
439 439
         // Send the output for rendering
@@ -665,7 +665,7 @@  discard block
 block discarded – undo
665 665
 function person_error_page($message) {
666 666
     global $this_page;
667 667
     $SEARCHURL = '';
668
-    switch($this_page) {
668
+    switch ($this_page) {
669 669
         case 'peer':
670 670
             $people = new MySociety\TheyWorkForYou\People\Peers();
671 671
             $MPSURL = new \MySociety\TheyWorkForYou\Url('peers');
@@ -850,7 +850,7 @@  discard block
 block discarded – undo
850 850
         $SEARCHENGINE = new \SEARCHENGINE($searchstring);
851 851
 
852 852
         $hansard = new MySociety\TheyWorkForYou\Hansard();
853
-        $args =  [
853
+        $args = [
854 854
             's' => $searchstring,
855 855
             'p' => 1,
856 856
             'num' => 3,
@@ -1066,7 +1066,7 @@  discard block
 block discarded – undo
1066 1066
 
1067 1067
     $lang = LANGUAGE;
1068 1068
 
1069
-    $reg = ['chamber_registers' => [] ];
1069
+    $reg = ['chamber_registers' => []];
1070 1070
 
1071 1071
     foreach ($valid_chambers as $chamber) {
1072 1072
         $key = 'person_regmem_' . $chamber . '_' . $lang;
@@ -1081,7 +1081,7 @@  discard block
 block discarded – undo
1081 1081
     }
1082 1082
 
1083 1083
     // sort chamber registers by published_date
1084
-    uasort($reg['chamber_registers'], function ($a, $b) {
1084
+    uasort($reg['chamber_registers'], function($a, $b) {
1085 1085
         return $a->published_date <=> $b->published_date;
1086 1086
     });
1087 1087
 
@@ -1175,8 +1175,8 @@  discard block
 block discarded – undo
1175 1175
         }
1176 1176
     }
1177 1177
 
1178
-    foreach($mreg as $reg) {
1179
-        $data['members'][] =  [
1178
+    foreach ($mreg as $reg) {
1179
+        $data['members'][] = [
1180 1180
             'url' => '/' . $rep_type . '/?p=' . $reg['person_id'],
1181 1181
             'name' => $reg['given_name'] . ' ' . $reg['family_name'],
1182 1182
         ];
Please login to merge, or discard this patch.
www/docs/api/api_convertURL.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     $LISTURL = new \MySociety\TheyWorkForYou\Url($hansardmajors[$id_data['major']]['page_all']);
43 43
     $fragment = '';
44 44
     if ($id_data['htype'] == '11' || $id_data['htype'] == '10') {
45
-        $LISTURL->insert([ 'id' => $id_data['gid'] ]);
45
+        $LISTURL->insert(['id' => $id_data['gid']]);
46 46
     } else {
47 47
         $parent_epobject_id = $id_data['subsection_id'];
48 48
         $parent_gid = '';
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
             $parent_gid = fix_gid_from_db($r['gid']);
56 56
         }
57 57
         if ($parent_gid != '') {
58
-            $LISTURL->insert([ 'id' => $parent_gid ]);
58
+            $LISTURL->insert(['id' => $parent_gid]);
59 59
             $fragment = '#g' . gid_to_anchor($id_data['gid']);
60 60
         }
61 61
     }
Please login to merge, or discard this patch.