mysociety / theyworkforyou

www/docs/user/login/index.php

Spacing +5 added lines, -5 removed lines

@@ -19,14 +19,14 @@ 
 if (get_http_var("submitted") == "true") {
     // Form has been submitted, so check input.
 
-    $email 		= get_http_var("email");
+    $email = get_http_var("email");
     $password 	= get_http_var("password");
     $remember 	= get_http_var("remember");
 
     // The user may have tried to do something that requires being logged in.
     // In which case we should arrive here with that page's URL in 'ret'.
     // We can then send the user there after log in.
-    $returnurl 	= get_http_var("ret");
+    $returnurl = get_http_var("ret");
 
     $errors = array();
 
@@ -53,7 +53,7 @@ 
             if ($remember == "true") {
                 $expire = "never";
             } else {
-                $expire ="session";
+                $expire = "session";
             }
 
             // $returnurl is the url of where we'll send the user after login.
@@ -96,7 +96,7 @@ 
 }
 
 
-function display_page( $errors=array() ) {
+function display_page($errors = array()) {
     global $PAGE, $this_page, $THEUSER;
 
     $PAGE->page_start();
@@ -127,7 +127,7 @@ 
     <?php
 
         $PAGE->stripe_end(array(
-            array (
+            array(
                 'type' => 'include',
                 'content' => 'userlogin'
             )

Braces +12 added lines, -6 removed lines

@@ -32,7 +32,8 @@ 
 
     if ($email == "") {
         $errors["email"] = "Please enter your email address";
-    } elseif (!validate_email($email)) {
+    }
+    elseif (!validate_email($email)) {
         $errors["email"] = "Please enter a valid email address";
     }
     if ($password == "") {
@@ -43,7 +44,8 @@ 
         // Validation errors. Print form again.
         display_page($errors);
 
-    } else {
+    }
+    else {
         // No errors so far, so try to log in.
 
         $valid = $THEUSER->isvalid($email, $password);
@@ -52,14 +54,16 @@ 
             // No validation errors.
             if ($remember == "true") {
                 $expire = "never";
-            } else {
+            }
+            else {
                 $expire ="session";
             }
 
             // $returnurl is the url of where we'll send the user after login.
             $THEUSER->login($returnurl, $expire);
 
-        } else {
+        }
+        else {
 
             // Merge the validation errors with any we already have.
             $errors = array_merge($errors, $valid);
@@ -69,7 +73,8 @@ 
 
     }
 
-} elseif ($resend = get_http_var('resend')) {
+}
+elseif ($resend = get_http_var('resend')) {
     $USER = new USER();
     $USER->init($resend);
     if (!$USER->confirmed()) {
@@ -90,7 +95,8 @@ 
         $PAGE->stripe_end();
         $PAGE->page_end();
     }
-} else {
+}
+else {
     // First time to the page...
     display_page();
 }

tests/TWFY_Database_TestCase.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
 
     public function tearDown()
     {
-        $this->db = NULL;
+        $this->db = null;
 
         parent::tearDown();
     }

tests/HousesTest.php

Indentation +6 added lines, -6 removed lines

@@ -9,7 +9,7 @@ 
     /**
      * Test that the Royal edge-case house is correctly defined.
      */
-	public function testRoyalHouseDefined()
+    public function testRoyalHouseDefined()
     {
         $this->assertEquals(0, HOUSE_TYPE_ROYAL);
     }
@@ -17,7 +17,7 @@ 
     /**
      * Test that the House of Commons is correctly defined.
      */
-	public function testCommonsHouseDefined()
+    public function testCommonsHouseDefined()
     {
         $this->assertEquals(1, HOUSE_TYPE_COMMONS);
     }
@@ -25,7 +25,7 @@ 
     /**
      * Test that the House of Lords is correctly defined.
      */
-	public function testLordsHouseDefined()
+    public function testLordsHouseDefined()
     {
         $this->assertEquals(2, HOUSE_TYPE_LORDS);
     }
@@ -33,7 +33,7 @@ 
     /**
      * Test that the Northern Ireland Assembly is correctly defined.
      */
-	public function testNIHouseDefined()
+    public function testNIHouseDefined()
     {
         $this->assertEquals(3, HOUSE_TYPE_NI);
     }
@@ -41,7 +41,7 @@ 
     /**
      * Test that the Scottish Parliament is correctly defined.
      */
-	public function testScotlandHouseDefined()
+    public function testScotlandHouseDefined()
     {
         $this->assertEquals(4, HOUSE_TYPE_SCOTLAND);
     }
@@ -49,7 +49,7 @@ 
     /**
      * Test that the Assembly for Wales is correctly defined.
      */
-	public function testWalesHouseDefined()
+    public function testWalesHouseDefined()
     {
         $this->assertEquals(5, HOUSE_TYPE_WALES);
     }

classes/Data.php

Doc Comments +3 added lines

@@ -159,6 +159,9 @@
         }
     }
 
+    /**
+     * @param string $type
+     */
     private function getMetadata($args="", $type) {
         // $type is either 'page' or 'section'
         global $this_page, $this_section;

Spacing +11 added lines, -11 removed lines

@@ -54,7 +54,7 @@ 
 
     public function __construct() {
 
-        include_once METADATAPATH;	// defined in config.php
+        include_once METADATAPATH; // defined in config.php
 
     }
 
@@ -114,7 +114,7 @@ 
      */
 
     public function set_page_metadata($page, $key, $value) {
-        $this->setMetadata(array("page"=>$page,"key"=>$key,"value"=>$value));
+        $this->setMetadata(array("page"=>$page, "key"=>$key, "value"=>$value));
     }
 
     /**
@@ -126,7 +126,7 @@ 
      */
 
     public function set_section_metadata($section, $key, $value) {
-        $this->setMetadata(array("section"=>$section,"key"=>$key,"value"=>$value));
+        $this->setMetadata(array("section"=>$section, "key"=>$key, "value"=>$value));
     }
 
     /**
@@ -150,7 +150,7 @@ 
      */
 
     public function test_for_metadata($type, $item, $key) {
-        $dataarray =& $this->$type;
+        $dataarray = & $this->$type;
 
         if (isset($dataarray[$item][$key])) {
             return true;
@@ -159,7 +159,7 @@ 
         }
     }
 
-    private function getMetadata($args="", $type) {
+    private function getMetadata($args = "", $type) {
         // $type is either 'page' or 'section'
         global $this_page, $this_section;
 
@@ -167,21 +167,21 @@ 
             $item = $args[$type];
             $key = $args['key'];
         } else {
-            $var = "this_".$type;
+            $var = "this_" . $type;
             $item = $$var; // $this_page or $this_section.
             $key = $args;
         }
 
         twfy_debug("DATA", "$type: $item, $key");
-        $dataarray =& $this->$type;
+        $dataarray = & $this->$type;
 
         if ($this->test_for_metadata($type, $item, $key)) {
             $return = $dataarray[$item][$key];
-            $debugtext = "Key: ".$type."[".$item."][".$key."]";
+            $debugtext = "Key: " . $type . "[" . $item . "][" . $key . "]";
 
         } elseif ($this->test_for_metadata($type, "default", $key)) {
             $return = $dataarray["default"][$key];
-            $debugtext = "Key: ".$type."['default'][".$key."]";
+            $debugtext = "Key: " . $type . "['default'][" . $key . "]";
 
         } else {
             $return = false;
@@ -206,9 +206,9 @@ 
         $key = $args["key"];
         $value = $args["value"];
 
-        twfy_debug("DATA", "Setting: ".$type."[".$item."][".$key."] = '" . print_r($value, 1) . "'");
+        twfy_debug("DATA", "Setting: " . $type . "[" . $item . "][" . $key . "] = '" . print_r($value, 1) . "'");
 
-        $dataarray =& $this->$type;
+        $dataarray = & $this->$type;
         $dataarray[$item][$key] = $value;
     }
 

Braces +12 added lines, -6 removed lines

@@ -121,7 +121,8 @@ 
     public function metadata($type, $item, $key) {
         if ($this->test_for_metadata($type, $item, $key)) {
             return $this->$type[$item][$key];
-        } else {
+        }
+        else {
             return "INVALID METADATA: $type[$item][$key]";
         }
     }
@@ -135,7 +136,8 @@ 
 
         if (isset($dataarray[$item][$key])) {
             return true;
-        } else {
+        }
+        else {
             return false;
         }
     }
@@ -152,7 +154,8 @@ 
         if (is_array($args)) {
             $item = $args[$type];
             $key = $args['key'];
-        } else {
+        }
+        else {
             $var = "this_".$type;
             $item = $$var; // $this_page or $this_section.
             $key = $args;
@@ -165,11 +168,13 @@ 
             $return = $dataarray[$item][$key];
             $debugtext = "Key: ".$type."[".$item."][".$key."]";
 
-        } elseif ($this->test_for_metadata($type, "default", $key)) {
+        }
+        elseif ($this->test_for_metadata($type, "default", $key)) {
             $return = $dataarray["default"][$key];
             $debugtext = "Key: ".$type."['default'][".$key."]";
 
-        } else {
+        }
+        else {
             $return = false;
             $debugtext = "No metadata found for key '$key'";
         }
@@ -184,7 +189,8 @@ 
         if (isset($args["section"])) {
             $type = "section";
             $item = $args["section"];
-        } else {
+        }
+        else {
             $type = "page";
             $item = $args["page"];
         }

classes/Db/Query.php

Doc Comments +12 added lines

@@ -175,6 +175,11 @@ 
     }
 
     // After SELECT.
+
+    /**
+     * @param integer $row_index
+     * @param string $column_name
+     */
     public function field($row_index, $column_name) {
         if ($this->rows > 0)
             return $this->data[$row_index][$column_name];
@@ -187,6 +192,10 @@ 
     }
 
     // After SELECT.
+
+    /**
+     * @param integer $row_index
+     */
     public function row($row_index) {
         if ($this->success && $this->rows > 0)
             return $this->data[$row_index];
@@ -224,6 +233,9 @@ 
         return $html;
     }
 
+    /**
+     * @param string $errormsg
+     */
     public function error($errormsg) {
         // When a query goes wrong...
         $this->success = false;

Indentation -1 removed lines

@@ -72,7 +72,6 @@
  * - `$this->field(n,col)` returns an empty string.
  * - `$this->insert_id()` returns `null`.
  * - `$this->affected_rows()` returns `null`.
-
  */
 
 class Query {

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -78,16 +78,16 @@ 
 class Query {
 
     public $success = true;
-    public $rows = NULL;
+    public $rows = null;
     public $data = array();
-    public $insert_id = NULL;
-    public $affected_rows = NULL;
+    public $insert_id = null;
+    public $affected_rows = null;
 
     public function __construct($conn) {
         $this->conn = $conn;
     }
 
-    public function query($sql="", $params = NULL) {
+    public function query($sql="", $params = null) {
 
         if (empty($sql)) {
             $this->success = false;
@@ -104,7 +104,7 @@ 
         twfy_debug ("SQL", $sql);
         twfy_debug ("SQL", print_r($params, 1));
 
-        if ($params !== NULL) {
+        if ($params !== null) {
             // Prepare and execute a statement
             $pdoStatement = $this->conn->prepare($sql);
 

Spacing +5 added lines, -5 removed lines

@@ -87,7 +87,7 @@ 
         $this->conn = $conn;
     }
 
-    public function query($sql="", $params = NULL) {
+    public function query($sql = "", $params = NULL) {
 
         if (empty($sql)) {
             $this->success = false;
@@ -101,8 +101,8 @@ 
             return;
         }
 
-        twfy_debug ("SQL", $sql);
-        twfy_debug ("SQL", print_r($params, 1));
+        twfy_debug("SQL", $sql);
+        twfy_debug("SQL", print_r($params, 1));
 
         if ($params !== NULL) {
             // Prepare and execute a statement
@@ -133,7 +133,7 @@ 
 
         if (!$this->success) return;
 
-        if ( (!$pdoStatement) or (empty($pdoStatement)) ) {
+        if ((!$pdoStatement) or (empty($pdoStatement))) {
             // A failed query.
             $this->success = false;
 
@@ -155,7 +155,7 @@ 
             }
             $this->affected_rows = $pdoStatement->rowCount();
 
-            twfy_debug ("SQLRESULT", array($this, 'displayResult'));
+            twfy_debug("SQLRESULT", array($this, 'displayResult'));
             // mysql_free_result($q);
         }
     }

Braces +19 added lines, -10 removed lines

@@ -112,7 +112,8 @@ 
 
                 if (is_int($paramValue)) {
                     $paramType = \PDO::PARAM_INT;
-                } else {
+                }
+                else {
                     $paramType = \PDO::PARAM_STR;
                 }
 
@@ -121,7 +122,8 @@ 
 
             $pdoStatement->execute();
 
-        } else {
+        }
+        else {
             // Execute the raw query
             $pdoStatement = $this->conn->query($sql);
         }
@@ -131,13 +133,16 @@ 
             $this->error($this->conn->errorCode() . ': ' . $this->conn->errorInfo()[2]);
         }
 
-        if (!$this->success) return;
+        if (!$this->success) {
+            return;
+        }
 
         if ( (!$pdoStatement) or (empty($pdoStatement)) ) {
             // A failed query.
             $this->success = false;
 
-        } else {
+        }
+        else {
 
             // A successful SELECT, SHOW, EXPLAIN or DESCRIBE query.
             $this->success = true;
@@ -150,7 +155,8 @@ 
             // Sanity check that lastInsertId() is actually a number, otherwise panic
             if (is_numeric($this->conn->lastInsertId())) {
                 $this->insert_id = (int) $this->conn->lastInsertId();
-            } else {
+            }
+            else {
                 throw new Exception('Last connection ID was not numeric!');
             }
             $this->affected_rows = $pdoStatement->rowCount();
@@ -176,8 +182,9 @@ 
 
     // After SELECT.
     public function field($row_index, $column_name) {
-        if ($this->rows > 0)
-            return $this->data[$row_index][$column_name];
+        if ($this->rows > 0) {
+                    return $this->data[$row_index][$column_name];
+        }
         return "";
     }
 
@@ -188,8 +195,9 @@ 
 
     // After SELECT.
     public function row($row_index) {
-        if ($this->success && $this->rows > 0)
-            return $this->data[$row_index];
+        if ($this->success && $this->rows > 0) {
+                    return $this->data[$row_index];
+        }
         return array();
     }
 
@@ -212,7 +220,8 @@ 
                     if ($n == "email" || $n == "password" || $n == "postcode") {
                         // Don't want to risk this data being displayed on any page.
                         $html .= "<td>**MASKED**</td>";
-                    } else {
+                    }
+                    else {
                         $html .= "<td>" . _htmlentities($field) . "</td>";
                     }
                 }

classes/Db/Connection.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
      * @param string $db_pass The password for the database user
      * @param string $db_name The name of the database
      *
-     * @return true If the connection has been created successfully.
+     * @return boolean If the connection has been created successfully.
      */
 
     public function init($db_host, $db_user, $db_pass, $db_name) {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * @return Query An object containing the results of the query.
      */
 
-    public function query($sql, $params = NULL) {
+    public function query($sql, $params = null) {
 
         $start = getmicrotime();
         $q = new \MySociety\TheyWorkForYou\Db\Query($this->conn);

Spacing +2 added lines, -2 removed lines

@@ -111,7 +111,7 @@ 
         $duration = getmicrotime() - $start;
         global $mysqltotalduration;
         $mysqltotalduration += $duration;
-        twfy_debug ("SQL", "Complete after $duration seconds.");
+        twfy_debug("SQL", "Complete after $duration seconds.");
         // We could also output $q->mysql_info() here, but that's for
         // PHP >= 4.3.0.
         return $q;
@@ -126,7 +126,7 @@ 
 
     public function display_total_duration() {
         global $mysqltotalduration;
-        twfy_debug ("TIME", "Total time for MySQL queries on this page: " . $mysqltotalduration . " seconds.");
+        twfy_debug("TIME", "Total time for MySQL queries on this page: " . $mysqltotalduration . " seconds.");
     }
 
     /**

www/includes/easyparliament/init.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
 include_once (INCLUDESPATH."easyparliament/user.php");
 
 // Test to see if this is a new-style template using the renderer class.
-if (! isset($new_style_template) OR $new_style_template !== TRUE) {
+if (! isset($new_style_template) or $new_style_template !== true) {
 
     // This is an old-style page. Use the old page classes.
     include_once (INCLUDESPATH."easyparliament/page.php");

Braces +7 added lines, -3 removed lines

@@ -41,7 +41,9 @@ 
 twfy_debug_timestamp("after including utility.php");
 
 // Set the default timezone
-if(function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
+if(function_exists('date_default_timezone_set')) {
+    date_default_timezone_set(TIMEZONE);
+}
 
 // Only do clever things with errors if we're not testing, otherwise show as default
 
@@ -51,7 +53,8 @@ 
     $error_level = E_ALL & ~E_NOTICE;
     if (DEVSITE) {
         $error_level = E_ALL | E_STRICT;
-    } elseif (version_compare(phpversion(), "5.3") >= 0) {
+    }
+    elseif (version_compare(phpversion(), "5.3") >= 0) {
         $error_level = $error_level & ~E_DEPRECATED;
     }
 
@@ -62,7 +65,8 @@ 
         $whoops = new \Whoops\Run;
         $whoops->pushHandler(new \Whoops\Handler\PrettyPageHandler);
         $whoops->register();
-    } else {
+    }
+    else {
         set_exception_handler("exception_handler");
     }
 

Spacing +25 added lines, -25 removed lines

@@ -4,7 +4,7 @@ 
 First some things to help make our PHP nicer and betterer
 ********************************************************************************/
 
-error_reporting (E_ALL);
+error_reporting(E_ALL);
 
 /********************************************************************************
 Now some constants that are the same for live and dev versions
@@ -12,22 +12,22 @@ 
 ********************************************************************************/
 
 // In case we need to switch these off globally at some point...
-define ("ALLOWCOMMENTS", true);
-define ("ALLOWTRACKBACKS", true);
+define("ALLOWCOMMENTS", true);
+define("ALLOWTRACKBACKS", true);
 
 // These variables are so we can keep date/time formats consistent across the site
 // and change them easily.
 // Formats here: http://www.php.net/manual/en/function.date.php
-define ("LONGERDATEFORMAT",		"l, j F Y");// Monday, 31 December 2003
-define ("LONGDATEFORMAT", 		"j F Y"); 	// 31 December 2003
-define ("SHORTDATEFORMAT", 		"j M Y");	// 31 Dec 2003
-define ("TIMEFORMAT", 			"g:i a");	// 11:59 pm
+define("LONGERDATEFORMAT", "l, j F Y"); // Monday, 31 December 2003
+define("LONGDATEFORMAT", "j F Y"); // 31 December 2003
+define("SHORTDATEFORMAT", "j M Y"); // 31 Dec 2003
+define("TIMEFORMAT", "g:i a"); // 11:59 pm
 
-define ("SHORTDATEFORMAT_SQL",	"%e %b %Y"); // 31 Dec 2003
-define ("TIMEFORMAT_SQL", 		"%l:%i %p"); // 11:59 PM
+define("SHORTDATEFORMAT_SQL", "%e %b %Y"); // 31 Dec 2003
+define("TIMEFORMAT_SQL", "%l:%i %p"); // 11:59 PM
 
 // Where we store the postcode of users if they search for an MP by postcode.
-define ('POSTCODE_COOKIE', 		'eppc');
+define('POSTCODE_COOKIE', 'eppc');
 
 /********************************************************************************
 And now all the files we'll include on every page.
@@ -41,7 +41,7 @@ 
 twfy_debug_timestamp("after including utility.php");
 
 // Set the default timezone
-if(function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
+if (function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
 
 // Only do clever things with errors if we're not testing, otherwise show as default
 
@@ -70,42 +70,42 @@ 
 
 // The time the page starts, so we can display the total at the end.
 // getmicrotime() is in utiltity.php.
-define ("STARTTIME", getmicrotime());
+define("STARTTIME", getmicrotime());
 if (!isset($_SERVER['WINDIR'])) {
     $rusage = getrusage();
-    define ('STARTTIMES', $rusage['ru_stime.tv_sec']*1000000 + $rusage['ru_stime.tv_usec']);
-    define ('STARTTIMEU', $rusage['ru_utime.tv_sec']*1000000 + $rusage['ru_utime.tv_usec']);
+    define('STARTTIMES', $rusage['ru_stime.tv_sec'] * 1000000 + $rusage['ru_stime.tv_usec']);
+    define('STARTTIMEU', $rusage['ru_utime.tv_sec'] * 1000000 + $rusage['ru_utime.tv_usec']);
 }
 
 $DATA = new \MySociety\TheyWorkForYou\Data;
 
 class ParlDB extends \MySociety\TheyWorkForYou\Db\Connection {
     public function __construct() {
-        $this->init (OPTION_TWFY_DB_HOST, OPTION_TWFY_DB_USER, OPTION_TWFY_DB_PASS, OPTION_TWFY_DB_NAME);
+        $this->init(OPTION_TWFY_DB_HOST, OPTION_TWFY_DB_USER, OPTION_TWFY_DB_PASS, OPTION_TWFY_DB_NAME);
     }
 }
 
-include_once (INCLUDESPATH."url.php");
+include_once (INCLUDESPATH . "url.php");
 
 $filter = new \MySociety\TheyWorkForYou\Utility\LibFilter;
 
-include_once (INCLUDESPATH."easyparliament/user.php");
+include_once (INCLUDESPATH . "easyparliament/user.php");
 
 // Test to see if this is a new-style template using the renderer class.
-if (! isset($new_style_template) OR $new_style_template !== TRUE) {
+if (!isset($new_style_template) OR $new_style_template !== TRUE) {
 
     // This is an old-style page. Use the old page classes.
-    include_once (INCLUDESPATH."easyparliament/page.php");
+    include_once (INCLUDESPATH . "easyparliament/page.php");
 
 }
 
-include_once (INCLUDESPATH."easyparliament/hansardlist.php");
-include_once (INCLUDESPATH."dbtypes.php");
-include_once (INCLUDESPATH."easyparliament/commentlist.php");
-include_once (INCLUDESPATH."easyparliament/comment.php");
-include_once (INCLUDESPATH."easyparliament/trackback.php");
+include_once (INCLUDESPATH . "easyparliament/hansardlist.php");
+include_once (INCLUDESPATH . "dbtypes.php");
+include_once (INCLUDESPATH . "easyparliament/commentlist.php");
+include_once (INCLUDESPATH . "easyparliament/comment.php");
+include_once (INCLUDESPATH . "easyparliament/trackback.php");
 
 // Added in as new module by Richard Allan MP
-include_once (INCLUDESPATH."easyparliament/alert.php");
+include_once (INCLUDESPATH . "easyparliament/alert.php");
 
 twfy_debug_timestamp("at end of init.php");

classes/Renderer/User.php

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
         $edittext   = $menudata['text'];
         $edittitle  = $menudata['title'];
         $EDITURL    = new \URL('userviewself');
-        if ($this->page == 'userviewself' || $this->page == 'useredit' ) {
+        if ($this->page == 'userviewself' || $this->page == 'useredit') {
             $editclass = 'on';
         } else {
             $editclass = '';
@@ -58,7 +58,7 @@ 
         // The 'Log out' link.
         $menudata   = $this->pagedata->page_metadata('userlogout', 'menu');
         $logouttext = $menudata['text'];
-        $logouttitle= $menudata['title'];
+        $logouttitle = $menudata['title'];
 
         $LOGOUTURL  = new \URL('userlogout');
         if ($this->page != 'userlogout') {

Braces +12 added lines, -6 removed lines

@@ -38,7 +38,8 @@ 
         //user logged in
         if ($this->user->isloggedin()) {
             $this->addLoggedInLinks();
-        } else {
+        }
+        else {
             $this->addLoggedOutLinks();
         }
     }
@@ -51,7 +52,8 @@ 
         $EDITURL    = new \URL('userviewself');
         if ($this->page == 'userviewself' || $this->page == 'useredit' ) {
             $editclass = 'on';
-        } else {
+        }
+        else {
             $editclass = '';
         }
 
@@ -64,7 +66,8 @@ 
         if ($this->page != 'userlogout') {
             $LOGOUTURL->insert(array("ret"=>$this->returl));
             $logoutclass = '';
-        } else {
+        }
+        else {
             $logoutclass = 'on';
         }
 
@@ -105,7 +108,8 @@ 
                 $JOINURL->insert(array("ret"=>$this->returl));
             }
             $joinclass = '';
-        } else {
+        }
+        else {
             $joinclass = 'on';
         }
 
@@ -127,7 +131,8 @@ 
                 $LOGINURL->insert(array("ret"=>$this->returl));
             }
             $loginclass = '';
-        } else {
+        }
+        else {
             $loginclass = 'on';
         }
 
@@ -153,7 +158,8 @@ 
             $items = array('yourmp');
             if (\MySociety\TheyWorkForYou\Utility\Postcode::postcodeIsScottish($this->user->postcode())) {
                 $items[] = 'yourmsp';
-            } elseif (\MySociety\TheyWorkForYou\Utility\Postcode::postcodeIsNi($this->user->postcode())) {
+            }
+            elseif (\MySociety\TheyWorkForYou\Utility\Postcode::postcodeIsNi($this->user->postcode())) {
                 $items[] = 'yourmla';
             }
 

classes/Memcache.php

Spacing +4 added lines, -4 removed lines

@@ -26,9 +26,9 @@ 
 
     public function set($key, $value, $timeout = 3600) {
         if (class_exists('\Memcached')) {
-            self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, $timeout);
+            self::$memcache->set(OPTION_TWFY_DB_NAME . ':' . $key, $value, $timeout);
         } else {
-            self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, MEMCACHE_COMPRESSED, $timeout);
+            self::$memcache->set(OPTION_TWFY_DB_NAME . ':' . $key, $value, MEMCACHE_COMPRESSED, $timeout);
         }
     }
 
@@ -36,9 +36,9 @@ 
         // see http://php.net/manual/en/memcache.get.php#112056 for explanation of this
         $was_found = false;
         if (class_exists('\Memcached')) {
-            $value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, null, $was_found);
+            $value = self::$memcache->get(OPTION_TWFY_DB_NAME . ':' . $key, null, $was_found);
         } else {
-            $value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, $was_found);
+            $value = self::$memcache->get(OPTION_TWFY_DB_NAME . ':' . $key, $was_found);
         }
         if ($was_found === false) {
             return false; // mmmmm

Braces +8 added lines, -4 removed lines

@@ -17,7 +17,8 @@ 
             if (class_exists('\Memcached')) {
                 self::$memcache = new \Memcached;
                 self::$memcache->addServer('localhost', 11211);
-            } else {
+            }
+            else {
                 self::$memcache = new \Memcache;
                 self::$memcache->connect('localhost', 11211);
             }
@@ -27,7 +28,8 @@ 
     public function set($key, $value, $timeout = 3600) {
         if (class_exists('\Memcached')) {
             self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, $timeout);
-        } else {
+        }
+        else {
             self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, MEMCACHE_COMPRESSED, $timeout);
         }
     }
@@ -37,12 +39,14 @@ 
         $was_found = false;
         if (class_exists('\Memcached')) {
             $value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, null, $was_found);
-        } else {
+        }
+        else {
             $value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, $was_found);
         }
         if ($was_found === false) {
             return false; // mmmmm
-        } else {
+        }
+        else {
             return $value;
         }
     }