mysociety / theyworkforyou

www/docs/news/editme.php

Upper-Lower-Casing +32 added lines, -32 removed lines

@@ -20,7 +20,7 @@ 
 
 Read <a href="http://www.mysociety.org/2009/01/21/blimey-it-looks-like-the-internets-won/">our victory mySociety blog post</a>,
 and do join our mailing list. :-)
-EOT
+eot
 , '2009-01-21 15:30:00', 'Matthew'),
 
 48 => array('API keys, and improved internal links', <<<EOT
@@ -45,7 +45,7 @@ 
 crowd-sourcing game to match the reference to the exact speech, much like our
 <a href="https://www.theyworkforyou.com/video/">video matching</a> (nearly 80%
 of our archive done!). :)
-EOT
+eot
 , '2008-07-18 14:01:00', 'Matthew'),
 
 47 => array('Video on TheyWorkForYou', <<<EOT
@@ -57,7 +57,7 @@ 
 
 <a href="http://www.mysociety.org/2008/06/01/video-recordings-of-the-house-of-commons-on-theyworkforyoucom/">Etienne's post on the mySociety blog</a>
 has some background information on the project.
-EOT
+eot
 , '2008-06-02 18:56:00', 'Matthew'),
 
 46 => array('The Scottish Parliament', <<<EOT
@@ -89,7 +89,7 @@ 
 launching this now to mark the success in getting endorsements for our <a
 href="/freeourbills/">Free Our Bills campaign</a>, and we'll be rolling out
 more goodies as the campaign goes along.
-EOT
+eot
 , '2008-05-06 13:35:28', 'Matthew'),
 
 45 => array('Shadow ministers and spokespersons', <<<EOT
@@ -98,7 +98,7 @@ 
 This information is given both on a person's page and within any debates they
 speak in, which could help explain why your local MP is speaking on transport
 or foreign affairs a lot. :)
-EOT
+eot
 , '2008-04-30 08:25:00', 'Matthew'),
 
 44 => array('Please donate to help us expand TheyWorkForYou', <<<EOT
@@ -107,7 +107,7 @@ 
 Unfortunately, the server that TheyWorkForYou sits on is almost full, so we can&#8217;t launch their hard work. Boo!
 
 TheyWorkForYou isn&#8217;t an externally funded project, and we need funding from other sources to keep it growing and improving. So if the season has filled you with generosity of spirit, why not <a href="https://secure.mysociety.org/donate/">drop us a few pennies</a> to pay for some upgrades? Any extra beyond what we need will go into the general pot to keep <a href="http://www.mysociety.org/">mySociety</a> running and the developers from starving.
-EOT
+eot
 , '2007-12-21 10:07:35', 'Tom'),
 
 43 => array('The Queen in Parliament', <<<EOT
@@ -121,7 +121,7 @@ 
 or just look at past
 <a href="https://www.theyworkforyou.com/search/?pid=13935&pop=1">prorogation and Queen's speeches</a>
 more easily than anywhere else I've found.
-EOT
+eot
 , '2007-09-11 15:34:47', 'Matthew'),
 
 42 => array('Missing confirmation emails', <<<EOT
@@ -132,7 +132,7 @@ 
 few days have now been sent out, and I've got in touch
 with anyone who signed up in the days prior to
 that to let them know what happened.
-EOT
+eot
 , "2007-09-03 17:12:47", 'Matthew'),
 
 41 => array('The Northern Ireland Assembly', <<<EOT
@@ -172,7 +172,7 @@ 
 
 ATB,<br>
 <a href="http://www.dracos.co.uk/">Matthew Somerville</a>
-EOT
+eot
 , "2006-12-11 00:00:00", 'Matthew'),
 
 40 => array('TheyWorkForYou API', <<<EOT
@@ -191,7 +191,7 @@ 
 Here's my <a href="http://www.mysociety.org/2006/barcamp-london/">BarCamp
 Presentation</a> launching the API, and a <a href="http://www.dracos.co.uk/work/theyworkforyou/api/fabfarts/">couple</a>
 of <a href="http://www.mysociety.org/2006/09/02/battle-your-way-to-sedgefield/">applications</a> using it.
-EOT
+eot
 , "2006-09-02 17:10:00"),
 
 39 => array('New features over the last couple of months', <<<EOT
@@ -219,7 +219,7 @@ 
 and when searching a particular person's speeches, we no longer group the results by debate, which
 was confusing, as you obviously expected to see all the speeches for that person that matched your
 search terms.
-EOT
+eot
 , "2006-08-18 09:46:36"),
 
 38 => array("Got an idea for a useful website?", <<<EOT
@@ -227,7 +227,7 @@ 
 come up with an idea for a useful site like this one, and it beats all
 the other ideas, we'll build it for free. <a href="http://www.mysociety.org/proposals2006/submit">Submit an idea</a>
 or <a href="http://www.mysociety.org/proposals2006/view">read and comment on what other people have submitted</a>.
-EOT
+eot
 , "2006-06-06 06:06:06"),
 
 37 => array("We've added the Lords, and more", <<<EOT
@@ -237,14 +237,14 @@ 
 also added a feature to the search to help you identify which MPs or
 Lords are interested in a certain word or phrases. Just search as
 usual and then click 'Show use by person'.
-EOT
+eot
 , "2006-06-01 12:34:56"),
 
 36 => array("Changes to the Register of Members' Interests", <<<EOT
 One of the many things our site does, probably without you realising, is to track the Register of Members' Interests, in which MPs are "to provide information of any pecuniary interest or other material benefit which a Member receives which might reasonably be thought by others to influence his or her actions, speeches or votes in Parliament, or actions taken in the capacity of a Member of Parliament". The latest entry published on the official site has always been shown on MP pages (<a href="https://www.theyworkforyou.com/mp/tony_blair/sedgefield#register">here's Tony Blair's</a>), however we kept all previous editions of the Register safe and sound. And now, after a bit of coding, you can view a history of the Register, either <a href="https://www.theyworkforyou.com/regmem/?f=2005-12-14">comparing particular editions</a>, or for particular MPs (<a href="https://www.theyworkforyou.com/regmem/?p=10001">Diane Abbott</a>, for example). Entries only have to stay on the Register for a year, so this can make for some interesting reading.
 
 Happy New Year! :) <a href="https://www.theyworkforyou.com/regmem/">Changes to the Register of Members' Interests</a>
-EOT
+eot
 , "2006-01-01 12:36:00"),
 
 35 => array("TheyWorkForYou.com Wins Award", <<<EOT
@@ -253,14 +253,14 @@ 
 Thanks to the kind souls who nominated us. We enjoyed ourselves.
 
 
-EOT
+eot
 , "2005-07-05 23:54:13"),
 
 34 => array("NEW! Email this page to a friend", <<<EOT
 At the top right hand side of every (ex)MP's page, we've added a simple new feature: email the page to a friend.
 
 <a href="/mp/">Have a go</a>, and let all your friends know how easy it is to keep tabs on what your former MP did and said in your name during the last Parliament.
-EOT
+eot
 , "2005-04-14 23:43:50"),
 
 33 => array("Play with Pledgebank, Pound the Streets", <<<EOT
@@ -273,7 +273,7 @@ 
 </blockquote>
 
 If you're up for it, why not <a href="http://www.pledgebank.com/theywork">sign up now?</a>
-EOT
+eot
 , "2005-04-13 22:41:23"),
 
 32 => array("NEW! How MPs voted on Key Issues", <<<EOT
@@ -286,7 +286,7 @@ 
 This information is the result sophisticated mining of PublicWhip's detailed vote data covering hundreds of Parliamentary divisions.
 
 We hope it'll make it easier for you to keep track of where your MP really stands on key issues - after all, They Work For You.
-EOT
+eot
 , "2005-04-05 22:59:57"),
 
 31 => array("Channel 4 linking to TheyWorkForYou.com", <<<EOT
@@ -295,7 +295,7 @@ 
 We've done a special paint job for users coming from the Channel 4 site, just to make them feel welcome. You can see an example <a href="https://www.theyworkforyou.com/mp/c4/paul_keetch/hereford">here</a>.
 
 We'd love to know what you think of this paint job, as we're planning a redesign. As ever, <a href="/contact/">get in touch</a>.
-EOT
+eot
 , "2005-04-05 22:53:32"),
 
 30 => array("NEW! Email Alerts & Other Features", <<<EOT
@@ -357,7 +357,7 @@ 
     - Tom, on behalf of the TheyWorkForYou.com volunteers
 
      <a href="https://www.theyworkforyou.com/about/">https://www.theyworkforyou.com/about/</a>  - New volunteers welcome!
-EOT
+eot
 , "2005-02-24 22:02:44"),
 
 26 => array("New Release of TheyWorkForYou.com Source Code", <<<EOT
@@ -374,7 +374,7 @@ 
 Feel free to download it and have a play.
 
 Whilst you're at it, don't forget we also publish a full <a href="https://www.theyworkforyou.com/raw/">XML version of the Hansard data</a>.
-EOT
+eot
 , "2005-01-25 00:15:19"),
 
 25 => array("Search by Date", <<<EOT
@@ -386,7 +386,7 @@ 
 Next step on search is probably an RSS version of keyword searches. We're still very keen to improve overall relevancy of results - anyone out there fancy lending us a Google Appliance to play with?
 
 As ever, <a href="/contact/">contact us</a> if you've got any suggestions how we might improve the site, or if you fancy volunteering.
-EOT
+eot
 , "2005-01-25 00:16:09"),
 
 20 => array("New! Ministerial Statements now included", <<<EOT
@@ -404,7 +404,7 @@ 
 Next up: Select Committees, which promise to be an order of magnitude more challenging. We'll keep you posted.
 
 PS We're always on the lookout for new volunteers - <a href="/contact/">contact us</a> if you are keen to help in almost any capacity.
-EOT
+eot
 , "2005-01-17 17:44:47"),
 
 19 => array("NEW! Westminster Hall debates now available.", <<<EOT
@@ -422,7 +422,7 @@ 
 
 
 
-EOT
+eot
 , "2004-12-22 23:47:19"),
 
 18 => array("RSS feed of your MP's recent appearances", <<<EOT
@@ -436,7 +436,7 @@ 
 RSS is a simple way to publish & distribute content which is frequently updated  (<a href="http://news.bbc.co.uk/1/hi/help/3223484.stm">learn more here</a>.)
 
 Some enlightened MPs are now incorporating this useful feed of their Parliamentary activity into their websites. See <a href="http://www.richardallan.org.uk/">Richard Allen's</a> website for a good example.
-EOT
+eot
 , "2004-11-27 16:38:41"),
 
 16 => array("NEW! MPs' Expenses", <<<EOT
@@ -445,7 +445,7 @@ 
 For example, it is good to note that <a href="https://www.theyworkforyou.com/mp/?pid=10508#expenses">Barbara Roche</a>, a North London MP, does not claim excessive travel expenses.
 
 Bear in mind that proper democracy does cost money, so please think twice before using these data as a stick with which to beat your MP. An "expensive" MP might be providing excellent value for money. And vice versa.
-EOT
+eot
 , "2004-11-08 10:11:14"),
 
 11 => array("TheyWorkForYou.com Development Wiki now public", <<<EOT
@@ -461,7 +461,7 @@ 
 (dissemination is fine, but please don't post the link with the login details embedded in the url)
 
 In case you're wondering what we're up to, well, we're just rousing ourselves for another tilt at completing our vision before the next election is called, so if anyone python or php skills and fancies lending a hand, do <a href="/contact/">contact us</a>.
-EOT
+eot
 , "2004-10-01 23:14:13"),
 
 8 => array("New! Full Source Code Published", <<<EOT
@@ -481,7 +481,7 @@ 
 
 <a href="https://www.theyworkforyou.com/rss/mp/10508.rdf">https://www.theyworkforyou.com/rss/mp/10508.rdf</a>
     - Typical MP 'recent appearances' RSS feed, uses person id.
-EOT
+eot
 , "2004-07-18 22:58:23"),
 
 7 => array("Public Beta Now Live", <<<EOT
@@ -502,7 +502,7 @@ 
 More than the usuals,
 
 - <i><a href="https://www.theyworkforyou.com/about/" title="link to About Us page">The TheyWorkForYou.com Volunteers</a></i>
-EOT
+eot
 , "2004-06-06 03:02:53"),
 
 6 => array("Want to help make us complete?", <<<EOT
@@ -514,14 +514,14 @@ 
 
 Just <a href="/contact/">contact us</a>.
 
-EOT
+eot
 , "2004-05-21 22:15:22"),
 
 5 => array("Know someone who'd like this website?", <<<EOT
 If you know someone who would appreciate being a beta tester, please <a href="/contact/">contact us</a> with their details.
 
 Many thanks.
-EOT
+eot
 , "2004-05-21 22:55:24"),
 
 4 => array("Welcome to our private beta test", <<<EOT
@@ -538,7 +538,7 @@ 
 In the meantime, please enjoy being the first people to scribble in the margins of Hansard. May you be first of many.
 
 - <em>The TheyWorkForYou.com volunteers</em>
-EOT
+eot
 , "2004-05-21 22:55:24")
 );
 

www/docs/search/index.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-$new_style_template = TRUE;
+$new_style_template = true;
 
 include_once '../../includes/easyparliament/init.php';
 include_once INCLUDESPATH . "easyparliament/glossary.php";

www/docs/alert/index.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-$new_style_template = TRUE;
+$new_style_template = true;
 
 include_once '../../includes/easyparliament/init.php';
 include_once INCLUDESPATH . 'easyparliament/member.php';

www/docs/alert/by-postcode/index.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-$new_style_template = TRUE;
+$new_style_template = true;
 
 include_once '../../../includes/easyparliament/init.php';
 include_once INCLUDESPATH . 'easyparliament/member.php';

www/docs/topic/topic.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 namespace MySociety\TheyWorkForYou;
 
 // Disable the old PAGE class.
-$new_style_template = TRUE;
+$new_style_template = true;
 
 // Include all the things this page needs.
 include_once '../../includes/easyparliament/init.php';

Spacing +3 added lines, -3 removed lines

@@ -54,12 +54,12 @@ 
                 $pc = get_http_var('pc');
                 $pc = preg_replace('#[^a-z0-9]#i', '', $pc);
                 if (validate_postcode($pc)) {
-                    twfy_debug ('MP', "MP lookup by postcode");
+                    twfy_debug('MP', "MP lookup by postcode");
                     $constituency = strtolower(Utility\Postcode::postcodeToConstituency($pc));
                     if ($constituency == "connection_timed_out") {
                         throw new Exception('Sorry, we couldn’t check your postcode right now, as our postcode lookup server is under quite a lot of load.');
                     } elseif ($constituency == "") {
-                        twfy_debug ('MP', "Can't display an MP, as submitted postcode didn't match a constituency");
+                        twfy_debug('MP', "Can't display an MP, as submitted postcode didn't match a constituency");
                         throw new Exception('Sorry, ' . _htmlentities($pc) . ' isn’t a known postcode');
                     } else {
                         // Generate the Member object
@@ -70,7 +70,7 @@ 
                         }
                     }
                 } else {
-                    twfy_debug ('MP', "Can't display an MP because the submitted postcode wasn't of a valid form.");
+                    twfy_debug('MP', "Can't display an MP because the submitted postcode wasn't of a valid form.");
                     throw new Exception('Sorry, ' . _htmlentities($pc) . ' isn’t a valid postcode');
                 }
             } catch (Exception $e) {

Braces +11 added lines, -10 removed lines

@@ -27,8 +27,7 @@ 
 $this_page = 'topic';
 
 // Make sure the requested topic actually exists, otherwise throw a 404.
-if ($topic = $topics->getTopic($topicname))
-{
+if ($topic = $topics->getTopic($topicname)) {
 
     $data = array();
     $data['topic'] = $topic;
@@ -45,8 +44,7 @@ 
         include_once INCLUDESPATH . 'easyparliament/member.php';
 
         // Check to see if there's a submitted postcode to try determine policy positions.
-        if (get_http_var('pc') != '')
-        {
+        if (get_http_var('pc') != '') {
 
             // Try all this, as it might go wrong.
             try {
@@ -58,10 +56,12 @@ 
                     $constituency = strtolower(Utility\Postcode::postcodeToConstituency($pc));
                     if ($constituency == "connection_timed_out") {
                         throw new Exception('Sorry, we couldn’t check your postcode right now, as our postcode lookup server is under quite a lot of load.');
-                    } elseif ($constituency == "") {
+                    }
+                    elseif ($constituency == "") {
                         twfy_debug ('MP', "Can't display an MP, as submitted postcode didn't match a constituency");
                         throw new Exception('Sorry, ' . _htmlentities($pc) . ' isn’t a known postcode');
-                    } else {
+                    }
+                    else {
                         // Generate the Member object
                         $member = new Member(array('constituency' => $constituency, 'house' => HOUSE_TYPE_COMMONS));
                         if ($member->person_id()) {
@@ -69,7 +69,8 @@ 
                             $THEUSER->set_postcode_cookie($pc);
                         }
                     }
-                } else {
+                }
+                else {
                     twfy_debug ('MP', "Can't display an MP because the submitted postcode wasn't of a valid form.");
                     throw new Exception('Sorry, ' . _htmlentities($pc) . ' isn’t a valid postcode');
                 }
@@ -81,8 +82,7 @@ 
 
         /////////////////////////////////////////////////////////
         // DOES THE USER HAVE A POSTCODE ALREADY SET?
-        elseif ($THEUSER->postcode_is_set())
-        {
+        elseif ($THEUSER->postcode_is_set()) {
             $member = new Member(array('postcode' => $THEUSER->postcode(), 'house' => HOUSE_TYPE_COMMONS));
         }
 
@@ -122,7 +122,8 @@ 
     // Send for rendering!
     Renderer::output('topic/topic', $data);
 
-} else {
+}
+else {
 
     header('HTTP/1.0 404 Not Found');
     Renderer::output('topic/error', array('error' => 'Sorry, but there isn’t a topic page by that name.'));

www/docs/topic/index.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 namespace MySociety\TheyWorkForYou;
 
 // Disable the old PAGE class.
-$new_style_template = TRUE;
+$new_style_template = true;
 global $this_page;
 $this_page = 'topics';
 

www/docs/topic/image.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
     $topic = $topics->getTopic($slug);
 }
 
-if (!$slug || !isset($topic) || $topic === NULL) {
+if (!$slug || !isset($topic) || $topic === null) {
     header('HTTP/1.0 404 Not Found');
     exit();
 }

www/docs/api/api_getPerson.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 <?php
 }
 
-function _api_getPerson_row($row, $has_party=FALSE) {
+function _api_getPerson_row($row, $has_party=false) {
     global $parties;
     $row['full_name'] = member_full_name($row['house'], $row['title'], $row['given_name'],
         $row['family_name'], $row['lordofname']);

Doc Comments +9 added lines

@@ -77,6 +77,9 @@ 
     }
 }
 
+/**
+ * @param MySociety\TheyWorkForYou\Db\Query $q
+ */
 function _api_getPerson_output($q, $flatten=false) {
     $output = array();
     $last_mod = 0;
@@ -95,10 +98,16 @@ 
     api_output($output, $last_mod);
 }
 
+/**
+ * @param integer $house
+ */
 function api_getPerson_constituency($constituency, $house) {
     _api_getPerson_constituency(array($constituency), $house);
 }
 
+/**
+ * @param integer $house
+ */
 function api_getPerson_postcode($pc, $house) {
     $pc = preg_replace('#[^a-z0-9 ]#i', '', $pc);
     $types = array();

Spacing +6 added lines, -6 removed lines

@@ -17,7 +17,7 @@ 
 <?php
 }
 
-function _api_getPerson_row($row, $has_party=FALSE) {
+function _api_getPerson_row($row, $has_party = FALSE) {
     global $parties;
     $row['full_name'] = member_full_name($row['house'], $row['title'], $row['given_name'],
         $row['family_name'], $row['lordofname']);
@@ -30,7 +30,7 @@ 
     }
     if ($has_party && isset($parties[$row['party']]))
         $row['party'] = $parties[$row['party']];
-    list($image,$sz) = MySociety\TheyWorkForYou\Utility\Member::findMemberImage($row['person_id']);
+    list($image, $sz) = MySociety\TheyWorkForYou\Utility\Member::findMemberImage($row['person_id']);
     if ($image) {
         list($width, $height) = getimagesize(str_replace(IMAGEPATH, BASEDIR . '/images/', $image));
         $row['image'] = $image;
@@ -43,7 +43,7 @@ 
         # Ministerialships and Select Committees
         $db = new ParlDB;
         $q = $db->query('SELECT * FROM moffice WHERE to_date="9999-12-31" and person=' . $row['person_id'] . ' ORDER BY from_date DESC');
-        for ($i=0; $i<$q->rows(); $i++) {
+        for ($i = 0; $i < $q->rows(); $i++) {
             $row['office'][] = $q->row($i);
         }
     }
@@ -55,7 +55,7 @@ 
     return $row;
 }
 
-function api_getPerson_id($id, $house='') {
+function api_getPerson_id($id, $house = '') {
     $db = new ParlDB;
     $params = array(
         ':person_id' => $id
@@ -77,10 +77,10 @@ 
     }
 }
 
-function _api_getPerson_output($q, $flatten=false) {
+function _api_getPerson_output($q, $flatten = false) {
     $output = array();
     $last_mod = 0;
-    for ($i=0; $i<$q->rows(); $i++) {
+    for ($i = 0; $i < $q->rows(); $i++) {
         $house = $q->field($i, 'house');
         $out = _api_getPerson_row($q->row($i), $house == HOUSE_TYPE_ROYAL ? false : true);
         $output[] = $out;

Braces +34 added lines, -17 removed lines

@@ -28,8 +28,9 @@ 
         $URL = new URL('mp');
         $row['url'] = $URL->generate('none') . make_member_url($row['full_name'], $row['constituency'], $row['house'], $row['person_id']);
     }
-    if ($has_party && isset($parties[$row['party']]))
-        $row['party'] = $parties[$row['party']];
+    if ($has_party && isset($parties[$row['party']])) {
+            $row['party'] = $parties[$row['party']];
+    }
     list($image,$sz) = MySociety\TheyWorkForYou\Utility\Member::findMemberImage($row['person_id']);
     if ($image) {
         list($width, $height) = getimagesize(str_replace(IMAGEPATH, BASEDIR . '/images/', $image));
@@ -49,7 +50,9 @@ 
     }
 
     foreach ($row as $k => $r) {
-        if (is_string($r)) $row[$k] = html_entity_decode($r);
+        if (is_string($r)) {
+            $row[$k] = html_entity_decode($r);
+        }
     }
 
     return $row;
@@ -72,7 +75,8 @@ 
         order by left_house desc", $params);
     if ($q->rows()) {
         _api_getPerson_output($q);
-    } else {
+    }
+    else {
         api_error('Unknown person ID');
     }
 }
@@ -85,8 +89,9 @@ 
         $out = _api_getPerson_row($q->row($i), $house == HOUSE_TYPE_ROYAL ? false : true);
         $output[] = $out;
         $time = strtotime($q->field($i, 'lastupdate'));
-        if ($time > $last_mod)
-            $last_mod = $time;
+        if ($time > $last_mod) {
+                    $last_mod = $time;
+        }
     }
     # Only one MP, not an array
     if ($flatten && count($output) == 1 && $house == HOUSE_TYPE_COMMONS) {
@@ -104,24 +109,30 @@ 
     $types = array();
     if ($house == HOUSE_TYPE_NI) {
         $types = array('NIE');
-    } elseif ($house == HOUSE_TYPE_SCOTLAND) {
+    }
+    elseif ($house == HOUSE_TYPE_SCOTLAND) {
         $types = array('SPC', 'SPE');
     }
     if (validate_postcode($pc)) {
         $constituencies = MySociety\TheyWorkForYou\Utility\Postcode::postcodeToConstituencies($pc);
         if ($constituencies == 'CONNECTION_TIMED_OUT') {
             api_error('Connection timed out');
-        } elseif ($types && isset($constituencies[$types[0]])) {
+        }
+        elseif ($types && isset($constituencies[$types[0]])) {
             $constituencies = array_map(function($c) use ($constituencies) { return $constituencies[$c]; }, $types);
             _api_getPerson_constituency($constituencies, $house);
-        } elseif ($types && isset($constituencies['WMC'])) {
+        }
+        elseif ($types && isset($constituencies['WMC'])) {
             api_error('Postcode not in correct region');
-        } elseif (isset($constituencies['WMC'])) {
+        }
+        elseif (isset($constituencies['WMC'])) {
             _api_getPerson_constituency(array($constituencies['WMC']), $house);
-        } else {
+        }
+        else {
             api_error('Unknown postcode');
         }
-    } else {
+    }
+    else {
         api_error('Invalid postcode');
     }
 }
@@ -134,13 +145,18 @@ 
 
     $cons = array();
     foreach ($constituencies as $constituency) {
-        if ($constituency == '') continue;
-        if ($constituency == 'Orkney ')
-            $constituency = 'Orkney & Shetland';
+        if ($constituency == '') {
+            continue;
+        }
+        if ($constituency == 'Orkney ') {
+                    $constituency = 'Orkney & Shetland';
+        }
 
         if ($house == HOUSE_TYPE_COMMONS) {
             $normalised = MySociety\TheyWorkForYou\Utility\Constituencies::normaliseConstituencyName($constituency);
-            if ($normalised) $constituency = $normalised;
+            if ($normalised) {
+                $constituency = $normalised;
+            }
         }
 
         $cons[] = $constituency;
@@ -167,7 +183,8 @@ 
 
     if ($q->rows > 0) {
         _api_getPerson_output($q, true);
-    } else {
+    }
+    else {
         api_error('Unknown constituency, or no results for that constituency');
     }
 }

www/docs/admin/featured.php

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -107,13 +107,13 @@ 
     $related2 = get_http_var('related2');
     $related3 = get_http_var('related3');
 
-    $gid = $url ? get_gid_from_url($url) : NULL;
-    $related_gid1 = $related1 ? get_gid_from_url($related1) : NULL;
-    $related_gid2 = $related2 ? get_gid_from_url($related2) : NULL;
-    $related_gid3 = $related3 ? get_gid_from_url($related3) : NULL;
+    $gid = $url ? get_gid_from_url($url) : null;
+    $related_gid1 = $related1 ? get_gid_from_url($related1) : null;
+    $related_gid2 = $related2 ? get_gid_from_url($related2) : null;
+    $related_gid3 = $related3 ? get_gid_from_url($related3) : null;
 
     print "<h2>Preview Content</h2>";
-    if ( $gid !== NULL ) {
+    if ( $gid !== null ) {
         $h = new MySociety\TheyWorkForYou\Homepage;
         $featured = $h->getFeaturedDebate($gid, $title, $context, array( $related_gid1, $related_gid2, $related_gid3 ));
 
@@ -153,7 +153,7 @@ 
 }
 
 function get_gid_from_url($url) {
-    $gid = NULL;
+    $gid = null;
     $parts = parse_url($url);
     parse_str($parts['query'], $query);
 

Spacing +7 added lines, -7 removed lines

@@ -12,7 +12,7 @@ 
 $out = '';
 if (get_http_var('preview')) {
     preview_featured();
-} else if ( get_http_var('confirm') ) {
+} else if (get_http_var('confirm')) {
     $out = update_featured();
 }
 
@@ -23,13 +23,13 @@ 
 print '</div>';
 
 function gid_to_url($gid) {
-    if ( !$gid ) {
+    if (!$gid) {
         return '';
     }
     global $hansardmajors;
     global $db;
 
-    $q = $db->query("SELECT major FROM hansard WHERE gid = :gid", array( ':gid' => $gid ));
+    $q = $db->query("SELECT major FROM hansard WHERE gid = :gid", array(':gid' => $gid));
     $url_gid = fix_gid_from_db($gid);
     $url = new \URL($hansardmajors[$q->field(0, 'major')]['page']);
     $url->insert(array('id' => $url_gid));
@@ -43,7 +43,7 @@ 
     $related = $featured->get_related();
     $context = $featured->get_context();
 
-    if ( get_http_var('url') ) {
+    if (get_http_var('url')) {
         $url = get_http_var('url');
         $title = get_http_var('title');
         $context = get_http_var('context');
@@ -113,9 +113,9 @@ 
     $related_gid3 = $related3 ? get_gid_from_url($related3) : NULL;
 
     print "<h2>Preview Content</h2>";
-    if ( $gid !== NULL ) {
+    if ($gid !== NULL) {
         $h = new MySociety\TheyWorkForYou\Homepage;
-        $featured = $h->getFeaturedDebate($gid, $title, $context, array( $related_gid1, $related_gid2, $related_gid3 ));
+        $featured = $h->getFeaturedDebate($gid, $title, $context, array($related_gid1, $related_gid2, $related_gid3));
 
         include INCLUDESPATH . 'easyparliament/templates/html/homepage/featured.php';
     } else {
@@ -157,7 +157,7 @@ 
     $parts = parse_url($url);
     parse_str($parts['query'], $query);
 
-    if ( $query['id'] ) {
+    if ($query['id']) {
         if (strpos($parts['path'], 'lords') !== false) {
             $gid = 'uk.org.publicwhip/lords/';
         } elseif (strpos($parts['path'], 'whall') !== false) {

Braces +10 added lines, -5 removed lines

@@ -12,7 +12,8 @@ 
 $out = '';
 if (get_http_var('preview')) {
     preview_featured();
-} else if ( get_http_var('confirm') ) {
+}
+else if ( get_http_var('confirm') ) {
     $out = update_featured();
 }
 
@@ -50,7 +51,8 @@ 
         $related1 = get_http_var('related1');
         $related2 = get_http_var('related2');
         $related3 = get_http_var('related3');
-    } else {
+    }
+    else {
         $url = gid_to_url($gid);
         $related1 = gid_to_url($related[0]);
         $related2 = gid_to_url($related[1]);
@@ -118,7 +120,8 @@ 
         $featured = $h->getFeaturedDebate($gid, $title, $context, array( $related_gid1, $related_gid2, $related_gid3 ));
 
         include INCLUDESPATH . 'easyparliament/templates/html/homepage/featured.php';
-    } else {
+    }
+    else {
         print "<p>A random debate from the last 7 days will be displayed</p>";
     }
 
@@ -160,9 +163,11 @@ 
     if ( $query['id'] ) {
         if (strpos($parts['path'], 'lords') !== false) {
             $gid = 'uk.org.publicwhip/lords/';
-        } elseif (strpos($parts['path'], 'whall') !== false) {
+        }
+        elseif (strpos($parts['path'], 'whall') !== false) {
             $gid = 'uk.org.publicwhip/westminhall/';
-        } else {
+        }
+        else {
             $gid = 'uk.org.publicwhip/debate/';
         }
         $gid .= $query['id'];