mysociety / theyworkforyou

tests/TWFY_Database_TestCase.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      */
     public function getConnection()
     {
-        $dsn = 'mysql:host=' . OPTION_TWFY_DB_HOST . ' ;dbname=' . OPTION_TWFY_DB_NAME . ';charset=utf8';
+        $dsn = 'mysql:host='.OPTION_TWFY_DB_HOST.' ;dbname='.OPTION_TWFY_DB_NAME.';charset=utf8';
         $username = OPTION_TWFY_DB_USER;
         $password = OPTION_TWFY_DB_PASS;
         $pdo = new PDO($dsn, $username, $password);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
 
     public function tearDown()
     {
-        $this->db = NULL;
+        $this->db = null;
 
         parent::tearDown();
     }

classes/Renderer.php

Indentation +5 added lines, -5 removed lines

@@ -84,12 +84,12 @@
         // Require the templates and output
 
         if ($template_only) {
-          require_once INCLUDESPATH . 'easyparliament/templates/html/' . $template . '.php';
+            require_once INCLUDESPATH . 'easyparliament/templates/html/' . $template . '.php';
         } else {
-          header('Content-Type: text/html; charset=utf-8');
-          require_once INCLUDESPATH . 'easyparliament/templates/html/header.php';
-          require_once INCLUDESPATH . 'easyparliament/templates/html/' . $template . '.php';
-          require_once INCLUDESPATH . 'easyparliament/templates/html/footer.php';
+            header('Content-Type: text/html; charset=utf-8');
+            require_once INCLUDESPATH . 'easyparliament/templates/html/header.php';
+            require_once INCLUDESPATH . 'easyparliament/templates/html/' . $template . '.php';
+            require_once INCLUDESPATH . 'easyparliament/templates/html/footer.php';
         }
     }
 

Spacing +8 added lines, -8 removed lines

@@ -43,7 +43,7 @@ 
         $user = new Renderer\User();
         $data = array_merge($user->data, $data);
 
-        if ( isset($page_errors) ) {
+        if (isset($page_errors)) {
             $data['page_errors'] = $page_errors;
         }
 
@@ -84,25 +84,25 @@ 
         // Require the templates and output
 
         if ($template_only) {
-          require_once INCLUDESPATH . 'easyparliament/templates/html/' . $template . '.php';
+          require_once INCLUDESPATH.'easyparliament/templates/html/'.$template.'.php';
         } else {
           header('Content-Type: text/html; charset=utf-8');
-          require_once INCLUDESPATH . 'easyparliament/templates/html/header.php';
-          require_once INCLUDESPATH . 'easyparliament/templates/html/' . $template . '.php';
-          require_once INCLUDESPATH . 'easyparliament/templates/html/footer.php';
+          require_once INCLUDESPATH.'easyparliament/templates/html/header.php';
+          require_once INCLUDESPATH.'easyparliament/templates/html/'.$template.'.php';
+          require_once INCLUDESPATH.'easyparliament/templates/html/footer.php';
         }
     }
 
     private static function addCommonURLs($data) {
         $urls = array();
-        if ( isset($data['urls']) ) {
+        if (isset($data['urls'])) {
             $urls = $data['urls'];
         }
 
         $common_urls = array('search', 'alert');
 
-        foreach ( $common_urls as $path ) {
-            if (!isset($urls[$path]) ) {
+        foreach ($common_urls as $path) {
+            if (!isset($urls[$path])) {
                 $url = new \URL($path);
                 $urls[$path] = $url->generate();
             }

classes/AlertView/Simple.php

Spacing +22 added lines, -22 removed lines

@@ -7,7 +7,7 @@ 
     public function display() {
         $data = array();
         $data['recent_election'] = false;
-        if ( $this->user->loggedin() ) {
+        if ($this->user->loggedin()) {
             $data['user_signed_in'] = true;
         }
 
@@ -17,21 +17,21 @@ 
             $data['postcode'] = get_http_var('postcode');
 
             $result = $this->createAlertForPostCode($data['email'], $data['postcode']);
-            $data = array_merge( $data, $result );
+            $data = array_merge($data, $result);
         } elseif (get_http_var('update')) {
             $result = $this->getNewMP(get_http_var('update'));
-            $data = array_merge( $data, $result );
+            $data = array_merge($data, $result);
         } elseif (get_http_var('update-alert')) {
-            $success = $this->replaceAlert( get_http_var('confirmation') );
+            $success = $this->replaceAlert(get_http_var('confirmation'));
             $data['confirmation_received'] = $success;
         } elseif (get_http_var('confirmed')) {
-            $success = $this->confirmAlert( get_http_var('confirmed') );
+            $success = $this->confirmAlert(get_http_var('confirmed'));
             $data['confirmation_received'] = $success;
         } else {
             $data['email'] = $this->user->email() ? $this->user->email() : '';
             $data['postcode'] = $this->user->postcode_is_set() ? $this->user->postcode() : '';
 
-            if ( $this->isEmailSignedUpForPostCode( $data['email'], $data['postcode'] ) ) {
+            if ($this->isEmailSignedUpForPostCode($data['email'], $data['postcode'])) {
                 $data['already_signed_up'] = True;
                 $mp = $this->getPersonFromPostcode($data['postcode']);
                 $data['mp_name'] = $mp->full_name();
@@ -66,13 +66,13 @@ 
     }
 
     private function createAlertForPostCode($email, $postcode) {
-        if ( !$this->validateDetails($email, $postcode) ) {
+        if (!$this->validateDetails($email, $postcode)) {
             return array('invalid-postcode-or-email' => True);
         }
 
         try {
             $person = $this->getPersonFromPostcode($postcode);
-        } catch ( \MySociety\TheyWorkForYou\MemberException $e ) {
+        } catch (\MySociety\TheyWorkForYou\MemberException $e) {
             return array('bad-constituency' => True);
         }
 
@@ -80,7 +80,7 @@ 
             'email' => $email,
             'pid' => $person->person_id,
             'pc' => $postcode,
-            'confirm_base' => 'https://' . DOMAIN . '/alert/by-postcode?confirmed=',
+            'confirm_base' => 'https://'.DOMAIN.'/alert/by-postcode?confirmed=',
         );
 
         $data = array();
@@ -89,7 +89,7 @@ 
 
         switch ($result) {
             case self::ALERT_EXISTS:
-                if ( $not_logged_in ) {
+                if ($not_logged_in) {
                     // no logged in user so send them an email to let them
                     // know someone tried to create an alert
                     $this->alert->send_already_signedup_email($details);
@@ -102,7 +102,7 @@ 
                 $data['error'] = True;
                 break;
             default: // alert created
-                if ( $not_logged_in ) {
+                if ($not_logged_in) {
                     $data['confirmation_sent'] = True;
                 } else {
                     $data['signedup_no_confirm'] = True;
@@ -116,8 +116,8 @@ 
         $existing = $this->alert->fetch_by_token($confirmation);
         preg_match('/speaker:(\d+)/', $existing['criteria'], $matches);
         $old_mp_id = $matches[1];
-        $old_mp = new \MySociety\TheyWorkForYou\Member(array( 'person_id' => $old_mp_id ) );
-        $new_mp = new \MySociety\TheyWorkForYou\Member(array( 'constituency' => $old_mp->constituency, 'house' => 1 ));
+        $old_mp = new \MySociety\TheyWorkForYou\Member(array('person_id' => $old_mp_id));
+        $new_mp = new \MySociety\TheyWorkForYou\Member(array('constituency' => $old_mp->constituency, 'house' => 1));
 
         $q = $this->db->query(
             "SELECT alert_id, criteria, registrationtoken FROM alerts
@@ -127,11 +127,11 @@ 
              AND deleted = 0",
             array(
                 ':email' => $existing['email'],
-                ':criteria' => '%speaker:' . $old_mp_id . '%'
+                ':criteria' => '%speaker:'.$old_mp_id.'%'
             )
         );
 
-        for ( $i = 0; $i < $q->rows; $i++ ) {
+        for ($i = 0; $i < $q->rows; $i++) {
             // need to reset this otherwise delete does not work
             $this->alert->token_checked = null;
             $other_criteria = trim(preg_replace('/speaker:\d+/', '', $q->field($i, 'criteria')));
@@ -141,11 +141,11 @@ 
                 'pid' => $new_mp->person_id,
                 'pc' => '',
             );
-            if ( $other_criteria ) {
+            if ($other_criteria) {
                 $details['keyword'] = $other_criteria;
             }
 
-            $this->alert->delete($q->field($i, 'alert_id') . '::' . $q->field($i ,'registrationtoken'));
+            $this->alert->delete($q->field($i, 'alert_id').'::'.$q->field($i, 'registrationtoken'));
             $this->alert->add($details, False);
         }
 
@@ -158,11 +158,11 @@ 
     private function isEmailSignedUpForPostCode($email, $postcode) {
         $is_signed_up = false;
 
-        if ( $email && $postcode ) {
+        if ($email && $postcode) {
             try {
                 $person = $this->getPersonFromPostcode($postcode);
                 $is_signed_up = $this->alert->fetch_by_mp($email, $person->person_id);
-            } catch ( \MySociety\TheyWorkForYou\MemberException $e ) {
+            } catch (\MySociety\TheyWorkForYou\MemberException $e) {
                 $is_signed_up = false;
             }
         }
@@ -178,10 +178,10 @@ 
         preg_match('/speaker:(\d+)/', $existing['criteria'], $matches);
         $criteria = $matches[1];
 
-        $old_mp = new \MySociety\TheyWorkForYou\Member(array( 'person_id' => $criteria ) );
-        $new_mp = new \MySociety\TheyWorkForYou\Member(array( 'constituency' => $old_mp->constituency, 'house' => 1 ));
+        $old_mp = new \MySociety\TheyWorkForYou\Member(array('person_id' => $criteria));
+        $new_mp = new \MySociety\TheyWorkForYou\Member(array('constituency' => $old_mp->constituency, 'house' => 1));
 
-        if ( $this->alert->fetch_by_mp( $existing['email'], $new_mp->person_id) ) {
+        if ($this->alert->fetch_by_mp($existing['email'], $new_mp->person_id)) {
             $data = array(
                 'already_signed_up' => True,
                 'old_mp' => $old_mp->full_name(),

Upper-Lower-Casing +12 added lines, -12 removed lines

@@ -32,7 +32,7 @@ 
             $data['postcode'] = $this->user->postcode_is_set() ? $this->user->postcode() : '';
 
             if ( $this->isEmailSignedUpForPostCode( $data['email'], $data['postcode'] ) ) {
-                $data['already_signed_up'] = True;
+                $data['already_signed_up'] = true;
                 $mp = $this->getPersonFromPostcode($data['postcode']);
                 $data['mp_name'] = $mp->full_name();
             }
@@ -67,13 +67,13 @@ 
 
     private function createAlertForPostCode($email, $postcode) {
         if ( !$this->validateDetails($email, $postcode) ) {
-            return array('invalid-postcode-or-email' => True);
+            return array('invalid-postcode-or-email' => true);
         }
 
         try {
             $person = $this->getPersonFromPostcode($postcode);
         } catch ( \MySociety\TheyWorkForYou\MemberException $e ) {
-            return array('bad-constituency' => True);
+            return array('bad-constituency' => true);
         }
 
         $details = array(
@@ -93,19 +93,19 @@ 
                     // no logged in user so send them an email to let them
                     // know someone tried to create an alert
                     $this->alert->send_already_signedup_email($details);
-                    $data['confirmation_sent'] = True;
+                    $data['confirmation_sent'] = true;
                 } else {
-                    $data['already_signed_up'] = True;
+                    $data['already_signed_up'] = true;
                 }
                 break;
             case self::CREATE_FAILED:
-                $data['error'] = True;
+                $data['error'] = true;
                 break;
             default: // alert created
                 if ( $not_logged_in ) {
-                    $data['confirmation_sent'] = True;
+                    $data['confirmation_sent'] = true;
                 } else {
-                    $data['signedup_no_confirm'] = True;
+                    $data['signedup_no_confirm'] = true;
                 }
         }
 
@@ -146,11 +146,11 @@ 
             }
 
             $this->alert->delete($q->field($i, 'alert_id') . '::' . $q->field($i ,'registrationtoken'));
-            $this->alert->add($details, False);
+            $this->alert->add($details, false);
         }
 
         return array(
-            'signedup_no_confirm' => True,
+            'signedup_no_confirm' => true,
             'new_mp' => $new_mp->full_name(),
         );
     }
@@ -183,7 +183,7 @@ 
 
         if ( $this->alert->fetch_by_mp( $existing['email'], $new_mp->person_id) ) {
             $data = array(
-                'already_signed_up' => True,
+                'already_signed_up' => true,
                 'old_mp' => $old_mp->full_name(),
                 'mp_name' => $new_mp->full_name(),
             );
@@ -194,7 +194,7 @@ 
             );
         }
 
-        $data['update'] = True;
+        $data['update'] = true;
         $data['confirmation'] = $confirmation;
 
         return $data;

classes/AlertView/Standard.php

Spacing +34 added lines, -34 removed lines

@@ -3,11 +3,11 @@ 
 namespace MySociety\TheyWorkForYou\AlertView;
 
 include_once '../../../www/includes/easyparliament/init.php';
-include_once INCLUDESPATH . "easyparliament/people.php";
-include_once INCLUDESPATH . "easyparliament/member.php";
-include_once INCLUDESPATH . "easyparliament/searchengine.php";
-include_once INCLUDESPATH . '../../commonlib/phplib/auth.php';
-include_once INCLUDESPATH . '../../commonlib/phplib/crosssell.php';
+include_once INCLUDESPATH."easyparliament/people.php";
+include_once INCLUDESPATH."easyparliament/member.php";
+include_once INCLUDESPATH."easyparliament/searchengine.php";
+include_once INCLUDESPATH.'../../commonlib/phplib/auth.php';
+include_once INCLUDESPATH.'../../commonlib/phplib/crosssell.php';
 
 class Standard extends \MySociety\TheyWorkForYou\AlertView {
     public $data;
@@ -139,7 +139,7 @@ 
 
         $se = new \SEARCHENGINE($text);
         if (!$se->valid) {
-            $errors['alertsearch'] = 'That search appears to be invalid - ' . $se->error . ' - please check and try again.';
+            $errors['alertsearch'] = 'That search appears to be invalid - '.$se->error.' - please check and try again.';
         }
 
         if (strlen($text) > 255) {
@@ -179,7 +179,7 @@ 
                 try {
                     $MEMBER = new \MEMBER(array('constituency'=>$constituency, 'house' => 1));
                     $cons[$constituency] = $MEMBER;
-                } catch ( \MySociety\TheyWorkForYou\MemberException $e ) {
+                } catch (\MySociety\TheyWorkForYou\MemberException $e) {
                     // do nothing
                 }
             }
@@ -199,17 +199,17 @@ 
 
         // If this goes well, the alert will be added to the database and a confirmation email
         // will be sent to them.
-        $success = $this->alert->add( $this->data, $confirm );
+        $success = $this->alert->add($this->data, $confirm);
 
-        if ($success>0 && !$confirm) {
+        if ($success > 0 && !$confirm) {
             $result = 'alert-added';
-        } elseif ($success>0) {
+        } elseif ($success > 0) {
             $result = 'alert-confirmation';
         } elseif ($success == -2) {
             // we need to make sure we know that the person attempting to sign up
             // for the alert has that email address to stop people trying to work
             // out what alerts they are signed up to
-            if ( $this->data['email_verified'] || ( $this->user->loggedin && $this->user->email() == $this->data['email'] ) ) {
+            if ($this->data['email_verified'] || ($this->user->loggedin && $this->user->email() == $this->data['email'])) {
                 $result = 'alert-exists';
             } else {
                 // don't throw an error message as that implies that they have already signed
@@ -234,7 +234,7 @@ 
 
 
     private function formatSearchTerms() {
-        if ( $this->data['alertsearch'] ) {
+        if ($this->data['alertsearch']) {
             $this->data['alertsearch_pretty'] = $this->prettifyCriteria($this->data['alertsearch']);
             $this->data['search_text'] = $this->data['alertsearch'];
         } else {
@@ -244,22 +244,22 @@ 
 
     private function prettifyCriteria($alert_criteria) {
         $text = '';
-        if ( $alert_criteria ) {
+        if ($alert_criteria) {
             $criteria = explode(' ', $alert_criteria);
             $words = array();
             $spokenby = array_values(\MySociety\TheyWorkForYou\Utility\Search::speakerNamesForIDs($alert_criteria));
 
             foreach ($criteria as $c) {
-                if (!preg_match('#^speaker:(\d+)#',$c,$m)) {
+                if (!preg_match('#^speaker:(\d+)#', $c, $m)) {
                     $words[] = $c;
                 }
             }
-            if ( $spokenby && count($words) ) {
-                $text = implode(' or ', $spokenby) . ' mentions [' . implode(' ', $words) . ']';
-            } else if ( count( $words ) ) {
-                $text = '[' . implode(' ', $words) . ']' . ' is mentioned';
-            } else if ( $spokenby ) {
-                $text = implode(' or ', $spokenby) . " speaks";
+            if ($spokenby && count($words)) {
+                $text = implode(' or ', $spokenby).' mentions ['.implode(' ', $words).']';
+            } else if (count($words)) {
+                $text = '['.implode(' ', $words).']'.' is mentioned';
+            } else if ($spokenby) {
+                $text = implode(' or ', $spokenby)." speaks";
             }
 
             return $text;
@@ -293,38 +293,38 @@ 
     }
 
     private function formatSearchMemberData() {
-        if ( isset($this->data['postcode']) ) {
+        if (isset($this->data['postcode'])) {
             try {
                 $postcode = $this->data['postcode'];
 
-                $MEMBER = new \MEMBER( array('postcode' => $postcode) );
+                $MEMBER = new \MEMBER(array('postcode' => $postcode));
                 // move the postcode to the front just to be tidy
-                $tidy_alertsearch = $postcode . " " . trim(str_replace("$postcode", "", $this->data['alertsearch']));
+                $tidy_alertsearch = $postcode." ".trim(str_replace("$postcode", "", $this->data['alertsearch']));
                 $alertsearch_display = str_replace("$postcode ", "", $tidy_alertsearch);
 
-                $this->data['member_alertsearch'] = str_replace("$postcode", "speaker:" . $MEMBER->person_id, $tidy_alertsearch);
+                $this->data['member_alertsearch'] = str_replace("$postcode", "speaker:".$MEMBER->person_id, $tidy_alertsearch);
                 $this->data['member_displaysearch'] = $alertsearch_display;
                 $this->data['member'] = $MEMBER;
 
-                if ( $this->data['scottish_text'] ) {
+                if ($this->data['scottish_text']) {
                     $constituencies = \MySociety\TheyWorkForYou\Utility\Postcode::postcodeToConstituencies($postcode);
-                    if ( isset($constituencies['SPC']) ) {
+                    if (isset($constituencies['SPC'])) {
                         $MEMBER = new \MEMBER(array('constituency' => $constituencies['SPC'], 'house' => 4));
-                        $this->data['scottish_alertsearch'] = str_replace("$postcode", "speaker:" . $MEMBER->person_id, $tidy_alertsearch);
+                        $this->data['scottish_alertsearch'] = str_replace("$postcode", "speaker:".$MEMBER->person_id, $tidy_alertsearch);
                         $this->data['scottish_member'] = $MEMBER;
                     }
                 }
-            } catch ( \MySociety\TheyWorkForYou\MemberException $e ) {
+            } catch (\MySociety\TheyWorkForYou\MemberException $e) {
                 $this->data['member_error'] = 1;
             }
         }
 
-        if ( $this->data['pid'] ) {
-            $MEMBER = new \MEMBER( array('person_id' => $this->data['pid']) );
+        if ($this->data['pid']) {
+            $MEMBER = new \MEMBER(array('person_id' => $this->data['pid']));
             $this->data['pid_member'] = $MEMBER;
         }
 
-        if ( $this->data['keyword'] ) {
+        if ($this->data['keyword']) {
             $this->data['display_keyword'] = $this->prettifyCriteria($this->data['keyword']);
         }
     }
@@ -354,12 +354,12 @@ 
         for ($i = 0; $i < $num_alerts; $i++) {
             $row = $q->row($i);
             $criteria = $this->prettifyCriteria($row['criteria']);
-            $token = $row['alert_id'] . '-' . $row['registrationtoken'];
+            $token = $row['alert_id'].'-'.$row['registrationtoken'];
 
             $status = 'confirmed';
-            if ( !$row['confirmed'] ) {
+            if (!$row['confirmed']) {
                 $status = 'unconfirmed';
-            } elseif ( $row['deleted'] == 2 ) {
+            } elseif ($row['deleted'] == 2) {
                 $status = 'suspended';
             }
 

Braces +3 added lines, -1 removed lines

@@ -127,7 +127,9 @@
         }
 
         $text = $this->data['alertsearch'];
-        if (!$text) $text = $this->data['keyword'];
+        if (!$text) {
+            $text = $this->data['keyword'];
+        }
 
         if ($this->data['submitted'] && !$this->data['pid'] && !$text) {
             $errors['alertsearch'] = 'Please enter what you want to be alerted about';

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 class Standard extends \MySociety\TheyWorkForYou\AlertView {
     public $data;
 
-    public function __construct($THEUSER = NULL) {
+    public function __construct($THEUSER = null) {
         parent::__construct($THEUSER);
         $this->data = array();
     }

classes/Renderer/User.php

Spacing +3 added lines, -3 removed lines

@@ -49,7 +49,7 @@ 
         $edittext   = $menudata['text'];
         $edittitle  = $menudata['title'];
         $EDITURL    = new \URL('userviewself');
-        if ($this->page == 'userviewself' || $this->page == 'useredit' ) {
+        if ($this->page == 'userviewself' || $this->page == 'useredit') {
             $editclass = 'on';
         } else {
             $editclass = '';
@@ -58,7 +58,7 @@ 
         // The 'Log out' link.
         $menudata   = $this->pagedata->page_metadata('userlogout', 'menu');
         $logouttext = $menudata['text'];
-        $logouttitle= $menudata['title'];
+        $logouttitle = $menudata['title'];
 
         $LOGOUTURL  = new \URL('userlogout');
         if ($this->page != 'userlogout') {
@@ -68,7 +68,7 @@ 
             $logoutclass = 'on';
         }
 
-        $username = $this->user->firstname() . ' ' . $this->user->lastname();
+        $username = $this->user->firstname().' '.$this->user->lastname();
 
         $this->data['user_nav_links'][] = array(
             'href'    => $LOGOUTURL->generate(),

classes/Renderer/Footer.php

Spacing +5 added lines, -5 removed lines

@@ -14,7 +14,7 @@ 
 
     public $data;
 
-    private $about_links = array ('help', 'about', 'linktous', 'houserules', 'blog', 'news', 'contact', 'privacy');
+    private $about_links = array('help', 'about', 'linktous', 'houserules', 'blog', 'news', 'contact', 'privacy');
     private $assemblies_links = array('hansard', 'sp_home', 'ni_home', 'wales_home');
     private $international_links = array('newzealand', 'australia', 'ireland', 'mzalendo');
     private $tech_links = array('code', 'api', 'data', 'pombola', 'devmailinglist', 'irc');
@@ -28,10 +28,10 @@ 
     public function __construct() {
         $this->data = array();
 
-        $this->data['about'] = $this->get_menu_links( $this->about_links );
-        $this->data['assemblies'] = $this->get_menu_links( $this->assemblies_links );
-        $this->data['international'] = $this->get_menu_links( $this->international_links );
-        $this->data['tech'] = $this->get_menu_links( $this->tech_links );
+        $this->data['about'] = $this->get_menu_links($this->about_links);
+        $this->data['assemblies'] = $this->get_menu_links($this->assemblies_links);
+        $this->data['international'] = $this->get_menu_links($this->international_links);
+        $this->data['tech'] = $this->get_menu_links($this->tech_links);
     }
 
     /**

classes/Model/Banner.php

Spacing +4 added lines, -4 removed lines

@@ -28,12 +28,12 @@ 
     public function get_text() {
         $text = $this->mem->get('banner');
 
-        if ( $text === false ) {
+        if ($text === false) {
             $q = $this->db->query("SELECT value FROM editorial WHERE item = 'banner'");
 
             if ($q->rows) {
                 $text = $q->field(0, 'value');
-                if ( trim($text) == '' ) {
+                if (trim($text) == '') {
                     $text = NULL;
                 }
                 $this->mem->set('banner', $text, 86400);
@@ -50,8 +50,8 @@ 
             )
         );
 
-        if ( $q->success() ) {
-            if ( trim($text) == '' ) {
+        if ($q->success()) {
+            if (trim($text) == '') {
                 $text = NULL;
             }
             $this->mem->set('banner', $text, 86400);

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
             if ($q->rows) {
                 $text = $q->field(0, 'value');
                 if ( trim($text) == '' ) {
-                    $text = NULL;
+                    $text = null;
                 }
                 $this->mem->set('banner', $text, 86400);
             }
@@ -52,7 +52,7 @@ 
 
         if ( $q->success() ) {
             if ( trim($text) == '' ) {
-                $text = NULL;
+                $text = null;
             }
             $this->mem->set('banner', $text, 86400);
             return true;

classes/Divisions.php

Indentation +67 added lines, -67 removed lines

@@ -38,25 +38,25 @@ 
     }
 
     public static function getMostRecentDivisionDate() {
-      $db = new \ParlDB;
-      $q = $db->query(
+        $db = new \ParlDB;
+        $q = $db->query(
         "SELECT policy_id, max(division_date) as recent from policydivisions GROUP BY policy_id"
-      );
+        );
 
-      $policy_maxes = array();
-      $row_count = $q->rows();
-      for ($n = 0; $n < $row_count; $n++) {
+        $policy_maxes = array();
+        $row_count = $q->rows();
+        for ($n = 0; $n < $row_count; $n++) {
         $policy_maxes[$q->field($n, 'policy_id')] = $q->field( $n, 'recent' );
-      }
-      $policy_maxes['latest'] = $policy_maxes ? max(array_values($policy_maxes)) : '';
-      return $policy_maxes;
+        }
+        $policy_maxes['latest'] = $policy_maxes ? max(array_values($policy_maxes)) : '';
+        return $policy_maxes;
     }
 
     public function getRecentDivisions($number = 20) {
         // Grab distinct divisions as sometimes we have the same division for more than one policy
         // and we don't want to display it twice
         $q = $this->db->query(
-          "SELECT distinct division_id, division_title, yes_text, no_text, division_date, division_number, gid, direction, majority_vote,
+            "SELECT distinct division_id, division_title, yes_text, no_text, division_date, division_number, gid, direction, majority_vote,
           yes_total, no_total, absent_total, both_total
           FROM policydivisions ORDER BY division_date DESC, division_number DESC LIMIT :count",
             array(
@@ -94,7 +94,7 @@ 
         $divisions = array();
         $row_count = $q->rows();
         for ($n = 0; $n < $row_count; $n++) {
-          $divisions[] = $this->getParliamentDivisionDetails($q->row($n));
+            $divisions[] = $this->getParliamentDivisionDetails($q->row($n));
         }
 
         return $divisions;
@@ -148,44 +148,44 @@ 
 
         $row_count = $q->rows();
         for ($n = 0; $n < $row_count; $n++) {
-          $policy_id = $q->field($n, 'policy_id');
+            $policy_id = $q->field($n, 'policy_id');
 
-          if (!array_key_exists($policy_id, $policy_divisions)) {
+            if (!array_key_exists($policy_id, $policy_divisions)) {
             $summary = array(
-              'max' => $q->field($n, 'latest'),
-              'min' => $q->field($n, 'earliest'),
-              'total' => $q->field($n, 'total'),
-              'for' => 0, 'against' => 0, 'absent' => 0, 'both' => 0, 'tell' => 0
+                'max' => $q->field($n, 'latest'),
+                'min' => $q->field($n, 'earliest'),
+                'total' => $q->field($n, 'total'),
+                'for' => 0, 'against' => 0, 'absent' => 0, 'both' => 0, 'tell' => 0
             );
 
             $policy_divisions[$policy_id] = $summary;
-          }
-
-          $summary = $policy_divisions[$policy_id];
-
-          $summary['total'] += $q->field($n, 'total');
-          if ($summary['max'] < $q->field($n, 'latest')) {
-              $summary['max'] = $q->field($n, 'latest');
-          }
-          if ($summary['min'] > $q->field($n, 'latest')) {
-              $summary['min'] = $q->field($n, 'latest');
-          }
-
-          $vote = $q->field($n, 'vote');
-          $policy_vote = str_replace('3', '', $q->field($n, 'policy_vote'));
-          if ( $vote == 'absent' ) {
-              $summary['absent'] += $q->field($n, 'total');
-          } else if ( $vote == 'both' ) {
-              $summary['both'] += $q->field($n, 'total');
-          } else if ( strpos($vote, 'tell') !== FALSE ) {
-              $summary['tell'] += $q->field($n, 'total');
-          } else if ( $policy_vote == $vote ) {
-              $summary['for'] += $q->field($n, 'total');
-          } else if ( $policy_vote != $vote ) {
-              $summary['against'] += $q->field($n, 'total');
-          }
-
-          $policy_divisions[$policy_id] = $summary;
+            }
+
+            $summary = $policy_divisions[$policy_id];
+
+            $summary['total'] += $q->field($n, 'total');
+            if ($summary['max'] < $q->field($n, 'latest')) {
+                $summary['max'] = $q->field($n, 'latest');
+            }
+            if ($summary['min'] > $q->field($n, 'latest')) {
+                $summary['min'] = $q->field($n, 'latest');
+            }
+
+            $vote = $q->field($n, 'vote');
+            $policy_vote = str_replace('3', '', $q->field($n, 'policy_vote'));
+            if ( $vote == 'absent' ) {
+                $summary['absent'] += $q->field($n, 'total');
+            } else if ( $vote == 'both' ) {
+                $summary['both'] += $q->field($n, 'total');
+            } else if ( strpos($vote, 'tell') !== FALSE ) {
+                $summary['tell'] += $q->field($n, 'total');
+            } else if ( $policy_vote == $vote ) {
+                $summary['for'] += $q->field($n, 'total');
+            } else if ( $policy_vote != $vote ) {
+                $summary['against'] += $q->field($n, 'total');
+            }
+
+            $policy_divisions[$policy_id] = $summary;
         }
 
         return $policy_divisions;
@@ -219,17 +219,17 @@ 
         );
 
         $votes = array(
-          'yes_votes' => array(),
-          'no_votes' => array(),
-          'absent_votes' => array(),
-          'both_votes' => array()
+            'yes_votes' => array(),
+            'no_votes' => array(),
+            'absent_votes' => array(),
+            'both_votes' => array()
         );
 
         foreach ($q->data as $vote) {
             $detail = array(
-              'person_id' => $vote['person_id'],
-              'name' => $vote['given_name'] . ' ' . $vote['family_name'],
-              'teller' => false
+                'person_id' => $vote['person_id'],
+                'name' => $vote['given_name'] . ' ' . $vote['family_name'],
+                'teller' => false
             );
 
             if (strpos($vote['vote'], 'tell') !== FALSE) {
@@ -237,13 +237,13 @@ 
             }
 
             if ($vote['vote'] == 'aye' or $vote['vote'] == 'tellaye') {
-              $votes['yes_votes'][] = $detail;
+                $votes['yes_votes'][] = $detail;
             } else if ($vote['vote'] == 'no' or $vote['vote'] == 'tellno') {
-              $votes['no_votes'][] = $detail;
+                $votes['no_votes'][] = $detail;
             } else if ($vote['vote'] == 'absent') {
-              $votes['absent_votes'][] = $detail;
+                $votes['absent_votes'][] = $detail;
             } else if ($vote['vote'] == 'both') {
-              $votes['both_votes'][] = $detail;
+                $votes['both_votes'][] = $detail;
             }
 
         }
@@ -338,11 +338,11 @@ 
         $divisions = array();
         $row_count = $q->rows();
         for ($n = 0; $n < $row_count; $n++) {
-          if ($context == 'Parliament') {
-              $divisions[] = $this->getParliamentDivisionDetails($q->row($n));
-          } else {
-              $divisions[] = $this->getDivisionDetails($q->row($n));
-          }
+            if ($context == 'Parliament') {
+                $divisions[] = $this->getParliamentDivisionDetails($q->row($n));
+            } else {
+                $divisions[] = $this->getDivisionDetails($q->row($n));
+            }
         }
 
         return $divisions;
@@ -444,13 +444,13 @@ 
 
         $division['mp_vote'] = '';
         if (array_key_exists('vote', $row)) {
-          $mp_vote = ' was absent';
-          if ($row['vote'] == 'aye') {
-              $mp_vote = 'voted in favour';
-          } else if ($row['vote'] == 'no') {
-              $mp_vote = 'voted against';
-          }
-          $division['mp_vote'] = $mp_vote;
+            $mp_vote = ' was absent';
+            if ($row['vote'] == 'aye') {
+                $mp_vote = 'voted in favour';
+            } else if ($row['vote'] == 'no') {
+                $mp_vote = 'voted against';
+            }
+            $division['mp_vote'] = $mp_vote;
         }
         $division['division_title'] = $row['division_title'];
         $division['vote'] = $vote;

Spacing +29 added lines, -29 removed lines

@@ -46,7 +46,7 @@ 
       $policy_maxes = array();
       $row_count = $q->rows();
       for ($n = 0; $n < $row_count; $n++) {
-        $policy_maxes[$q->field($n, 'policy_id')] = $q->field( $n, 'recent' );
+        $policy_maxes[$q->field($n, 'policy_id')] = $q->field($n, 'recent');
       }
       $policy_maxes['latest'] = $policy_maxes ? max(array_values($policy_maxes)) : '';
       return $policy_maxes;
@@ -117,7 +117,7 @@ 
     public function getMemberDivisionsForPolicy($policyID = null) {
         $where_extra = '';
         $args = array(':person_id' => $this->member->person_id);
-        if ( $policyID ) {
+        if ($policyID) {
             $where_extra = 'AND policy_id = :policy_id';
             $args[':policy_id'] = $policyID;
         }
@@ -173,15 +173,15 @@ 
 
           $vote = $q->field($n, 'vote');
           $policy_vote = str_replace('3', '', $q->field($n, 'policy_vote'));
-          if ( $vote == 'absent' ) {
+          if ($vote == 'absent') {
               $summary['absent'] += $q->field($n, 'total');
-          } else if ( $vote == 'both' ) {
+          } else if ($vote == 'both') {
               $summary['both'] += $q->field($n, 'total');
-          } else if ( strpos($vote, 'tell') !== FALSE ) {
+          } else if (strpos($vote, 'tell') !== FALSE) {
               $summary['tell'] += $q->field($n, 'total');
-          } else if ( $policy_vote == $vote ) {
+          } else if ($policy_vote == $vote) {
               $summary['for'] += $q->field($n, 'total');
-          } else if ( $policy_vote != $vote ) {
+          } else if ($policy_vote != $vote) {
               $summary['against'] += $q->field($n, 'total');
           }
 
@@ -228,7 +228,7 @@ 
         foreach ($q->data as $vote) {
             $detail = array(
               'person_id' => $vote['person_id'],
-              'name' => $vote['given_name'] . ' ' . $vote['family_name'],
+              'name' => $vote['given_name'].' '.$vote['family_name'],
               'teller' => false
             );
 
@@ -280,20 +280,20 @@ 
         $min = $votes['min'];
 
         $actions = array(
-            $votes['for'] . ' ' . make_plural('vote', $votes['for']) . ' for',
-            $votes['against'] . ' ' . make_plural('vote', $votes['against']) . ' against'
+            $votes['for'].' '.make_plural('vote', $votes['for']).' for',
+            $votes['against'].' '.make_plural('vote', $votes['against']).' against'
         );
 
-        if ( $votes['both'] ) {
-            $actions[] = $votes['both'] . ' ' . make_plural('abstention', $votes['both']);
+        if ($votes['both']) {
+            $actions[] = $votes['both'].' '.make_plural('abstention', $votes['both']);
         }
-        if ( $votes['absent'] ) {
-            $actions[] = $votes['absent'] . ' ' . make_plural('absence', $votes['absent']);
+        if ($votes['absent']) {
+            $actions[] = $votes['absent'].' '.make_plural('absence', $votes['absent']);
         }
         if ($max == $min) {
-            return join(', ', $actions) . ', in ' . $max;
+            return join(', ', $actions).', in '.$max;
         } else {
-            return join(', ', $actions) . ', between ' . $min . '&ndash;' . $max;
+            return join(', ', $actions).', between '.$min.'&ndash;'.$max;
         }
     }
 
@@ -351,7 +351,7 @@ 
 
     private function constructYesNoVoteDescription($direction, $title, $short_text) {
         $text = ' voted ';
-        if ( $short_text ) {
+        if ($short_text) {
             $text .= $short_text;
         } else {
             $text .= "$direction on <em>$title</em>";
@@ -369,7 +369,7 @@ 
          * votes so we need to generate some text using the title of the division
          */
 
-        switch ( strtolower($vote) ) {
+        switch (strtolower($vote)) {
             case 'yes':
             case 'aye':
                 $description = $this->constructYesNoVoteDescription('yes', $division_title, $yes_text);
@@ -378,15 +378,15 @@ 
                 $description = $this->constructYesNoVoteDescription('no', $division_title, $no_text);
                 break;
             case 'absent':
-                $description = ' was absent for a vote on <em>' . $division_title . '</em>';
+                $description = ' was absent for a vote on <em>'.$division_title.'</em>';
                 break;
             case 'both':
-                $description = ' abstained on a vote on <em>' . $division_title . '</em>';
+                $description = ' abstained on a vote on <em>'.$division_title.'</em>';
                 break;
             case 'tellyes':
             case 'tellno':
             case 'tellaye':
-                $description = ' acted as teller for a vote on <em>' . $division_title . '</em>';
+                $description = ' acted as teller for a vote on <em>'.$division_title.'</em>';
                 break;
             default:
                 $description = $division_title;
@@ -399,7 +399,7 @@ 
         $division = array();
 
         $direction = $row['direction'];
-        if ( strpos( $direction, 'strong') !== FALSE ) {
+        if (strpos($direction, 'strong') !== FALSE) {
             $division['strong'] = TRUE;
         } else {
             $division['strong'] = FALSE;
@@ -455,7 +455,7 @@ 
         $division['division_title'] = $row['division_title'];
         $division['vote'] = $vote;
 
-        $division['summary'] = $row['yes_total'] . ' for, ' . $row['no_total'] . ' against, ' . $row['absent_total'] . ' absent';
+        $division['summary'] = $row['yes_total'].' for, '.$row['no_total'].' against, '.$row['absent_total'].' absent';
         $division['for'] = $row['yes_total'];
         $division['against'] = $row['no_total'];
         $division['both'] = $row['both_total'];
@@ -471,24 +471,24 @@ 
         for ($n = 0; $n < $row_count; $n++) {
             $policy_id = $q->field($n, 'policy_id');
 
-            if ( !array_key_exists($policy_id, $policies) ) {
+            if (!array_key_exists($policy_id, $policies)) {
                 $policies[$policy_id] = array(
                     'policy_id' => $policy_id,
                     'weak_count' => 0,
                     'divisions' => array()
                 );
-                if ( $this->policies ) {
+                if ($this->policies) {
                     $policies[$policy_id]['desc'] = $this->policies->getPolicies()[$policy_id];
                     $policies[$policy_id]['header'] = $this->policies->getPolicyDetails($policy_id);
                 }
-                if ( $this->positions ) {
+                if ($this->positions) {
                     $policies[$policy_id]['position'] = $this->positions->positionsById[$policy_id];
                 }
             }
 
             $division = $this->getDivisionDetails($q->row($n));
 
-            if ( !$division['strong'] ) {
+            if (!$division['strong']) {
                 $policies[$policy_id]['weak_count']++;
             }
 
@@ -503,9 +503,9 @@ 
 
         $gid = get_canonical_gid($gid);
 
-        $q = $this->db->query("SELECT gid, major FROM hansard WHERE epobject_id = ( SELECT subsection_id FROM hansard WHERE gid = :gid )", array( ':gid' => $gid ));
+        $q = $this->db->query("SELECT gid, major FROM hansard WHERE epobject_id = ( SELECT subsection_id FROM hansard WHERE gid = :gid )", array(':gid' => $gid));
         $parent_gid = $q->field(0, 'gid');
-        if ( !$parent_gid ) {
+        if (!$parent_gid) {
             return '';
         }
         $parent_gid = fix_gid_from_db($parent_gid);

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -29,7 +29,7 @@ 
      * @param Member   $member   The member to get positions for.
      */
 
-    public function __construct(Member $member = NULL, PolicyPositions $positions = NULL, Policies $policies = NULL)
+    public function __construct(Member $member = null, PolicyPositions $positions = null, Policies $policies = null)
     {
         $this->member = $member;
         $this->positions = $positions;
@@ -177,7 +177,7 @@ 
               $summary['absent'] += $q->field($n, 'total');
           } else if ( $vote == 'both' ) {
               $summary['both'] += $q->field($n, 'total');
-          } else if ( strpos($vote, 'tell') !== FALSE ) {
+          } else if ( strpos($vote, 'tell') !== false ) {
               $summary['tell'] += $q->field($n, 'total');
           } else if ( $policy_vote == $vote ) {
               $summary['for'] += $q->field($n, 'total');
@@ -232,7 +232,7 @@ 
               'teller' => false
             );
 
-            if (strpos($vote['vote'], 'tell') !== FALSE) {
+            if (strpos($vote['vote'], 'tell') !== false) {
                 $detail['teller'] = true;
             }
 
@@ -399,10 +399,10 @@ 
         $division = array();
 
         $direction = $row['direction'];
-        if ( strpos( $direction, 'strong') !== FALSE ) {
-            $division['strong'] = TRUE;
+        if ( strpos( $direction, 'strong') !== false ) {
+            $division['strong'] = true;
         } else {
-            $division['strong'] = FALSE;
+            $division['strong'] = false;
         }
 
         $division['division_id'] = $row['division_id'];

classes/Party.php

Spacing +25 added lines, -25 removed lines

@@ -20,7 +20,7 @@ 
     public function __construct($name) {
         // treat Labour and Labour/Co-operative the same as that's how
         // people view them and it'll confuse the results otherwise
-        if ( $name == 'Labour/Co-operative' ) {
+        if ($name == 'Labour/Co-operative') {
             $name = 'Labour';
         }
         $this->name = $name;
@@ -42,7 +42,7 @@ 
                 ':date' => date('Y-m-d'),
             )
         );
-        if ( $member_count->rows ) {
+        if ($member_count->rows) {
             $num_members = $member_count->field(0, 'num_members');
             return $num_members;
         } else {
@@ -70,12 +70,12 @@ 
             )
         );
 
-        if ( $position->rows ) {
+        if ($position->rows) {
             $score = $position->field(0, 'score');
             $score_desc = score_to_strongly($score);
 
-            if ( $want_score ) {
-                return array( $score_desc, $score);
+            if ($want_score) {
+                return array($score_desc, $score);
             } else {
                 return $score_desc;
             }
@@ -114,7 +114,7 @@ 
             ':party' => $this->name
         );
 
-        if ( $this->name == 'Labour' ) {
+        if ($this->name == 'Labour') {
             $party_where = '( party = :party OR party = :party2 )';
             $params = array(
                 ':party' => $this->name,
@@ -122,7 +122,7 @@ 
             );
         }
 
-        for ( $i = 0; $i < $num_divs; $i++ ) {
+        for ($i = 0; $i < $num_divs; $i++) {
             $division_id = $divisions->field($i, 'division_id');
             $weights = $this->get_vote_scores($divisions->field($i, 'policy_vote'));
 
@@ -142,42 +142,42 @@ 
             );
 
             $num_votes = 0;
-            for ( $j = 0; $j < $votes->rows(); $j++ ) {
+            for ($j = 0; $j < $votes->rows(); $j++) {
                 $vote_dir = $votes->field($j, 'vote');
-                if ( $vote_dir == '' ) continue;
-                if ( $vote_dir == 'tellno' ) $vote_dir = 'no';
-                if ( $vote_dir == 'tellaye' ) $vote_dir = 'aye';
+                if ($vote_dir == '') continue;
+                if ($vote_dir == 'tellno') $vote_dir = 'no';
+                if ($vote_dir == 'tellaye') $vote_dir = 'aye';
 
                 $num_votes += $votes->field($j, 'num_votes');
                 $score += ($votes->field($j, 'num_votes') * $weights[$vote_dir]);
             }
 
             $total_votes += $num_votes;
-            $max_score += $num_votes * max( array_values( $weights ) );
+            $max_score += $num_votes * max(array_values($weights));
         }
 
-        if ( $total_votes == 0 ) {
+        if ($total_votes == 0) {
             return null;
         }
 
         // this implies that all the divisions in the policy have a policy
         // position of absent so we set weight to -1 to indicate we can't
         // really say what the parties position is.
-        if ( $max_score == 0 ) {
+        if ($max_score == 0) {
             $weight = -1;
         } else {
-            $weight = 1 - ( $score/$max_score );
+            $weight = 1 - ($score / $max_score);
         }
         $score_desc = score_to_strongly($weight);
 
-        if ( $want_score ) {
-            return array( $score_desc, $weight);
+        if ($want_score) {
+            return array($score_desc, $weight);
         } else {
             return $score_desc;
         }
     }
 
-    public function cache_position( $position ) {
+    public function cache_position($position) {
         $this->db->query(
             "REPLACE INTO partypolicy
                 (party, house, policy_id, score)
@@ -197,9 +197,9 @@ 
             return $positions;
         }
 
-        foreach ( $policies->getPolicies() as $policy_id => $policy_text ) {
-            list( $position, $score ) = $this->$method($policy_id, true);
-            if ( $position === null ) {
+        foreach ($policies->getPolicies() as $policy_id => $policy_text) {
+            list($position, $score) = $this->$method($policy_id, true);
+            if ($position === null) {
                 continue;
             }
 
@@ -219,7 +219,7 @@ 
         $both = 1;
         $agree = 10;
 
-        if ( stripos($vote, '3') !== FALSE ) {
+        if (stripos($vote, '3') !== FALSE) {
             $agree = 50;
             $absent = 25;
             $both = 25;
@@ -230,10 +230,10 @@ 
             'both' => $both
         );
 
-        if ( stripos($vote, 'aye') !== FALSE ) {
+        if (stripos($vote, 'aye') !== FALSE) {
             $scores['aye'] = $agree;
             $scores['no'] = 0;
-        } else if ( stripos($vote, 'no') !== FALSE ) {
+        } else if (stripos($vote, 'no') !== FALSE) {
             $scores['no'] = $agree;
             $scores['aye'] = 0;
         } else {
@@ -256,7 +256,7 @@ 
         $parties = array();
         $party_count = $party_list->rows;
 
-        for ( $i = 0; $i < $party_count; $i++ ) {
+        for ($i = 0; $i < $party_count; $i++) {
             $party = $party_list->field($i, 'party');
             if (
                 !$party

Braces +9 added lines, -3 removed lines

@@ -144,9 +144,15 @@
             $num_votes = 0;
             for ( $j = 0; $j < $votes->rows(); $j++ ) {
                 $vote_dir = $votes->field($j, 'vote');
-                if ( $vote_dir == '' ) continue;
-                if ( $vote_dir == 'tellno' ) $vote_dir = 'no';
-                if ( $vote_dir == 'tellaye' ) $vote_dir = 'aye';
+                if ( $vote_dir == '' ) {
+                    continue;
+                }
+                if ( $vote_dir == 'tellno' ) {
+                    $vote_dir = 'no';
+                }
+                if ( $vote_dir == 'tellaye' ) {
+                    $vote_dir = 'aye';
+                }
 
                 $num_votes += $votes->field($j, 'num_votes');
                 $score += ($votes->field($j, 'num_votes') * $weights[$vote_dir]);

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -219,7 +219,7 @@ 
         $both = 1;
         $agree = 10;
 
-        if ( stripos($vote, '3') !== FALSE ) {
+        if ( stripos($vote, '3') !== false ) {
             $agree = 50;
             $absent = 25;
             $both = 25;
@@ -230,10 +230,10 @@ 
             'both' => $both
         );
 
-        if ( stripos($vote, 'aye') !== FALSE ) {
+        if ( stripos($vote, 'aye') !== false ) {
             $scores['aye'] = $agree;
             $scores['no'] = 0;
-        } else if ( stripos($vote, 'no') !== FALSE ) {
+        } else if ( stripos($vote, 'no') !== false ) {
             $scores['no'] = $agree;
             $scores['aye'] = 0;
         } else {