AtoZView::display() - Code Metrics - Inspection of "Re-introduce glossary additions for superusers" - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1932)

by Struan

created 2025-10-07 13:44 UTC

AtoZView::display() A

↳ Parent: AtoZView

Complexity

Conditions	4
Paths	4

Size

Total Lines	25
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	15
c	1
b	0
f	0
nc	4
nop	0
dl	0
loc	25
rs	9.7666

<?php

namespace MySociety\TheyWorkForYou\GlossaryView;

class AtoZView extends BaseView {
    public function display(): array {
        $data = [
            'template_name' => 'atoz',
            'this_page' => 'glossary',
        ];


        $az = 'A';
        if ((get_http_var('az') != '') && is_string(get_http_var('az'))) {
            $az = strtoupper(substr(get_http_var('az'), 0, 1));
        }

        $data['letter'] = $az;

        if ($this->has_edit_access()) {
            $url = new \MySociety\TheyWorkForYou\Url('glossary_addterm');
            $data['add_url'] = $url->generate('url');
        }

        $glossary = new \GLOSSARY(['sort' => 'regexp_replace']);
        $glossary->current_letter = $az;

        $data['page_title'] = $az . ': Glossary Index';
        $data['glossary'] = $glossary;
        return $data;
    }

    private function get_next_prev($glossary): array {

        $url = new \MySociety\TheyWorkForYou\Url('glossary');
        $url->insert(['gl' => $glossary->previous_term['glossary_id']]);
        $previous_link = $url->generate('url');
        $url->insert(['gl' => $glossary->next_term['glossary_id']]);
        $next_link = $url->generate('url');

        $nextprev =  [
            'next'	=>  [
                'url'	=> $next_link,
                'title'	=> 'Next term',
                'body'	=> $glossary->next_term['title'],
            ],
            'prev'	=>  [
                'url'	=> $previous_link,
                'title'	=> 'Previous term',
                'body'	=> $glossary->previous_term['title'],
            ],
        ];

        return $nextprev;
    }
}


1			<?php
2
3			namespace MySociety\TheyWorkForYou\GlossaryView;
4
5			class AtoZView extends BaseView {
6			public function display(): array {
7			$data = [
8			'template_name' => 'atoz',
9			'this_page' => 'glossary',
10			];
11
12
13			$az = 'A';
14			if ((get_http_var('az') != '') && is_string(get_http_var('az'))) {
15			$az = strtoupper(substr(get_http_var('az'), 0, 1));
16			}
17
18			$data['letter'] = $az;
19
20			if ($this->has_edit_access()) {
21			$url = new \MySociety\TheyWorkForYou\Url('glossary_addterm');
22			$data['add_url'] = $url->generate('url');
23			}
24
25			$glossary = new \GLOSSARY(['sort' => 'regexp_replace']);
26			$glossary->current_letter = $az;
27
28			$data['page_title'] = $az . ': Glossary Index';
29			$data['glossary'] = $glossary;
30			return $data;
31			}
32
33			private function get_next_prev($glossary): array {
			0 ignored issues – show Unused Code introduced 2025-10-07 13:27 UTC by Report Bug Copy Issue Report The method `get_next_prev()` is not used, and could be removed. This check looks for private methods that have been defined, but are not used inside the class. Loading history...
34			$url = new \MySociety\TheyWorkForYou\Url('glossary');
35			$url->insert(['gl' => $glossary->previous_term['glossary_id']]);
36			$previous_link = $url->generate('url');
37			$url->insert(['gl' => $glossary->next_term['glossary_id']]);
38			$next_link = $url->generate('url');
39
40			$nextprev = [
41			'next' => [
42			'url' => $next_link,
43			'title' => 'Next term',
44			'body' => $glossary->next_term['title'],
45			],
46			'prev' => [
47			'url' => $previous_link,
48			'title' => 'Previous term',
49			'body' => $glossary->previous_term['title'],
50			],
51			];
52
53			return $nextprev;
54			}
55			}
56

mysociety / theyworkforyou

Pull Request — master (#1932)

AtoZView::display() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like