mysociety / theyworkforyou

www/includes/easyparliament/member.php

Spacing +3 added lines, -3 removed lines

@@ -86,7 +86,7 @@ 
 
         # All the following only happen if the house to display isn't yet set.
         # TODO: This relies on interpreting the default value of 0 as a false, which may be error-prone.
-        if (! (bool) $this->house_disp) {
+        if (!(bool) $this->house_disp) {
             if ($house == HOUSE_TYPE_LONDON_ASSEMBLY # London Assembly
                 || $house == HOUSE_TYPE_SCOTLAND     # MSPs and
                 || $house == HOUSE_TYPE_WALES        # MSs and
@@ -251,7 +251,7 @@ 
             $policiesList = new Policies($policyID);
         }
         $rel_agreements = $policiesList->all_policy_agreements[$policyID] ?? [];
-        $rel_agreements = array_filter($rel_agreements, function ($agreement) use ($house) {
+        $rel_agreements = array_filter($rel_agreements, function($agreement) use ($house) {
             return $this->date_in_memberships($house, $agreement['date']);
         });
         return $rel_agreements;
@@ -526,7 +526,7 @@ 
         }
 
         if ($display && array_key_exists('register_member_interests_html', $this->extra_info) && ($this->extra_info['register_member_interests_html'] != '')) {
-            $args =  [
+            $args = [
                 "sort" => "regexp_replace",
             ];
             $GLOSSARY = new GLOSSARY($args);

www/includes/easyparliament/glossary.php

Spacing +6 added lines, -6 removed lines

@@ -24,12 +24,12 @@ 
 include_once INCLUDESPATH . "easyparliament/searchengine.php";
 
 class GLOSSARY {
-    public $num_terms;			// how many glossary entries do we have
+    public $num_terms; // how many glossary entries do we have
     // (changes depending on how GLOSSARY is called
-    public $hansard_count;		// how many times does the phrase appear in hansard?
-    public $query;				// search term
-    public $glossary_id;		// if this is set then we only have 1 glossary term
-    public $current_term;		// will only be set if we have a valid epobject_id
+    public $hansard_count; // how many times does the phrase appear in hansard?
+    public $query; // search term
+    public $glossary_id; // if this is set then we only have 1 glossary term
+    public $current_term; // will only be set if we have a valid epobject_id
     public $current_letter;
 
     // constructor...
@@ -72,7 +72,7 @@ 
 
         // These stop stupid submissions.
         // everything should be lowercase.
-        $this->stopwords = [ "the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate" ];
+        $this->stopwords = ["the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate"];
 
     }
 

www/includes/dbtypes.php

Spacing +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
 ];
 $hansardmajors[104] = $hansardmajors[4];
 
-$parties =  [
+$parties = [
     'Bp'    => 'Bishop',
     'Con'   => 'Conservative',
     'CWM'   => 'Deputy Speaker',

tests/SectionTest.php

Spacing +8 added lines, -8 removed lines

@@ -16,14 +16,14 @@ 
 
     public function testDebatesFront() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type ]);
+            $page = $this->fetch_page(['type' => $type]);
             $this->assertStringContainsString($type, $page);
         }
     }
 
     public function testDebatesYear() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type, 'y' => '2014' ]);
+            $page = $this->fetch_page(['type' => $type, 'y' => '2014']);
             $this->assertStringContainsString('<div class="calendar">', $page);
             $this->assertStringContainsString('January', $page);
             $this->assertMatchesRegularExpression('/<td colspan="2">&nbsp;<\/td><td[^>]*><a href="\/' . $type . '\/\?d=2014-01-01">1<\/a><\/td><td[^>]*><span>2<\/span><\/td>/', $page);
@@ -32,7 +32,7 @@ 
 
     public function testDebatesDay() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type, 'd' => '2014-01-01' ]);
+            $page = $this->fetch_page(['type' => $type, 'd' => '2014-01-01']);
             $this->assertStringContainsString('Wednesday,  1 January 2014', $page);
             $this->assertStringContainsString('HeadingA', $page);
             if ($type == 'wrans') {
@@ -57,7 +57,7 @@ 
                 continue;
             }
 
-            $page = $this->fetch_page([ 'type' => $type, 'id' => '2014-01-01b.1.1' ]);
+            $page = $this->fetch_page(['type' => $type, 'id' => '2014-01-01b.1.1']);
             if ($type == 'wrans') {
                 $this->assertMatchesRegularExpression("#All .*?written answers on  1 Jan 2014#i", $page);
                 $this->assertStringContainsString("QuestionA", $page);
@@ -69,7 +69,7 @@ 
 
     public function testDebatesSubheading() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type, 'id' => '2014-01-01b.1.2' ]);
+            $page = $this->fetch_page(['type' => $type, 'id' => '2014-01-01b.1.2']);
             $this->assertStringContainsString("HeadingA", $page);
             if ($type == 'spwrans') {
                 $this->assertStringContainsString("QuestionA", $page);
@@ -99,7 +99,7 @@ 
 
     public function testDebatesSpeech() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type, 'id' => '2014-01-01b.1.3' ]);
+            $page = $this->fetch_page(['type' => $type, 'id' => '2014-01-01b.1.3']);
             if ($type == 'wrans' || $type == 'spwrans' || $type == 'wms') {
                 $this->assertMatchesRegularExpression("#Location: .*?/$type/\?id=2014-01-01b\.1\.2#", $page);
             } else {
@@ -124,13 +124,13 @@ 
      * @group xapian
      */
     public function testGlossaryAndSearchHighlights() {
-        $page = $this->fetch_page([ 'type' => 'lords', 's' => 'constituency', 'id' => '2014-02-02b.1.3' ]);
+        $page = $this->fetch_page(['type' => 'lords', 's' => 'constituency', 'id' => '2014-02-02b.1.3']);
         $this->assertStringContainsString("constituency", $page);
         $this->assertStringContainsString("<span class=\"hi\"><a href=\"/glossary/?gl=1\" title=\"In a general election, each Constituency chooses an MP to represent them....\" class=\"glossary\">constituency</a></span>", $page);
     }
 
     public function testGidRedirect() {
-        $page = $this->fetch_page([ 'type' => 'wrans', 'id' => '2014-01-01a.187335.h' ]);
+        $page = $this->fetch_page(['type' => 'wrans', 'id' => '2014-01-01a.187335.h']);
         $this->assertMatchesRegularExpression("#Location: .*?/wrans/\?id=2014-01-01b\.1\.2#", $page);
     }
 }

classes/DataClass/Regmem/Person.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -42,6 +42,6 @@
                 return $category;
             }
         }
-        throw new InvalidArgumentException("Category $categoryId not found in register");
+        throw new InvalidArgumentException("category $categoryId not found in register");
     }
 }

www/includes/easyparliament/templates/html/interests/highlighted_2024.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
                                     <th>MP's comment</th>
                                 </tr>
                     <?php foreach ($register->persons as $person) { ?>
-                        <?php foreach($person->categories as $category) { ?>
+                        <?php foreach ($person->categories as $category) { ?>
                             <?php if ($category->category_id != $category_id) { ?>
                                 <?php continue; ?>
                             <?php }; ?>

www/includes/easyparliament/templates/html/homepage/devolved-list.php

Spacing +3 added lines, -3 removed lines

@@ -1,9 +1,9 @@
 <?php
-$nav_items =  [
+$nav_items = [
     ['hansard', 'alldebatesfront', 'mps', 'peers', 'interests_home', 'wranswmsfront', 'divisions_recent_commons', 'divisions_recent_lords'],
     ['sp_home', 'sp_home', 'spdebatesfront', 'msps', 'interest_category_sp', 'spwransfront', 'divisions_recent_sp'],
-    ['wales_home', 'wales_home', 'wales_debates', 'mss','interest_category_wp', 'welshlanguage', 'divisions_recent_wales'],
-    ['ni_home', 'ni_home', 'nioverview', 'mlas','interest_category_ni'],
+    ['wales_home', 'wales_home', 'wales_debates', 'mss', 'interest_category_wp', 'welshlanguage', 'divisions_recent_wales'],
+    ['ni_home', 'ni_home', 'nioverview', 'mlas', 'interest_category_ni'],
 ];
 
 ?>  

classes/DataClass/Regmem/CategoryList.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 
     public function limitToCategoryIds(array $categoryIds) {
         // Filter the categories to only include those with the given IDs
-        $this->items = array_filter($this->items, function ($category) use ($categoryIds) {
+        $this->items = array_filter($this->items, function($category) use ($categoryIds) {
             return in_array($category->category_id, $categoryIds);
         });
     }

classes/Renderer/Header.php

Spacing +3 added lines, -3 removed lines

@@ -169,7 +169,7 @@ 
 
         if ($nextprev) {
             // Four different kinds of back/forth links we might build.
-            $links =  ["first", "prev", "up", "next", "last"];
+            $links = ["first", "prev", "up", "next", "last"];
 
             foreach ($links as $type) {
                 if ($link = $this->generate_next_prev_link($nextprev, $type)) {
@@ -307,9 +307,9 @@ 
         // Page names mapping to those in metadata.php.
         // Links in the top menu, and the sublinks we see if
         // we're within that section.
-        $nav_items =  [
+        $nav_items = [
             ['home'],
-            ['hansard', 'mps', 'peers', 'alldebatesfront', 'interests_home', 'wranswmsfront', 'pbc_front', 'divisions_recent_commons', 'divisions_recent_lords',  'calendar_summary'],
+            ['hansard', 'mps', 'peers', 'alldebatesfront', 'interests_home', 'wranswmsfront', 'pbc_front', 'divisions_recent_commons', 'divisions_recent_lords', 'calendar_summary'],
             ['sp_home', 'spoverview', 'msps', 'interest_category_sp', 'spdebatesfront', 'divisions_recent_sp'], #'spwransfront'
             ['ni_home', 'nioverview', 'mlas', 'interest_category_ni'],
             ['wales_home', 'seneddoverview', 'mss', 'interest_category_wp', 'wales_debates', 'divisions_recent_wales'],