Passed
Pull Request — master (#1920)
by Struan
04:43
created
www/docs/admin/edittopic.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
             <select name="sets[]" multiple>
126 126
               <option value="">None</option>
127 127
             <?php
128
-              $policies = new \MySociety\TheyWorkForYou\Policies();
128
+                $policies = new \MySociety\TheyWorkForYou\Policies();
129 129
 $set_descriptions = $policies->getSetDescriptions();
130 130
 $related_sets = $topic->getPolicySets();
131 131
 foreach ($set_descriptions as $set => $description) { ?>
Please login to merge, or discard this patch.
www/docs/admin/websites.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     $sysretval = 0;
107 107
     $personid = get_http_var('editperson');
108 108
 
109
-    $q  = $db->query("DELETE FROM personinfo WHERE data_key = 'mp_website' AND personinfo.person_id = :person_id", [
109
+    $q = $db->query("DELETE FROM personinfo WHERE data_key = 'mp_website' AND personinfo.person_id = :person_id", [
110 110
         ':person_id' => $personid,
111 111
     ]);
112 112
 
@@ -142,9 +142,9 @@  discard block
 block discarded – undo
142 142
 
143 143
     $rettext .= '<div id="subnav_websites">';
144 144
     foreach ($subnav as $label => $path) {
145
-        $rettext .=  '<a href="' . $path . '">' . $label . '</a>';
145
+        $rettext .= '<a href="' . $path . '">' . $label . '</a>';
146 146
     }
147
-    $rettext .=  '</div>';
147
+    $rettext .= '</div>';
148 148
 
149 149
     return $rettext;
150 150
 }
Please login to merge, or discard this patch.
www/docs/random/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,5 +11,5 @@
 block discarded – undo
11 11
 $gid = fix_gid_from_db($gid);
12 12
 
13 13
 $URL = new \MySociety\TheyWorkForYou\Url('debates');
14
-$URL->insert([ 'id' => $gid ]);
14
+$URL->insert(['id' => $gid]);
15 15
 header('Location: ' . $URL->generate());
Please login to merge, or discard this patch.
www/docs/postcode/index.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -89,13 +89,13 @@
 block discarded – undo
89 89
     $member_names = \MySociety\TheyWorkForYou\Utility\House::house_to_members($house);
90 90
     if ($house == HOUSE_TYPE_SCOTLAND) {
91 91
         $urlp = 'msp';
92
-        $a = [ $areas['SPC'], $areas['SPE'] ];
92
+        $a = [$areas['SPC'], $areas['SPE']];
93 93
     } elseif ($house == HOUSE_TYPE_WALES) {
94 94
         $urlp = 'ms';
95
-        $a = [ $areas['WAC'], $areas['WAE'] ];
95
+        $a = [$areas['WAC'], $areas['WAE']];
96 96
     } elseif ($house == HOUSE_TYPE_NI) {
97 97
         $urlp = 'mla';
98
-        $a = [ $areas['NIE'] ];
98
+        $a = [$areas['NIE']];
99 99
     }
100 100
     $urlpl = $urlp . 's';
101 101
     $urlp = "/$urlp/?p=";
Please login to merge, or discard this patch.
www/docs/mp/index.php 2 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@
 block discarded – undo
221 221
 // Basic name, title and description
222 222
 $member_name = ucfirst($MEMBER->full_name());
223 223
 $title = $member_name;
224
-$desc = "Read $member_name's contributions to Parliament, including speeches and questions";
224
+$desc = "read $member_name's contributions to Parliament, including speeches and questions";
225 225
 
226 226
 // Enhance description if this is a current member
227 227
 if ($MEMBER->current_member_anywhere()) {
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
                 'health', 'education', 'reform', 'home', 'environment',
410 410
                 'transport', 'housing', 'misc',
411 411
             ];
412
-            $sets = array_filter($sets, function ($v) use ($set_descriptions) {
412
+            $sets = array_filter($sets, function($v) use ($set_descriptions) {
413 413
                 return array_key_exists($v, $set_descriptions);
414 414
             });
415 415
             shuffle($sets);
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
 function person_error_page($message) {
622 622
     global $this_page;
623 623
     $SEARCHURL = '';
624
-    switch($this_page) {
624
+    switch ($this_page) {
625 625
         case 'peer':
626 626
             $people = new MySociety\TheyWorkForYou\People\Peers();
627 627
             $MPSURL = new \MySociety\TheyWorkForYou\Url('peers');
@@ -807,7 +807,7 @@  discard block
 block discarded – undo
807 807
         $SEARCHENGINE = new \SEARCHENGINE($searchstring);
808 808
 
809 809
         $hansard = new MySociety\TheyWorkForYou\Hansard();
810
-        $args =  [
810
+        $args = [
811 811
             's' => $searchstring,
812 812
             'p' => 1,
813 813
             'num' => 3,
@@ -1023,7 +1023,7 @@  discard block
 block discarded – undo
1023 1023
 
1024 1024
     $lang = LANGUAGE;
1025 1025
 
1026
-    $reg = ['chamber_registers' => [] ];
1026
+    $reg = ['chamber_registers' => []];
1027 1027
 
1028 1028
     foreach ($valid_chambers as $chamber) {
1029 1029
         $key = 'person_regmem_' . $chamber . '_' . $lang;
@@ -1038,7 +1038,7 @@  discard block
 block discarded – undo
1038 1038
     }
1039 1039
 
1040 1040
     // sort chamber registers by published_date
1041
-    uasort($reg['chamber_registers'], function ($a, $b) {
1041
+    uasort($reg['chamber_registers'], function($a, $b) {
1042 1042
         return $a->published_date <=> $b->published_date;
1043 1043
     });
1044 1044
 
@@ -1132,8 +1132,8 @@  discard block
 block discarded – undo
1132 1132
         }
1133 1133
     }
1134 1134
 
1135
-    foreach($mreg as $reg) {
1136
-        $data['members'][] =  [
1135
+    foreach ($mreg as $reg) {
1136
+        $data['members'][] = [
1137 1137
             'url' => '/' . $rep_type . '/?p=' . $reg['person_id'],
1138 1138
             'name' => $reg['given_name'] . ' ' . $reg['family_name'],
1139 1139
         ];
Please login to merge, or discard this patch.
www/docs/api/api_convertURL.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     $LISTURL = new \MySociety\TheyWorkForYou\Url($hansardmajors[$id_data['major']]['page_all']);
43 43
     $fragment = '';
44 44
     if ($id_data['htype'] == '11' || $id_data['htype'] == '10') {
45
-        $LISTURL->insert([ 'id' => $id_data['gid'] ]);
45
+        $LISTURL->insert(['id' => $id_data['gid']]);
46 46
     } else {
47 47
         $parent_epobject_id = $id_data['subsection_id'];
48 48
         $parent_gid = '';
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
             $parent_gid = fix_gid_from_db($r['gid']);
56 56
         }
57 57
         if ($parent_gid != '') {
58
-            $LISTURL->insert([ 'id' => $parent_gid ]);
58
+            $LISTURL->insert(['id' => $parent_gid]);
59 59
             $fragment = '#g' . gid_to_anchor($id_data['gid']);
60 60
         }
61 61
     }
Please login to merge, or discard this patch.
www/docs/api/api_getConstituencies.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@
 block discarded – undo
135 135
             );
136 136
         }
137 137
     }
138
-    usort($out, function ($a, $b) {
138
+    usort($out, function($a, $b) {
139 139
         if ($a['distance'] > $b['distance']) {
140 140
             return 1;
141 141
         }
Please login to merge, or discard this patch.
www/docs/api/api_getPerson.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
         if ($constituencies == 'CONNECTION_TIMED_OUT') {
131 131
             api_error('Connection timed out');
132 132
         } elseif ($types && isset($constituencies[$types[0]])) {
133
-            $constituencies = array_map(function ($c) use ($constituencies) { return $constituencies[$c]; }, $types);
133
+            $constituencies = array_map(function($c) use ($constituencies) { return $constituencies[$c]; }, $types);
134 134
             _api_getPerson_constituency($constituencies, $house);
135 135
         } elseif ($types && isset($constituencies['WMC'])) {
136 136
             api_error('Postcode not in correct region');
Please login to merge, or discard this patch.
www/docs/calendar/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
     foreach ($data['order'] as &$chamber) {
81 81
         if (in_array($chamber['major'] ?? 0, $majors)) {
82 82
             $URL = new \MySociety\TheyWorkForYou\Url($hansardmajors[$chamber['major']]['page_all']);
83
-            $URL->insert([ 'd' => $date ]);
83
+            $URL->insert(['d' => $date]);
84 84
             $chamber['url'] = $URL->generate();
85 85
         }
86 86
     }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     [$firstyear, $firstmonth, $day] = explode('-', $min_future_date);
111 111
     [$finalyear, $finalmonth, $day] = explode('-', $max_future_date);
112 112
 
113
-    $q =  $db->query("SELECT DISTINCT(event_date) AS event_date FROM future
113
+    $q = $db->query("SELECT DISTINCT(event_date) AS event_date FROM future
114 114
         WHERE event_date >= :firstdate
115 115
         AND event_date <= :finaldate
116 116
         AND deleted = 0
Please login to merge, or discard this patch.