mysociety / theyworkforyou

www/includes/easyparliament/templates/html/mp/votes_svg.php

Indentation +9 added lines, -9 removed lines

@@ -44,15 +44,15 @@
     <text font-size="24" font-weight="normal" fill="#000000">
         <?php foreach ($lines as $j => $line) { ?>
             <tspan x="40" y="<?= $stance_y + $stance_padding_top + $stance_baseline_offset + ($stance_lineheight * $j) ?>"><?php
-               if (strpos($line, '*') !== false) {
-                   echo preg_replace(
-                       '#(?:^|[*])([^\r\n *][^*\n]*[^\r\n *])(?:$|[*])#i',
-                       '$1',
-                       $line
-                   );
-               } else {
-                   echo $line;
-               }
+                if (strpos($line, '*') !== false) {
+                    echo preg_replace(
+                        '#(?:^|[*])([^\r\n *][^*\n]*[^\r\n *])(?:$|[*])#i',
+                        '$1',
+                        $line
+                    );
+                } else {
+                    echo $line;
+                }
             ?></tspan>
         <?php } ?>
     </text>

www/includes/easyparliament/commentreportlist.php

Spacing +2 added lines, -2 removed lines

@@ -96,7 +96,7 @@ 
 
         $data = [];
         foreach ($q as $row) {
-            $data[] =  [
+            $data[] = [
                 'report_id'		=> $row['report_id'],
                 'comment_id' 	=> $row['comment_id'],
                 'firstname'		=> $row['firstname'],
@@ -107,7 +107,7 @@ 
             ];
         }
         foreach ($r as $row) {
-            $data[] =  [
+            $data[] = [
                 'report_id'		=> $row['report_id'],
                 'comment_id' 	=> $row['comment_id'],
                 'firstname'		=> $row['firstname'],

www/includes/easyparliament/member.php

Spacing +3 added lines, -3 removed lines

@@ -86,7 +86,7 @@ 
 
         # All the following only happen if the house to display isn't yet set.
         # TODO: This relies on interpreting the default value of 0 as a false, which may be error-prone.
-        if (! (bool) $this->house_disp) {
+        if (!(bool) $this->house_disp) {
             if ($house == HOUSE_TYPE_LONDON_ASSEMBLY # London Assembly
                 || $house == HOUSE_TYPE_SCOTLAND     # MSPs and
                 || $house == HOUSE_TYPE_WALES        # MSs and
@@ -251,7 +251,7 @@ 
             $policiesList = new Policies($policyID);
         }
         $rel_agreements = $policiesList->all_policy_agreements[$policyID] ?? [];
-        $rel_agreements = array_filter($rel_agreements, function ($agreement) use ($house) {
+        $rel_agreements = array_filter($rel_agreements, function($agreement) use ($house) {
             return $this->date_in_memberships($house, $agreement['date']);
         });
         return $rel_agreements;
@@ -526,7 +526,7 @@ 
         }
 
         if ($display && array_key_exists('register_member_interests_html', $this->extra_info) && ($this->extra_info['register_member_interests_html'] != '')) {
-            $args =  [
+            $args = [
                 "sort" => "regexp_replace",
             ];
             $GLOSSARY = new GLOSSARY($args);

www/includes/easyparliament/glossary.php

Spacing +6 added lines, -6 removed lines

@@ -24,12 +24,12 @@ 
 include_once INCLUDESPATH . "easyparliament/searchengine.php";
 
 class GLOSSARY {
-    public $num_terms;			// how many glossary entries do we have
+    public $num_terms; // how many glossary entries do we have
     // (changes depending on how GLOSSARY is called
-    public $hansard_count;		// how many times does the phrase appear in hansard?
-    public $query;				// search term
-    public $glossary_id;		// if this is set then we only have 1 glossary term
-    public $current_term;		// will only be set if we have a valid epobject_id
+    public $hansard_count; // how many times does the phrase appear in hansard?
+    public $query; // search term
+    public $glossary_id; // if this is set then we only have 1 glossary term
+    public $current_term; // will only be set if we have a valid epobject_id
     public $current_letter;
 
     // constructor...
@@ -72,7 +72,7 @@ 
 
         // These stop stupid submissions.
         // everything should be lowercase.
-        $this->stopwords = [ "the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate" ];
+        $this->stopwords = ["the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate"];
 
     }
 

www/includes/dbtypes.php

Spacing +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
 ];
 $hansardmajors[104] = $hansardmajors[4];
 
-$parties =  [
+$parties = [
     'Bp'    => 'Bishop',
     'Con'   => 'Conservative',
     'CWM'   => 'Deputy Speaker',

tests/SearchTest.php

Spacing +12 added lines, -12 removed lines

@@ -21,11 +21,11 @@ 
 
     public function testConstituencySearch() {
         $this->assertEquals(
-            [ [ 'Alyn and Deeside' ], false ],
+            [['Alyn and Deeside'], false],
             \MySociety\TheyWorkForYou\Utility\Search::searchConstituenciesByQuery('Alyn')
         );
         $this->assertEquals(
-            [ [ 'Alyn and Deeside' ], false ],
+            [['Alyn and Deeside'], false],
             \MySociety\TheyWorkForYou\Utility\Search::searchConstituenciesByQuery('Alyn and Deeside')
         );
     }
@@ -109,7 +109,7 @@ 
      * @group xapian
      */
     public function testSearchPage() {
-        $page = $this->fetch_page([ ]);
+        $page = $this->fetch_page([]);
         $this->assertStringContainsString('Search', $page);
     }
 
@@ -119,7 +119,7 @@ 
      * @group xapian
      */
     public function testSearchPageMP() {
-        $page = $this->fetch_page([ 'q' => 'Mary Smith' ]);
+        $page = $this->fetch_page(['q' => 'Mary Smith']);
         $this->assertStringContainsString('Mary Smith', $page);
         $this->assertMatchesRegularExpression('/MP *for Amber Valley/', $page);
     }
@@ -130,7 +130,7 @@ 
      * @group xapian
      */
     public function testSearchPageMultipleMP() {
-        $page = $this->fetch_page([ 'q' => 'Jones' ]);
+        $page = $this->fetch_page(['q' => 'Jones']);
         $this->assertStringContainsString('People matching <em class="current-search-term">Jones</em>', $page);
         $this->assertStringContainsString('Andrew Jones', $page);
         $this->assertStringContainsString('Simon Jones', $page);
@@ -142,7 +142,7 @@ 
      * @group xapian
      */
     public function testSearchPageCons() {
-        $page = $this->fetch_page([ 'q' => 'Amber' ]);
+        $page = $this->fetch_page(['q' => 'Amber']);
         $this->assertStringContainsString('MP for <em class="current-search-term">Amber</em>', $page);
         $this->assertStringContainsString('Mary Smith', $page);
     }
@@ -154,7 +154,7 @@ 
      * @group xapian
      */
     public function testSearchPageConsWithNoMp() {
-        $page = $this->fetch_page([ 'q' => 'Alyn' ]);
+        $page = $this->fetch_page(['q' => 'Alyn']);
         $this->assertStringNotContainsString('MP for <em class="current-search-term">Alyn</em>', $page);
         $this->assertStringNotContainsString('MPs in constituencies matching', $page);
     }
@@ -166,7 +166,7 @@ 
      * @group xapian
      */
     public function testSearchPageMultipleCons() {
-        $page = $this->fetch_page([ 'q' => 'Liverpool' ]);
+        $page = $this->fetch_page(['q' => 'Liverpool']);
         $this->assertStringContainsString('MPs in constituencies matching <em class="current-search-term">Liverpool</em>', $page);
         $this->assertStringContainsString('Susan Brown', $page);
         $this->assertMatchesRegularExpression('/MP *for Liverpool, Riverside/', $page);
@@ -180,7 +180,7 @@ 
      * @group xapian
      */
     public function testSearchPageGlossary() {
-        $page = $this->fetch_page([ 'q' => 'other place' ]);
+        $page = $this->fetch_page(['q' => 'other place']);
         $this->assertStringContainsString('Glossary items matching', $page);
         $this->assertStringContainsString('<a href="/glossary/?gl=1">&ldquo;other place', $page);
     }
@@ -191,7 +191,7 @@ 
      * @group xapian
      */
     public function testSearchPageSpellCorrect() {
-        $page = $this->fetch_page([ 'q' => 'plice' ]);
+        $page = $this->fetch_page(['q' => 'plice']);
         $this->assertStringContainsString('Did you mean <a href="/search/?q=place">place', $page);
     }
 
@@ -201,7 +201,7 @@ 
      * @group xapian
      */
     public function testSearchBySpeakerNoResults() {
-        $page = $this->fetch_page([ 'q' => 'splice', 'o' => 'p' ]);
+        $page = $this->fetch_page(['q' => 'splice', 'o' => 'p']);
         $this->assertStringContainsString('Who says splice the most', $page);
         $this->assertStringContainsString('No results', $page);
     }
@@ -228,7 +228,7 @@ 
      * @group xapian
      */
     public function testSearchPageRSS() {
-        $page = $this->fetch_page([ 'q' => 'test' ]);
+        $page = $this->fetch_page(['q' => 'test']);
         $this->assertStringContainsString('<a href="/search/rss/?s=test">get an RSS feed', $page);
     }
 

tests/DivisionsTest.php

Spacing +7 added lines, -7 removed lines

@@ -13,16 +13,16 @@ 
     }
 
     private function fetch_division_page() {
-        return $this->fetch_page([ 'pagetype' => 'divisions', 'pid' => 2, 'policy' => 363, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/divisions' ]);
+        return $this->fetch_page(['pagetype' => 'divisions', 'pid' => 2, 'policy' => 363, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/divisions']);
     }
 
     private function fetch_mp_recent_page() {
-        $vars = [ 'pagetype' => 'recent', 'pid' => 2, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/recent' ];
+        $vars = ['pagetype' => 'recent', 'pid' => 2, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/recent'];
         return $this->base_fetch_page($vars, 'mp', 'index.php', '/mp/recent.php');
     }
 
     private function fetch_recent_page() {
-        return $this->base_fetch_page(['url' => '/divisions' ], 'divisions', 'index.php', '/divisions/index.php');
+        return $this->base_fetch_page(['url' => '/divisions'], 'divisions', 'index.php', '/divisions/index.php');
     }
 
 
@@ -51,13 +51,13 @@ 
 
     public function testMPPageContainsAgreement() {
         // Checks this MP contains a reference to the agreement
-        $page = $this->fetch_page([ 'pagetype' => 'divisions', 'pid' => 2, 'policy' => 363, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/divisions' ]);
+        $page = $this->fetch_page(['pagetype' => 'divisions', 'pid' => 2, 'policy' => 363, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/divisions']);
         $this->assertStringContainsString('Example Agreement', $page);
     }
 
     public function testMPPageDoesNotContainsAgreement() {
         // Checks this MP does not contain agreement - should be out of time scope
-        $page = $this->fetch_page([ 'pagetype' => 'divisions', 'pid' => 6, 'policy' => 363, 'url' => '/mp/6/test_current-mp/test_westminster_constituency/divisions' ]);
+        $page = $this->fetch_page(['pagetype' => 'divisions', 'pid' => 6, 'policy' => 363, 'url' => '/mp/6/test_current-mp/test_westminster_constituency/divisions']);
         $this->assertStringNotContainsString('Example Agreement', $page);
         $this->assertStringNotContainsString('This person has not voted on this policy', $page);
 
@@ -121,7 +121,7 @@ 
     }
 
     public function testNotEnoughInfoStatement() {
-        $page = $this->fetch_page([ 'pagetype' => 'divisions', 'pid' => 2, 'policy' => 810, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/divisions' ]);
+        $page = $this->fetch_page(['pagetype' => 'divisions', 'pid' => 2, 'policy' => 810, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/divisions']);
         $this->assertStringContainsString('We don’t have enough information to calculate Mrs Test Current-MP’s position', $page);
     }
 
@@ -132,7 +132,7 @@ 
     }
 
     public function testSingleDivision() {
-        $page = $this->base_fetch_page(['url' => '/divisions/division.php', 'vote' => 'pw-3012-01-01-1-commons' ], 'divisions', 'division.php', '/divisions/division.php');
+        $page = $this->base_fetch_page(['url' => '/divisions/division.php', 'vote' => 'pw-3012-01-01-1-commons'], 'divisions', 'division.php', '/divisions/division.php');
         $this->assertStringContainsString('A majority of MPs  <b>voted in favour</b> of a thing', $page);
         $this->assertStringContainsString('Aye: 200', $page);
         $this->assertStringNotContainsString('No:', $page); # Summary 100, but no actual votes. In reality, summary can only be <= actual.

tests/SectionTest.php

Spacing +8 added lines, -8 removed lines

@@ -16,14 +16,14 @@ 
 
     public function testDebatesFront() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type ]);
+            $page = $this->fetch_page(['type' => $type]);
             $this->assertStringContainsString($type, $page);
         }
     }
 
     public function testDebatesYear() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type, 'y' => '2014' ]);
+            $page = $this->fetch_page(['type' => $type, 'y' => '2014']);
             $this->assertStringContainsString('<div class="calendar">', $page);
             $this->assertStringContainsString('January', $page);
             $this->assertMatchesRegularExpression('/<td colspan="2">&nbsp;<\/td><td[^>]*><a href="\/' . $type . '\/\?d=2014-01-01">1<\/a><\/td><td[^>]*><span>2<\/span><\/td>/', $page);
@@ -32,7 +32,7 @@ 
 
     public function testDebatesDay() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type, 'd' => '2014-01-01' ]);
+            $page = $this->fetch_page(['type' => $type, 'd' => '2014-01-01']);
             $this->assertStringContainsString('Wednesday,  1 January 2014', $page);
             $this->assertStringContainsString('HeadingA', $page);
             if ($type == 'wrans') {
@@ -57,7 +57,7 @@ 
                 continue;
             }
 
-            $page = $this->fetch_page([ 'type' => $type, 'id' => '2014-01-01b.1.1' ]);
+            $page = $this->fetch_page(['type' => $type, 'id' => '2014-01-01b.1.1']);
             if ($type == 'wrans') {
                 $this->assertMatchesRegularExpression("#All .*?written answers on  1 Jan 2014#i", $page);
                 $this->assertStringContainsString("QuestionA", $page);
@@ -69,7 +69,7 @@ 
 
     public function testDebatesSubheading() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type, 'id' => '2014-01-01b.1.2' ]);
+            $page = $this->fetch_page(['type' => $type, 'id' => '2014-01-01b.1.2']);
             $this->assertStringContainsString("HeadingA", $page);
             if ($type == 'spwrans') {
                 $this->assertStringContainsString("QuestionA", $page);
@@ -99,7 +99,7 @@ 
 
     public function testDebatesSpeech() {
         foreach ($this->types as $type) {
-            $page = $this->fetch_page([ 'type' => $type, 'id' => '2014-01-01b.1.3' ]);
+            $page = $this->fetch_page(['type' => $type, 'id' => '2014-01-01b.1.3']);
             if ($type == 'wrans' || $type == 'spwrans' || $type == 'wms') {
                 $this->assertMatchesRegularExpression("#Location: .*?/$type/\?id=2014-01-01b\.1\.2#", $page);
             } else {
@@ -124,13 +124,13 @@ 
      * @group xapian
      */
     public function testGlossaryAndSearchHighlights() {
-        $page = $this->fetch_page([ 'type' => 'lords', 's' => 'constituency', 'id' => '2014-02-02b.1.3' ]);
+        $page = $this->fetch_page(['type' => 'lords', 's' => 'constituency', 'id' => '2014-02-02b.1.3']);
         $this->assertStringContainsString("constituency", $page);
         $this->assertStringContainsString("<span class=\"hi\"><a href=\"/glossary/?gl=1\" title=\"In a general election, each Constituency chooses an MP to represent them....\" class=\"glossary\">constituency</a></span>", $page);
     }
 
     public function testGidRedirect() {
-        $page = $this->fetch_page([ 'type' => 'wrans', 'id' => '2014-01-01a.187335.h' ]);
+        $page = $this->fetch_page(['type' => 'wrans', 'id' => '2014-01-01a.187335.h']);
         $this->assertMatchesRegularExpression("#Location: .*?/wrans/\?id=2014-01-01b\.1\.2#", $page);
     }
 }

classes/DataClass/Regmem/Person.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -42,6 +42,6 @@
                 return $category;
             }
         }
-        throw new InvalidArgumentException("Category $categoryId not found in register");
+        throw new InvalidArgumentException("category $categoryId not found in register");
     }
 }