ALERT::add()

Complexity

Conditions	10
Paths	16

Size

Total Lines	121
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	27.6558

Importance

Changes

0

<?php
    public function add($details, $confirmation_email = false, $instantly_confirm = true) {

        // Adds a new alert's info into the database.
        // Then calls another function to send them a confirmation email.
        // $details is an associative array of all the alert's details, of the form:
        // array (
        //		"email" => "user@foo.com",
        //		"criteria"	=> "speaker:521",
        //		etc... using the same keys as the object variable names.
        // )

        $criteria = \MySociety\TheyWorkForYou\Utility\Alert::detailsToCriteria($details);
        $ignore_speaker_votes = $details['ignore_speaker_votes'] ? 1 : 0;

        $q = $this->db->query("SELECT * FROM alerts
            WHERE email = :email
            AND criteria = :criteria
            AND confirmed=1", [
            ':email' => $details['email'],
            ':criteria' => $criteria,
        ])->first();
        if ($q) {
            if ($q['deleted'] || $q['ignore_speaker_votes'] != $ignore_speaker_votes) {
                $this->db->query("UPDATE alerts SET deleted=0, ignore_speaker_votes=:ignore_speaker_votes
                    WHERE email = :email
                    AND criteria = :criteria
                    AND confirmed=1", [
                    ':email' => $details['email'],
                    ':criteria' => $criteria,
                    ':ignore_speaker_votes' => $ignore_speaker_votes,
                ]);
                return 1;
            } else {
                return -2;
            }
        }

        $q = $this->db->query("INSERT INTO alerts (
                email, criteria, postcode, lang, ignore_speaker_votes, deleted, confirmed, created
            ) VALUES (
                :email,
                :criteria,
                :pc,
                :lang,
                :ignore_speaker_votes,
                '0', '0', NOW()
            )
        ", [
            ':email' => $details['email'],
            ':criteria' => $criteria,
            ':ignore_speaker_votes' => $ignore_speaker_votes,
            ':pc' => $details['pc'],
            ':lang' => LANGUAGE,
        ]);

        if ($q->success()) {

            // Get the alert id so that we can perform the updates for confirmation

            $this->alert_id = $q->insert_id();
            $this->criteria = $criteria;
            $this->ignore_speaker_votes = $ignore_speaker_votes;

            // We have to set the alert's registration token.
            // This will be sent to them via email, so we can confirm they exist.
            // The token will be the first 16 characters of a hash.

            // This gives a code for their email address which is then joined
            // to the timestamp so as to provide a unique ID for each alert.

            $token = substr(password_hash($details["email"] . microtime(), PASSWORD_BCRYPT), 29, 16);

            // Full stops don't work well at the end of URLs in emails, so
            // replace them. And double slash would be treated as single and
            // not work either. We won't be doing anything clever with the hash
            // stuff, just need to match this token.
            $token = strtr($token, './', 'Xx');
            $this->registrationtoken = $token;

The property registrationtoken does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            // Add that to the database.

            $r = $this->db->query("UPDATE alerts
                        SET registrationtoken = :registration_token
                        WHERE alert_id = :alert_id
                        ", [
                ':registration_token' => $this->registrationtoken,
                ':alert_id' => $this->alert_id,
            ]);

            if ($r->success()) {
                // Updated DB OK.

                if ($confirmation_email) {
                    // Right, send the email...
                    $success = $this->send_confirmation_email($details);

                    if ($success) {
                        // Email sent OK
                        return 1;
                    } else {
                        // Couldn't send the email.
                        return -1;
                    }
                } elseif ($instantly_confirm) {
                    // No confirmation email needed.
                    $this->db->query("UPDATE alerts
                        SET confirmed = '1'
                        WHERE alert_id = :alert_id
                        ", [
                        ':alert_id' => $this->alert_id,
                    ]);
                    return 1;
                }
            } else {
                // Couldn't add the registration token to the DB.
                return -1;
            }

        } else {
            // Couldn't add the user's data to the DB.
            return -1;
        }