mysociety /
theyworkforyou
| Conditions | 46 |
| Paths | > 20000 |
| Total Lines | 202 |
| Code Lines | 147 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 173 | function parse_amendments() { |
||
| 174 | global $amendments, $bill, $clauses, $title; |
||
| 175 | foreach ($amendments as $num => $amendment) { |
||
| 176 | # Page 8, line 4 [Clause 13], leave out `21-day' and insert `30-day' |
||
| 177 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], leave out `(.*?)\' and insert `(.*?)\'#s', $amendment, $m)) { |
||
| 178 | $page = $m[1]; |
||
| 179 | $line = $m[2]; |
||
| 180 | $clause = $m[3]; |
||
| 181 | $delete = $m[4]; |
||
| 182 | $insert = $m[5]; |
||
| 183 | unset($amendments[$num]); |
||
| 184 | $bill[$page][$line] = preg_replace("#(.*)$delete#", "$1<del title='$num'>$delete</del><ins title='$num'>$insert</ins>", $bill[$page][$line]); |
||
| 185 | } |
||
| 186 | # Page 2, line 32 [Clause 3], leave out from `make' to end of line 35 and insert `...' |
||
| 187 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], leave out from `(.*?)\' to end of line (\d+) and insert(?:--)?\s+`(.*?)\'#s', $amendment, $m)) { |
||
| 188 | $page = $m[1]; |
||
| 189 | $line = $m[2]; |
||
| 190 | $clause = $m[3]; |
||
| 191 | $from_text = $m[4]; |
||
| 192 | $end_line = $m[5]; |
||
| 193 | $insert = $m[6]; |
||
| 194 | unset($amendments[$num]); |
||
| 195 | $bill[$page][$line] = str_replace($from_text, "$from_text <del title='$num'>", $bill[$page][$line]) . '</del><ins title="' . $num . '">' . $insert . '</ins>'; |
||
| 196 | for ($i = $line + 1; $i <= $end_line; $i++) { |
||
| 197 | $bill[$page][$i] = '<del title="' . $num . '">' . $bill[$page][$i] . '</del>'; |
||
| 198 | } |
||
| 199 | } |
||
| 200 | # Page 4, line 9 [Clause 6], leave out from `under' to `creating' and insert `this Part making provision' |
||
| 201 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], leave out from `(.*?)\' to `(.*?)\' and insert `(.*?)\'#s', $amendment, $m)) { |
||
| 202 | $page = $m[1]; |
||
| 203 | $line = $m[2]; |
||
| 204 | $clause = $m[3]; |
||
| 205 | $from_text = $m[4]; |
||
| 206 | $to_text = $m[5]; |
||
| 207 | $insert = $m[6]; |
||
| 208 | unset($amendments[$num]); |
||
| 209 | $bill[$page][$line] = preg_replace("#$from_text(.*?)$to_text#", "$from_text <del title='$num'>$1</del><ins title='$num'>$insert</ins> $to_text", $bill[$page][$line]); |
||
| 210 | } |
||
| 211 | # Page 7, line 1 [Clause 12], leave out from `of' to `the' in line 2 and insert `...' |
||
| 212 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], leave out from `(.*?)\' to `(.*?)\' in line (\d+) and insert `(.*?)\'#s', $amendment, $m)) { |
||
| 213 | $page = $m[1]; |
||
| 214 | $from_line = $m[2]; |
||
| 215 | $clause = $m[3]; |
||
| 216 | $from_text = $m[4]; |
||
| 217 | $to_text = $m[5]; |
||
| 218 | $to_line = $m[6]; |
||
| 219 | $insert = $m[7]; |
||
| 220 | unset($amendments[$num]); |
||
| 221 | $bill[$page][$from_line] = str_replace($from_text, "$from_text <del title='$num'>", $bill[$page][$from_line]) . '</del>'; |
||
| 222 | for ($i = $from_line + 1; $i < $to_line; $i++) { |
||
| 223 | $bill[$page][$i] = '<del title="' . $num . '">' . $bill[$page][$i] . '</del>'; |
||
| 224 | } |
||
| 225 | $bill[$page][$to_line] = '<del title="' . $num . '">' . str_replace($to_text, "</del><ins title='$num'>$insert</ins> $to_text", $bill[$page][$to_line]); |
||
| 226 | } |
||
| 227 | # Page 3, line 13 [Clause 4], leave out from beginning to `confer' and insert `An order under this Part may not make provision to' |
||
| 228 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], leave out from beginning to `(.*?)\' and insert `(.*?)\'#s', $amendment, $m)) { |
||
| 229 | $page = $m[1]; |
||
| 230 | $line = $m[2]; |
||
| 231 | $clause = $m[3]; |
||
| 232 | $to_text = $m[4]; |
||
| 233 | $insert = $m[5]; |
||
| 234 | unset($amendments[$num]); |
||
| 235 | $bill[$page][$line] = "<ins title='$num'>$insert</ins><del title='$num'>" . str_replace($to_text, "</del> $to_text", $bill[$page][$line]); |
||
| 236 | } |
||
| 237 | # Page 19, line 2 [Clause 34], leave out from `under' to the end of the line and insert `...' |
||
| 238 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], leave out from `(.*?)\' to the end of the line and insert\s+`(.*?)\'#s', $amendment, $m)) { |
||
| 239 | $page = $m[1]; |
||
| 240 | $line = $m[2]; |
||
| 241 | $clause = $m[3]; |
||
| 242 | $from_text = $m[4]; |
||
| 243 | $insert = $m[5]; |
||
| 244 | unset($amendments[$num]); |
||
| 245 | $bill[$page][$line] = str_replace($from_text, "$from_text <del title='$num'>", $bill[$page][$line]) . "</del><ins title='$num'>$insert</ins>"; |
||
| 246 | } |
||
| 247 | # Page 4 [Clause 7], leave out line 26 and insert `An order under this Part may not make provision to--' |
||
| 248 | if (preg_match('#Page\s+(\d+) \[Clause (\d+)\], leave out line (\d+)(?: and insert `(.*?)\')?#', $amendment, $m)) { |
||
| 249 | $page = $m[1]; |
||
| 250 | $line = $m[3]; |
||
| 251 | $clause = $m[2]; |
||
| 252 | $insert = $m[4] ?? null; |
||
| 253 | unset($amendments[$num]); |
||
| 254 | $bill[$page][$line] = '<del title="' . $num . '">' . $bill[$page][$line] . '</del>'; |
||
| 255 | if ($insert) { |
||
| 256 | $bill[$page][$line] .= '<ins title="' . $num . '">' . $insert . '</ins>'; |
||
| 257 | } |
||
| 258 | } |
||
| 259 | # Page 8, line 24 [Clause 14], at end insert-- `...' |
||
| 260 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], (?:at end|after subsection \(\d+\)) insert--\s+`(.*?)\'#s', $amendment, $m)) { |
||
| 261 | $page = $m[1]; |
||
| 262 | $line = $m[2]; |
||
| 263 | $clause = $m[3]; |
||
| 264 | $insert = $m[4]; |
||
| 265 | unset($amendments[$num]); |
||
| 266 | $bill[$page][$line] .= '<ins title="' . $num . '">' . $insert . '</ins>'; |
||
| 267 | } |
||
| 268 | # Title, line 1, leave out `reforming legislation' and insert `...' |
||
| 269 | if (preg_match('#Title, line.*?, leave out `(.*?)\' and insert `(.*?)\'#s', $amendment, $m)) { |
||
| 270 | $delete = $m[1]; |
||
| 271 | $insert = $m[2]; |
||
| 272 | unset($amendments[$num]); |
||
| 273 | $title = str_replace($delete, "<del title='$num'>$delete</del><ins title='$num'>$insert</ins>", $title); |
||
| 274 | } |
||
| 275 | # Page 4, line 23 [Clause 6], leave out paragraph (b) |
||
| 276 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], leave out paragraph \((.*?)\)(?: and insert-- `(.*?)\')?#', $amendment, $m)) { |
||
| 277 | $page = $m[1]; |
||
| 278 | $line = $m[2]; |
||
| 279 | $clause = $m[3]; |
||
| 280 | $paragraph = $m[4]; |
||
| 281 | $insert = $m[5] ?? null; |
||
| 282 | foreach ($clauses[$clause] as $subclause_num => $subclause) { |
||
| 283 | foreach ($subclause as $subsubclause_num => $subsubclause) { |
||
| 284 | $startP = $subsubclause['startP']; |
||
| 285 | if ($startP == $page && $subsubclause['startL'] == $line) { |
||
| 286 | if ($startP == $subsubclause['endP']) { |
||
| 287 | unset($amendments[$num]); |
||
| 288 | for ($i = $subsubclause['startL']; $i <= $subsubclause['endL']; $i++) { |
||
| 289 | $bill[$page][$i] = '<del title="' . $num . '">' . $bill[$page][$i] . '</del>'; |
||
| 290 | } |
||
| 291 | if ($insert) { |
||
| 292 | $bill[$page][$i - 1] .= "<ins title='$num'>$insert</ins>"; |
||
| 293 | } |
||
| 294 | } |
||
| 295 | } |
||
| 296 | } |
||
| 297 | } |
||
| 298 | } |
||
| 299 | # Page 6, line 40 [Clause 12], leave out subsection (3) |
||
| 300 | if (preg_match('#Page\s+(\d+), line (\d+) \[Clause (\d+)\], leave out subsection \((.*?)\)(?: and insert-- `(.*?)\')?#', $amendment, $m)) { |
||
| 301 | $page = $m[1]; |
||
| 302 | $line = $m[2]; |
||
| 303 | $clause = $m[3]; |
||
| 304 | $subsection = $m[4]; |
||
| 305 | $insert = $m[5] ?? null; |
||
| 306 | $finished = false; |
||
| 307 | foreach ($clauses[$clause] as $subclause_num => $subclause) { |
||
| 308 | foreach ($subclause as $subsubclause_num => $subsubclause) { |
||
| 309 | $startP = $subsubclause['startP']; |
||
| 310 | if ($startP == $page && $subsubclause['startL'] == $line) { |
||
| 311 | if ($startP == $subsubclause['endP']) { |
||
| 312 | unset($amendments[$num]); |
||
| 313 | $finished = true; |
||
| 314 | } |
||
| 315 | } |
||
| 316 | if ($finished) { |
||
| 317 | for ($i = $subsubclause['startL']; $i <= $subsubclause['endL']; $i++) { |
||
| 318 | $bill[$page][$i] = '<del title="' . $num . '">' . $bill[$page][$i] . '</del>'; |
||
| 319 | } |
||
| 320 | } |
||
| 321 | } |
||
| 322 | if ($finished) { |
||
| 323 | if ($insert) { |
||
| 324 | $bill[$page][$i - 1] .= "<ins title='$num'>$insert</ins>"; |
||
| 325 | } |
||
| 326 | break; |
||
| 327 | } |
||
| 328 | } |
||
| 329 | } |
||
| 330 | # Page 12, line 17, leave out clause 24 |
||
| 331 | if (preg_match('#Page\s+(\d+), line (\d+), leave out clause (\d+)#', $amendment, $m)) { |
||
| 332 | $page = $m[1]; |
||
| 333 | $line = $m[2]; |
||
| 334 | $clause = $m[3]; |
||
| 335 | $finished = false; |
||
| 336 | foreach ($clauses[$clause] as $subclause_num => $subclause) { |
||
| 337 | foreach ($subclause as $subsubclause_num => $subsubclause) { |
||
| 338 | if ($subsubclause['startP'] == $page && $subsubclause['startL'] == $line) { |
||
| 339 | unset($amendments[$num]); |
||
| 340 | $finished = true; |
||
| 341 | } |
||
| 342 | if ($finished) { |
||
| 343 | for ($p = $subsubclause['startP']; $p <= $subsubclause['endP']; $p++) { |
||
| 344 | if ($p > $subsubclause['startP']) { |
||
| 345 | $starti = 1; |
||
| 346 | } else { |
||
| 347 | $starti = $subsubclause['startL']; |
||
| 348 | } |
||
| 349 | for ($i = $starti; $i <= $subsubclause['endL']; $i++) { # XXX Doesn't really work spanning pages |
||
| 350 | $bill[$p][$i] = '<del title="' . $num . '">' . $bill[$p][$i] . '</del>'; |
||
| 351 | } |
||
| 352 | } |
||
| 353 | } |
||
| 354 | } |
||
| 355 | } |
||
| 356 | } |
||
| 357 | |||
| 358 | # New clause |
||
| 359 | if (preg_match('#^\*(.*?)\*\s+(.*?)$#s', $amendment, $m)) { |
||
| 360 | unset($amendments[$num]); |
||
| 361 | $page = 0; |
||
| 362 | $line = 0; |
||
| 363 | foreach ($clauses[$clause] as $subclause_num => $subclause) { |
||
| 364 | foreach ($subclause as $subsubclause_num => $subsubclause) { |
||
| 365 | if ($subsubclause['endP'] > $page) { |
||
| 366 | $page = $subsubclause['endP']; |
||
| 367 | $line = 0; |
||
| 368 | } |
||
| 369 | if ($subsubclause['endL'] > $line) { |
||
| 370 | $line = $subsubclause['endL']; |
||
| 371 | } |
||
| 372 | } |
||
| 373 | } |
||
| 374 | $bill[$page][$line] .= "<ins title='$num'>$amendment</ins>\n\n"; |
||
| 375 | } |
||
| 378 |
Loading history...
In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.