mysociety /
theyworkforyou
| Conditions | 25 |
| Paths | 578 |
| Total Lines | 128 |
| Code Lines | 87 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 650 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 12 | public static function searchByUsage($search, $house = 0) { |
||
| 13 | $data = []; |
||
| 14 | $SEARCHENGINE = new \SEARCHENGINE($search); |
||
| 15 | $data['pagetitle'] = $SEARCHENGINE->query_description_short(); |
||
| 16 | $SEARCHENGINE = new \SEARCHENGINE($search . ' groupby:speech'); |
||
| 17 | $count = $SEARCHENGINE->run_count(0, 5000, 'date'); |
||
| 18 | if ($count <= 0) { |
||
| 19 | $data['error'] = 'No results'; |
||
| 20 | |||
| 21 | return $data; |
||
| 22 | } |
||
| 23 | $SEARCHENGINE->run_search(0, 5000, 'date'); |
||
| 24 | $gids = $SEARCHENGINE->get_gids(); |
||
| 25 | if (count($gids) <= 0) { |
||
| 26 | $data['error'] = 'No results'; |
||
| 27 | |||
| 28 | return $data; |
||
| 29 | } |
||
| 30 | if (count($gids) == 5000) { |
||
| 31 | $data['limit_reached'] = true; |
||
| 32 | } |
||
| 33 | |||
| 34 | # Fetch all the speakers of the results, count them up and get min/max date usage |
||
| 35 | $speaker_count = []; |
||
| 36 | $gids = join('","', $gids); |
||
| 37 | $db = new \ParlDB(); |
||
| 38 | $q = $db->query('SELECT person_id,hdate FROM hansard WHERE gid IN ("' . $gids . '")'); |
||
| 39 | foreach ($q as $row) { |
||
| 40 | $person_id = $row['person_id']; |
||
| 41 | $hdate = $row['hdate']; |
||
| 42 | if (!isset($speaker_count[$person_id])) { |
||
| 43 | $speaker_count[$person_id] = 0; |
||
| 44 | $maxdate[$person_id] = '1001-01-01'; |
||
| 45 | $mindate[$person_id] = '9999-12-31'; |
||
| 46 | } |
||
| 47 | $speaker_count[$person_id]++; |
||
| 48 | if ($hdate < $mindate[$person_id]) { |
||
|
Comprehensibility
Best Practice
introduced
by
|
|||
| 49 | $mindate[$person_id] = $hdate; |
||
| 50 | } |
||
| 51 | if ($hdate > $maxdate[$person_id]) { |
||
| 52 | $maxdate[$person_id] = $hdate; |
||
| 53 | } |
||
| 54 | } |
||
| 55 | |||
| 56 | # Fetch details of all the speakers |
||
| 57 | $speakers = []; |
||
| 58 | $pids = []; |
||
| 59 | if (count($speaker_count)) { |
||
| 60 | $person_ids = join(',', array_keys($speaker_count)); |
||
| 61 | $q = $db->query('SELECT member_id, member.person_id, title, given_name, family_name, lordofname, |
||
| 62 | constituency, house, party, |
||
| 63 | moffice_id, dept, position, from_date, to_date, left_house |
||
| 64 | FROM member LEFT JOIN moffice ON member.person_id = moffice.person |
||
| 65 | JOIN person_names pn ON member.person_id = pn.person_id AND pn.type="name" AND pn.start_date <= left_house AND left_house <= pn.end_date |
||
| 66 | WHERE member.person_id IN (' . $person_ids . ') |
||
| 67 | ' . ($house ? " AND house=$house" : '') . ' |
||
| 68 | ORDER BY left_house DESC'); |
||
| 69 | foreach ($q as $row) { |
||
| 70 | $mid = $row['member_id']; |
||
| 71 | if (!isset($pids[$mid])) { |
||
| 72 | $title = $row['title']; |
||
| 73 | $first = $row['given_name']; |
||
| 74 | $last = $row['family_name']; |
||
| 75 | $lordofname = $row['lordofname']; |
||
| 76 | $house = $row['house']; |
||
| 77 | $party = $row['party']; |
||
| 78 | $full_name = ucfirst(member_full_name($house, $title, $first, $last, $lordofname)); |
||
| 79 | $pid = $row['person_id']; |
||
| 80 | $pids[$mid] = $pid; |
||
| 81 | $speakers[$pid]['house'] = $house; |
||
| 82 | $speakers[$pid]['left'] = $row['left_house']; |
||
| 83 | } |
||
| 84 | $dept = $row['dept']; |
||
| 85 | $posn = $row['position']; |
||
| 86 | $moffice_id = $row['moffice_id']; |
||
| 87 | if ($dept && $row['to_date'] == '9999-12-31') { |
||
| 88 | $speakers[$pid]['office'][$moffice_id] = prettify_office($posn, $dept); |
||
| 89 | } |
||
| 90 | if (!isset($speakers[$pid]['name'])) { |
||
| 91 | $speakers[$pid]['name'] = $full_name . ($house == 1 ? ' MP' : ''); |
||
| 92 | } |
||
| 93 | if (!isset($speakers[$pid]['party']) && $party) { |
||
| 94 | $speakers[$pid]['party'] = $party; |
||
| 95 | } |
||
| 96 | } |
||
| 97 | } |
||
| 98 | if (isset($speaker_count[0])) { |
||
| 99 | $speakers[0] = ['party' => '', 'name' => 'Headings, procedural text, etc.', 'house' => 0, 'count' => 0]; |
||
| 100 | } |
||
| 101 | $party_count = []; |
||
| 102 | $ok = 0; |
||
| 103 | foreach ($speakers as $pid => &$speaker) { |
||
| 104 | $speaker['count'] = $speaker_count[$pid]; |
||
| 105 | $speaker['pmaxdate'] = $maxdate[$pid]; |
||
| 106 | $speaker['pmindate'] = $mindate[$pid]; |
||
| 107 | $ok = 1; |
||
| 108 | if (isset($speaker['party'])) { |
||
| 109 | if (!isset($party_count[$speaker['party']])) { |
||
| 110 | $party_count[$speaker['party']] = 0; |
||
| 111 | } |
||
| 112 | $party_count[$speaker['party']] += $count; |
||
| 113 | } |
||
| 114 | } |
||
| 115 | |||
| 116 | uasort($speakers, function ($a, $b) { |
||
| 117 | |||
| 118 | if ($a['count'] > $b['count']) { |
||
| 119 | return -1; |
||
| 120 | } |
||
| 121 | |||
| 122 | if ($a['count'] < $b['count']) { |
||
| 123 | return 1; |
||
| 124 | } |
||
| 125 | |||
| 126 | return 0; |
||
| 127 | |||
| 128 | }); |
||
| 129 | |||
| 130 | arsort($party_count); |
||
| 131 | if (!$ok) { |
||
| 132 | $data['error'] = 'No results'; |
||
| 133 | return $data; |
||
| 134 | } |
||
| 135 | |||
| 136 | $data['party_count'] = $party_count; |
||
| 137 | $data['speakers'] = $speakers; |
||
| 138 | |||
| 139 | return $data; |
||
| 140 | } |
||
| 317 |
Loading history...