Conditions | 120 |
Total Lines | 419 |
Code Lines | 288 |
Lines | 419 |
Ratio | 100 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like store_energy_input_item.worker() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | import time |
||
106 | View Code Duplication | def worker(store): |
|
107 | #################################################################################################################### |
||
108 | # Step 1: get all input meters associated with the store |
||
109 | #################################################################################################################### |
||
110 | print("Step 1: get all input meters associated with the store " + str(store['name'])) |
||
111 | |||
112 | meter_list = list() |
||
113 | cnx_system_db = None |
||
114 | cursor_system_db = None |
||
115 | try: |
||
116 | cnx_system_db = mysql.connector.connect(**config.myems_system_db) |
||
117 | cursor_system_db = cnx_system_db.cursor() |
||
118 | except Exception as e: |
||
119 | error_string = "Error in step 1.1 of store_energy_input_item.worker " + str(e) |
||
120 | if cursor_system_db: |
||
121 | cursor_system_db.close() |
||
122 | if cnx_system_db: |
||
123 | cnx_system_db.close() |
||
124 | print(error_string) |
||
125 | return error_string |
||
126 | |||
127 | try: |
||
128 | cursor_system_db.execute(" SELECT m.id, m.name, m.energy_item_id " |
||
129 | " FROM tbl_meters m, tbl_stores_meters sm " |
||
130 | " WHERE m.id = sm.meter_id " |
||
131 | " AND m.is_counted = true " |
||
132 | " AND m.energy_item_id is NOT NULL " |
||
133 | " AND sm.store_id = %s ", |
||
134 | (store['id'],)) |
||
135 | rows_meters = cursor_system_db.fetchall() |
||
136 | |||
137 | if rows_meters is not None and len(rows_meters) > 0: |
||
138 | for row in rows_meters: |
||
139 | meter_list.append({"id": row[0], |
||
140 | "name": row[1], |
||
141 | "energy_item_id": row[2]}) |
||
142 | |||
143 | except Exception as e: |
||
144 | error_string = "Error in step 1.2 of store_energy_input_item.worker " + str(e) |
||
145 | if cursor_system_db: |
||
146 | cursor_system_db.close() |
||
147 | if cnx_system_db: |
||
148 | cnx_system_db.close() |
||
149 | print(error_string) |
||
150 | return error_string |
||
151 | |||
152 | #################################################################################################################### |
||
153 | # Step 2: get all input virtual meters associated with the store |
||
154 | #################################################################################################################### |
||
155 | print("Step 2: get all input virtual meters associated with the store") |
||
156 | virtual_meter_list = list() |
||
157 | |||
158 | try: |
||
159 | cursor_system_db.execute(" SELECT m.id, m.name, m.energy_item_id " |
||
160 | " FROM tbl_virtual_meters m, tbl_stores_virtual_meters sm " |
||
161 | " WHERE m.id = sm.virtual_meter_id " |
||
162 | " AND m.energy_item_id is NOT NULL " |
||
163 | " AND m.is_counted = true " |
||
164 | " AND sm.store_id = %s ", |
||
165 | (store['id'],)) |
||
166 | rows_virtual_meters = cursor_system_db.fetchall() |
||
167 | |||
168 | if rows_virtual_meters is not None and len(rows_virtual_meters) > 0: |
||
169 | for row in rows_virtual_meters: |
||
170 | virtual_meter_list.append({"id": row[0], |
||
171 | "name": row[1], |
||
172 | "energy_item_id": row[2]}) |
||
173 | |||
174 | except Exception as e: |
||
175 | error_string = "Error in step 2.1 of store_energy_input_item.worker " + str(e) |
||
176 | if cursor_system_db: |
||
177 | cursor_system_db.close() |
||
178 | if cnx_system_db: |
||
179 | cnx_system_db.close() |
||
180 | print(error_string) |
||
181 | return error_string |
||
182 | |||
183 | #################################################################################################################### |
||
184 | # Step 3: get all input offline meters associated with the store |
||
185 | #################################################################################################################### |
||
186 | print("Step 3: get all input offline meters associated with the store") |
||
187 | |||
188 | offline_meter_list = list() |
||
189 | |||
190 | try: |
||
191 | cursor_system_db.execute(" SELECT m.id, m.name, m.energy_item_id " |
||
192 | " FROM tbl_offline_meters m, tbl_stores_offline_meters sm " |
||
193 | " WHERE m.id = sm.offline_meter_id " |
||
194 | " AND m.energy_item_id is NOT NULL " |
||
195 | " AND m.is_counted = true " |
||
196 | " AND sm.store_id = %s ", |
||
197 | (store['id'],)) |
||
198 | rows_offline_meters = cursor_system_db.fetchall() |
||
199 | |||
200 | if rows_offline_meters is not None and len(rows_offline_meters) > 0: |
||
201 | for row in rows_offline_meters: |
||
202 | offline_meter_list.append({"id": row[0], |
||
203 | "name": row[1], |
||
204 | "energy_item_id": row[2]}) |
||
205 | |||
206 | except Exception as e: |
||
207 | error_string = "Error in step 3.1 of store_energy_input_item.worker " + str(e) |
||
208 | print(error_string) |
||
209 | return error_string |
||
210 | finally: |
||
211 | if cursor_system_db: |
||
212 | cursor_system_db.close() |
||
213 | if cnx_system_db: |
||
214 | cnx_system_db.close() |
||
215 | |||
216 | #################################################################################################################### |
||
217 | # stop to the next store if this store is empty |
||
218 | #################################################################################################################### |
||
219 | if (meter_list is None or len(meter_list) == 0) and \ |
||
220 | (virtual_meter_list is None or len(virtual_meter_list) == 0) and \ |
||
221 | (offline_meter_list is None or len(offline_meter_list) == 0): |
||
222 | print("This is an empty store ") |
||
223 | return None |
||
224 | |||
225 | #################################################################################################################### |
||
226 | # Step 4: determine start datetime and end datetime to aggregate |
||
227 | #################################################################################################################### |
||
228 | print("Step 4: determine start datetime and end datetime to aggregate") |
||
229 | cnx_energy_db = None |
||
230 | cursor_energy_db = None |
||
231 | try: |
||
232 | cnx_energy_db = mysql.connector.connect(**config.myems_energy_db) |
||
233 | cursor_energy_db = cnx_energy_db.cursor() |
||
234 | except Exception as e: |
||
235 | error_string = "Error in step 4.1 of store_energy_input_item.worker " + str(e) |
||
236 | if cursor_energy_db: |
||
237 | cursor_energy_db.close() |
||
238 | if cnx_energy_db: |
||
239 | cnx_energy_db.close() |
||
240 | print(error_string) |
||
241 | return error_string |
||
242 | |||
243 | try: |
||
244 | query = (" SELECT MAX(start_datetime_utc) " |
||
245 | " FROM tbl_store_input_item_hourly " |
||
246 | " WHERE store_id = %s ") |
||
247 | cursor_energy_db.execute(query, (store['id'],)) |
||
248 | row_datetime = cursor_energy_db.fetchone() |
||
249 | start_datetime_utc = datetime.strptime(config.start_datetime_utc, '%Y-%m-%d %H:%M:%S') |
||
250 | start_datetime_utc = start_datetime_utc.replace(minute=0, second=0, microsecond=0, tzinfo=None) |
||
251 | |||
252 | if row_datetime is not None and len(row_datetime) > 0 and isinstance(row_datetime[0], datetime): |
||
253 | # replace second and microsecond with 0 |
||
254 | # note: do not replace minute in case of calculating in half hourly |
||
255 | start_datetime_utc = row_datetime[0].replace(second=0, microsecond=0, tzinfo=None) |
||
256 | # start from the next time slot |
||
257 | start_datetime_utc += timedelta(minutes=config.minutes_to_count) |
||
258 | |||
259 | end_datetime_utc = datetime.utcnow().replace(second=0, microsecond=0, tzinfo=None) |
||
260 | |||
261 | print("start_datetime_utc: " + start_datetime_utc.isoformat()[0:19] |
||
262 | + "end_datetime_utc: " + end_datetime_utc.isoformat()[0:19]) |
||
263 | |||
264 | except Exception as e: |
||
265 | error_string = "Error in step 4.2 of store_energy_input_item.worker " + str(e) |
||
266 | if cursor_energy_db: |
||
267 | cursor_energy_db.close() |
||
268 | if cnx_energy_db: |
||
269 | cnx_energy_db.close() |
||
270 | print(error_string) |
||
271 | return error_string |
||
272 | |||
273 | #################################################################################################################### |
||
274 | # Step 5: for each meter in list, get energy input data from energy database |
||
275 | #################################################################################################################### |
||
276 | energy_meter_hourly = dict() |
||
277 | try: |
||
278 | if meter_list is not None and len(meter_list) > 0: |
||
279 | for meter in meter_list: |
||
280 | meter_id = str(meter['id']) |
||
281 | |||
282 | query = (" SELECT start_datetime_utc, actual_value " |
||
283 | " FROM tbl_meter_hourly " |
||
284 | " WHERE meter_id = %s " |
||
285 | " AND start_datetime_utc >= %s " |
||
286 | " AND start_datetime_utc < %s " |
||
287 | " ORDER BY start_datetime_utc ") |
||
288 | cursor_energy_db.execute(query, (meter_id, start_datetime_utc, end_datetime_utc,)) |
||
289 | rows_energy_values = cursor_energy_db.fetchall() |
||
290 | if rows_energy_values is None or len(rows_energy_values) == 0: |
||
291 | energy_meter_hourly[meter_id] = None |
||
292 | else: |
||
293 | energy_meter_hourly[meter_id] = dict() |
||
294 | for row_energy_value in rows_energy_values: |
||
295 | energy_meter_hourly[meter_id][row_energy_value[0]] = row_energy_value[1] |
||
296 | except Exception as e: |
||
297 | error_string = "Error in step 5.1 of store_energy_input_item.worker " + str(e) |
||
298 | if cursor_energy_db: |
||
299 | cursor_energy_db.close() |
||
300 | if cnx_energy_db: |
||
301 | cnx_energy_db.close() |
||
302 | print(error_string) |
||
303 | return error_string |
||
304 | |||
305 | #################################################################################################################### |
||
306 | # Step 6: for each virtual meter in list, get energy input data from energy database |
||
307 | #################################################################################################################### |
||
308 | energy_virtual_meter_hourly = dict() |
||
309 | if virtual_meter_list is not None and len(virtual_meter_list) > 0: |
||
310 | try: |
||
311 | for virtual_meter in virtual_meter_list: |
||
312 | virtual_meter_id = str(virtual_meter['id']) |
||
313 | |||
314 | query = (" SELECT start_datetime_utc, actual_value " |
||
315 | " FROM tbl_virtual_meter_hourly " |
||
316 | " WHERE virtual_meter_id = %s " |
||
317 | " AND start_datetime_utc >= %s " |
||
318 | " AND start_datetime_utc < %s " |
||
319 | " ORDER BY start_datetime_utc ") |
||
320 | cursor_energy_db.execute(query, (virtual_meter_id, start_datetime_utc, end_datetime_utc,)) |
||
321 | rows_energy_values = cursor_energy_db.fetchall() |
||
322 | if rows_energy_values is None or len(rows_energy_values) == 0: |
||
323 | energy_virtual_meter_hourly[virtual_meter_id] = None |
||
324 | else: |
||
325 | energy_virtual_meter_hourly[virtual_meter_id] = dict() |
||
326 | for row_energy_value in rows_energy_values: |
||
327 | energy_virtual_meter_hourly[virtual_meter_id][row_energy_value[0]] = row_energy_value[1] |
||
328 | except Exception as e: |
||
329 | error_string = "Error in step 6.1 of store_energy_input_item.worker " + str(e) |
||
330 | if cursor_energy_db: |
||
331 | cursor_energy_db.close() |
||
332 | if cnx_energy_db: |
||
333 | cnx_energy_db.close() |
||
334 | print(error_string) |
||
335 | return error_string |
||
336 | |||
337 | #################################################################################################################### |
||
338 | # Step 7: for each offline meter in list, get energy input data from energy database |
||
339 | #################################################################################################################### |
||
340 | energy_offline_meter_hourly = dict() |
||
341 | if offline_meter_list is not None and len(offline_meter_list) > 0: |
||
342 | try: |
||
343 | for offline_meter in offline_meter_list: |
||
344 | offline_meter_id = str(offline_meter['id']) |
||
345 | |||
346 | query = (" SELECT start_datetime_utc, actual_value " |
||
347 | " FROM tbl_offline_meter_hourly " |
||
348 | " WHERE offline_meter_id = %s " |
||
349 | " AND start_datetime_utc >= %s " |
||
350 | " AND start_datetime_utc < %s " |
||
351 | " ORDER BY start_datetime_utc ") |
||
352 | cursor_energy_db.execute(query, (offline_meter_id, start_datetime_utc, end_datetime_utc,)) |
||
353 | rows_energy_values = cursor_energy_db.fetchall() |
||
354 | if rows_energy_values is None or len(rows_energy_values) == 0: |
||
355 | energy_offline_meter_hourly[offline_meter_id] = None |
||
356 | else: |
||
357 | energy_offline_meter_hourly[offline_meter_id] = dict() |
||
358 | for row_energy_value in rows_energy_values: |
||
359 | energy_offline_meter_hourly[offline_meter_id][row_energy_value[0]] = row_energy_value[1] |
||
360 | |||
361 | except Exception as e: |
||
362 | error_string = "Error in step 7.1 of store_energy_input_item.worker " + str(e) |
||
363 | if cursor_energy_db: |
||
364 | cursor_energy_db.close() |
||
365 | if cnx_energy_db: |
||
366 | cnx_energy_db.close() |
||
367 | print(error_string) |
||
368 | return error_string |
||
369 | |||
370 | #################################################################################################################### |
||
371 | # Step 8: determine common time slot to aggregate |
||
372 | #################################################################################################################### |
||
373 | |||
374 | common_start_datetime_utc = start_datetime_utc |
||
375 | common_end_datetime_utc = end_datetime_utc |
||
376 | |||
377 | print("Getting common time slot of energy values for all meters") |
||
378 | if energy_meter_hourly is not None and len(energy_meter_hourly) > 0: |
||
379 | for meter_id, energy_hourly in energy_meter_hourly.items(): |
||
380 | if energy_hourly is None or len(energy_hourly) == 0: |
||
381 | common_start_datetime_utc = None |
||
382 | common_end_datetime_utc = None |
||
383 | break |
||
384 | else: |
||
385 | if common_start_datetime_utc < min(energy_hourly.keys()): |
||
386 | common_start_datetime_utc = min(energy_hourly.keys()) |
||
387 | if common_end_datetime_utc > max(energy_hourly.keys()): |
||
388 | common_end_datetime_utc = max(energy_hourly.keys()) |
||
389 | |||
390 | print("Getting common time slot of energy values for all virtual meters") |
||
391 | if common_start_datetime_utc is not None and common_start_datetime_utc is not None: |
||
392 | if energy_virtual_meter_hourly is not None and len(energy_virtual_meter_hourly) > 0: |
||
393 | for meter_id, energy_hourly in energy_virtual_meter_hourly.items(): |
||
394 | if energy_hourly is None or len(energy_hourly) == 0: |
||
395 | common_start_datetime_utc = None |
||
396 | common_end_datetime_utc = None |
||
397 | break |
||
398 | else: |
||
399 | if common_start_datetime_utc < min(energy_hourly.keys()): |
||
400 | common_start_datetime_utc = min(energy_hourly.keys()) |
||
401 | if common_end_datetime_utc > max(energy_hourly.keys()): |
||
402 | common_end_datetime_utc = max(energy_hourly.keys()) |
||
403 | |||
404 | print("Getting common time slot of energy values for all offline meters") |
||
405 | if common_start_datetime_utc is not None and common_start_datetime_utc is not None: |
||
406 | if energy_offline_meter_hourly is not None and len(energy_offline_meter_hourly) > 0: |
||
407 | for meter_id, energy_hourly in energy_offline_meter_hourly.items(): |
||
408 | if energy_hourly is None or len(energy_hourly) == 0: |
||
409 | common_start_datetime_utc = None |
||
410 | common_end_datetime_utc = None |
||
411 | break |
||
412 | else: |
||
413 | if common_start_datetime_utc < min(energy_hourly.keys()): |
||
414 | common_start_datetime_utc = min(energy_hourly.keys()) |
||
415 | if common_end_datetime_utc > max(energy_hourly.keys()): |
||
416 | common_end_datetime_utc = max(energy_hourly.keys()) |
||
417 | |||
418 | if (energy_meter_hourly is None or len(energy_meter_hourly) == 0) and \ |
||
419 | (energy_virtual_meter_hourly is None or len(energy_virtual_meter_hourly) == 0) and \ |
||
420 | (energy_offline_meter_hourly is None or len(energy_offline_meter_hourly) == 0): |
||
421 | # There isn't any energy data |
||
422 | print("There isn't any energy data") |
||
423 | # continue the for store loop to the next store |
||
424 | print("continue the for store loop to the next store") |
||
425 | if cursor_energy_db: |
||
426 | cursor_energy_db.close() |
||
427 | if cnx_energy_db: |
||
428 | cnx_energy_db.close() |
||
429 | return None |
||
430 | |||
431 | print("common_start_datetime_utc: " + str(common_start_datetime_utc)) |
||
432 | print("common_end_datetime_utc: " + str(common_end_datetime_utc)) |
||
433 | |||
434 | #################################################################################################################### |
||
435 | # Step 9: aggregate energy data in the common time slot by energy items and hourly |
||
436 | #################################################################################################################### |
||
437 | |||
438 | print("Step 9: aggregate energy data in the common time slot by energy items and hourly") |
||
439 | aggregated_values = list() |
||
440 | try: |
||
441 | current_datetime_utc = common_start_datetime_utc |
||
442 | while common_start_datetime_utc is not None \ |
||
443 | and common_end_datetime_utc is not None \ |
||
444 | and current_datetime_utc <= common_end_datetime_utc: |
||
445 | aggregated_value = dict() |
||
446 | aggregated_value['start_datetime_utc'] = current_datetime_utc |
||
447 | aggregated_value['meta_data'] = dict() |
||
448 | |||
449 | if meter_list is not None and len(meter_list) > 0: |
||
450 | for meter in meter_list: |
||
451 | meter_id = str(meter['id']) |
||
452 | energy_item_id = meter['energy_item_id'] |
||
453 | actual_value = energy_meter_hourly[meter_id].get(current_datetime_utc, Decimal(0.0)) |
||
454 | aggregated_value['meta_data'][energy_item_id] = \ |
||
455 | aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value |
||
456 | |||
457 | if virtual_meter_list is not None and len(virtual_meter_list) > 0: |
||
458 | for virtual_meter in virtual_meter_list: |
||
459 | virtual_meter_id = str(virtual_meter['id']) |
||
460 | energy_item_id = virtual_meter['energy_item_id'] |
||
461 | actual_value = energy_virtual_meter_hourly[virtual_meter_id].get(current_datetime_utc, Decimal(0.0)) |
||
462 | aggregated_value['meta_data'][energy_item_id] = \ |
||
463 | aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value |
||
464 | |||
465 | if offline_meter_list is not None and len(offline_meter_list) > 0: |
||
466 | for offline_meter in offline_meter_list: |
||
467 | offline_meter_id = str(offline_meter['id']) |
||
468 | energy_item_id = offline_meter['energy_item_id'] |
||
469 | actual_value = energy_offline_meter_hourly[offline_meter_id].get(current_datetime_utc, Decimal(0.0)) |
||
470 | aggregated_value['meta_data'][energy_item_id] = \ |
||
471 | aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value |
||
472 | |||
473 | aggregated_values.append(aggregated_value) |
||
474 | |||
475 | current_datetime_utc += timedelta(minutes=config.minutes_to_count) |
||
476 | |||
477 | except Exception as e: |
||
478 | error_string = "Error in step 9 of store_energy_input_item.worker " + str(e) |
||
479 | if cursor_energy_db: |
||
480 | cursor_energy_db.close() |
||
481 | if cnx_energy_db: |
||
482 | cnx_energy_db.close() |
||
483 | print(error_string) |
||
484 | return error_string |
||
485 | |||
486 | #################################################################################################################### |
||
487 | # Step 10: save energy data to energy database |
||
488 | #################################################################################################################### |
||
489 | print("Step 10: save energy data to energy database") |
||
490 | |||
491 | if len(aggregated_values) > 0: |
||
492 | try: |
||
493 | add_values = (" INSERT INTO tbl_store_input_item_hourly " |
||
494 | " (store_id, " |
||
495 | " energy_item_id, " |
||
496 | " start_datetime_utc, " |
||
497 | " actual_value) " |
||
498 | " VALUES ") |
||
499 | |||
500 | for aggregated_value in aggregated_values: |
||
501 | for energy_item_id, actual_value in aggregated_value['meta_data'].items(): |
||
502 | add_values += " (" + str(store['id']) + "," |
||
503 | add_values += " " + str(energy_item_id) + "," |
||
504 | add_values += "'" + aggregated_value['start_datetime_utc'].isoformat()[0:19] + "'," |
||
505 | add_values += str(actual_value) + "), " |
||
506 | print("add_values:" + add_values) |
||
507 | # trim ", " at the end of string and then execute |
||
508 | cursor_energy_db.execute(add_values[:-2]) |
||
509 | cnx_energy_db.commit() |
||
510 | |||
511 | except Exception as e: |
||
512 | error_string = "Error in step 10.1 of store_energy_input_item.worker " + str(e) |
||
513 | print(error_string) |
||
514 | return error_string |
||
515 | finally: |
||
516 | if cursor_energy_db: |
||
517 | cursor_energy_db.close() |
||
518 | if cnx_energy_db: |
||
519 | cnx_energy_db.close() |
||
520 | else: |
||
521 | if cursor_energy_db: |
||
522 | cursor_energy_db.close() |
||
523 | if cnx_energy_db: |
||
524 | cnx_energy_db.close() |
||
525 |