mybuilder /
cronos-bundle
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 57 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 10 | public function getConfigTreeBuilder(): TreeBuilder |
||
| 11 | { |
||
| 12 | if (method_exists(TreeBuilder::class, 'getRootNode')) { |
||
| 13 | $treeBuilder = new TreeBuilder('my_builder_cronos'); |
||
| 14 | $rootNode = $treeBuilder->getRootNode(); |
||
| 15 | } else { |
||
| 16 | $treeBuilder = new TreeBuilder(); |
||
|
|
|||
| 17 | $rootNode = $treeBuilder->root('my_builder_cronos'); |
||
| 18 | } |
||
| 19 | |||
| 20 | $rootNode |
||
| 21 | ->children() |
||
| 22 | ->arrayNode('exporter') |
||
| 23 | ->addDefaultsIfNotSet() |
||
| 24 | ->children() |
||
| 25 | ->scalarNode('key') |
||
| 26 | ->isRequired() |
||
| 27 | ->cannotBeEmpty() |
||
| 28 | ->info('Unique key that wraps all the cron configured for the current application.') |
||
| 29 | ->example('my_symfony_app') |
||
| 30 | ->end() |
||
| 31 | ->scalarNode('mailto') |
||
| 32 | ->cannotBeEmpty() |
||
| 33 | ->info('Sets the default email address for all cron output to go to.') |
||
| 34 | ->example('[email protected]') |
||
| 35 | ->end() |
||
| 36 | ->scalarNode('path') |
||
| 37 | ->example('/usr/local/bin:/usr/bin:/bin') |
||
| 38 | ->info('Sets the path for all commands in the crontab.') |
||
| 39 | ->end() |
||
| 40 | ->scalarNode('executor') |
||
| 41 | ->cannotBeEmpty() |
||
| 42 | ->defaultValue('php') |
||
| 43 | ->example('php') |
||
| 44 | ->info('Allows you to specify a program that all commands should be passed to such as "/usr/local/bin/php".') |
||
| 45 | ->end() |
||
| 46 | ->scalarNode('console') |
||
| 47 | ->cannotBeEmpty() |
||
| 48 | ->defaultValue('%kernel.root_dir%/../bin/console') |
||
| 49 | ->example('%kernel.project_dir%/bin/console') |
||
| 50 | ->info('Allows you to specify the console that all commands should be passed to such as "bin/console".') |
||
| 51 | ->end() |
||
| 52 | ->scalarNode('shell') |
||
| 53 | ->cannotBeEmpty() |
||
| 54 | ->example('/bin/sh') |
||
| 55 | ->info('Allows you to specify which shell each program should be run with.') |
||
| 56 | ->end() |
||
| 57 | ->scalarNode('timezone') |
||
| 58 | ->example('Europe/Paris') |
||
| 59 | ->info('Allows you to add CRON_TZ which specifies the time zone specific for the cron table.') |
||
| 60 | ->end() |
||
| 61 | ->end() |
||
| 62 | ->end() |
||
| 63 | ->end(); |
||
| 64 | |||
| 65 | return $treeBuilder; |
||
| 66 | } |
||
| 67 | } |
||
| 68 |
Loading history...
This check looks for function calls that miss required arguments.