Issues in GenerateKeyPairCommand.php (master) - Issues in master - mvdstam/oauth2-server-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Issues (52)

Security Analysis 8 potential vulnerabilities

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation (7)

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection (1)

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Commands/GenerateKeyPairCommand.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Mvdstam\Oauth2ServerLaravel\Commands;

use Exception;
use Illuminate\Console\Command;

class GenerateKeyPairCommand extends Command
{

    /**
     * @var string
     */
    protected $signature = 'oauth2-server:generate-key-pair {passphrase?}';

    /**
     * @var string
     */
    protected $description = 'Generate a RSA keypair for use in your OAuth2 server';

    public function handle()
    {
        if (!($passphrase = $this->argument('passphrase'))) {
            $passphrase = $this->secret('Enter passphrase or leave empty (not recommended)');
        }

        $this->info('Creating storage directory...');
        $storagePath = storage_path('app/oauth2-server');
        if (!is_dir($storagePath) && !mkdir($storagePath, 0777, true)) {
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
            throw new Exception('Unable to create storage directory for oauth2 server');
        }

        $this->info('Generating keypair...');
        list($publicKey, $privateKey) = $this->getKeyPair($passphrase);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $publicKeyFile = $storagePath . DIRECTORY_SEPARATOR . 'public.pem';
        $privateKeyFile = $storagePath . DIRECTORY_SEPARATOR . 'private.pem';

        if (is_file($publicKeyFile) || is_file($privateKeyFile)) {
            throw new Exception('Unable to store keys files because they already exist on disk.');
        }

        $this->info('Storing keys...');
        if (!file_put_contents($publicKeyFile, $publicKey) || !file_put_contents($privateKeyFile, $privateKey)) {
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
            throw new Exception('Unable to write keys to file. Is the directory writable?');
        }

        $this->info('Keys generated succesfully!');
    }

    /**
     * @param string|null $passphrase
     * @return string[]
     */
    protected function getKeyPair($passphrase = null)
    {
        $config = [
            'digest_alg' => 'sha256',
            'private_key_bits' => 4096,
            'private_key_type' => OPENSSL_KEYTYPE_RSA,
        ];

        $keyPair = openssl_pkey_new($config);
        openssl_pkey_export($keyPair, $privateKey, $passphrase);

        return [
            openssl_pkey_get_details($keyPair)['key'],
            $privateKey
        ];
    }
}


1			<?php
2
3			namespace Mvdstam\Oauth2ServerLaravel\Commands;
4
5			use Exception;
6			use Illuminate\Console\Command;
7
8			class GenerateKeyPairCommand extends Command
9			{
10
11			/**
12			* @var string
13			*/
14			protected $signature = 'oauth2-server:generate-key-pair {passphrase?}';
15
16			/**
17			* @var string
18			*/
19			protected $description = 'Generate a RSA keypair for use in your OAuth2 server';
20
21			public function handle()
22			{
23			if (!($passphrase = $this->argument('passphrase'))) {
24			$passphrase = $this->secret('Enter passphrase or leave empty (not recommended)');
25			}
26
27			$this->info('Creating storage directory...');
28			$storagePath = storage_path('app/oauth2-server');
29			if (!is_dir($storagePath) && !mkdir($storagePath, 0777, true)) {
			0 ignored issues – show Security File Manipulation introduced 2017-05-21 11:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$storagePath` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. 1 path for user data to reach this point Read from `$_SERVER` in vendor/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php on line 20 Data is passed through array_replace() in vendor/Request.php on line 324 Data is passed through call_user_func() in vendor/Request.php on line 1936 `\Illuminate\Http\Request::create($url, 'GET', array(), array(), array(), $_SERVER)` is passed to Container::instance() in vendor/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php on line 20 Container::$instances is assigned in vendor/src/Illuminate/Container/Container.php on line 346 Tainted property Container::$instances is read in vendor/src/Illuminate/Container/Container.php on line 635 Container::make() returns tainted data in vendor/src/Illuminate/Foundation/helpers.php on line 106 app() returns tainted data in vendor/src/Illuminate/Foundation/helpers.php on line 759 storage_path() returns tainted data, and `$storagePath` is assigned in src/Commands/GenerateKeyPairCommand.php on line 28 General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
30			throw new Exception('Unable to create storage directory for oauth2 server');
31			}
32
33			$this->info('Generating keypair...');
34			list($publicKey, $privateKey) = $this->getKeyPair($passphrase);
			0 ignored issues – show Bug introduced 2017-05-21 10:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$passphrase` can also be of type `array`; however, `Mvdstam\Oauth2ServerLara...irCommand::getKeyPair()` does only seem to accept `string\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
35
36			$publicKeyFile = $storagePath . DIRECTORY_SEPARATOR . 'public.pem';
37			$privateKeyFile = $storagePath . DIRECTORY_SEPARATOR . 'private.pem';
38
39			if (is_file($publicKeyFile) \|\| is_file($privateKeyFile)) {
40			throw new Exception('Unable to store keys files because they already exist on disk.');
41			}
42
43			$this->info('Storing keys...');
44			if (!file_put_contents($publicKeyFile, $publicKey) \|\| !file_put_contents($privateKeyFile, $privateKey)) {
			0 ignored issues – show Security File Manipulation introduced 2017-05-21 11:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$publicKeyFile` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. 1 path for user data to reach this point Read from `$_SERVER` in vendor/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php on line 20 Data is passed through array_replace() in vendor/Request.php on line 324 Data is passed through call_user_func() in vendor/Request.php on line 1936 `\Illuminate\Http\Request::create($url, 'GET', array(), array(), array(), $_SERVER)` is passed to Container::instance() in vendor/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php on line 20 Container::$instances is assigned in vendor/src/Illuminate/Container/Container.php on line 346 Tainted property Container::$instances is read in vendor/src/Illuminate/Container/Container.php on line 635 Container::make() returns tainted data in vendor/src/Illuminate/Foundation/helpers.php on line 106 app() returns tainted data in vendor/src/Illuminate/Foundation/helpers.php on line 759 storage_path() returns tainted data, and `$storagePath` is assigned in src/Commands/GenerateKeyPairCommand.php on line 28 `$publicKeyFile` is assigned in src/Commands/GenerateKeyPairCommand.php on line 36 General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history... Security File Manipulation introduced 2017-05-21 11:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$privateKeyFile` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. 1 path for user data to reach this point Read from `$_SERVER` in vendor/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php on line 20 Data is passed through array_replace() in vendor/Request.php on line 324 Data is passed through call_user_func() in vendor/Request.php on line 1936 `\Illuminate\Http\Request::create($url, 'GET', array(), array(), array(), $_SERVER)` is passed to Container::instance() in vendor/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php on line 20 Container::$instances is assigned in vendor/src/Illuminate/Container/Container.php on line 346 Tainted property Container::$instances is read in vendor/src/Illuminate/Container/Container.php on line 635 Container::make() returns tainted data in vendor/src/Illuminate/Foundation/helpers.php on line 106 app() returns tainted data in vendor/src/Illuminate/Foundation/helpers.php on line 759 storage_path() returns tainted data, and `$storagePath` is assigned in src/Commands/GenerateKeyPairCommand.php on line 28 `$privateKeyFile` is assigned in src/Commands/GenerateKeyPairCommand.php on line 37 General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
45			throw new Exception('Unable to write keys to file. Is the directory writable?');
46			}
47
48			$this->info('Keys generated succesfully!');
49			}
50
51			/**
52			* @param string\|null $passphrase
53			* @return string[]
54			*/
55			protected function getKeyPair($passphrase = null)
56			{
57			$config = [
58			'digest_alg' => 'sha256',
59			'private_key_bits' => 4096,
60			'private_key_type' => OPENSSL_KEYTYPE_RSA,
61			];
62
63			$keyPair = openssl_pkey_new($config);
64			openssl_pkey_export($keyPair, $privateKey, $passphrase);
65
66			return [
67			openssl_pkey_get_details($keyPair)['key'],
68			$privateKey
69			];
70			}
71			}
72

mvdstam / oauth2-server-laravel

Issues (52)

Security Analysis 8 potential vulnerabilities

src/Commands/GenerateKeyPairCommand.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1 path for user data to reach this point

General Strategies to prevent injection

1 path for user data to reach this point

General Strategies to prevent injection

1 path for user data to reach this point

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like