Mvdstam\Oauth2ServerLaravel\Commands\CreateClientCommand

Complexity

Total Complexity

8

Size/Duplication

Total Lines	78
Duplicated Lines	28.21 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

17.24%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getClientId()	11	11	2
A	getClientSecret()	11	11	2
A	handle()	0	16	3

<?php


namespace Mvdstam\Oauth2ServerLaravel\Commands;


use Exception;
use Illuminate\Console\Command;
use Mvdstam\Oauth2ServerLaravel\Repositories\ClientRepository;
use Mvdstam\Oauth2ServerLaravel\Repositories\ScopeRepository;
use Ramsey\Uuid\Uuid;
use Ramsey\Uuid\UuidInterface;

class CreateClientCommand extends Command
{

    protected $signature = 'oauth2-server:create-client {--id=} {--secret=} {--name=} {--redirect_uri=} {--scope=*}';

    protected $description = 'Create new clients for your OAuth2 server';

    /**
     * @var ClientRepository
     */
    protected $clients;

    /**
     * @var ScopeRepository
     */
    protected $scopes;

    /**
     * CreateClientCommand constructor.
     * @param ClientRepository $clients
     * @param ScopeRepository $scopes
     */
    public function __construct(ClientRepository $clients, ScopeRepository $scopes)
    {
        parent::__construct();

        $this->clients = $clients;
        $this->scopes = $scopes;
    }

    public function handle()
    {
        try {
            $this->clients->forceCreate([

The method scopes() does not exist on Illuminate\Database\Eloquent\Model. Did you maybe mean getGlobalScopes()?

                'id' => (string) $this->getClientId(),
                'secret' => (string) $this->getClientSecret(),
                'name' => $this->option('name') ?: $this->ask('Please enter a name'),
                'redirect_uri' => $this->option('redirect_uri')
            ])->scopes()->sync($this->option('scope'));
        } catch (Exception $e) {
            $this->error("An error occurred: {$e->getMessage()}");
            return 1;
        }

        $this->info('Client created succesfully');
    }

    /**
     * @return UuidInterface
     */
    protected function getClientId()

This method seems to be duplicated in your project.

    {
        if (!($clientId = $this->option('id'))) {
            $this->info('Generating a random UUID for client id...');
            $clientId = Uuid::uuid1();
        } else {
            $clientId = Uuid::fromString($clientId);

It seems like $clientId defined by \Ramsey\Uuid\Uuid::fromString($clientId) on line 70 can also be of type array; however, Ramsey\Uuid\Uuid::fromString() does only seem to accept string, maybe add an additional type check?

        }

        return $clientId;
    }

    /**
     * @return UuidInterface
     */
    protected function getClientSecret()

This method seems to be duplicated in your project.

    {
        if (!($clientSecret = $this->option('secret'))) {
            $this->info('Generating a random UUID for client secret...');
            $clientSecret = Uuid::uuid1();
        } else {
            $clientSecret = Uuid::fromString($clientSecret);

It seems like $clientSecret defined by \Ramsey\Uuid\Uuid::fromString($clientSecret) on line 85 can also be of type array; however, Ramsey\Uuid\Uuid::fromString() does only seem to accept string, maybe add an additional type check?

        }

        return $clientSecret;
    }

}