Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
25 | class DownloaderTest extends TestCase |
||
26 | { |
||
27 | /** |
||
28 | * @var Downloader |
||
29 | */ |
||
30 | private $downloader; |
||
31 | |||
32 | /** |
||
33 | * @var Resource |
||
34 | */ |
||
35 | protected $resource; |
||
36 | |||
37 | /** |
||
38 | * @var string |
||
39 | */ |
||
40 | protected $html; |
||
41 | |||
42 | public function setUp() |
||
60 | |||
61 | /** |
||
62 | * @covers VDB\Spider\Downloader\Downloader::download() |
||
63 | * @covers VDB\Spider\Downloader\Downloader::getPersistenceHandler() |
||
64 | * @covers VDB\Spider\Downloader\Downloader::fetchResource() |
||
65 | * @covers VDB\Spider\Downloader\Downloader::getRequestHandler() |
||
66 | * @covers VDB\Spider\Downloader\Downloader::getRequestHandler() |
||
67 | */ |
||
68 | public function testDownload() |
||
73 | |||
74 | /** |
||
75 | * @covers VDB\Spider\Downloader\Downloader::download() |
||
76 | * @covers VDB\Spider\Downloader\Downloader::fetchResource() |
||
77 | * @covers VDB\Spider\Downloader\Downloader::getPersistenceHandler() |
||
78 | * @covers VDB\Spider\Downloader\Downloader::getRequestHandler() |
||
79 | * @covers VDB\Spider\Downloader\Downloader::setRequestHandler() |
||
80 | */ |
||
81 | View Code Duplication | public function testDownloadFailed() |
|
94 | |||
95 | /** |
||
96 | * @covers VDB\Spider\Downloader\Downloader::download() |
||
97 | * @covers VDB\Spider\Downloader\Downloader::getRequestHandler() |
||
98 | * @covers VDB\Spider\Downloader\Downloader::getPersistenceHandler() |
||
99 | * @covers VDB\Spider\Downloader\Downloader::matchesPostfetchFilter() |
||
100 | * @covers VDB\Spider\Downloader\Downloader::fetchResource() |
||
101 | * @covers VDB\Spider\Downloader\Downloader::addPostFetchFilter() |
||
102 | */ |
||
103 | View Code Duplication | public function testFilterNotMatches() |
|
116 | |||
117 | /** |
||
118 | * @covers VDB\Spider\Downloader\Downloader::download() |
||
119 | * @covers VDB\Spider\Downloader\Downloader::getPersistenceHandler() |
||
120 | * @covers VDB\Spider\Downloader\Downloader::getRequestHandler() |
||
121 | * @covers VDB\Spider\Downloader\Downloader::matchesPostfetchFilter() |
||
122 | * @covers VDB\Spider\Downloader\Downloader::fetchResource() |
||
123 | * @covers VDB\Spider\Downloader\Downloader::addPostFetchFilter() |
||
124 | */ |
||
125 | View Code Duplication | public function testFilterMatches() |
|
138 | } |
||
139 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.