mvdbos / php-spider

src/VDB/Spider/Discoverer/Discoverer.php

<?php

namespace VDB\Spider\Discoverer;

use VDB\Spider\Resource;
use VDB\Spider\Uri\DiscoveredUri;

/**
 * @author Matthijs van den Bos
 * @copyright 2013 Matthijs van den Bos
 */
abstract class Discoverer
{
    /** @var DiscovererSet */
    protected $discovererSet;

    /**
     * @param DiscovererSet $discovererSet

Should the type for parameter $discovererSet not be null|DiscovererSet?

     */
    public function setDiscovererSet(DiscovererSet $discovererSet = null)
    {
        $this->discovererSet = $discovererSet;
    }

    public function getName()
    {
        return get_class($this);
    }

    abstract public function discover(Resource $resource);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

}