GuzzleRequestHandler::getClient() - Code Metrics - Inspection of "Simplified deps and upgraded to Guzzle 6" - mvdbos/php-spider - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#26)

by Matthijs

created 2016-01-03 10:27 UTC

GuzzleRequestHandler::getClient() A

↳ Parent: GuzzleRequestHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	8
rs	9.4286
cc	2
eloc	4
nc	2
nop	0

<?php
namespace VDB\Spider\RequestHandler;

use GuzzleHttp\Client;
use GuzzleHttp\HandlerStack;
use GuzzleHttp\Message\Request;
use GuzzleHttp\Message\RequestInterface;
use VDB\Spider\RequestHandler\RequestHandlerInterface;
use VDB\Spider\Resource;
use VDB\Spider\Uri\DiscoveredUri;

/**
 * @author Matthijs van den Bos <[email protected]>
 * @copyright 2013 Matthijs van den Bos
 */
class GuzzleRequestHandler implements RequestHandlerInterface
{
    /** @var Client */
    private $client;

    /** @var HandlerStack */
    private $handlerStack;

    /**
     * @param HandlerStack $handlerStack
     * @return RequestHandlerInterface
     */
    public function setHandlerStack(HandlerStack $handlerStack)
    {
        $this->handlerStack = $handlerStack;

        return $this;
    }

    /**
     * @return HandlerStack
     */
    public function getHandlerStack()
    {
        if (!$this->handlerStack) {
            $this->handlerStack = HandlerStack::create();
        }

        return $this->handlerStack;
    }

    /**
     * @param Client $client
     * @return RequestHandlerInterface
     */
    public function setClient(Client $client)
    {
        $this->client = $client;

        return $this;
    }

    /**
     * @return Client
     */
    public function getClient()
    {
        if (!$this->client) {
            $this->client = new Client(['config' => $this->getHandlerStack()]);
        }

        return $this->client;
    }

    /**
     * @param DiscoveredUri $uri
     * @return Resource
     */
    public function request(DiscoveredUri $uri)
    {
        $response = $this->getClient()->get($uri->toString());
        return new Resource($uri, $response);
    }
}


1			<?php
2			namespace VDB\Spider\RequestHandler;
3
4			use GuzzleHttp\Client;
5			use GuzzleHttp\HandlerStack;
6			use GuzzleHttp\Message\Request;
7			use GuzzleHttp\Message\RequestInterface;
8			use VDB\Spider\RequestHandler\RequestHandlerInterface;
9			use VDB\Spider\Resource;
10			use VDB\Spider\Uri\DiscoveredUri;
11
12			/**
13			* @author Matthijs van den Bos <[email protected]>
14			* @copyright 2013 Matthijs van den Bos
15			*/
16			class GuzzleRequestHandler implements RequestHandlerInterface
17			{
18			/** @var Client */
19			private $client;
20
21			/** @var HandlerStack */
22			private $handlerStack;
23
24			/**
25			* @param HandlerStack $handlerStack
26			* @return RequestHandlerInterface
27			*/
28			public function setHandlerStack(HandlerStack $handlerStack)
29			{
30			$this->handlerStack = $handlerStack;
31
32			return $this;
33			}
34
35			/**
36			* @return HandlerStack
37			*/
38			public function getHandlerStack()
39			{
40			if (!$this->handlerStack) {
41			$this->handlerStack = HandlerStack::create();
42			}
43
44			return $this->handlerStack;
45			}
46
47			/**
48			* @param Client $client
49			* @return RequestHandlerInterface
50			*/
51			public function setClient(Client $client)
52			{
53			$this->client = $client;
54
55			return $this;
56			}
57
58			/**
59			* @return Client
60			*/
61			public function getClient()
62			{
63			if (!$this->client) {
64			$this->client = new Client(['config' => $this->getHandlerStack()]);
65			}
66
67			return $this->client;
68			}
69
70			/**
71			* @param DiscoveredUri $uri
72			* @return Resource
73			*/
74			public function request(DiscoveredUri $uri)
75			{
76			$response = $this->getClient()->get($uri->toString());
77			return new Resource($uri, $response);
78			}
79			}
80

mvdbos / php-spider

Pull Request — master (#26)

GuzzleRequestHandler::getClient() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like