CrawlerDiscoverer::discover() - Code Metrics - Inspection of "Merge pull request #19 from mvdbos/feature/remove-..." - mvdbos/php-spider - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( db69bb...88bf51 )

by Matthijs

created 2015-12-30 01:13 UTC

CrawlerDiscoverer::discover() A

↳ Parent: CrawlerDiscoverer

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4286
cc	3
eloc	8
nc	3
nop	1

<?php
namespace VDB\Spider\Discoverer;

use Symfony\Component\DomCrawler\Crawler;
use VDB\Spider\Discoverer\DiscovererInterface;
use VDB\Spider\Discoverer\Discoverer;
use VDB\Spider\Resource;
use VDB\Uri\Exception\UriSyntaxException;
use VDB\Uri\Uri;
use VDB\Spider\Uri\DiscoveredUri;
use VDB\Uri\UriInterface;

/**
 * @author Matthijs van den Bos
 * @copyright 2013 Matthijs van den Bos
 */
abstract class CrawlerDiscoverer extends Discoverer implements DiscovererInterface
{
    /** @var string */
    protected $selector;

    /**
     * @param $selector
     */
    public function __construct($selector)
    {
        $this->selector = $selector;
    }

    /**
     * @return Crawler
     */
    abstract protected function getFilteredCrawler(Resource $resource);

    /**
     * @param Resource $resource
     * @return DiscoveredUri[]
     */
    public function discover(Resource $resource)
    {
        $crawler = $this->getFilteredCrawler($resource);

        $uris = array();
        foreach ($crawler as $node) {
            try {
                $uris[] = new DiscoveredUri(new Uri($node->getAttribute('href'), $resource->getUri()->toString()));
            } catch (UriSyntaxException $e) {
                // do nothing. We simply ignore invalid URI's
            }
        }
        return $uris;
    }
}


1			<?php
2			namespace VDB\Spider\Discoverer;
3
4			use Symfony\Component\DomCrawler\Crawler;
5			use VDB\Spider\Discoverer\DiscovererInterface;
6			use VDB\Spider\Discoverer\Discoverer;
7			use VDB\Spider\Resource;
8			use VDB\Uri\Exception\UriSyntaxException;
9			use VDB\Uri\Uri;
10			use VDB\Spider\Uri\DiscoveredUri;
11			use VDB\Uri\UriInterface;
12
13			/**
14			* @author Matthijs van den Bos
15			* @copyright 2013 Matthijs van den Bos
16			*/
17			abstract class CrawlerDiscoverer extends Discoverer implements DiscovererInterface
18			{
19			/** @var string */
20			protected $selector;
21
22			/**
23			* @param $selector
24			*/
25			public function __construct($selector)
26			{
27			$this->selector = $selector;
28			}
29
30			/**
31			* @return Crawler
32			*/
33			abstract protected function getFilteredCrawler(Resource $resource);
34
35			/**
36			* @param Resource $resource
37			* @return DiscoveredUri[]
38			*/
39			public function discover(Resource $resource)
40			{
41			$crawler = $this->getFilteredCrawler($resource);
42
43			$uris = array();
44			foreach ($crawler as $node) {
45			try {
46			$uris[] = new DiscoveredUri(new Uri($node->getAttribute('href'), $resource->getUri()->toString()));
47			} catch (UriSyntaxException $e) {
48			// do nothing. We simply ignore invalid URI's
49			}
50			}
51			return $uris;
52			}
53			}
54

mvdbos / php-spider

Push — master ( db69bb...88bf51 )

CrawlerDiscoverer::discover() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like