mvc5 / mvc5

src/Exception/Base.php

<?php
/**
 *
 */

namespace Mvc5\Exception;

use Mvc5\Arg;
use Mvc5\Exception as _Exception;

trait Base
{
    /**
     * @param mixed|\Throwable $exception
     * @param int $offset
     * @return \Throwable
     */
    protected static function backtrace(\Throwable $exception, $offset = 2)
    {
        $offset && ($origin = $exception->getTrace()[$offset]) && isset($origin[Arg::FILE])
            && ($exception->file = $origin[Arg::FILE]) && ($exception->line = $origin[Arg::LINE]);

Accessing file on the interface Throwable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing line on the interface Throwable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return static::offset($exception, $offset);
    }

    /**
     * @param string $exception
     * @param array|string $params
     * @param int $offset
     * @return \Throwable
     */
    protected static function create($exception, $params = [], $offset = 2)
    {
        return static::backtrace(static::instance($exception, (array) $params), $offset);
    }

    /**
     * @param string $exception
     * @param array $params
     * @return \Throwable
     */
    protected static function instance($exception, array $params = [])
    {
        return new $exception(...$params);
    }

    /**
     * @param $exception
     * @param int $offset
     * @return \Throwable
     */
    protected static function offset($exception, $offset = 1)
    {
        $offset && $exception->offset = $offset;

        return $exception;
    }

    /**
     * @param $exception
     * @return mixed
     * @throws \Throwable
     */
    static function raise(\Throwable $exception)
    {
        throw $exception;
    }
}