Issues in Action.php - All Issues - Inspection of "Merge pull request #84 from devosc/master" - mvc5/mvc5 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f172d4...76e139 )

by devosc

created 2016-12-21 05:21 UTC

All Issues
New 1

src/Controller/Action.php (1 issue)

Labels

Best Practice 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 */

namespace Mvc5\Controller;

use Mvc5\Plugins\Service;

class Action
{
    /**
     *
     */
    use Service;

    /**
     * @param $controller
     * @param array $args
     * @return mixed
     */
    function __invoke($controller = null, array $args = [])

    {
        return $controller ? $this->call($controller, $args) : null;
    }
}


1		<?php
2		/**
3		*
4		*/
5
6		namespace Mvc5\Controller;
7
8		use Mvc5\Plugins\Service;
9
10		class Action
11		{
12		/**
13		*
14		*/
15		use Service;
16
17		/**
18		* @param $controller
19		* @param array $args
20		* @return mixed
21		*/
22	2	function __invoke($controller = null, array $args = [])
		0 ignored issues – show Best Practice introduced 2016-05-26 17:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
23		{
24	2	return $controller ? $this->call($controller, $args) : null;
25		}
26		}
27

mvc5 / mvc5

Push — master ( f172d4...76e139 )

src/Controller/Action.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like