These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | /** |
||
3 | * |
||
4 | */ |
||
5 | |||
6 | namespace Mvc5\Config; |
||
7 | |||
8 | trait Iterator |
||
9 | { |
||
10 | /** |
||
11 | * @return int |
||
12 | */ |
||
13 | 2 | function count() |
|
0 ignored issues
–
show
|
|||
14 | { |
||
15 | /** @var Config $this */ |
||
16 | 2 | return count($this->config); |
|
0 ignored issues
–
show
The property
$config is declared protected in Mvc5\Config\Config . Since you implemented __get() , maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
17 | } |
||
18 | |||
19 | /** |
||
20 | * @return mixed |
||
21 | */ |
||
22 | 27 | function current() |
|
0 ignored issues
–
show
|
|||
23 | { |
||
24 | /** @var Config $this */ |
||
25 | 27 | return is_array($this->config) ? current($this->config) : $this->config->current(); |
|
0 ignored issues
–
show
The property
$config is declared protected in Mvc5\Config\Config . Since you implemented __get() , maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
26 | } |
||
27 | |||
28 | /** |
||
29 | * @return mixed |
||
30 | */ |
||
31 | 24 | function key() |
|
0 ignored issues
–
show
|
|||
32 | { |
||
33 | /** @var Config $this */ |
||
34 | 24 | return is_array($this->config) ? key($this->config) : $this->config->key(); |
|
0 ignored issues
–
show
The property
$config is declared protected in Mvc5\Config\Config . Since you implemented __get() , maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
35 | } |
||
36 | |||
37 | /** |
||
38 | * |
||
39 | */ |
||
40 | 23 | function next() |
|
0 ignored issues
–
show
|
|||
41 | { |
||
42 | /** @var Config $this */ |
||
43 | 23 | is_array($this->config) ? next($this->config) : $this->config->next(); |
|
0 ignored issues
–
show
The property
$config is declared protected in Mvc5\Config\Config . Since you implemented __get() , maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
44 | 23 | } |
|
45 | |||
46 | /** |
||
47 | * |
||
48 | */ |
||
49 | 21 | function rewind() |
|
0 ignored issues
–
show
|
|||
50 | { |
||
51 | /** @var Config $this */ |
||
52 | 21 | is_array($this->config) ? reset($this->config) : $this->config->rewind(); |
|
0 ignored issues
–
show
The property
$config is declared protected in Mvc5\Config\Config . Since you implemented __get() , maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
53 | 21 | } |
|
54 | |||
55 | /** |
||
56 | * @return bool |
||
57 | */ |
||
58 | 21 | function valid() |
|
0 ignored issues
–
show
|
|||
59 | { |
||
60 | /** @var Config $this */ |
||
61 | 21 | return is_array($this->config) ? null !== $this->key() : $this->config->valid(); |
|
0 ignored issues
–
show
The property
$config is declared protected in Mvc5\Config\Config . Since you implemented __get() , maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
62 | } |
||
63 | } |
||
64 |
Adding explicit visibility (
private
,protected
, orpublic
) is generally recommend to communicate to other developers how, and from where this method is intended to be used.