Issues in ArrayAccess.php - All Issues - Inspection of "Merge pull request #84 from devosc/master" - mvc5/mvc5 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f172d4...76e139 )

by devosc

created 2016-12-21 05:21 UTC

src/Config/ArrayAccess.php (8 issues)

Labels

Best Practice 8

Severity

Minor 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 */

namespace Mvc5\Config;

trait ArrayAccess
{
    /**
     * @param string $name
     * @return mixed
     */
    abstract function get($name);


    /**
     * @param string $name
     * @return bool
     */
    abstract function has($name);


    /**
     * @param mixed $name
     * @return bool
     */
    function offsetExists($name)

    {
        return $this->has($name);
    }

    /**
     * @param mixed $name
     * @return mixed
     */
    function offsetGet($name)

    {
        return $this->get($name);
    }

    /**
     * @param mixed $name
     * @param mixed $value
     * @return mixed $value
     */
    function offsetSet($name, $value)

    {
        return $this->set($name, $value);
    }

    /**
     * @param mixed $name
     */
    function offsetUnset($name)

    {
        $this->remove($name);
    }

    /**
     * @param string $name
     * @return void
     */
    abstract function remove($name);


    /**
     * @param string $name
     * @param mixed $value
     * @return mixed
     */
    abstract function set($name, $value);

}


1		<?php
2		/**
3		*
4		*/
5
6		namespace Mvc5\Config;
7
8		trait ArrayAccess
9		{
10		/**
11		* @param string $name
12		* @return mixed
13		*/
14		abstract function get($name);
		0 ignored issues – show Best Practice introduced 2016-05-02 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
15
16		/**
17		* @param string $name
18		* @return bool
19		*/
20		abstract function has($name);
		0 ignored issues – show Best Practice introduced 2016-05-02 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
21
22		/**
23		* @param mixed $name
24		* @return bool
25		*/
26	48	function offsetExists($name)
		0 ignored issues – show Best Practice introduced 2016-05-02 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
27		{
28	48	return $this->has($name);
29		}
30
31		/**
32		* @param mixed $name
33		* @return mixed
34		*/
35	284	function offsetGet($name)
		0 ignored issues – show Best Practice introduced 2016-05-02 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
36		{
37	284	return $this->get($name);
38		}
39
40		/**
41		* @param mixed $name
42		* @param mixed $value
43		* @return mixed $value
44		*/
45	132	function offsetSet($name, $value)
		0 ignored issues – show Best Practice introduced 2016-05-02 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
46		{
47	132	return $this->set($name, $value);
48		}
49
50		/**
51		* @param mixed $name
52		*/
53	3	function offsetUnset($name)
		0 ignored issues – show Best Practice introduced 2016-05-02 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
54		{
55	3	$this->remove($name);
56	3	}
57
58		/**
59		* @param string $name
60		* @return void
61		*/
62		abstract function remove($name);
		0 ignored issues – show Best Practice introduced 2016-05-02 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
63
64		/**
65		* @param string $name
66		* @param mixed $value
67		* @return mixed
68		*/
69		abstract function set($name, $value);
		0 ignored issues – show Best Practice introduced 2016-05-02 20:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
70		}
71

mvc5 / mvc5

Push — master ( f172d4...76e139 )

src/Config/ArrayAccess.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like