mushti / request

src/Components/Body.php

<?php

namespace Raptor\Request\Components;

class Body
{
    /**
     * Request body parameters ($_POST).
     *
     * @var array
     */
    protected $param;

    /**
     * Uploaded files ($_FILES).
     *
     * @var array
     */
    protected $files;

    /**
     * Content length ($_SERVER['CONTENT_LENGTH']).
     *
     * @var array
     */
    protected $contentLength;

    /**
     * Content type ($_SERVER['CONTENT_TYPE']).
     *
     * @var array
     */
    protected $contentType;

    /**
     * Get request body parameters.
     *
     * @param  string $key (optional)
     * @param  mixed $default (optional)
     * @return  mixed
     */
    public function param($key = null, $default = null)
    {
        if ($this->param === null) {
            $this->param = $_POST;
            if (
                isset($_SERVER['CONTENT_TYPE']) && 
                $_SERVER['CONTENT_TYPE'] === 'application/x-www-form-urlencoded'
            ) {
                parse_str(file_get_contents("php://input"), $this->param);

$this->param of type void is incompatible with the type array|null expected by parameter $arr of parse_str().

            }
        }
        if ($key === null) {
            return $this->param;
        }
        return isset($this->param[$key]) ? $this->param[$key] : $default;
    }

    /**
     * Get uploaded files.
     *
     * @param  string $key (optional)
     * @return  array
     */
    public function files($key = null)
    {
        if ($this->files === null) {
            $this->files = $_FILES;
        }
        if ($key === null) {
            return $this->files;
        }
        return isset($this->files[$key]) ? $this->files[$key] : null;
    }

    /**
     * Get the content length.
     *
     * @return int
     */
    public function contentLength()
    {
        if ($this->contentLength) {

The expression $this->contentLength of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->contentLength;

The expression return $this->contentLength returns the type array which is incompatible with the documented return type integer.

        }
        return $this->contentLength = isset($_SERVER['CONTENT_LENGTH']) ? (int) $_SERVER['CONTENT_LENGTH'] : null;

It seems like IssetNode ? (int)$_SERVER['CONTENT_LENGTH'] : null can also be of type integer. However, the property $contentLength is declared as type array. Maybe add an additional type check?

    }

    /**
     * Get the content type.
     *
     * @return string
     */
    public function contentType()
    {
        if ($this->contentType) {

The expression $this->contentType of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->contentType;

The expression return $this->contentType returns the type array which is incompatible with the documented return type string.

        }
        return $this->contentType = isset($_SERVER['CONTENT_TYPE']) ? $_SERVER['CONTENT_TYPE'] : null;
    }
}