murrant / librenmsv2

app/Http/Controllers/DeviceController.php

<?php

namespace App\Http\Controllers;

use App\DataTables\DeviceDataTable;
use App\Models\Device;
use App\Models\DeviceGroup;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class DeviceController extends Controller
{
    use Helpers;

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(DeviceDataTable $dataTable, $group_id = -1)
    {
        $group_name = "";
        if ($group_id >= 0) {
            $dataTable->addScope(new \App\DataTables\Scopes\DeviceGroup($group_id));
            $group_name = DeviceGroup::find($group_id)->name;
        }

        return $dataTable->render('devices.list', compact('group_name'));
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function create()
    {
        // add new device form
        return view('devices.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $request)
    {
        // save device

        $this->validate($request, [
            'hostname'        => 'required|unique:devices|max:128',
            'snmpver'         => 'required|alpha_num|max:4',
            'transport'       => 'required|alpha_num|max:16',
            'port_assoc_mode' => 'required|alpha',
            'community'       => 'required_if:snmpver,v1,v2c|max:255',
            'authlevel'       => 'required_if:snmpver,v3|alpha|max:15',
            'authname'        => 'required_if:authlevel,authNoPriv|max:64',
            'authalgo'        => 'required_if:authlevel,authNoPriv|in:MD5,SHA|max:3',
            'cryptopass'      => 'required_if:authlevel,authPriv|max:64',
            'cryptoalgo'      => 'required_if:authlevel,authPriv|in:AES,DES|max:3',
        ]);
        return redirect()->route('devices.index');
    }

    /**
     * Display the specified resource.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  int $id
     * @param string $page
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function show(Request $request, $id, $page = 'overview')
    {
        $device = Device::find($id);
        $device_url = url('devices/'.$device->device_id);

        $page_setup['navbar'] = [

$page_setup was never initialized. Although not strictly required by PHP, it is generally a good practice to add $page_setup = array(); before regardless.

            'Overview' => $device_url,
            'Graphs'   => $device_url . '/graphs',
            'Health'   => $device_url . '/health',
        ];
        return view('devices.show', compact(['device', 'page_setup', 'request', 'page']));
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function edit($id)
    {
        //edit device form??
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function update(Request $request, $id)
    {
        //process device modify
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function destroy($id)
    {
        // delete device
    }
}