PortController::__construct() - Code Metrics - Inspection of "Merge pull request #138 from murrant/route_cleanup" - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 744b64...0d51b0 )

by Tony

created 2016-05-27 17:49 UTC

PortController::__construct() A

↳ Parent: PortController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Metric	Value
dl	0
loc	3
ccs	0
cts	3
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace App\Http\Controllers;

use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class PortController extends Controller
{
    use Helpers;

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response

     */
    public function index()
    {
        $api = $this->api->be(auth()->user());

        $ports = $api->get('/api/ports?include=device');

        return view('ports.list', ['ports'=>$ports]);
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

     */
    public function show($id)
    {
        // show a single device
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

     */
    public function edit($id)
    {
        //edit device form??
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response

     */
    public function update(Request $request, $id)
    {
        //process device modify
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Dingo\Api\Http;
6			use Dingo\Api\Routing\Helpers;
7			use Illuminate\Http\Request;
8
9			class PortController extends Controller
10			{
11			use Helpers;
12
13			/**
14			* Display a listing of the resource.
15			*
16			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-04-13 21:28 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
17			*/
18			public function index()
19			{
20			$api = $this->api->be(auth()->user());
			0 ignored issues – show Bug introduced 2016-02-25 06:47 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
21			$ports = $api->get('/api/ports?include=device');
22
23			return view('ports.list', ['ports'=>$ports]);
24			}
25
26			/**
27			* Display the specified resource.
28			*
29			* @param int $id
30			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-04-13 21:28 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
31			*/
32			public function show($id)
33			{
34			// show a single device
35			}
36
37			/**
38			* Show the form for editing the specified resource.
39			*
40			* @param int $id
41			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-04-13 21:28 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
42			*/
43			public function edit($id)
44			{
45			//edit device form??
46			}
47
48			/**
49			* Update the specified resource in storage.
50			*
51			* @param \Illuminate\Http\Request $request
52			* @param int $id
53			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-04-13 21:28 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
54			*/
55			public function update(Request $request, $id)
56			{
57			//process device modify
58			}
59			}
60

librenms / librenmsv2

Push — master ( 744b64...0d51b0 )

PortController::__construct() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like