NotificationController::create() - Code Metrics - Inspection of "Clean up the routes" - murrant/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — route_cleanup ( fa8e4e )

by Tony

created 2016-05-25 05:13 UTC

NotificationController::create() A

↳ Parent: NotificationController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1

<?php

namespace App\Http\Controllers;

use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class NotificationController extends Controller
{
    use Helpers;

    /**
     * Display a listing of the resource.
     *
     * @param null $type
     * @return \Illuminate\Http\Response
     */
    public function index($type = null)
    {

        $notifications = $this->api->be(auth()->user())->get('/api/notifications/'.$type);

        if ($type === 'archive') {
            $page = '';
            $button = 'Notifications';
            $bg = 'maroon';
        }
        else {
            $page = 'archive';
            $button = 'Archive';
            $bg = 'blue';
        }

        return view('notifications.list', compact(['notifications', 'page', 'button', 'bg', "type"]));
    }

    /**
     * Update a notifications status.
     *
     * @param $id
     * @param $action
     * @return \Illuminate\Http\JsonResponse
     */
    public function update($id, $action)
    {
        return response()->json($this->api->be(auth()->user())->patch('/api/notifications/'.$id.'/'.$action));

    }

    /**
     * Create a new notification
     *
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function create(Request $request)
    {
        $this->validate($request, [
            'title' => 'required|unique:notifications|max:255',
            'body'  => 'required',
        ]);
        return response()->json($this->api->be(auth()->user())->put('/api/notifications', ['title' => $request->title, 'body' => $request->body]));

    }

}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Dingo\Api\Http;
6			use Dingo\Api\Routing\Helpers;
7			use Illuminate\Http\Request;
8
9			class NotificationController extends Controller
10			{
11			use Helpers;
12
13			/**
14			* Display a listing of the resource.
15			*
16			* @param null $type
17			* @return \Illuminate\Http\Response
18			*/
19			public function index($type = null)
20			{
21
22			$notifications = $this->api->be(auth()->user())->get('/api/notifications/'.$type);
			0 ignored issues – show Bug introduced 2016-04-12 02:05 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
23			if ($type === 'archive') {
24			$page = '';
25			$button = 'Notifications';
26			$bg = 'maroon';
27			}
28			else {
29			$page = 'archive';
30			$button = 'Archive';
31			$bg = 'blue';
32			}
33
34			return view('notifications.list', compact(['notifications', 'page', 'button', 'bg', "type"]));
35			}
36
37			/**
38			* Update a notifications status.
39			*
40			* @param $id
41			* @param $action
42			* @return \Illuminate\Http\JsonResponse
43			*/
44			public function update($id, $action)
45			{
46			return response()->json($this->api->be(auth()->user())->patch('/api/notifications/'.$id.'/'.$action));
			0 ignored issues – show Bug introduced 2016-04-12 02:05 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
47			}
48
49			/**
50			* Create a new notification
51			*
52			* @param Request $request
53			* @return \Illuminate\Http\JsonResponse
54			*/
55			public function create(Request $request)
56			{
57			$this->validate($request, [
58			'title' => 'required\|unique:notifications\|max:255',
59			'body' => 'required',
60			]);
61			return response()->json($this->api->be(auth()->user())->put('/api/notifications', ['title' => $request->title, 'body' => $request->body]));
			0 ignored issues – show Bug introduced 2016-04-12 02:05 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
62			}
63
64			}
65

murrant / librenmsv2

Push — route_cleanup ( fa8e4e )

NotificationController::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like