App\Console\Commands\MigrateSettings

Complexity

Total Complexity

9

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	handle()	0	35	8

<?php

namespace App\Console\Commands;

use App\Models\DbConfig;
use Config;
use Illuminate\Console\Command;
use Settings;

class MigrateSettings extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'librenms:migrate-settings
    {--force} : Force the migration. WARNING: May lose some of your settings.
    {--dry-run} : Print changes that would be made, but do not commit them.';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Import settings from config.php that existed in the database previously into the database.  (The database now overrides config.php)';

    /**
     * Create a new command instance.
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        if (Settings::get('settings.migrated')) {
            $this->info(trans('commands.migrate-settings.migrated'));

It seems like trans('commands.migrate-settings.migrated') targeting trans() can also be of type object<Symfony\Component\Translation\TranslatorInterface>; however, Illuminate\Console\Command::info() does only seem to accept string, maybe add an additional type check?

            if (!$this->option('force')) {
                return;
            }
            $this->warn(trans('commands.migrate-settings.migrated_warning'));

It seems like trans('commands.migrate-settings.migrated_warning') targeting trans() can also be of type object<Symfony\Component\Translation\TranslatorInterface>; however, Illuminate\Console\Command::warn() does only seem to accept string, maybe add an additional type check?

        }

        $settings = DbConfig::pluck('config_name');

        foreach ($settings as $key) {
            $config_key = '_config.'.$key;

            if (Config::has($config_key)) {
                $old = Settings::get($key);
                $new = Config::get($config_key);

                if ($old !== $new) {
                    $this->info(trans('commands.migrate-settings.migrating', ['setting' => $key, 'old' => $old, 'new' => $new]));

It seems like trans('commands.migrate-settings.migrating', array('setting' => $key, 'old' => $old, 'new' => $new)) targeting trans() can also be of type object<Symfony\Component\Translation\TranslatorInterface>; however, Illuminate\Console\Command::info() does only seem to accept string, maybe add an additional type check?

                    if (!$this->option('dry-run')) {
                        // we aren't authenticated so we can't write through the Settings facade
                        DbConfig::updateOrCreate(['config_name' => $key], ['config_value' => $new]);

The method updateOrCreate() does not exist on App\Models\DbConfig. Did you maybe mean create()?

                    }
                }
            }
        }

        if (!$this->option('dry-run')) {
            Settings::flush();  // clear the settings cache
            DbConfig::updateOrCreate(['config_name' => 'settings.migrated'], ['config_value' => true]);

The method updateOrCreate() does not exist on App\Models\DbConfig. Did you maybe mean create()?

        }
    }
}