App\Api\Controllers\NotificationController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

22.58%

Importance

Changes	10
Bugs	3	Features	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	11	2
B	update()	0	22	5
A	create()	0	14	2

<?php

namespace App\Api\Controllers;

use App\Api\Transformers\NotificationTransformer;
use App\Models\Notification;
use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class NotificationController extends Controller
{

    use Helpers;

    /**
     * Display a listing of all notifications
     *
     * @param Request $request
     * @param null $type archive or null (all)
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request, $type = null)
    {
        if ($type === 'archive')
        {
            $notifications = Notification::isArchived($request->user())->get();

The method get does only exist in Illuminate\Database\Query\Builder, but not in App\Models\Notification.

        }
        else {
            $notifications = Notification::isUnread()->get();
        }
        return $this->response->collection($notifications, NotificationTransformer::class);
    }

    public function update(Request $request, $id, $action)

The parameter $request is not used and could be removed.

    {
        $notification = Notification::find($id);
        $enable = strpos($action, 'un') === false;
        if (!$enable) {
            $action = substr($action, 2);
        }

        if ($action == 'read') {
            $result = $notification->markRead($enable);
        }
        elseif ($action == 'sticky') {
            $result = $notification->markSticky(false);
        }

        if ($result === false) {

The variable $result does not seem to be defined for all execution paths leading up to this point.

            return $this->response->errorInternal();
        }
        else {
            return $this->response->array(array('statusText' => 'OK'));
        }
    }

    /**
     * Create a new notification
     *
     * @return \Illuminate\Http\Response
     */
    public function create(Request $request)
    {
        $notification = new Notification;
        $notification->title = $request->title;

The property title does not seem to exist in Illuminate\Http\Request.

        $notification->body = $request->body;

The property body does not seem to exist in Illuminate\Http\Request.

        $notification->checksum = hash('sha512', $request->user()->user_id.'.LOCAL.'.$request->title);
        $notification->source = $request->user()->user_id;
        if ($notification->save()) {
            return $this->response->array(array('statusText' => 'OK'));
        }
        else {
            return $this->response->errorInternal();
        }
    }

}