App\Http\Controllers\UserController::preferences()

Complexity

Conditions	5
Paths	8

Size

Total Lines	34
Code Lines	21

Duplication

Lines	0
Ratio	0 %

1 Method

Rating	Name	Duplication	Size	Complexity
A	UserController::index()	0	7	2

<?php

namespace App\Http\Controllers;

use App\DataTables\General\UserDataTable;
use App\Http\Requests\CreateUserRequest;
use App\Http\Requests\DeleteUserRequest;
use App\Http\Requests\UpdateUserRequest;
use App\Models\User;
use Auth;
use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class UserController extends Controller
{
    use Helpers;

    /**
     * Constructor
     */
    public function __construct(Request $request)

The parameter $request is not used and could be removed.

    {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @param UserDataTable $dataTable
     * @return \Illuminate\Http\Response
     */
    public function index(UserDataTable $dataTable)
    {
        if (Auth::user()->isAdmin()) {
            return $dataTable->render('users.manage');

The return type of return $dataTable->render('users.manage'); (Illuminate\Http\JsonResponse|Illuminate\View\View) is incompatible with the return type documented by App\Http\Controllers\UserController::index of type Illuminate\Http\Response.

        }
        return $this->edit(Auth::id());
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('users.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param CreateUserRequest $request
     * @return \Illuminate\Http\Response
     */
    public function store(CreateUserRequest $request)
    {
        $user = User::create($request->all());

        return response()->json(['message' => "User ".$user->username." created."]);
    }

    /**
     * Display the specified resource.
     *
     * @param  int $user_id
     * @return \Illuminate\Http\Response
     */
    public function show($user_id)
    {
        $user = User::with('devices', 'ports')->findOrFail($user_id);
        return view('users.preferences', ['updated' => false])->withUser($user);
        // show read only view of user info here
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $user_id
     * @return \Illuminate\Http\Response
     */
    public function edit($user_id)
    {
        $user = User::with('devices', 'ports')->findOrFail($user_id);

        if (Auth::user()->isAdmin()) {
            return view('users.edit')->withUser($user);
        }
    }

    /**
     * Update the specified resource in storage.
     *
     * @param UpdateUserRequest|Request $request
     * @param $user_id
     * @param $type Type of update info|password|adddevice|removedevice|addpor|removeport
     * @param  int $id

There is no parameter named $id. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(UpdateUserRequest $request, $user_id)
    {
        $user = User::find($user_id);
        $user->update($request->all());


        return redirect()->back()->with(['type' => 'success', 'message' => 'User '.$user->username.' updated.']);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $user_id
     * @return \Illuminate\Http\Response
     */
    public function destroy(DeleteUserRequest $request, $user_id)

The parameter $request is not used and could be removed.

    {
        $user = User::find($user_id);
        $user->delete();

        return response()->json(['message' => "User ".$user->username." deleted."]);
    }
}