App\DataTables\General\UserDataTable

Complexity

Total Complexity

4

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	ajax()	0	20	1
A	query()	0	5	1
A	getColumns()	0	17	1
A	filename()	0	4	1

<?php
/**
 * UsersDataTable.php
 *
 * Provide layout and data for the Users DataTable
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package    LibreNMS
 * @link       http://librenms.org
 * @copyright  2016 Tony Murray
 * @author     Tony Murray <murraytony@gmail.com>
 */

namespace App\DataTables\General;

use App\DataTables\BaseDataTable;
use App\Models\User;

class UserDataTable extends BaseDataTable
{
    /**
     * Display ajax response.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function ajax()
    {
        return $this->datatables
            ->eloquent($this->query())
            ->editColumn('level', function($user) {

function ($user) { return trans('user.level.' . $user->level); } is of type object<Closure>, but the function expects a string.

                return trans('user.level.'.$user->level);
            })
            ->editColumn('actions', function($user) {

function ($user) { $edit = '<a type="button" class="btn btn-xs btn-primary" href="' . route('users.edit', array('user_id' => $user->user_id)) . '"><i class="fa fa-edit fa-lg fa-fw"></i><span class="hidden-xs"> Edit</span></a> '; $delete = '<button type="button" class="btn btn-xs btn-danger userDeleteModal" data-toggle="modal" data-target="#deleteModal" data-href="' . route('users.destroy', array('user_id' => $user->user_id)) . '"><i class="fa fa-trash fa-lg fa-fw"></i><span class="hidden-xs"> Delete</span></button> '; return $edit . $delete; } is of type object<Closure>, but the function expects a string.

                $edit = '<a type="button" class="btn btn-xs btn-primary" href="'.
                    route('users.edit', ['user_id' => $user->user_id]).
                    '"><i class="fa fa-edit fa-lg fa-fw"></i><span class="hidden-xs"> Edit</span></a> ';

                $delete = '<button type="button" class="btn btn-xs btn-danger userDeleteModal" data-toggle="modal" data-target="#deleteModal" data-href="'.
                    route('users.destroy', ['user_id' => $user->user_id]).
                    '"><i class="fa fa-trash fa-lg fa-fw"></i><span class="hidden-xs"> Delete</span></button> ';

                return $edit.$delete;
            })
            ->make(true);
    }

    /**
     * Get the query object to be processed by datatables.
     *
     * @return \Illuminate\Database\Query\Builder|\Illuminate\Database\Eloquent\Builder
     */
    public function query()
    {
        $users = User::select('users.*');
        return $this->applyScopes($users);

The expression $this->applyScopes($users); of type Illuminate\Database\Query\Builder|Illuminate\Database\Eloquent\Builder adds the type Illuminate\Database\Query\Builder to the return on line 67 which is incompatible with the return type declared by the interface Yajra\Datatables\Contracts\DataTableContract::query of type Illuminate\Database\Eloquent\Builder.

    }

    /**
     * Get columns.
     *
     * @return array
     */
    public function getColumns()
    {
        return [
            'username' => [
                'title' => trans('user.text.username'),
            ],
            'realname' => [
                'title' => trans('user.text.realname'),
            ],
            'level'    => [
                'title' => trans('user.text.level'),
            ],
            'actions'  => [
                'title' => trans('user.text.actions'),
            ],
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'users';
    }
}