App\DataTables\General\IPv4DataTable

Complexity

Total Complexity

6

Size/Duplication

Total Lines	69
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	ajax()	14	14	3
A	query()	6	6	1
A	getColumns()	17	17	1
A	filename()	4	4	1

<?php
/**
 * app/DataTables/General/IPv4DataTable.php
 *
 * Datatable for ipv4 search
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package    LibreNMS
 * @link       http://librenms.org
 * @copyright  2016 Neil Lathwood
 * @author     Neil Lathwood <neil@lathwood.co.uk>
 */

namespace App\DataTables\General;

use App\DataTables\BaseDataTable;
use App\Models\General\IPv4;

class IPv4DataTable extends BaseDataTable

This class seems to be duplicated in your project.

{

    /**
     * Display ajax response.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function ajax()
    {
        return $this->datatables
            ->eloquent($this->query())
            ->editColumn('hostname', function($data) {

function ($data) { $hostname = is_null($data->device) ? trans('devices.text.deleted') : $data->device->hostname; return '<a href="' . url('devices/' . $data->device_id) . '">' . $hostname . '</a>'; } is of type object<Closure>, but the function expects a string.

                $hostname = is_null($data->device) ? trans('devices.text.deleted') : $data->device->hostname;
                return '<a href="'.url("devices/".$data->device_id).'">'.$hostname.'</a>';
            })
            ->editColumn('ifName', function($data) {

function ($data) { $ifName = is_null($data->ifName) ? trans('devices.text.deleted') : $data->ifName; return '<a href="' . url('devices/' . $data->device_id . '/ports/' . $data->port_id) . '">' . $ifName . '</a>'; } is of type object<Closure>, but the function expects a string.

                $ifName = is_null($data->ifName) ? trans('devices.text.deleted') : $data->ifName;
                return '<a href="'.url("devices/".$data->device_id."/ports/".$data->port_id).'">'.$ifName.'</a>';
            })
            ->make(true);
    }

    /**
     * Get the query object to be processed by datatables.
     *
     * @return \Illuminate\Database\Query\Builder|\Illuminate\Database\Eloquent\Builder
     */
    public function query()
    {
        $data = IPv4::join('ports', 'ports.port_id', '=', 'ipv4_addresses.port_id')->join('devices', 'devices.device_id', '=', 'ports.device_id')->select('ipv4_addresses.*', 'ports.*', 'devices.*');
        //FIXME We should use this once laravel-datatables supports it upstream $data = IPv4::with('port.device')->select('ipv4_addresses.*');
        return $this->applyScopes($data);

The expression $this->applyScopes($data); of type Illuminate\Database\Query\Builder|Illuminate\Database\Eloquent\Builder adds the type Illuminate\Database\Query\Builder to the return on line 63 which is incompatible with the return type declared by the interface Yajra\Datatables\Contracts\DataTableContract::query of type Illuminate\Database\Eloquent\Builder.

    }

    /**
     * Get columns.
     *
     * @return array
     */
    public function getColumns()
    {
        return [
            'hostname'  => [
                'title' => trans('devices.label.hostname'),
            ],
            'ifName'    => [
                'title' => trans('general.text.interface'),
            ],
            'ipv4_address' => [
                'title'    => trans('general.text.address'),
            ],
            'ifDescr'   => [
                'title' => trans('general.text.port_descr'),
            ],
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'ipv4';
    }

}