SyslogDataTable::ajax() - Code Metrics - Inspection of "Settings WIP" - murrant/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — settings-ui ( dc66cd...0a0011 )

by Tony

created 2016-05-12 02:46 UTC

SyslogDataTable::ajax() A

↳ Parent: SyslogDataTable

Complexity

Conditions	2
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	10
Ratio	100 %

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	10
loc	10
rs	9.4285
cc	2
eloc	7
nc	1
nop	0

<?php
/**
 * app/DataTables/General/SyslogDataTable.php
 *
 * Datatable for syslog
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package    LibreNMS
 * @link       http://librenms.org
 * @copyright  2016 Neil Lathwood
 * @author     Neil Lathwood <[email protected]>
 */

namespace App\DataTables\General;

use App\DataTables\BaseDataTable;
use App\Models\General\Syslog;

class SyslogDataTable extends BaseDataTable

{
    /**
     * Display ajax response.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function ajax()
    {
        return $this->datatables
            ->eloquent($this->query())
            ->editColumn('device.hostname', function($syslog) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $hostname = is_null($syslog->device) ? trans('devices.text.deleted') : $syslog->device->hostname;
                return '<a href="'.url("devices/".$syslog->device_id).'">'.$hostname.'</a>';
            })
            ->make(true);
    }

    /**
     * Get the query object to be processed by datatables.
     *
     * @return \Illuminate\Database\Query\Builder|\Illuminate\Database\Eloquent\Builder
     */
    public function query()
    {
        $syslog = Syslog::with('device')->select('syslog.*');
        return $this->applyScopes($syslog);

    }

    /**
     * Get columns.
     *
     * @return array
     */
    public function getColumns()
    {
        return [
            'device.hostname' => [
                'title'       => trans('devices.label.hostname'),
            ],
            'program'      => [
                'title' => trans('general.text.program'),
            ],
            'msg'   => [
                'title' => trans('general.text.message'),
            ],
            'timestamp'  => [
                'title' => trans('general.text.timestamp'),
            ],
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'syslog';
    }

    /**
     * Get ajax url.
     *
     * @return \Illuminate\Contracts\Routing\UrlGenerator|string
     */
    public function getAjax()
    {
        return url('syslog');

    }

}


1		<?php
2		/**
3		* app/DataTables/General/SyslogDataTable.php
4		*
5		* Datatable for syslog
6		*
7		* This program is free software: you can redistribute it and/or modify
8		* it under the terms of the GNU General Public License as published by
9		* the Free Software Foundation, either version 3 of the License, or
10		* (at your option) any later version.
11		*
12		* This program is distributed in the hope that it will be useful,
13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
15		* GNU General Public License for more details.
16		*
17		* You should have received a copy of the GNU General Public License
18		* along with this program. If not, see <http://www.gnu.org/licenses/>.
19		*
20		* @package LibreNMS
21		* @link http://librenms.org
22		* @copyright 2016 Neil Lathwood
23		* @author Neil Lathwood <[email protected]>
24		*/
25
26		namespace App\DataTables\General;
27
28		use App\DataTables\BaseDataTable;
29		use App\Models\General\Syslog;
30
31	View Code Duplication	class SyslogDataTable extends BaseDataTable
		0 ignored issues – show Duplication introduced 2016-04-27 02:12 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		/**
34		* Display ajax response.
35		*
36		* @return \Illuminate\Http\JsonResponse
37		*/
38		public function ajax()
39		{
40		return $this->datatables
41		->eloquent($this->query())
42		->editColumn('device.hostname', function($syslog) {
		0 ignored issues – show Documentation introduced 2016-04-27 19:41 UTC by Report Bug Copy Issue Report `function ($syslog) { .... $hostname . '</a>'; }` is of type `object<Closure>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43		$hostname = is_null($syslog->device) ? trans('devices.text.deleted') : $syslog->device->hostname;
44		return '<a href="'.url("devices/".$syslog->device_id).'">'.$hostname.'</a>';
45		})
46		->make(true);
47		}
48
49		/**
50		* Get the query object to be processed by datatables.
51		*
52		* @return \Illuminate\Database\Query\Builder\|\Illuminate\Database\Eloquent\Builder
53		*/
54		public function query()
55		{
56		$syslog = Syslog::with('device')->select('syslog.*');
57		return $this->applyScopes($syslog);
		0 ignored issues – show Bug Compatibility introduced 2016-04-27 02:12 UTC by Report Bug Copy Issue Report The expression `$this->applyScopes($syslog);` of type `Illuminate\Database\Quer...tabase\Eloquent\Builder` adds the type `Illuminate\Database\Query\Builder` to the return on line 57 which is incompatible with the return type declared by the interface `Yajra\Datatables\Contrac...ataTableContract::query` of type `Illuminate\Database\Eloquent\Builder`. Loading history...
58		}
59
60		/**
61		* Get columns.
62		*
63		* @return array
64		*/
65		public function getColumns()
66		{
67		return [
68		'device.hostname' => [
69		'title' => trans('devices.label.hostname'),
70		],
71		'program' => [
72		'title' => trans('general.text.program'),
73		],
74		'msg' => [
75		'title' => trans('general.text.message'),
76		],
77		'timestamp' => [
78		'title' => trans('general.text.timestamp'),
79		],
80		];
81		}
82
83		/**
84		* Get filename for export.
85		*
86		* @return string
87		*/
88		protected function filename()
89		{
90		return 'syslog';
91		}
92
93		/**
94		* Get ajax url.
95		*
96		* @return \Illuminate\Contracts\Routing\UrlGenerator\|string
97		*/
98		public function getAjax()
99		{
100		return url('syslog');
		0 ignored issues – show Bug Compatibility introduced 2016-05-11 15:32 UTC by Report Bug Copy Issue Report The expression `url('syslog');` of type `Illuminate\Contracts\Routing\UrlGenerator\|string` adds the type `Illuminate\Contracts\Routing\UrlGenerator` to the return on line 100 which is incompatible with the return type of the parent method `App\DataTables\BaseDataTable::getAjax` of type `string`. Loading history...
101		}
102
103		}
104

murrant / librenmsv2

Push — settings-ui ( dc66cd...0a0011 )

SyslogDataTable::ajax() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like