murrant /
librenmsv2
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 32 | View Code Duplication | class UserPortController extends Controller |
|
|
|
|||
| 33 | { |
||
| 34 | /** |
||
| 35 | * @param AdminOnlyRequest $request |
||
| 36 | * @param $user_id |
||
| 37 | * @return mixed |
||
| 38 | */ |
||
| 39 | public function create(AdminOnlyRequest $request, $user_id) |
||
|
1 ignored issue
–
show
|
|||
| 40 | { |
||
| 41 | $user = User::with('ports')->find($user_id); |
||
| 42 | return view('users.ports-create')->withUser($user); |
||
| 43 | } |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @param AdminOnlyRequest $request |
||
| 47 | * @param $user_id |
||
| 48 | * @param $port_id |
||
| 49 | * @return mixed |
||
| 50 | */ |
||
| 51 | public function store(AdminOnlyRequest $request, $user_id) |
||
| 52 | { |
||
| 53 | $user = User::find($user_id); |
||
| 54 | |||
| 55 | $port_ids = $request->input('ports'); |
||
| 56 | |||
| 57 | if (!is_array($port_ids) || count($port_ids) == 0) { |
||
| 58 | return redirect()->back(); |
||
| 59 | } |
||
| 60 | |||
| 61 | foreach ($port_ids as $port_id) { |
||
| 62 | $port = Port::find($port_id); |
||
| 63 | $user->ports()->attach($port); |
||
| 64 | } |
||
| 65 | return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.portsadded')]); |
||
| 66 | } |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @param AdminOnlyRequest $request |
||
| 70 | * @param $user_id |
||
| 71 | * @param $port_id |
||
| 72 | * @return mixed |
||
| 73 | */ |
||
| 74 | public function destroy(AdminOnlyRequest $request, $user_id, $port_id) |
||
| 81 | |||
| 82 | } |
||
| 83 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.