DashboardWidgetController - Code Metrics - Inspection of "Merge remote-tracking branch 'upstream/develop' in..." - murrant/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — misc ( 5d788f...8599dc )

by Tony

created 2016-04-16 03:27 UTC

DashboardWidgetController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	133
Duplicated Lines	5.26 %

Coupling/Cohesion

Components	2
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	13
c	1
b	0
f	0
lcom	2
cbo	6
dl	7
loc	133
rs	10

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	index()	0	4	1
A	create()	0	4	1
A	store()	7	20	2
A	show()	0	6	1
A	edit()	0	4	1
A	update()	0	15	2
A	destroy()	0	10	2
A	get_content()	0	5	1
A	get_settings()	0	5	1

How to fix Duplicated Code

<?php

namespace App\Api\Controllers;

use App\Models\Widgets;
use App\Models\Dashboard;
use App\Models\UsersWidgets;
use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class DashboardWidgetController extends Controller
{

    use Helpers;

    public function __construct() {

    }

    /**
     * Display a listing of all authorized devices
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

    {
        //
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $row                         = Dashboard::find($request->dashboard_id)->widgets()->max('row')+1;
        $user_widget                 = new UsersWidgets;
        $user_widget->user_id        = $request->user()->user_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user_widget->widget_id      = $request->widget_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user_widget->col            = $request->col;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user_widget->row            = $row;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user_widget->size_x         = $request->size_x;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user_widget->size_y         = $request->size_y;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user_widget->title          = $request->title;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user_widget->dashboard_id   = $request->dashboard_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($user_widget->save())

        {
            return $this->response->array(array('statusText' => 'OK', 'user_widget_id' => $user_widget->user_widget_id));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        else {
            return $this->response->errorInternal();
        }
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show(Request $request, $id)

    {
        $widget  = Widgets::find($id);
        $content = $this->api->be(auth()->user())->get('/api/dashboard-widget/' . $id . '/content');

        return array('widget' => $widget, 'content' => $content);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $users_widgets         = UsersWidgets::find($id);
        $users_widgets->col    = $request->input('x');
        $users_widgets->row    = $request->input('y');
        $users_widgets->size_x = $request->input('width');
        $users_widgets->size_y = $request->input('height');
        if ($users_widgets->save())
        {
            return $this->response->array(array('statusText' => 'OK'));
        }
        else {
            return $this->response->errorInternal();
        }
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        if (UsersWidgets::destroy($id))
        {
            return $this->response->array(array('statusText' => 'OK'));
        }
        else {
            return $this->response->errorInternal();
        }
    }

    public function get_content($id)

    {
        $content[] = 'Yes we have some text';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return $this->response->array(array('statusText' => 'OK', 'content' => $content));
    }

    public function get_settings($id)

    {
        $settings = array('Yes we have some settings');
        return $this->response->array(array('statusText' => 'OK', 'content' => $settings));
    }

}


1		<?php
2
3		namespace App\Api\Controllers;
4
5		use App\Models\Widgets;
6		use App\Models\Dashboard;
7		use App\Models\UsersWidgets;
8		use Dingo\Api\Http;
9		use Dingo\Api\Routing\Helpers;
10		use Illuminate\Http\Request;
11
12		class DashboardWidgetController extends Controller
13		{
14
15		use Helpers;
16
17		public function __construct() {
18
19		}
20
21		/**
22		* Display a listing of all authorized devices
23		*
24		* @return \Illuminate\Http\Response
25		*/
26		public function index(Request $request)
		1 ignored issue – show Unused Code introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
27		{
28		//
29		}
30
31		/**
32		* Show the form for creating a new resource.
33		*
34		* @return \Illuminate\Http\Response
35		*/
36		public function create()
37		{
38		//
39		}
40
41		/**
42		* Store a newly created resource in storage.
43		*
44		* @param \Illuminate\Http\Request $request
45		* @return \Illuminate\Http\Response
46		*/
47		public function store(Request $request)
48		{
49		$row = Dashboard::find($request->dashboard_id)->widgets()->max('row')+1;
50		$user_widget = new UsersWidgets;
51		$user_widget->user_id = $request->user()->user_id;
		0 ignored issues – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `user_id` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52		$user_widget->widget_id = $request->widget_id;
		1 ignored issue – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `widget_id` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `widget_id` does not seem to exist in `Illuminate\Http\Request`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
53		$user_widget->col = $request->col;
		1 ignored issue – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `col` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `col` does not seem to exist in `Illuminate\Http\Request`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
54		$user_widget->row = $row;
		0 ignored issues – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `row` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55		$user_widget->size_x = $request->size_x;
		1 ignored issue – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `size_x` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `size_x` does not seem to exist in `Illuminate\Http\Request`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
56		$user_widget->size_y = $request->size_y;
		1 ignored issue – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `size_y` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `size_y` does not seem to exist in `Illuminate\Http\Request`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
57		$user_widget->title = $request->title;
		1 ignored issue – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `title` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `title` does not seem to exist in `Illuminate\Http\Request`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
58		$user_widget->dashboard_id = $request->dashboard_id;
		1 ignored issue – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `dashboard_id` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `dashboard_id` does not seem to exist in `Illuminate\Http\Request`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
59	View Code Duplication	if ($user_widget->save())
		0 ignored issues – show Duplication introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		{
61		return $this->response->array(array('statusText' => 'OK', 'user_widget_id' => $user_widget->user_widget_id));
		0 ignored issues – show Documentation introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The property `user_widget_id` does not exist on `object<App\Models\UsersWidgets>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
62		}
63		else {
64		return $this->response->errorInternal();
65		}
66		}
67
68		/**
69		* Display the specified resource.
70		*
71		* @param int $id
72		* @return \Illuminate\Http\Response
73		*/
74		public function show(Request $request, $id)
		1 ignored issue – show Unused Code introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
75		{
76		$widget = Widgets::find($id);
77		$content = $this->api->be(auth()->user())->get('/api/dashboard-widget/' . $id . '/content');
		0 ignored issues – show Bug introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
78		return array('widget' => $widget, 'content' => $content);
79		}
80
81		/**
82		* Show the form for editing the specified resource.
83		*
84		* @param int $id
85		* @return \Illuminate\Http\Response
86		*/
87		public function edit($id)
		0 ignored issues – show Unused Code introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
88		{
89		//
90		}
91
92		/**
93		* Update the specified resource in storage.
94		*
95		* @param \Illuminate\Http\Request $request
96		* @param int $id
97		* @return \Illuminate\Http\Response
98		*/
99		public function update(Request $request, $id)
100		{
101		$users_widgets = UsersWidgets::find($id);
102		$users_widgets->col = $request->input('x');
103		$users_widgets->row = $request->input('y');
104		$users_widgets->size_x = $request->input('width');
105		$users_widgets->size_y = $request->input('height');
106		if ($users_widgets->save())
107		{
108		return $this->response->array(array('statusText' => 'OK'));
109		}
110		else {
111		return $this->response->errorInternal();
112		}
113		}
114
115		/**
116		* Remove the specified resource from storage.
117		*
118		* @param int $id
119		* @return \Illuminate\Http\Response
120		*/
121		public function destroy($id)
122		{
123		if (UsersWidgets::destroy($id))
124		{
125		return $this->response->array(array('statusText' => 'OK'));
126		}
127		else {
128		return $this->response->errorInternal();
129		}
130		}
131
132		public function get_content($id)
		0 ignored issues – show Unused Code introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
133		{
134		$content[] = 'Yes we have some text';
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report `$content` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$content = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
135		return $this->response->array(array('statusText' => 'OK', 'content' => $content));
136		}
137
138		public function get_settings($id)
		0 ignored issues – show Unused Code introduced 2016-04-16 03:29 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
139		{
140		$settings = array('Yes we have some settings');
141		return $this->response->array(array('statusText' => 'OK', 'content' => $settings));
142		}
143
144		}
145

murrant / librenmsv2

Push — misc ( 5d788f...8599dc )

DashboardWidgetController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like