NotificationController::update() - Code Metrics - murrant/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

NotificationController::update() A
last analyzed 2017-03-03 04:21 UTC

↳ Parent: NotificationController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	4
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class NotificationController extends Controller
{
    use Helpers;

    /**
     * Display a listing of the resource.
     *
     * @param null $type
     * @return \Illuminate\Http\Response

     */
    public function index($type = null)
    {

        $notifications = $this->api->be(auth()->user())->get('/api/notifications/'.$type);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        if ($type === 'archive') {
            $page = '';
            $button = 'Notifications';
            $bg = 'maroon';
        } else {
            $page = 'archive';
            $button = 'Archive';
            $bg = 'blue';
        }

        return view('notifications.list', compact(['notifications', 'page', 'button', 'bg', "type"]));
    }

    /**
     * Update a notifications status.
     *
     * @param $id
     * @param $action
     * @return \Illuminate\Http\JsonResponse
     */
    public function update($id, $action)
    {
        return response()->json($this->api->be(auth()->user())->patch('/api/notifications/'.$id.'/'.$action));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Create a new notification
     *
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function create(Request $request)
    {
        $this->validate($request, [
            'title' => 'required|unique:notifications|max:255',
            'body'  => 'required',
        ]);
        return response()->json($this->api->be(auth()->user())->put('/api/notifications', ['title' => $request->title, 'body' => $request->body]));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use Dingo\Api\Routing\Helpers;
6		use Illuminate\Http\Request;
7
8		class NotificationController extends Controller
9		{
10		use Helpers;
11
12		/**
13		* Display a listing of the resource.
14		*
15		* @param null $type
16		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2017-03-02 21:18 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
17		*/
18	1	public function index($type = null)
19		{
20
21	1	$notifications = $this->api->be(auth()->user())->get('/api/notifications/'.$type);
		0 ignored issues – show Bug introduced 2016-07-29 02:40 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
22	1	if ($type === 'archive') {
23	1	$page = '';
24	1	$button = 'Notifications';
25	1	$bg = 'maroon';
26		} else {
27	1	$page = 'archive';
28	1	$button = 'Archive';
29	1	$bg = 'blue';
30		}
31
32	1	return view('notifications.list', compact(['notifications', 'page', 'button', 'bg', "type"]));
33		}
34
35		/**
36		* Update a notifications status.
37		*
38		* @param $id
39		* @param $action
40		* @return \Illuminate\Http\JsonResponse
41		*/
42		public function update($id, $action)
43		{
44		return response()->json($this->api->be(auth()->user())->patch('/api/notifications/'.$id.'/'.$action));
		0 ignored issues – show Bug introduced 2016-07-29 02:40 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
45		}
46
47		/**
48		* Create a new notification
49		*
50		* @param Request $request
51		* @return \Illuminate\Http\JsonResponse
52		*/
53		public function create(Request $request)
54		{
55		$this->validate($request, [
56		'title' => 'required\|unique:notifications\|max:255',
57		'body' => 'required',
58		]);
59		return response()->json($this->api->be(auth()->user())->put('/api/notifications', ['title' => $request->title, 'body' => $request->body]));
		0 ignored issues – show Bug introduced 2016-07-29 02:40 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
60		}
61		}
62

murrant / librenmsv2

NotificationController::update() A last analyzed 2017-03-03 04:21 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

NotificationController::update() A
last analyzed 2017-03-03 04:21 UTC