AlertsController   A
last analyzed

Complexity

Total Complexity 9

Size/Duplication

Total Lines 83
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 5

Test Coverage

Coverage 15.79%

Importance

Changes 0
Metric Value
dl 0
loc 83
ccs 3
cts 19
cp 0.1579
rs 10
c 0
b 0
f 0
wmc 9
lcom 1
cbo 5

7 Methods

Rating   Name   Duplication   Size   Complexity  
A index() 0 5 2
A create() 0 4 1
A store() 0 4 1
A show() 0 4 1
A edit() 0 4 1
A update() 0 10 2
A destroy() 0 4 1
1
<?php
2
/**
3
 * app/Api/Controllers/Alerting/AlertsController.php
4
 *
5
 * API Controller for alerts data
6
 *
7
 * This program is free software: you can redistribute it and/or modify
8
 * it under the terms of the GNU General Public License as published by
9
 * the Free Software Foundation, either version 3 of the License, or
10
 * (at your option) any later version.
11
 *
12
 * This program is distributed in the hope that it will be useful,
13
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
15
 * GNU General Public License for more details.
16
 *
17
 * You should have received a copy of the GNU General Public License
18
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
19
 *
20
 * @package    LibreNMS
21
 * @link       http://librenms.org
22
 * @copyright  2016 Neil Lathwood
23
 * @author     Neil Lathwood <[email protected]>
24
 */
25
26
namespace App\Api\Controllers\Alerting;
27
28
use App\Api\Controllers\Controller;
29
use App\Models\Alerting\Alert;
30
use Dingo\Api\Routing\Helpers;
31
use Illuminate\Http\Request;
32
33
class AlertsController extends Controller
34
{
35
36
    use Helpers;
37
38
    /**
39
     * Display a listing of all alerts
40
     *
41
     * @param Request $request
42
     * @return \Illuminate\Http\Response
43
     */
44 1
    public function index(Request $request)
45
    {
46 1
        $per_page = $request->per_page ?: 25;
47 1
        return Alert::active()->paginate($per_page);
0 ignored issues
show
Bug introduced by
The method paginate does only exist in Illuminate\Database\Query\Builder, but not in App\Models\Alerting\Alert.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
48
    }
49
50
51
    /**
52
     * Show the form for creating a new resource.
53
     *
54
     * @return \Illuminate\Http\Response|null
55
     */
56
    public function create()
57
    {
58
        //
59
    }
60
61
    /**
62
     * Store a newly created resource in storage.
63
     *
64
     * @param  \Illuminate\Http\Request  $request
65
     * @return \Illuminate\Http\Response|null
66
     */
67
    public function store(Request $request)
68
    {
69
        //
70
    }
71
72
    /**
73
     * Display the specified resource.
74
     *
75
     * @param  int  $id
76
     * @return \Illuminate\Http\Response|null
77
     */
78
    public function show(Request $request, $id)
0 ignored issues
show
Unused Code introduced by
The parameter $id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
79
    {
80
        //
81
    }
82
83
    /**
84
     * Show the form for editing the specified resource.
85
     *
86
     * @param  int  $id
87
     * @return \Illuminate\Http\Response|null
88
     */
89
    public function edit($id)
0 ignored issues
show
Unused Code introduced by
The parameter $id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
90
    {
91
        //
92
    }
93
94
    public function update(Request $request, $id)
95
    {
96
        $alert         = Alert::find($id);
97
        $alert->state  = $request->input('state');
98
        if ($alert->save()) {
99
            return $this->response->array(array('statusText' => 'OK'));
100
        } else {
101
            return $this->response->errorInternal();
102
        }
103
    }
104
105
    /**
106
     * Remove the specified resource from storage.
107
     *
108
     * @param  int  $id
109
     * @return \Illuminate\Http\Response|null
110
     */
111
    public function destroy($id)
0 ignored issues
show
Unused Code introduced by
The parameter $id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
112
    {
113
        //
114
    }
115
}
116