Inspection of "Update API Component" - multidimension-al/cakephpify - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f10ba0...92e5ec )

by AJ

created 2017-01-28 07:44 UTC

Status

Indentation +53 added lines, -53 removed lines patch added patch discarded remove patch

@@ -43,7 +43,7 @@  discard block
 block discarded – undo
             ->getMock();
         $registry = new ComponentRegistry($this->controller);
         $this->component = new ShopifyAPIComponent($registry);
-		$this->component->initialize(['apiKey' => 'abc123']);
+        $this->component->initialize(['apiKey' => 'abc123']);
         $event = new Event('Controller.startup', $this->controller);
         $this->component->startup($event);
     }
@@ -56,36 +56,36 @@  discard block
 block discarded – undo
 
     public function testShopDomain()
     {
-		$shopDomain = "test.myshopify.com";
-		$return = $this->component->setShopDomain($shopDomain);
-		$this->assertSame($return, $shopDomain);
-		$return = $this->component->getShopDomain();
-		$this->assertSame($return, $shopDomain);
+        $shopDomain = "test.myshopify.com";
+        $return = $this->component->setShopDomain($shopDomain);
+        $this->assertSame($return, $shopDomain);
+        $return = $this->component->getShopDomain();
+        $this->assertSame($return, $shopDomain);
 		
-		$shopDomain = "random.myshopify.com";
-		$this->component->setShopDomain($shopDomain);
-		$return = $this->component->setShopDomain($shopDomain);
-		$this->assertSame($return, $shopDomain);
-		$return = $this->component->getShopDomain();
-		$this->assertSame($return, $shopDomain);
+        $shopDomain = "random.myshopify.com";
+        $this->component->setShopDomain($shopDomain);
+        $return = $this->component->setShopDomain($shopDomain);
+        $this->assertSame($return, $shopDomain);
+        $return = $this->component->getShopDomain();
+        $this->assertSame($return, $shopDomain);
 		
-		$shopDomain = NULL;
-		$return = $this->component->setShopDomain($shopDomain);
-		$this->assertNull($return);
-		$return = $this->component->getShopDomain();
-		$this->assertNull($return);
+        $shopDomain = NULL;
+        $return = $this->component->setShopDomain($shopDomain);
+        $this->assertNull($return);
+        $return = $this->component->getShopDomain();
+        $this->assertNull($return);
 		
-		$shopDomain = false;
-		$return = $this->component->setShopDomain($shopDomain);
-		$this->assertFalse($return);
-		$return = $this->component->getShopDomain();
-		$this->assertFalse($return);
+        $shopDomain = false;
+        $return = $this->component->setShopDomain($shopDomain);
+        $this->assertFalse($return);
+        $return = $this->component->getShopDomain();
+        $this->assertFalse($return);
 		
-		$shopDomain = true;
-		$return = $this->component->setShopDomain($shopDomain);
-		$this->assertTrue($return);
-		$return = $this->component->getShopDomain();
-		$this->assertTrue($return);
+        $shopDomain = true;
+        $return = $this->component->setShopDomain($shopDomain);
+        $this->assertTrue($return);
+        $return = $this->component->getShopDomain();
+        $this->assertTrue($return);
     }
 
     public function testSetAccessToken()
@@ -105,36 +105,36 @@  discard block
 block discarded – undo
 
     public function testNonce()
     {
-		$nonce = md5(rand());
-		$return = $this->component->setNonce($nonce);
-		$this->assertSame($return, $nonce);
-		$return = $this->component->getNonce();
-		$this->assertSame($return, $nonce);
+        $nonce = md5(rand());
+        $return = $this->component->setNonce($nonce);
+        $this->assertSame($return, $nonce);
+        $return = $this->component->getNonce();
+        $this->assertSame($return, $nonce);
 		
-		$nonce = md5(rand());
-		$this->component->setNonce($nonce);
-		$return = $this->component->setNonce($nonce);
-		$this->assertSame($return, $nonce);
-		$return = $this->component->getNonce();
-		$this->assertSame($return, $nonce);
+        $nonce = md5(rand());
+        $this->component->setNonce($nonce);
+        $return = $this->component->setNonce($nonce);
+        $this->assertSame($return, $nonce);
+        $return = $this->component->getNonce();
+        $this->assertSame($return, $nonce);
 		
-		$nonce = NULL;
-		$return = $this->component->setNonce($nonce);
-		$this->assertNull($return);
-		$return = $this->component->getNonce();
-		$this->assertNull($return);
+        $nonce = NULL;
+        $return = $this->component->setNonce($nonce);
+        $this->assertNull($return);
+        $return = $this->component->getNonce();
+        $this->assertNull($return);
 		
-		$nonce = false;
-		$return = $this->component->setNonce($nonce);
-		$this->assertFalse($return);
-		$return = $this->component->getNonce();
-		$this->assertFalse($return);
+        $nonce = false;
+        $return = $this->component->setNonce($nonce);
+        $this->assertFalse($return);
+        $return = $this->component->getNonce();
+        $this->assertFalse($return);
 		
-		$nonce = true;
-		$return = $this->component->setNonce($nonce);
-		$this->assertTrue($return);
-		$return = $this->component->getNonce();
-		$this->assertTrue($return);
+        $nonce = true;
+        $return = $this->component->setNonce($nonce);
+        $this->assertTrue($return);
+        $return = $this->component->getNonce();
+        $this->assertTrue($return);
     }
 
 }

Please login to merge, or discard this patch.

		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	->getMock();
44	44	$registry = new ComponentRegistry($this->controller);
45	45	$this->component = new ShopifyAPIComponent($registry);
46		- $this->component->initialize(['apiKey' => 'abc123']);
	46	+ $this->component->initialize(['apiKey' => 'abc123']);
47	47	$event = new Event('Controller.startup', $this->controller);
48	48	$this->component->startup($event);
49	49	}
		@@ -56,36 +56,36 @@ discard block
		block discarded – undo
56	56
57	57	public function testShopDomain()
58	58	{
59		- $shopDomain = "test.myshopify.com";
60		- $return = $this->component->setShopDomain($shopDomain);
61		- $this->assertSame($return, $shopDomain);
62		- $return = $this->component->getShopDomain();
63		- $this->assertSame($return, $shopDomain);
	59	+ $shopDomain = "test.myshopify.com";
	60	+ $return = $this->component->setShopDomain($shopDomain);
	61	+ $this->assertSame($return, $shopDomain);
	62	+ $return = $this->component->getShopDomain();
	63	+ $this->assertSame($return, $shopDomain);
64	64
65		- $shopDomain = "random.myshopify.com";
66		- $this->component->setShopDomain($shopDomain);
67		- $return = $this->component->setShopDomain($shopDomain);
68		- $this->assertSame($return, $shopDomain);
69		- $return = $this->component->getShopDomain();
70		- $this->assertSame($return, $shopDomain);
	65	+ $shopDomain = "random.myshopify.com";
	66	+ $this->component->setShopDomain($shopDomain);
	67	+ $return = $this->component->setShopDomain($shopDomain);
	68	+ $this->assertSame($return, $shopDomain);
	69	+ $return = $this->component->getShopDomain();
	70	+ $this->assertSame($return, $shopDomain);
71	71
72		- $shopDomain = NULL;
73		- $return = $this->component->setShopDomain($shopDomain);
74		- $this->assertNull($return);
75		- $return = $this->component->getShopDomain();
76		- $this->assertNull($return);
	72	+ $shopDomain = NULL;
	73	+ $return = $this->component->setShopDomain($shopDomain);
	74	+ $this->assertNull($return);
	75	+ $return = $this->component->getShopDomain();
	76	+ $this->assertNull($return);
77	77
78		- $shopDomain = false;
79		- $return = $this->component->setShopDomain($shopDomain);
80		- $this->assertFalse($return);
81		- $return = $this->component->getShopDomain();
82		- $this->assertFalse($return);
	78	+ $shopDomain = false;
	79	+ $return = $this->component->setShopDomain($shopDomain);
	80	+ $this->assertFalse($return);
	81	+ $return = $this->component->getShopDomain();
	82	+ $this->assertFalse($return);
83	83
84		- $shopDomain = true;
85		- $return = $this->component->setShopDomain($shopDomain);
86		- $this->assertTrue($return);
87		- $return = $this->component->getShopDomain();
88		- $this->assertTrue($return);
	84	+ $shopDomain = true;
	85	+ $return = $this->component->setShopDomain($shopDomain);
	86	+ $this->assertTrue($return);
	87	+ $return = $this->component->getShopDomain();
	88	+ $this->assertTrue($return);
89	89	}
90	90
91	91	public function testSetAccessToken()
		@@ -105,36 +105,36 @@ discard block
		block discarded – undo
105	105
106	106	public function testNonce()
107	107	{
108		- $nonce = md5(rand());
109		- $return = $this->component->setNonce($nonce);
110		- $this->assertSame($return, $nonce);
111		- $return = $this->component->getNonce();
112		- $this->assertSame($return, $nonce);
	108	+ $nonce = md5(rand());
	109	+ $return = $this->component->setNonce($nonce);
	110	+ $this->assertSame($return, $nonce);
	111	+ $return = $this->component->getNonce();
	112	+ $this->assertSame($return, $nonce);
113	113
114		- $nonce = md5(rand());
115		- $this->component->setNonce($nonce);
116		- $return = $this->component->setNonce($nonce);
117		- $this->assertSame($return, $nonce);
118		- $return = $this->component->getNonce();
119		- $this->assertSame($return, $nonce);
	114	+ $nonce = md5(rand());
	115	+ $this->component->setNonce($nonce);
	116	+ $return = $this->component->setNonce($nonce);
	117	+ $this->assertSame($return, $nonce);
	118	+ $return = $this->component->getNonce();
	119	+ $this->assertSame($return, $nonce);
120	120
121		- $nonce = NULL;
122		- $return = $this->component->setNonce($nonce);
123		- $this->assertNull($return);
124		- $return = $this->component->getNonce();
125		- $this->assertNull($return);
	121	+ $nonce = NULL;
	122	+ $return = $this->component->setNonce($nonce);
	123	+ $this->assertNull($return);
	124	+ $return = $this->component->getNonce();
	125	+ $this->assertNull($return);
126	126
127		- $nonce = false;
128		- $return = $this->component->setNonce($nonce);
129		- $this->assertFalse($return);
130		- $return = $this->component->getNonce();
131		- $this->assertFalse($return);
	127	+ $nonce = false;
	128	+ $return = $this->component->setNonce($nonce);
	129	+ $this->assertFalse($return);
	130	+ $return = $this->component->getNonce();
	131	+ $this->assertFalse($return);
132	132
133		- $nonce = true;
134		- $return = $this->component->setNonce($nonce);
135		- $this->assertTrue($return);
136		- $return = $this->component->getNonce();
137		- $this->assertTrue($return);
	133	+ $nonce = true;
	134	+ $return = $this->component->setNonce($nonce);
	135	+ $this->assertTrue($return);
	136	+ $return = $this->component->getNonce();
	137	+ $this->assertTrue($return);
138	138	}
139	139
140	140	}

multidimension-al / cakephpify

Push — master ( f10ba0...92e5ec )

Status

Category

Indentation +53 added lines, -53 removed lines patch added patch discarded remove patch